[jira] Created: (OFBIZ-1693) Currency conversion broken when creating accounting transaction entries

[Nicolas Malin (Jira)]

Currency conversion broken when creating accounting transaction entries
-----------------------------------------------------------------------

                 Key: OFBIZ-1693
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1693
             Project: OFBiz
          Issue Type: Bug
          Components: accounting
    Affects Versions: SVN trunk
            Reporter: Rashko Rejmer
            Priority: Trivial
             Fix For: SVN trunk


Bugs:
 - createAcctgTransAndEntries service expects Double value.
 - Missing label for Variance Reason Gl Accounts tab button.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rashko Rejmer updated OFBIZ-1693:
---------------------------------

    Attachment: posting_service.patch

> Currency conversion broken when creating accounting transaction entries
> -----------------------------------------------------------------------
>
>                 Key: OFBIZ-1693
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1693
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Rashko Rejmer
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: posting_service.patch
>
>
> Bugs:
>  - createAcctgTransAndEntries service expects Double value.
>  - Missing label for Variance Reason Gl Accounts tab button.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato reassigned OFBIZ-1693:
----------------------------------------

    Assignee: Jacopo Cappellato

> Currency conversion broken when creating accounting transaction entries
> -----------------------------------------------------------------------
>
>                 Key: OFBIZ-1693
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1693
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Rashko Rejmer
>            Assignee: Jacopo Cappellato
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: posting_service.patch
>
>
> Bugs:
>  - createAcctgTransAndEntries service expects Double value.
>  - Missing label for Variance Reason Gl Accounts tab button.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rashko Rejmer updated OFBIZ-1693:
---------------------------------

    Attachment:     (was: posting_service.patch)

> Currency conversion broken when creating accounting transaction entries
> -----------------------------------------------------------------------
>
>                 Key: OFBIZ-1693
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1693
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Rashko Rejmer
>            Assignee: Jacopo Cappellato
>            Priority: Trivial
>             Fix For: SVN trunk
>
>
> Bugs:
>  - createAcctgTransAndEntries service expects Double value.
>  - Missing label for Variance Reason Gl Accounts tab button.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rashko Rejmer updated OFBIZ-1693:
---------------------------------

    Attachment: posting_service.patch

I removed the missing UI label from this patch.
There is a separate issue for this: https://issues.apache.org/jira/browse/OFBIZ-1731

> Currency conversion broken when creating accounting transaction entries
> -----------------------------------------------------------------------
>
>                 Key: OFBIZ-1693
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1693
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Rashko Rejmer
>            Assignee: Jacopo Cappellato
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: posting_service.patch
>
>
> Bugs:
>  - createAcctgTransAndEntries service expects Double value.
>  - Missing label for Variance Reason Gl Accounts tab button.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato closed OFBIZ-1693.
------------------------------------

    Resolution: Fixed

Thank you Rashko,

your patch is in rev. 646199
Have you had a chance to test the uom conversions in this service? Are they working properly now? Is the Double value returned by the convertUom service ("convertedValue") correctly passed to the acctgTransEntry.amount field (that is a BigDecimal, if I am not wrong)?

Jacopo

> Currency conversion broken when creating accounting transaction entries
> -----------------------------------------------------------------------
>
>                 Key: OFBIZ-1693
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1693
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Rashko Rejmer
>            Assignee: Jacopo Cappellato
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: posting_service.patch
>
>
> Bugs:
>  - createAcctgTransAndEntries service expects Double value.
>  - Missing label for Variance Reason Gl Accounts tab button.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12587129#action_12587129 ]

Rashko Rejmer commented on OFBIZ-1693:
--------------------------------------

Thanks Jacopo,

Yes, I have checked uom conversion, and calculations are right.

Regards,
Rashko Rejmer

> Currency conversion broken when creating accounting transaction entries
> -----------------------------------------------------------------------
>
>                 Key: OFBIZ-1693
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1693
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Rashko Rejmer
>            Assignee: Jacopo Cappellato
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: posting_service.patch
>
>
> Bugs:
>  - createAcctgTransAndEntries service expects Double value.
>  - Missing label for Variance Reason Gl Accounts tab button.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.