[jira] Created: (OFBIZ-1698) Locale labels in language dirrerent from the fallback sometime are not displayed
Locked
12
12
[jira] Commented: (OFBIZ-1698) Locale labels in language different from the fallback sometime are not displayed
 
|
[ https://issues.apache.org/jira/browse/OFBIZ-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12610689#action_12610689 ] Jacques Le Roux commented on OFBIZ-1698: ---------------------------------------- Hi Bruno, Please let me know if you are still interested by this issue (I already asked on dev ML). I gave it a try today. After a 1st review, here are some remarks There are some annoyances : ======================================================================================== Trivial (but maybe not in you Python script) -<?xml version="1.0" encoding="UTF-8"?> -<!-- - +<?xml version="1.0" encoding="UTF-8" ?><!-- ---> -<resource xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"> +--><resource xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"> ======================================================================================== ." and at large all special characters are replaced by HTML entities (not easy to learn and maintain) - <value xml:lang="nl">Berekenings eigenschappen voor de boekhouddiensten zijn niet geconfigureerd, processen is gestopt."</value> + <value xml:lang="nl">Berekenings eigenschappen voor de boekhouddiensten zijn niet geconfigureerd, processen is gestopt."</value> ======================================================================================== Because your algorithm was written before we decided to not have overriden labels in different files, we have some in this patch. If you are still interested you could change your script to only keep CommonDescription in Common file in the case below. At large, the rule should be discussed before. But in case of duplicated lables, we may automatically keep only labels within their own file (like CommonDescription). Your script may in other cases write a list of possible changes to check by hand, ie 2 patches : 1 for changes to apply, one for changes to check before applying. ContentUiLabels.xml + <property key="CommonDescription"> + <value xml:lang="ar">وصف</value> + <value xml:lang="en">Description</value> + <value xml:lang="it">Descrizione</value> + <value xml:lang="ro">Descriere</value> + <value xml:lang="th">รายละเอียด</value> + <value xml:lang="zh">描述</value> + </property> - <property key="CommonDescription"> - <value xml:lang="ar">وصف</value> - <value xml:lang="en">Description</value> - <value xml:lang="it">Descrizione</value> - <value xml:lang="ro">Descriere</value> - <value xml:lang="th">รายละเอียด</value> - <value xml:lang="zh">描述</value> - </property> ProductUiLabels.xml + <property key="CommonDescription"> + <value xml:lang="en">Description</value> + <value xml:lang="fr">Description</value> + <value xml:lang="it">Descrizione</value> + <value xml:lang="ro">Descriere</value> + <value xml:lang="ru">Описание</value> + <value xml:lang="th">อธิบาย</value> + <value xml:lang="zh">描述</value> + </property> - <property key="CommonDescription"> - <value xml:lang="en">Description</value> - <value xml:lang="fr">Description</value> - <value xml:lang="it">Descrizione</value> - <value xml:lang="ro">Descriere</value> - <value xml:lang="ru">Описание</value> - <value xml:lang="th">อธิบาย</value> - <value xml:lang="zh">描述</value> - </property> CommonUiLabels.xml <property key="CommonDescription"> <value xml:lang="ar">وصف</value> <value xml:lang="cs">Popis</value> <value xml:lang="de">Beschreibung</value> <value xml:lang="en">Description</value> <value xml:lang="es">Descripción</value> <value xml:lang="fr">Description</value> <value xml:lang="it">Descrizione</value> <value xml:lang="nl">Omschrijving</value> <value xml:lang="pt">Descrição</value> <value xml:lang="ro">Descriere</value> <value xml:lang="ru">Описание</value> <value xml:lang="th">คำอธิบาย</value> <value xml:lang="zh">描述</value> <value xml:lang="zh_CN">描述</value> </property> Please, let me know what you think. > Locale labels in language different from the fallback sometime are not displayed > -------------------------------------------------------------------------------- > > Key: OFBIZ-1698 > URL: https://issues.apache.org/jira/browse/OFBIZ-1698 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Reporter: Bruno Busco > Assignee: Jacques Le Roux > Attachments: cleanlabels.patch.zip > > > A label is not displayed in the selected language but in the fallback one when ALL the following are true: > - A language different from the one specified as "locale.properties.fallback" in framework/common/config/general.properties is selected > - The label is defined in more than one XXXUiLabels.XML file (say File1UiLabels.xml and File2UiLabels.xml) > - The screen includes first File1UiLabels.xml and then File2UiLabels.xml > - In File1UiLabels.xml there is NO translation for the selected language > - In File2UiLabels.xml there is the translation for the selected language > This bug was not present in Release 4.0 and i think could have been introduced with the new locale system. > You can check the bug going in the trunk demo in the ecommerce main page and selecting italian. -> Labels "Cart Summary" and "Special Offers" are not translated. > In the R4.0 demo it is all OK -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-1698) Locale labels in language different from the fallback sometime are not displayed
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco updated OFBIZ-1698: ------------------------------- Attachment: cleanlabels_1.zip Jacques, yes I am still interesting in this issue. In the attached file "cleanlabels_1.zip" I have included a new version of the script which now scans some new added UiLabels files and fixes the " problem. The problem on the file header I did not manage to fix it and so I changed the files manually. I have run the script on the latest trunk and included the patch in the zip file. About your suggestion about moving automatically the labels in the proper file looking at the name I do not have time to implement it but I think it is better to commit this patch that removes all the duplications (636 have been found and rempved). Then without duplications the moving of the labels will be simpler and could also be done manually. > Locale labels in language different from the fallback sometime are not displayed > -------------------------------------------------------------------------------- > > Key: OFBIZ-1698 > URL: https://issues.apache.org/jira/browse/OFBIZ-1698 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Reporter: Bruno Busco > Assignee: Jacques Le Roux > Attachments: cleanlabels.patch.zip, cleanlabels_1.zip > > > A label is not displayed in the selected language but in the fallback one when ALL the following are true: > - A language different from the one specified as "locale.properties.fallback" in framework/common/config/general.properties is selected > - The label is defined in more than one XXXUiLabels.XML file (say File1UiLabels.xml and File2UiLabels.xml) > - The screen includes first File1UiLabels.xml and then File2UiLabels.xml > - In File1UiLabels.xml there is NO translation for the selected language > - In File2UiLabels.xml there is the translation for the selected language > This bug was not present in Release 4.0 and i think could have been introduced with the new locale system. > You can check the bug going in the trunk demo in the ecommerce main page and selecting italian. -> Labels "Cart Summary" and "Special Offers" are not translated. > In the R4.0 demo it is all OK -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1698) Locale labels in language different from the fallback sometime are not displayed
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12610924#action_12610924 ] Jacques Le Roux commented on OFBIZ-1698: ---------------------------------------- Thanks for update Bruno, I think you are right. I will commit your results, after a quick check > Locale labels in language different from the fallback sometime are not displayed > -------------------------------------------------------------------------------- > > Key: OFBIZ-1698 > URL: https://issues.apache.org/jira/browse/OFBIZ-1698 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Reporter: Bruno Busco > Assignee: Jacques Le Roux > Attachments: cleanlabels.patch.zip, cleanlabels_1.zip > > > A label is not displayed in the selected language but in the fallback one when ALL the following are true: > - A language different from the one specified as "locale.properties.fallback" in framework/common/config/general.properties is selected > - The label is defined in more than one XXXUiLabels.XML file (say File1UiLabels.xml and File2UiLabels.xml) > - The screen includes first File1UiLabels.xml and then File2UiLabels.xml > - In File1UiLabels.xml there is NO translation for the selected language > - In File2UiLabels.xml there is the translation for the selected language > This bug was not present in Release 4.0 and i think could have been introduced with the new locale system. > You can check the bug going in the trunk demo in the ecommerce main page and selecting italian. -> Labels "Cart Summary" and "Special Offers" are not translated. > In the R4.0 demo it is all OK -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1698) Locale labels in language different from the fallback sometime are not displayed
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12611062#action_12611062 ] Jacques Le Roux commented on OFBIZ-1698: ---------------------------------------- Bruno, Something is not clear to me. Your script says : Duplication of label CommonDescription found in applications/product/config/ProductUiLabels.xml (7 languages) Label removed from file applications/product/config/ProductUiLabels.xml But the label is only moved (sorted) in the file not removed. Is that normal ? Are you sure of that "Number of removed labels : 636" ? BTW, if we want to remove them we should at least check that a such label exists in the right file (here common) and that in this right file there are not less languagues and that existing values are the same. Else I suggest to write something (both labels) to allow to do it manually later, rather than removing it automatically. It takes a man to do errors, but it takes a machine to really screw it up ;o) > Locale labels in language different from the fallback sometime are not displayed > -------------------------------------------------------------------------------- > > Key: OFBIZ-1698 > URL: https://issues.apache.org/jira/browse/OFBIZ-1698 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Reporter: Bruno Busco > Assignee: Jacques Le Roux > Attachments: cleanlabels.patch.zip, cleanlabels_1.zip > > > A label is not displayed in the selected language but in the fallback one when ALL the following are true: > - A language different from the one specified as "locale.properties.fallback" in framework/common/config/general.properties is selected > - The label is defined in more than one XXXUiLabels.XML file (say File1UiLabels.xml and File2UiLabels.xml) > - The screen includes first File1UiLabels.xml and then File2UiLabels.xml > - In File1UiLabels.xml there is NO translation for the selected language > - In File2UiLabels.xml there is the translation for the selected language > This bug was not present in Release 4.0 and i think could have been introduced with the new locale system. > You can check the bug going in the trunk demo in the ecommerce main page and selecting italian. -> Labels "Cart Summary" and "Special Offers" are not translated. > In the R4.0 demo it is all OK -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1698) Locale labels in language different from the fallback sometime are not displayed
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12611210#action_12611210 ] Bruno Busco commented on OFBIZ-1698: ------------------------------------ Jacques, you are right there is something not working in the script. It SHOULD delete the label but it fails to do it. At the moment I cannot fix it, I will fix it asap. Sorry, Bruno > Locale labels in language different from the fallback sometime are not displayed > -------------------------------------------------------------------------------- > > Key: OFBIZ-1698 > URL: https://issues.apache.org/jira/browse/OFBIZ-1698 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Reporter: Bruno Busco > Assignee: Jacques Le Roux > Attachments: cleanlabels.patch.zip, cleanlabels_1.zip > > > A label is not displayed in the selected language but in the fallback one when ALL the following are true: > - A language different from the one specified as "locale.properties.fallback" in framework/common/config/general.properties is selected > - The label is defined in more than one XXXUiLabels.XML file (say File1UiLabels.xml and File2UiLabels.xml) > - The screen includes first File1UiLabels.xml and then File2UiLabels.xml > - In File1UiLabels.xml there is NO translation for the selected language > - In File2UiLabels.xml there is the translation for the selected language > This bug was not present in Release 4.0 and i think could have been introduced with the new locale system. > You can check the bug going in the trunk demo in the ecommerce main page and selecting italian. -> Labels "Cart Summary" and "Special Offers" are not translated. > In the R4.0 demo it is all OK -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1698) Locale labels in language different from the fallback sometime are not displayed
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12621860#action_12621860 ] Jacques Le Roux commented on OFBIZ-1698: ---------------------------------------- Just a reminder about this (for myself mostly it seems ;o) : when there are no labels for a language it's not defaulting to en > Locale labels in language different from the fallback sometime are not displayed > -------------------------------------------------------------------------------- > > Key: OFBIZ-1698 > URL: https://issues.apache.org/jira/browse/OFBIZ-1698 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Reporter: Bruno Busco > Assignee: Jacques Le Roux > Attachments: cleanlabels.patch.zip, cleanlabels_1.zip > > > A label is not displayed in the selected language but in the fallback one when ALL the following are true: > - A language different from the one specified as "locale.properties.fallback" in framework/common/config/general.properties is selected > - The label is defined in more than one XXXUiLabels.XML file (say File1UiLabels.xml and File2UiLabels.xml) > - The screen includes first File1UiLabels.xml and then File2UiLabels.xml > - In File1UiLabels.xml there is NO translation for the selected language > - In File2UiLabels.xml there is the translation for the selected language > This bug was not present in Release 4.0 and i think could have been introduced with the new locale system. > You can check the bug going in the trunk demo in the ecommerce main page and selecting italian. -> Labels "Cart Summary" and "Special Offers" are not translated. > In the R4.0 demo it is all OK -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1698) Locale labels in language different from the fallback sometime are not displayed
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12621866#action_12621866 ] Adrian Crum commented on OFBIZ-1698: ------------------------------------ Jacques, If you provide an example of where this is occurring, I will take a look at it. > Locale labels in language different from the fallback sometime are not displayed > -------------------------------------------------------------------------------- > > Key: OFBIZ-1698 > URL: https://issues.apache.org/jira/browse/OFBIZ-1698 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Reporter: Bruno Busco > Assignee: Jacques Le Roux > Attachments: cleanlabels.patch.zip, cleanlabels_1.zip > > > A label is not displayed in the selected language but in the fallback one when ALL the following are true: > - A language different from the one specified as "locale.properties.fallback" in framework/common/config/general.properties is selected > - The label is defined in more than one XXXUiLabels.XML file (say File1UiLabels.xml and File2UiLabels.xml) > - The screen includes first File1UiLabels.xml and then File2UiLabels.xml > - In File1UiLabels.xml there is NO translation for the selected language > - In File2UiLabels.xml there is the translation for the selected language > This bug was not present in Release 4.0 and i think could have been introduced with the new locale system. > You can check the bug going in the trunk demo in the ecommerce main page and selecting italian. -> Labels "Cart Summary" and "Special Offers" are not translated. > In the R4.0 demo it is all OK -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1698) Locale labels in language different from the fallback sometime are not displayed
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12621881#action_12621881 ] Jacques Le Roux commented on OFBIZ-1698: ---------------------------------------- Adrian, I have 2, please look at revisions 685140 and 684522 > Locale labels in language different from the fallback sometime are not displayed > -------------------------------------------------------------------------------- > > Key: OFBIZ-1698 > URL: https://issues.apache.org/jira/browse/OFBIZ-1698 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Reporter: Bruno Busco > Assignee: Jacques Le Roux > Attachments: cleanlabels.patch.zip, cleanlabels_1.zip > > > A label is not displayed in the selected language but in the fallback one when ALL the following are true: > - A language different from the one specified as "locale.properties.fallback" in framework/common/config/general.properties is selected > - The label is defined in more than one XXXUiLabels.XML file (say File1UiLabels.xml and File2UiLabels.xml) > - The screen includes first File1UiLabels.xml and then File2UiLabels.xml > - In File1UiLabels.xml there is NO translation for the selected language > - In File2UiLabels.xml there is the translation for the selected language > This bug was not present in Release 4.0 and i think could have been introduced with the new locale system. > You can check the bug going in the trunk demo in the ecommerce main page and selecting italian. -> Labels "Cart Summary" and "Special Offers" are not translated. > In the R4.0 demo it is all OK -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1698) Locale labels in language different from the fallback sometime are not displayed
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625198#action_12625198 ] Jacques Le Roux commented on OFBIZ-1698: ---------------------------------------- Moreover, this bug seems to be random... The only way for now is to put all languages needed, even if it's the same sentence than in English Actually French is the most, and maybe sole, concerned and only for few words. So it's not a big deal... We will only have to put them as they appears... > Locale labels in language different from the fallback sometime are not displayed > -------------------------------------------------------------------------------- > > Key: OFBIZ-1698 > URL: https://issues.apache.org/jira/browse/OFBIZ-1698 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Reporter: Bruno Busco > Assignee: Jacques Le Roux > Attachments: cleanlabels.patch.zip, cleanlabels_1.zip > > > A label is not displayed in the selected language but in the fallback one when ALL the following are true: > - A language different from the one specified as "locale.properties.fallback" in framework/common/config/general.properties is selected > - The label is defined in more than one XXXUiLabels.XML file (say File1UiLabels.xml and File2UiLabels.xml) > - The screen includes first File1UiLabels.xml and then File2UiLabels.xml > - In File1UiLabels.xml there is NO translation for the selected language > - In File2UiLabels.xml there is the translation for the selected language > This bug was not present in Release 4.0 and i think could have been introduced with the new locale system. > You can check the bug going in the trunk demo in the ecommerce main page and selecting italian. -> Labels "Cart Summary" and "Special Offers" are not translated. > In the R4.0 demo it is all OK -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1698) Locale labels in language different from the fallback sometime are not displayed
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634159#action_12634159 ] Adrian Crum commented on OFBIZ-1698: ------------------------------------ Jacques, I believe the problem was fixed in rev 698429. Can we close this now? > Locale labels in language different from the fallback sometime are not displayed > -------------------------------------------------------------------------------- > > Key: OFBIZ-1698 > URL: https://issues.apache.org/jira/browse/OFBIZ-1698 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Reporter: Bruno Busco > Assignee: Jacques Le Roux > Attachments: cleanlabels.patch.zip, cleanlabels_1.zip > > > A label is not displayed in the selected language but in the fallback one when ALL the following are true: > - A language different from the one specified as "locale.properties.fallback" in framework/common/config/general.properties is selected > - The label is defined in more than one XXXUiLabels.XML file (say File1UiLabels.xml and File2UiLabels.xml) > - The screen includes first File1UiLabels.xml and then File2UiLabels.xml > - In File1UiLabels.xml there is NO translation for the selected language > - In File2UiLabels.xml there is the translation for the selected language > This bug was not present in Release 4.0 and i think could have been introduced with the new locale system. > You can check the bug going in the trunk demo in the ecommerce main page and selecting italian. -> Labels "Cart Summary" and "Special Offers" are not translated. > In the R4.0 demo it is all OK -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Closed: (OFBIZ-1698) Locale labels in language different from the fallback sometime are not displayed
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-1698. ---------------------------------- Resolution: Fixed Assignee: Adrian Crum (was: Jacques Le Roux) Seems ok so far, thanks Adrian > Locale labels in language different from the fallback sometime are not displayed > -------------------------------------------------------------------------------- > > Key: OFBIZ-1698 > URL: https://issues.apache.org/jira/browse/OFBIZ-1698 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Reporter: Bruno Busco > Assignee: Adrian Crum > Attachments: cleanlabels.patch.zip, cleanlabels_1.zip > > > A label is not displayed in the selected language but in the fallback one when ALL the following are true: > - A language different from the one specified as "locale.properties.fallback" in framework/common/config/general.properties is selected > - The label is defined in more than one XXXUiLabels.XML file (say File1UiLabels.xml and File2UiLabels.xml) > - The screen includes first File1UiLabels.xml and then File2UiLabels.xml > - In File1UiLabels.xml there is NO translation for the selected language > - In File2UiLabels.xml there is the translation for the selected language > This bug was not present in Release 4.0 and i think could have been introduced with the new locale system. > You can check the bug going in the trunk demo in the ecommerce main page and selecting italian. -> Labels "Cart Summary" and "Special Offers" are not translated. > In the R4.0 demo it is all OK -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |