[jira] Created: (OFBIZ-1720) service receiveInventoryProduct failed on existant inventoryItem

[Nicolas Malin (Jira)]

service receiveInventoryProduct failed on existant inventoryItem
----------------------------------------------------------------

                 Key: OFBIZ-1720
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1720
             Project: OFBiz
          Issue Type: Bug
          Components: product
    Affects Versions: SVN trunk
            Reporter: nicolas malin
             Fix For: SVN trunk
         Attachments: receiveInventoryProduct.patch

When you call the service receiveInventoryProduct with a currentInventoryItemId attribute, the service failed because it call updateInventoryItem service without inventoryItemId.

The patch correct this issue.

Nicolas

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

nicolas malin updated OFBIZ-1720:
---------------------------------

    Attachment: receiveInventoryProduct.patch

> service receiveInventoryProduct failed on existant inventoryItem
> ----------------------------------------------------------------
>
>                 Key: OFBIZ-1720
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1720
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: nicolas malin
>             Fix For: SVN trunk
>
>         Attachments: receiveInventoryProduct.patch
>
>   Original Estimate: 0.03h
>  Remaining Estimate: 0.03h
>
> When you call the service receiveInventoryProduct with a currentInventoryItemId attribute, the service failed because it call updateInventoryItem service without inventoryItemId.
> The patch correct this issue.
> Nicolas

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reassigned OFBIZ-1720:
--------------------------------------

    Assignee: Jacques Le Roux

> service receiveInventoryProduct failed on existant inventoryItem
> ----------------------------------------------------------------
>
>                 Key: OFBIZ-1720
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1720
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: nicolas malin
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: receiveInventoryProduct.patch
>
>   Original Estimate: 0.03h
>  Remaining Estimate: 0.03h
>
> When you call the service receiveInventoryProduct with a currentInventoryItemId attribute, the service failed because it call updateInventoryItem service without inventoryItemId.
> The patch correct this issue.
> Nicolas

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-1720.
----------------------------------

    Resolution: Fixed

Thanks Nicolas,

Your patch is int runk revision: 641718  

> service receiveInventoryProduct failed on existant inventoryItem
> ----------------------------------------------------------------
>
>                 Key: OFBIZ-1720
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1720
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: nicolas malin
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: receiveInventoryProduct.patch
>
>   Original Estimate: 0.03h
>  Remaining Estimate: 0.03h
>
> When you call the service receiveInventoryProduct with a currentInventoryItemId attribute, the service failed because it call updateInventoryItem service without inventoryItemId.
> The patch correct this issue.
> Nicolas

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12582598#action_12582598 ]

Jacopo Cappellato commented on OFBIZ-1720:
------------------------------------------

I'm not sure if my comment is out of topic here but... when we receive a product we should always create new inventory item(s) for it, and not update existing ones. This is very important for many things, including material tracking, quality control, cost metrics.

Jacopo

> service receiveInventoryProduct failed on existant inventoryItem
> ----------------------------------------------------------------
>
>                 Key: OFBIZ-1720
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1720
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: nicolas malin
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: receiveInventoryProduct.patch
>
>   Original Estimate: 0.03h
>  Remaining Estimate: 0.03h
>
> When you call the service receiveInventoryProduct with a currentInventoryItemId attribute, the service failed because it call updateInventoryItem service without inventoryItemId.
> The patch correct this issue.
> Nicolas

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12582631#action_12582631 ]

Jacques Le Roux commented on OFBIZ-1720:
----------------------------------------

Thanks for comment Jacopo,

I hope it will reach Nicolas, maybe this comes from Neogia specificities ?... It's noted on my side.

> service receiveInventoryProduct failed on existant inventoryItem
> ----------------------------------------------------------------
>
>                 Key: OFBIZ-1720
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1720
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: nicolas malin
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: receiveInventoryProduct.patch
>
>   Original Estimate: 0.03h
>  Remaining Estimate: 0.03h
>
> When you call the service receiveInventoryProduct with a currentInventoryItemId attribute, the service failed because it call updateInventoryItem service without inventoryItemId.
> The patch correct this issue.
> Nicolas

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12582639#action_12582639 ]

David E. Jones commented on OFBIZ-1720:
---------------------------------------

It's true that normally a new InventoryItem needs to be created, but there are some exceptions. The main one is for serialized inventory where an item with a specific serial number is returned or re-received after repair or whatever.

> service receiveInventoryProduct failed on existant inventoryItem
> ----------------------------------------------------------------
>
>                 Key: OFBIZ-1720
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1720
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: nicolas malin
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: receiveInventoryProduct.patch
>
>   Original Estimate: 0.03h
>  Remaining Estimate: 0.03h
>
> When you call the service receiveInventoryProduct with a currentInventoryItemId attribute, the service failed because it call updateInventoryItem service without inventoryItemId.
> The patch correct this issue.
> Nicolas

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12582647#action_12582647 ]

Jacques Le Roux commented on OFBIZ-1720:
----------------------------------------

Interesting, thanks David

> service receiveInventoryProduct failed on existant inventoryItem
> ----------------------------------------------------------------
>
>                 Key: OFBIZ-1720
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1720
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: nicolas malin
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: receiveInventoryProduct.patch
>
>   Original Estimate: 0.03h
>  Remaining Estimate: 0.03h
>
> When you call the service receiveInventoryProduct with a currentInventoryItemId attribute, the service failed because it call updateInventoryItem service without inventoryItemId.
> The patch correct this issue.
> Nicolas

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12582948#action_12582948 ]

nicolas malin commented on OFBIZ-1720:
--------------------------------------

The reason of my correction was, actually I prepare a warehouse module on ofbiz and for all sales order I reserve a stock location with inventoryItem and inventoryItem.qoh to 0 by OrderItemShipGrpItemRsv. When I receive products needs for completed orders from supplier, I directly update inventoryItem associate to order. But in my case if a create a new inventoryItem I loose relation whit orders.

But I look only my case :) , it's probably that my correction is bad for other case

Nicoas

> service receiveInventoryProduct failed on existant inventoryItem
> ----------------------------------------------------------------
>
>                 Key: OFBIZ-1720
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1720
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: nicolas malin
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: receiveInventoryProduct.patch
>
>   Original Estimate: 0.03h
>  Remaining Estimate: 0.03h
>
> When you call the service receiveInventoryProduct with a currentInventoryItemId attribute, the service failed because it call updateInventoryItem service without inventoryItemId.
> The patch correct this issue.
> Nicolas

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.