[jira] Created: (OFBIZ-1740) Product detail page shows page title as "Product Page" instead of the actual product name

[Nicolas Malin (Jira)]

Product detail page shows page title as "Product Page" instead of the actual product name
-----------------------------------------------------------------------------------------

                 Key: OFBIZ-1740
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1740
             Project: OFBiz
          Issue Type: Bug
          Components: ecommerce
    Affects Versions: SVN trunk
         Environment: Ubuntu 7.10 Firefox 2.0.0.12
            Reporter: Raj Saini


Product detail page should show the product name in the page title instead of "Product Page". This is due to the reason that page title is retried from Product generic entity instead of ProductContentWrapper in product.bsh file.

Attached patch fixes this problem and product name and product description is used for Page title and description meta description field respectively.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Raj Saini updated OFBIZ-1740:
-----------------------------

    Attachment: productdetail.patch

This patch fixes the missing page title and meta description for product detail page

> Product detail page shows page title as "Product Page" instead of the actual product name
> -----------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1740
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1740
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ecommerce
>    Affects Versions: SVN trunk
>         Environment: Ubuntu 7.10 Firefox 2.0.0.12
>            Reporter: Raj Saini
>         Attachments: productdetail.patch
>
>
> Product detail page should show the product name in the page title instead of "Product Page". This is due to the reason that page title is retried from Product generic entity instead of ProductContentWrapper in product.bsh file.
> Attached patch fixes this problem and product name and product description is used for Page title and description meta description field respectively.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reassigned OFBIZ-1740:
--------------------------------------

    Assignee: Jacques Le Roux

> Product detail page shows page title as "Product Page" instead of the actual product name
> -----------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1740
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1740
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ecommerce
>    Affects Versions: SVN trunk
>         Environment: Ubuntu 7.10 Firefox 2.0.0.12
>            Reporter: Raj Saini
>            Assignee: Jacques Le Roux
>         Attachments: productdetail.patch
>
>
> Product detail page should show the product name in the page title instead of "Product Page". This is due to the reason that page title is retried from Product generic entity instead of ProductContentWrapper in product.bsh file.
> Attached patch fixes this problem and product name and product description is used for Page title and description meta description field respectively.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12586309#action_12586309 ]

Jacques Le Roux commented on OFBIZ-1740:
----------------------------------------

Hi Raj,

First about your patch, you have checked the "ASF Granted License" option, great. But please dont put your name in patch nor any tabs. Please read http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices.

Second, I don't say that your patch may not be useful, but where and how do you see "Product Page" in the page title .

> Product detail page shows page title as "Product Page" instead of the actual product name
> -----------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1740
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1740
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ecommerce
>    Affects Versions: SVN trunk
>         Environment: Ubuntu 7.10 Firefox 2.0.0.12
>            Reporter: Raj Saini
>            Assignee: Jacques Le Roux
>         Attachments: productdetail.patch
>
>
> Product detail page should show the product name in the page title instead of "Product Page". This is due to the reason that page title is retried from Product generic entity instead of ProductContentWrapper in product.bsh file.
> Attached patch fixes this problem and product name and product description is used for Page title and description meta description field respectively.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12586320#action_12586320 ]

Raj Saini commented on OFBIZ-1740:
----------------------------------

Hi Jacques,

Sorry for the name. That was for the internal use and crept into the patch It was not intentional and I never did that in the past.

Sorry again for the tabs. I generally configure eclipse to replace tabs with spaces. I will take care of it and re-submit the patch.

To see the "Product Page" as title, got to main page (featured products) and click on Round Gizmo product. On the product page you will see the Product Page instead of the actual product name.

Do you want me to re-submit the patch?

> Product detail page shows page title as "Product Page" instead of the actual product name
> -----------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1740
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1740
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ecommerce
>    Affects Versions: SVN trunk
>         Environment: Ubuntu 7.10 Firefox 2.0.0.12
>            Reporter: Raj Saini
>            Assignee: Jacques Le Roux
>         Attachments: productdetail.patch
>
>
> Product detail page should show the product name in the page title instead of "Product Page". This is due to the reason that page title is retried from Product generic entity instead of ProductContentWrapper in product.bsh file.
> Attached patch fixes this problem and product name and product description is used for Page title and description meta description field respectively.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-1740.
----------------------------------

       Resolution: Fixed
    Fix Version/s: Release Branch 4.0
                   SVN trunk

Thanks Raj,

Your (slightly modified) patch in in trunk rev. 645457, and  release4.0 as well : 645458

By the way you forgot to put
    import org.ofbiz.product.product.ProductWorker;
in the patch

> Product detail page shows page title as "Product Page" instead of the actual product name
> -----------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1740
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1740
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ecommerce
>    Affects Versions: SVN trunk
>         Environment: Ubuntu 7.10 Firefox 2.0.0.12
>            Reporter: Raj Saini
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk, Release Branch 4.0
>
>         Attachments: productdetail.patch
>
>
> Product detail page should show the product name in the page title instead of "Product Page". This is due to the reason that page title is retried from Product generic entity instead of ProductContentWrapper in product.bsh file.
> Attached patch fixes this problem and product name and product description is used for Page title and description meta description field respectively.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12586331#action_12586331 ]

Raj Saini commented on OFBIZ-1740:
----------------------------------

Thanks Jacques,

It is my laziness that I did not test it on trunk before submitting the patch. I generally test and fix it on my private repository  first and then move them to Ofbiz trunk or branch.

I promise to take care of such minor issue in future to minimize  the time of committers in reviewing and committing the patches.

> Product detail page shows page title as "Product Page" instead of the actual product name
> -----------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1740
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1740
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ecommerce
>    Affects Versions: SVN trunk
>         Environment: Ubuntu 7.10 Firefox 2.0.0.12
>            Reporter: Raj Saini
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk, Release Branch 4.0
>
>         Attachments: productdetail.patch
>
>
> Product detail page should show the product name in the page title instead of "Product Page". This is due to the reason that page title is retried from Product generic entity instead of ProductContentWrapper in product.bsh file.
> Attached patch fixes this problem and product name and product description is used for Page title and description meta description field respectively.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12586883#action_12586883 ]

Jacques Le Roux commented on OFBIZ-1740:
----------------------------------------

You are welcome Raj

> Product detail page shows page title as "Product Page" instead of the actual product name
> -----------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1740
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1740
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ecommerce
>    Affects Versions: SVN trunk
>         Environment: Ubuntu 7.10 Firefox 2.0.0.12
>            Reporter: Raj Saini
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk, Release Branch 4.0
>
>         Attachments: productdetail.patch
>
>
> Product detail page should show the product name in the page title instead of "Product Page". This is due to the reason that page title is retried from Product generic entity instead of ProductContentWrapper in product.bsh file.
> Attached patch fixes this problem and product name and product description is used for Page title and description meta description field respectively.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.