[jira] Created: (OFBIZ-1761) Useless & unuseable service "prepareIncomeStatement" parameter

[Nicolas Malin (Jira)]

Useless & unuseable service "prepareIncomeStatement" parameter
--------------------------------------------------------------

                 Key: OFBIZ-1761
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1761
             Project: OFBiz
          Issue Type: Bug
          Components: accounting
    Affects Versions: SVN trunk
            Reporter: Nuttanart Pornprasitsakul
            Priority: Trivial


"glAccountTotalsMap" is an unneccessary parameter of service named "prepareIncomeStatement".

It has no one assign value for.

by the way there is closely variable named "glAccountTotalMap" but it's clear value everytime before it is used so i think it has no meaning to "glAccountTotalsMap"

prepareIncomeStatement service is at /applications/accounting/script/org/ofbiz/accounting/ledger/GeneralLedgerServices.xml

and declared at /applications/accounting/servicedef/services_ledger.xml

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nuttanart Pornprasitsakul updated OFBIZ-1761:
---------------------------------------------

    Attachment: services_ledger.patch

> Useless & unuseable service "prepareIncomeStatement" parameter
> --------------------------------------------------------------
>
>                 Key: OFBIZ-1761
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1761
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Nuttanart Pornprasitsakul
>            Priority: Trivial
>         Attachments: GeneralLedgerServices.patch, services_ledger.patch
>
>
> "glAccountTotalsMap" is an unneccessary parameter of service named "prepareIncomeStatement".
> It has no one assign value for.
> by the way there is closely variable named "glAccountTotalMap" but it's clear value everytime before it is used so i think it has no meaning to "glAccountTotalsMap"
> prepareIncomeStatement service is at /applications/accounting/script/org/ofbiz/accounting/ledger/GeneralLedgerServices.xml
> and declared at /applications/accounting/servicedef/services_ledger.xml

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nuttanart Pornprasitsakul updated OFBIZ-1761:
---------------------------------------------

    Attachment: GeneralLedgerServices.patch

> Useless & unuseable service "prepareIncomeStatement" parameter
> --------------------------------------------------------------
>
>                 Key: OFBIZ-1761
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1761
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Nuttanart Pornprasitsakul
>            Priority: Trivial
>         Attachments: GeneralLedgerServices.patch, services_ledger.patch
>
>
> "glAccountTotalsMap" is an unneccessary parameter of service named "prepareIncomeStatement".
> It has no one assign value for.
> by the way there is closely variable named "glAccountTotalMap" but it's clear value everytime before it is used so i think it has no meaning to "glAccountTotalsMap"
> prepareIncomeStatement service is at /applications/accounting/script/org/ofbiz/accounting/ledger/GeneralLedgerServices.xml
> and declared at /applications/accounting/servicedef/services_ledger.xml

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nuttanart Pornprasitsakul updated OFBIZ-1761:
---------------------------------------------

    Priority: Minor  (was: Trivial)

> Useless & unuseable service "prepareIncomeStatement" parameter
> --------------------------------------------------------------
>
>                 Key: OFBIZ-1761
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1761
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Nuttanart Pornprasitsakul
>            Priority: Minor
>         Attachments: GeneralLedgerServices.patch, services_ledger.patch
>
>
> "glAccountTotalsMap" is an unneccessary parameter of service named "prepareIncomeStatement".
> It has no one assign value for.
> by the way there is closely variable named "glAccountTotalMap" but it's clear value everytime before it is used so i think it has no meaning to "glAccountTotalsMap"
> prepareIncomeStatement service is at /applications/accounting/script/org/ofbiz/accounting/ledger/GeneralLedgerServices.xml
> and declared at /applications/accounting/servicedef/services_ledger.xml

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato reassigned OFBIZ-1761:
----------------------------------------

    Assignee: Jacopo Cappellato

> Useless & unuseable service "prepareIncomeStatement" parameter
> --------------------------------------------------------------
>
>                 Key: OFBIZ-1761
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1761
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Nuttanart Pornprasitsakul
>            Assignee: Jacopo Cappellato
>            Priority: Minor
>         Attachments: GeneralLedgerServices.patch, services_ledger.patch
>
>
> "glAccountTotalsMap" is an unneccessary parameter of service named "prepareIncomeStatement".
> It has no one assign value for.
> by the way there is closely variable named "glAccountTotalMap" but it's clear value everytime before it is used so i think it has no meaning to "glAccountTotalsMap"
> prepareIncomeStatement service is at /applications/accounting/script/org/ofbiz/accounting/ledger/GeneralLedgerServices.xml
> and declared at /applications/accounting/servicedef/services_ledger.xml

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato closed OFBIZ-1761.
------------------------------------

    Resolution: Fixed

Thank you Nuttanart,
your patch is in rev. 761902

> Useless & unuseable service "prepareIncomeStatement" parameter
> --------------------------------------------------------------
>
>                 Key: OFBIZ-1761
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1761
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Nuttanart Pornprasitsakul
>            Assignee: Jacopo Cappellato
>            Priority: Minor
>         Attachments: GeneralLedgerServices.patch, services_ledger.patch
>
>
> "glAccountTotalsMap" is an unneccessary parameter of service named "prepareIncomeStatement".
> It has no one assign value for.
> by the way there is closely variable named "glAccountTotalMap" but it's clear value everytime before it is used so i think it has no meaning to "glAccountTotalsMap"
> prepareIncomeStatement service is at /applications/accounting/script/org/ofbiz/accounting/ledger/GeneralLedgerServices.xml
> and declared at /applications/accounting/servicedef/services_ledger.xml

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.