[jira] Created: (OFBIZ-179) Searching product with catalog
Locked
12
12
[jira] Created: (OFBIZ-179) Searching product with catalog
 
|
Searching product with catalog
------------------------------ Key: OFBIZ-179 URL: http://issues.apache.org/jira/browse/OFBIZ-179 Project: OFBiz (The Open for Business Project) Issue Type: Improvement Components: ecommerce, order, product Affects Versions: SVN trunk Environment: Windows Reporter: Marco Risaliti Priority: Minor Now is not possible to search all the products inside different categories. In detail into the front-end (ecommerce application) is now possible into the advanced search button to searching products outside the selected catalog. For example If I have two different Stores (Shop1, Shop2) and Catalog (Catalog1, Catalog2) of two different Web Sites (WebSite1, WebSite2) is it possibile to see the products of Catalog1 & Catalog2 from both of the WebSites. So I have made a change to the ecommerce advanced search that in case any categories was selected it will use the categories linked to the selected catalog for searching products. I this case will be not more possible to see the products outside the Catalogs of the current WebSite apart products shared between different Catalogs. In the backend I have add the possibility to search products by catalogs. I this patch you can find all those changes and a lot of changes for I18n missing. I hope this time I have attached a patch with tabs transformed to space, if it's not true can you tell me so I can check it. Can some committers look at this and then if everythings is ok commits. Thanks in advance Marco Risaliti -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Updated: (OFBIZ-179) Searching product with catalog
|
|
[ http://issues.apache.org/jira/browse/OFBIZ-179?page=all ]
Marco Risaliti updated OFBIZ-179: --------------------------------- Attachment: search_by_catalog.patch.txt This is the patch > Searching product with catalog > ------------------------------ > > Key: OFBIZ-179 > URL: http://issues.apache.org/jira/browse/OFBIZ-179 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: ecommerce, order, product > Affects Versions: SVN trunk > Environment: Windows > Reporter: Marco Risaliti > Priority: Minor > Attachments: search_by_catalog.patch.txt > > > Now is not possible to search all the products inside different categories. > In detail into the front-end (ecommerce application) is now possible into the advanced search button to searching products outside the selected catalog. > For example If I have two different Stores (Shop1, Shop2) and Catalog (Catalog1, Catalog2) of two different Web Sites (WebSite1, WebSite2) is it possibile to see the products of Catalog1 & Catalog2 from both of the WebSites. > So I have made a change to the ecommerce advanced search that in case any categories was selected it will use the categories linked to the selected catalog for searching products. > I this case will be not more possible to see the products outside the Catalogs of the current WebSite apart products shared between different Catalogs. > In the backend I have add the possibility to search products by catalogs. > I this patch you can find all those changes and a lot of changes for I18n missing. > I hope this time I have attached a patch with tabs transformed to space, if it's not true can you tell me so I can check it. > Can some committers look at this and then if everythings is ok commits. > Thanks in advance > Marco Risaliti -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Assigned: (OFBIZ-179) Searching product with catalog
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-179?page=all ]
Jacques Le Roux reassigned OFBIZ-179: ------------------------------------- Assignee: Jacques Le Roux > Searching product with catalog > ------------------------------ > > Key: OFBIZ-179 > URL: http://issues.apache.org/jira/browse/OFBIZ-179 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: ecommerce, order, product > Affects Versions: SVN trunk > Environment: Windows > Reporter: Marco Risaliti > Assigned To: Jacques Le Roux > Priority: Minor > Attachments: search_by_catalog.patch.txt > > > Now is not possible to search all the products inside different categories. > In detail into the front-end (ecommerce application) is now possible into the advanced search button to searching products outside the selected catalog. > For example If I have two different Stores (Shop1, Shop2) and Catalog (Catalog1, Catalog2) of two different Web Sites (WebSite1, WebSite2) is it possibile to see the products of Catalog1 & Catalog2 from both of the WebSites. > So I have made a change to the ecommerce advanced search that in case any categories was selected it will use the categories linked to the selected catalog for searching products. > I this case will be not more possible to see the products outside the Catalogs of the current WebSite apart products shared between different Catalogs. > In the backend I have add the possibility to search products by catalogs. > I this patch you can find all those changes and a lot of changes for I18n missing. > I hope this time I have attached a patch with tabs transformed to space, if it's not true can you tell me so I can check it. > Can some committers look at this and then if everythings is ok commits. > Thanks in advance > Marco Risaliti -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-179) Searching product with catalog
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-179?page=comments#action_12430658 ]
Jacques Le Roux commented on OFBIZ-179: --------------------------------------- Hi Marco, At least for the moment I can say that there is only one tab in line 161 of this patch. Don't worry I will fix it if I commit the patch. But in this patch there is much more than a tab ;o) and I will need some time to review it. Thanks > Searching product with catalog > ------------------------------ > > Key: OFBIZ-179 > URL: http://issues.apache.org/jira/browse/OFBIZ-179 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: ecommerce, order, product > Affects Versions: SVN trunk > Environment: Windows > Reporter: Marco Risaliti > Assigned To: Jacques Le Roux > Priority: Minor > Attachments: search_by_catalog.patch.txt > > > Now is not possible to search all the products inside different categories. > In detail into the front-end (ecommerce application) is now possible into the advanced search button to searching products outside the selected catalog. > For example If I have two different Stores (Shop1, Shop2) and Catalog (Catalog1, Catalog2) of two different Web Sites (WebSite1, WebSite2) is it possibile to see the products of Catalog1 & Catalog2 from both of the WebSites. > So I have made a change to the ecommerce advanced search that in case any categories was selected it will use the categories linked to the selected catalog for searching products. > I this case will be not more possible to see the products outside the Catalogs of the current WebSite apart products shared between different Catalogs. > In the backend I have add the possibility to search products by catalogs. > I this patch you can find all those changes and a lot of changes for I18n missing. > I hope this time I have attached a patch with tabs transformed to space, if it's not true can you tell me so I can check it. > Can some committers look at this and then if everythings is ok commits. > Thanks in advance > Marco Risaliti -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-179) Searching product with catalog
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-179?page=comments#action_12430782 ]
Marco Risaliti commented on OFBIZ-179: -------------------------------------- Hi Jacques, ok sorry again for the tab probably I have done it outside Eclipse and so the tab awas not converted to space. Sure that this is a patch where I have changed a lot of classes/bsh/flt file to avoid confusion on the correct productu visibility on the ecommerce application. Take the time you need for me is not urgent but I think that those changes can be a good improvement to the ecommerce applications. Thanks a lot again Marco > Searching product with catalog > ------------------------------ > > Key: OFBIZ-179 > URL: http://issues.apache.org/jira/browse/OFBIZ-179 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: ecommerce, order, product > Affects Versions: SVN trunk > Environment: Windows > Reporter: Marco Risaliti > Assigned To: Jacques Le Roux > Priority: Minor > Attachments: search_by_catalog.patch.txt > > > Now is not possible to search all the products inside different categories. > In detail into the front-end (ecommerce application) is now possible into the advanced search button to searching products outside the selected catalog. > For example If I have two different Stores (Shop1, Shop2) and Catalog (Catalog1, Catalog2) of two different Web Sites (WebSite1, WebSite2) is it possibile to see the products of Catalog1 & Catalog2 from both of the WebSites. > So I have made a change to the ecommerce advanced search that in case any categories was selected it will use the categories linked to the selected catalog for searching products. > I this case will be not more possible to see the products outside the Catalogs of the current WebSite apart products shared between different Catalogs. > In the backend I have add the possibility to search products by catalogs. > I this patch you can find all those changes and a lot of changes for I18n missing. > I hope this time I have attached a patch with tabs transformed to space, if it's not true can you tell me so I can check it. > Can some committers look at this and then if everythings is ok commits. > Thanks in advance > Marco Risaliti -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-179) Searching product with catalog
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-179?page=comments#action_12430886 ]
David E. Jones commented on OFBIZ-179: -------------------------------------- Marco: Could you split this into 2 patches, one for the bug fix and another for the i18n and l10n? I took a look at it because the product searching code is pretty complicated and changes there tend to be somewhat error-prone. Ironically in a brief review I didn't see any issues with the bug fixing parts, but it looked like there were some problems with the localization (like certain labels not being put in the English file, which means that for all non-Spanish locales the label would break). Anyway, the bug fixes certainly need to be tested and I'd be happy to look at this if you could split those out. > Searching product with catalog > ------------------------------ > > Key: OFBIZ-179 > URL: http://issues.apache.org/jira/browse/OFBIZ-179 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: ecommerce, order, product > Affects Versions: SVN trunk > Environment: Windows > Reporter: Marco Risaliti > Assigned To: Jacques Le Roux > Priority: Minor > Attachments: search_by_catalog.patch.txt > > > Now is not possible to search all the products inside different categories. > In detail into the front-end (ecommerce application) is now possible into the advanced search button to searching products outside the selected catalog. > For example If I have two different Stores (Shop1, Shop2) and Catalog (Catalog1, Catalog2) of two different Web Sites (WebSite1, WebSite2) is it possibile to see the products of Catalog1 & Catalog2 from both of the WebSites. > So I have made a change to the ecommerce advanced search that in case any categories was selected it will use the categories linked to the selected catalog for searching products. > I this case will be not more possible to see the products outside the Catalogs of the current WebSite apart products shared between different Catalogs. > In the backend I have add the possibility to search products by catalogs. > I this patch you can find all those changes and a lot of changes for I18n missing. > I hope this time I have attached a patch with tabs transformed to space, if it's not true can you tell me so I can check it. > Can some committers look at this and then if everythings is ok commits. > Thanks in advance > Marco Risaliti -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Updated: (OFBIZ-179) Searching product with catalog
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-179?page=all ]
Marco Risaliti updated OFBIZ-179: --------------------------------- Attachment: search_by_catalog2.patch search_by_catalog2_18n.patch Hi David, search_by_catalog2.patch is for improvement to search products by catalogs & search_by_catalog2_18n.patch is for the i18n part. In the search_by_catalog2_18n.patch some translation only in Italian properties because there are corrections (wrong translations) to existing labels. In search_by_catalog2.patch you can find the new CatalogConstraint subclass in ProductSearch to search by Catalog (group of Categories). I have done this changes : In the front-end (ecommerce application) if any category is selected it's searchs products inside the selected catalog (group of Categories), to avoid that end-users can see products inside different web-store. In the back-end there are the list of all categories and if no category is selected but a catalog is selected it can search products inside this catalog (group of Categories). Thanks Marco > Searching product with catalog > ------------------------------ > > Key: OFBIZ-179 > URL: http://issues.apache.org/jira/browse/OFBIZ-179 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: ecommerce, order, product > Affects Versions: SVN trunk > Environment: Windows > Reporter: Marco Risaliti > Assigned To: Jacques Le Roux > Priority: Minor > Attachments: search_by_catalog.patch.txt, search_by_catalog2.patch, search_by_catalog2_18n.patch > > > Now is not possible to search all the products inside different categories. > In detail into the front-end (ecommerce application) is now possible into the advanced search button to searching products outside the selected catalog. > For example If I have two different Stores (Shop1, Shop2) and Catalog (Catalog1, Catalog2) of two different Web Sites (WebSite1, WebSite2) is it possibile to see the products of Catalog1 & Catalog2 from both of the WebSites. > So I have made a change to the ecommerce advanced search that in case any categories was selected it will use the categories linked to the selected catalog for searching products. > I this case will be not more possible to see the products outside the Catalogs of the current WebSite apart products shared between different Catalogs. > In the backend I have add the possibility to search products by catalogs. > I this patch you can find all those changes and a lot of changes for I18n missing. > I hope this time I have attached a patch with tabs transformed to space, if it's not true can you tell me so I can check it. > Can some committers look at this and then if everythings is ok commits. > Thanks in advance > Marco Risaliti -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-179) Searching product with catalog
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-179?page=comments#action_12432691 ]
Marco Risaliti commented on OFBIZ-179: -------------------------------------- Hi to all committers, can someone take a look at this because it's an improvement of the e-commerce application and this patch is big and stop me to continue to review some more issue. I hope someone is interested on it. Thanks a lot for your work Marco > Searching product with catalog > ------------------------------ > > Key: OFBIZ-179 > URL: http://issues.apache.org/jira/browse/OFBIZ-179 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: ecommerce, order, product > Affects Versions: SVN trunk > Environment: Windows > Reporter: Marco Risaliti > Assigned To: Jacques Le Roux > Priority: Minor > Attachments: search_by_catalog.patch.txt, search_by_catalog2.patch, search_by_catalog2_18n.patch > > > Now is not possible to search all the products inside different categories. > In detail into the front-end (ecommerce application) is now possible into the advanced search button to searching products outside the selected catalog. > For example If I have two different Stores (Shop1, Shop2) and Catalog (Catalog1, Catalog2) of two different Web Sites (WebSite1, WebSite2) is it possibile to see the products of Catalog1 & Catalog2 from both of the WebSites. > So I have made a change to the ecommerce advanced search that in case any categories was selected it will use the categories linked to the selected catalog for searching products. > I this case will be not more possible to see the products outside the Catalogs of the current WebSite apart products shared between different Catalogs. > In the backend I have add the possibility to search products by catalogs. > I this patch you can find all those changes and a lot of changes for I18n missing. > I hope this time I have attached a patch with tabs transformed to space, if it's not true can you tell me so I can check it. > Can some committers look at this and then if everythings is ok commits. > Thanks in advance > Marco Risaliti -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Updated: (OFBIZ-179) Searching product with catalog
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-179?page=all ]
Jacques Le Roux updated OFBIZ-179: ---------------------------------- Attachment: (was: search_by_catalog.patch.txt) > Searching product with catalog > ------------------------------ > > Key: OFBIZ-179 > URL: http://issues.apache.org/jira/browse/OFBIZ-179 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: ecommerce, order, product > Affects Versions: SVN trunk > Environment: Windows > Reporter: Marco Risaliti > Assigned To: Jacques Le Roux > Priority: Minor > Attachments: search_by_catalog2.patch, search_by_catalog2_18n.patch > > > Now is not possible to search all the products inside different categories. > In detail into the front-end (ecommerce application) is now possible into the advanced search button to searching products outside the selected catalog. > For example If I have two different Stores (Shop1, Shop2) and Catalog (Catalog1, Catalog2) of two different Web Sites (WebSite1, WebSite2) is it possibile to see the products of Catalog1 & Catalog2 from both of the WebSites. > So I have made a change to the ecommerce advanced search that in case any categories was selected it will use the categories linked to the selected catalog for searching products. > I this case will be not more possible to see the products outside the Catalogs of the current WebSite apart products shared between different Catalogs. > In the backend I have add the possibility to search products by catalogs. > I this patch you can find all those changes and a lot of changes for I18n missing. > I hope this time I have attached a patch with tabs transformed to space, if it's not true can you tell me so I can check it. > Can some committers look at this and then if everythings is ok commits. > Thanks in advance > Marco Risaliti -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-179) Searching product with catalog
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-179?page=comments#action_12433737 ]
Jacques Le Roux commented on OFBIZ-179: --------------------------------------- Hi Marco, The patch search_by_catalog2_18n.patch is committed in revision 442000. I deleted the old patch. At least this part is done. Thanks > Searching product with catalog > ------------------------------ > > Key: OFBIZ-179 > URL: http://issues.apache.org/jira/browse/OFBIZ-179 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: ecommerce, order, product > Affects Versions: SVN trunk > Environment: Windows > Reporter: Marco Risaliti > Assigned To: Jacques Le Roux > Priority: Minor > Attachments: search_by_catalog2.patch, search_by_catalog2_18n.patch > > > Now is not possible to search all the products inside different categories. > In detail into the front-end (ecommerce application) is now possible into the advanced search button to searching products outside the selected catalog. > For example If I have two different Stores (Shop1, Shop2) and Catalog (Catalog1, Catalog2) of two different Web Sites (WebSite1, WebSite2) is it possibile to see the products of Catalog1 & Catalog2 from both of the WebSites. > So I have made a change to the ecommerce advanced search that in case any categories was selected it will use the categories linked to the selected catalog for searching products. > I this case will be not more possible to see the products outside the Catalogs of the current WebSite apart products shared between different Catalogs. > In the backend I have add the possibility to search products by catalogs. > I this patch you can find all those changes and a lot of changes for I18n missing. > I hope this time I have attached a patch with tabs transformed to space, if it's not true can you tell me so I can check it. > Can some committers look at this and then if everythings is ok commits. > Thanks in advance > Marco Risaliti -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-179) Searching product with catalog
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-179?page=comments#action_12433758 ]
David E. Jones commented on OFBIZ-179: -------------------------------------- I just spent a few minutes reviewing the search_by_catalog2.patch file. These look like some great additions to the existing functionality, but there are a few issues with these changes: - a number of changes that are simply reformatting (makes it more difficult to review, plus leads to inconsistent fomatting in the file) - the locale establishment is not consistent, and the request.getLocale alone should not be used; the best method is the UtilHttp.getLocale(request) method - instead of passing around the request in addition to the session we should just pass around the request instead of the session - I don't really like the way the i18n is handled with the set/getResourceBundle methods; it's generally better to use the UtilProperties stuff directly and let it take care of the details as is done elsewhere - I'm not sure what the point is of the new CatalogConstraint... it looks like it ignores the prodCatalogId and otherwise could be more correctly called a "CategorySetConstraint", like the FeatureSetConstraint is an alternative to the FeatureConstraint > Searching product with catalog > ------------------------------ > > Key: OFBIZ-179 > URL: http://issues.apache.org/jira/browse/OFBIZ-179 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: ecommerce, order, product > Affects Versions: SVN trunk > Environment: Windows > Reporter: Marco Risaliti > Assigned To: Jacques Le Roux > Priority: Minor > Attachments: search_by_catalog2.patch, search_by_catalog2_18n.patch > > > Now is not possible to search all the products inside different categories. > In detail into the front-end (ecommerce application) is now possible into the advanced search button to searching products outside the selected catalog. > For example If I have two different Stores (Shop1, Shop2) and Catalog (Catalog1, Catalog2) of two different Web Sites (WebSite1, WebSite2) is it possibile to see the products of Catalog1 & Catalog2 from both of the WebSites. > So I have made a change to the ecommerce advanced search that in case any categories was selected it will use the categories linked to the selected catalog for searching products. > I this case will be not more possible to see the products outside the Catalogs of the current WebSite apart products shared between different Catalogs. > In the backend I have add the possibility to search products by catalogs. > I this patch you can find all those changes and a lot of changes for I18n missing. > I hope this time I have attached a patch with tabs transformed to space, if it's not true can you tell me so I can check it. > Can some committers look at this and then if everythings is ok commits. > Thanks in advance > Marco Risaliti -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-179) Searching product with catalog
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-179?page=comments#action_12433975 ]
Marco Risaliti commented on OFBIZ-179: -------------------------------------- Hi David, Thanks a lot for review the patch included into this issue. You can see my comment in-line: - a number of changes that are simply reformatting (makes it more difficult to review, plus leads to inconsistent fomatting in the file) Probably it's due to save and then delete rows into the sources but I'm not sure in any case I will provide a new patch to see if it happens again. - the locale establishment is not consistent, and the request.getLocale alone should not be used; the best method is the UtilHttp.getLocale(request) method Yes, I have see that in a lot of place it's used the method UtilHttp.getLocale(request) but into the ProductSearch.java there wasn't any request at disposal to get the related bundle so this why I have included into ProductSearchSession.java. I didn't like to pass the request to those sort of service (ProductSearch.java). Did you have any different idea to solve it ? - instead of passing around the request in addition to the session we should just pass around the request instead of the session Yes, I agree with you that If I use simple the request I can retrieve the session from the method getSession() and I will change the code to avoid this duplication of parameters. - I don't really like the way the i18n is handled with the set/getResourceBundle methods; it's generally better to use the UtilProperties stuff directly and let it take care of the details as is done elsewhere Yes, i have agree with you but in the ProductSearch.java I have not at disposal the locale to execute directly the method UtilProperties.getMessage(resource, name, locale). - I'm not sure what the point is of the new CatalogConstraint... it looks like it ignores the prodCatalogId and otherwise could be more correctly called a "CategorySetConstraint", like the FeatureSetConstraint is an alternative to the FeatureConstraint In reality if you look into the code it's shows the catalog name into the method prettyPrintConstraint() of CatalogConstraint and to retrieve the products it needs a set of keys (productCategoryIds). I prefer if you can help me to solve in better way the issue because also I have found only this solution for the moment. Thanks Marco > Searching product with catalog > ------------------------------ > > Key: OFBIZ-179 > URL: http://issues.apache.org/jira/browse/OFBIZ-179 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: ecommerce, order, product > Affects Versions: SVN trunk > Environment: Windows > Reporter: Marco Risaliti > Assigned To: Jacques Le Roux > Priority: Minor > Attachments: search_by_catalog2.patch, search_by_catalog2_18n.patch > > > Now is not possible to search all the products inside different categories. > In detail into the front-end (ecommerce application) is now possible into the advanced search button to searching products outside the selected catalog. > For example If I have two different Stores (Shop1, Shop2) and Catalog (Catalog1, Catalog2) of two different Web Sites (WebSite1, WebSite2) is it possibile to see the products of Catalog1 & Catalog2 from both of the WebSites. > So I have made a change to the ecommerce advanced search that in case any categories was selected it will use the categories linked to the selected catalog for searching products. > I this case will be not more possible to see the products outside the Catalogs of the current WebSite apart products shared between different Catalogs. > In the backend I have add the possibility to search products by catalogs. > I this patch you can find all those changes and a lot of changes for I18n missing. > I hope this time I have attached a patch with tabs transformed to space, if it's not true can you tell me so I can check it. > Can some committers look at this and then if everythings is ok commits. > Thanks in advance > Marco Risaliti -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-179) Searching product with catalog
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-179?page=comments#action_12434327 ]
David E. Jones commented on OFBIZ-179: -------------------------------------- Marco, It sounds like we may have to revisit this in a bit, like after we get through the issue review and all the action around the incubation graduation effort. A few of these issues really need to be addressed, but it would be great to have support for the two main things I see that are part of this: 1. internationalization of the product search 2. addition of a condition type to do searching within a set of categories and/or a catalog BTW, I don't know if this was ever clear but the current functionality _does_ already take advantage of the search and view allow categories on a catalog to constrain searches. > Searching product with catalog > ------------------------------ > > Key: OFBIZ-179 > URL: http://issues.apache.org/jira/browse/OFBIZ-179 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: ecommerce, order, product > Affects Versions: SVN trunk > Environment: Windows > Reporter: Marco Risaliti > Assigned To: Jacques Le Roux > Priority: Minor > Attachments: search_by_catalog2.patch, search_by_catalog2_18n.patch > > > Now is not possible to search all the products inside different categories. > In detail into the front-end (ecommerce application) is now possible into the advanced search button to searching products outside the selected catalog. > For example If I have two different Stores (Shop1, Shop2) and Catalog (Catalog1, Catalog2) of two different Web Sites (WebSite1, WebSite2) is it possibile to see the products of Catalog1 & Catalog2 from both of the WebSites. > So I have made a change to the ecommerce advanced search that in case any categories was selected it will use the categories linked to the selected catalog for searching products. > I this case will be not more possible to see the products outside the Catalogs of the current WebSite apart products shared between different Catalogs. > In the backend I have add the possibility to search products by catalogs. > I this patch you can find all those changes and a lot of changes for I18n missing. > I hope this time I have attached a patch with tabs transformed to space, if it's not true can you tell me so I can check it. > Can some committers look at this and then if everythings is ok commits. > Thanks in advance > Marco Risaliti -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-179) Searching product with catalog
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-179?page=comments#action_12436761 ]
Jacques Le Roux commented on OFBIZ-179: --------------------------------------- Hi Marco, David, In a few weeks I may help on "Internationalization of the product search" if you wish. > Searching product with catalog > ------------------------------ > > Key: OFBIZ-179 > URL: http://issues.apache.org/jira/browse/OFBIZ-179 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: ecommerce, order, product > Affects Versions: SVN trunk > Environment: Windows > Reporter: Marco Risaliti > Assigned To: Jacques Le Roux > Priority: Minor > Attachments: search_by_catalog2.patch, search_by_catalog2_18n.patch > > > Now is not possible to search all the products inside different categories. > In detail into the front-end (ecommerce application) is now possible into the advanced search button to searching products outside the selected catalog. > For example If I have two different Stores (Shop1, Shop2) and Catalog (Catalog1, Catalog2) of two different Web Sites (WebSite1, WebSite2) is it possibile to see the products of Catalog1 & Catalog2 from both of the WebSites. > So I have made a change to the ecommerce advanced search that in case any categories was selected it will use the categories linked to the selected catalog for searching products. > I this case will be not more possible to see the products outside the Catalogs of the current WebSite apart products shared between different Catalogs. > In the backend I have add the possibility to search products by catalogs. > I this patch you can find all those changes and a lot of changes for I18n missing. > I hope this time I have attached a patch with tabs transformed to space, if it's not true can you tell me so I can check it. > Can some committers look at this and then if everythings is ok commits. > Thanks in advance > Marco Risaliti -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Updated: (OFBIZ-179) Searching product with catalog
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-179?page=all ]
Marco Risaliti updated OFBIZ-179: --------------------------------- Attachment: search_by_catalog2bis.patch Hi David, I had finally the time to review this issue and now I will attach a new patch that replace the old one. I have follow your suggestion and now it uses the method UtilProperties.getMessage() to retrieve message from resource bundle and for the locale I have used UtilHttp.getLocale(). Now all the methods use the request or alternative the session as you suggest and I was completely agreed with you. So if you can look at it, when you have time at disposal, to see this new patch I will appreciate it. Thanks in advance Marco > Searching product with catalog > ------------------------------ > > Key: OFBIZ-179 > URL: http://issues.apache.org/jira/browse/OFBIZ-179 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: ecommerce, order, product > Affects Versions: SVN trunk > Environment: Windows > Reporter: Marco Risaliti > Assigned To: Jacques Le Roux > Priority: Minor > Attachments: search_by_catalog2.patch, search_by_catalog2_18n.patch, search_by_catalog2bis.patch > > > Now is not possible to search all the products inside different categories. > In detail into the front-end (ecommerce application) is now possible into the advanced search button to searching products outside the selected catalog. > For example If I have two different Stores (Shop1, Shop2) and Catalog (Catalog1, Catalog2) of two different Web Sites (WebSite1, WebSite2) is it possibile to see the products of Catalog1 & Catalog2 from both of the WebSites. > So I have made a change to the ecommerce advanced search that in case any categories was selected it will use the categories linked to the selected catalog for searching products. > I this case will be not more possible to see the products outside the Catalogs of the current WebSite apart products shared between different Catalogs. > In the backend I have add the possibility to search products by catalogs. > I this patch you can find all those changes and a lot of changes for I18n missing. > I hope this time I have attached a patch with tabs transformed to space, if it's not true can you tell me so I can check it. > Can some committers look at this and then if everythings is ok commits. > Thanks in advance > Marco Risaliti -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-179) Searching product with catalog
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-179?page=comments#action_12443797 ]
Marco Risaliti commented on OFBIZ-179: -------------------------------------- Hi David, can you look at this when you have time a disposal to review this new patch. Thanks in advance Marco > Searching product with catalog > ------------------------------ > > Key: OFBIZ-179 > URL: http://issues.apache.org/jira/browse/OFBIZ-179 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: ecommerce, order, product > Affects Versions: SVN trunk > Environment: Windows > Reporter: Marco Risaliti > Assigned To: Jacques Le Roux > Priority: Minor > Attachments: search_by_catalog2.patch, search_by_catalog2_18n.patch, search_by_catalog2bis.patch > > > Now is not possible to search all the products inside different categories. > In detail into the front-end (ecommerce application) is now possible into the advanced search button to searching products outside the selected catalog. > For example If I have two different Stores (Shop1, Shop2) and Catalog (Catalog1, Catalog2) of two different Web Sites (WebSite1, WebSite2) is it possibile to see the products of Catalog1 & Catalog2 from both of the WebSites. > So I have made a change to the ecommerce advanced search that in case any categories was selected it will use the categories linked to the selected catalog for searching products. > I this case will be not more possible to see the products outside the Catalogs of the current WebSite apart products shared between different Catalogs. > In the backend I have add the possibility to search products by catalogs. > I this patch you can find all those changes and a lot of changes for I18n missing. > I hope this time I have attached a patch with tabs transformed to space, if it's not true can you tell me so I can check it. > Can some committers look at this and then if everythings is ok commits. > Thanks in advance > Marco Risaliti -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-179) Searching product with catalog
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-179?page=comments#action_12448839 ]
Jacques Le Roux commented on OFBIZ-179: --------------------------------------- OK Marco, It seems that David has not enough time to look at it now. I think I will try to do it except if David prefers not, David ? > Searching product with catalog > ------------------------------ > > Key: OFBIZ-179 > URL: http://issues.apache.org/jira/browse/OFBIZ-179 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: ecommerce, order, product > Affects Versions: SVN trunk > Environment: Windows > Reporter: Marco Risaliti > Assigned To: Jacques Le Roux > Priority: Minor > Attachments: search_by_catalog2.patch, search_by_catalog2_18n.patch, search_by_catalog2bis.patch > > > Now is not possible to search all the products inside different categories. > In detail into the front-end (ecommerce application) is now possible into the advanced search button to searching products outside the selected catalog. > For example If I have two different Stores (Shop1, Shop2) and Catalog (Catalog1, Catalog2) of two different Web Sites (WebSite1, WebSite2) is it possibile to see the products of Catalog1 & Catalog2 from both of the WebSites. > So I have made a change to the ecommerce advanced search that in case any categories was selected it will use the categories linked to the selected catalog for searching products. > I this case will be not more possible to see the products outside the Catalogs of the current WebSite apart products shared between different Catalogs. > In the backend I have add the possibility to search products by catalogs. > I this patch you can find all those changes and a lot of changes for I18n missing. > I hope this time I have attached a patch with tabs transformed to space, if it's not true can you tell me so I can check it. > Can some committers look at this and then if everythings is ok commits. > Thanks in advance > Marco Risaliti -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-179) Searching product with catalog
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-179?page=comments#action_12448878 ]
Marco Risaliti commented on OFBIZ-179: -------------------------------------- Hi Jacques, yes if you have time at disposal it's great if you can look at this issue. At the moment only the patch search_by_catalog2bis.patch remain to be review/commit. Thanks a lot Marco > Searching product with catalog > ------------------------------ > > Key: OFBIZ-179 > URL: http://issues.apache.org/jira/browse/OFBIZ-179 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: ecommerce, order, product > Affects Versions: SVN trunk > Environment: Windows > Reporter: Marco Risaliti > Assigned To: Jacques Le Roux > Priority: Minor > Attachments: search_by_catalog2.patch, search_by_catalog2_18n.patch, search_by_catalog2bis.patch > > > Now is not possible to search all the products inside different categories. > In detail into the front-end (ecommerce application) is now possible into the advanced search button to searching products outside the selected catalog. > For example If I have two different Stores (Shop1, Shop2) and Catalog (Catalog1, Catalog2) of two different Web Sites (WebSite1, WebSite2) is it possibile to see the products of Catalog1 & Catalog2 from both of the WebSites. > So I have made a change to the ecommerce advanced search that in case any categories was selected it will use the categories linked to the selected catalog for searching products. > I this case will be not more possible to see the products outside the Catalogs of the current WebSite apart products shared between different Catalogs. > In the backend I have add the possibility to search products by catalogs. > I this patch you can find all those changes and a lot of changes for I18n missing. > I hope this time I have attached a patch with tabs transformed to space, if it's not true can you tell me so I can check it. > Can some committers look at this and then if everythings is ok commits. > Thanks in advance > Marco Risaliti -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Updated: (OFBIZ-179) Searching product with catalog
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-179?page=all ]
David E. Jones updated OFBIZ-179: --------------------------------- Attachment: (was: search_by_catalog2.patch) > Searching product with catalog > ------------------------------ > > Key: OFBIZ-179 > URL: http://issues.apache.org/jira/browse/OFBIZ-179 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: ecommerce, order, product > Affects Versions: SVN trunk > Environment: Windows > Reporter: Marco Risaliti > Assigned To: Jacques Le Roux > Priority: Minor > Attachments: search_by_catalog2bis.patch > > > Now is not possible to search all the products inside different categories. > In detail into the front-end (ecommerce application) is now possible into the advanced search button to searching products outside the selected catalog. > For example If I have two different Stores (Shop1, Shop2) and Catalog (Catalog1, Catalog2) of two different Web Sites (WebSite1, WebSite2) is it possibile to see the products of Catalog1 & Catalog2 from both of the WebSites. > So I have made a change to the ecommerce advanced search that in case any categories was selected it will use the categories linked to the selected catalog for searching products. > I this case will be not more possible to see the products outside the Catalogs of the current WebSite apart products shared between different Catalogs. > In the backend I have add the possibility to search products by catalogs. > I this patch you can find all those changes and a lot of changes for I18n missing. > I hope this time I have attached a patch with tabs transformed to space, if it's not true can you tell me so I can check it. > Can some committers look at this and then if everythings is ok commits. > Thanks in advance > Marco Risaliti -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Updated: (OFBIZ-179) Searching product with catalog
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-179?page=all ]
David E. Jones updated OFBIZ-179: --------------------------------- Attachment: (was: search_by_catalog2_18n.patch) > Searching product with catalog > ------------------------------ > > Key: OFBIZ-179 > URL: http://issues.apache.org/jira/browse/OFBIZ-179 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: ecommerce, order, product > Affects Versions: SVN trunk > Environment: Windows > Reporter: Marco Risaliti > Assigned To: Jacques Le Roux > Priority: Minor > Attachments: search_by_catalog2bis.patch > > > Now is not possible to search all the products inside different categories. > In detail into the front-end (ecommerce application) is now possible into the advanced search button to searching products outside the selected catalog. > For example If I have two different Stores (Shop1, Shop2) and Catalog (Catalog1, Catalog2) of two different Web Sites (WebSite1, WebSite2) is it possibile to see the products of Catalog1 & Catalog2 from both of the WebSites. > So I have made a change to the ecommerce advanced search that in case any categories was selected it will use the categories linked to the selected catalog for searching products. > I this case will be not more possible to see the products outside the Catalogs of the current WebSite apart products shared between different Catalogs. > In the backend I have add the possibility to search products by catalogs. > I this patch you can find all those changes and a lot of changes for I18n missing. > I hope this time I have attached a patch with tabs transformed to space, if it's not true can you tell me so I can check it. > Can some committers look at this and then if everythings is ok commits. > Thanks in advance > Marco Risaliti -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |