[jira] Created: (OFBIZ-1801) Conversion of some bean shell scripts to groovy

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
30 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (OFBIZ-1801) Conversion of some bean shell scripts to groovy

Nicolas Malin (Jira)
Conversion of some bean shell scripts to groovy
-----------------------------------------------

                 Key: OFBIZ-1801
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1801
             Project: OFBiz
          Issue Type: Improvement
          Components: product
    Affects Versions: SVN trunk
            Reporter: Marco Risaliti
            Assignee: Marco Risaliti
            Priority: Minor
             Fix For: SVN trunk


I have tried to convert some bsh script of product screens and seems to me groovy is very more faster/readable and easy to write.
I upload here some new scripts that has to be tested.
I will upload later a patch for ProductScreens.xml for using the new groovy scripts.

Thanks
Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-1801) Conversion of some bean shell scripts to groovy

Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-1801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marco Risaliti updated OFBIZ-1801:
----------------------------------

    Attachment: EditProductAssoc.groovy
                ApplyFeaturesFromGroup.groovy
                ApplyFeaturesFromCategory.groovy

first new groovy scripts.

> Conversion of some bean shell scripts to groovy
> -----------------------------------------------
>
>                 Key: OFBIZ-1801
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1801
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: ApplyFeaturesFromCategory.groovy, ApplyFeaturesFromGroup.groovy, EditProductAssoc.groovy, EditProductContent.groovy, EditProductContentContent.groovy, EditProductInventoryItems.groovy
>
>
> I have tried to convert some bsh script of product screens and seems to me groovy is very more faster/readable and easy to write.
> I upload here some new scripts that has to be tested.
> I will upload later a patch for ProductScreens.xml for using the new groovy scripts.
> Thanks
> Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-1801) Conversion of some bean shell scripts to groovy

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-1801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marco Risaliti updated OFBIZ-1801:
----------------------------------

    Attachment: EditProductInventoryItems.groovy
                EditProductContentContent.groovy
                EditProductContent.groovy

> Conversion of some bean shell scripts to groovy
> -----------------------------------------------
>
>                 Key: OFBIZ-1801
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1801
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: ApplyFeaturesFromCategory.groovy, ApplyFeaturesFromGroup.groovy, EditProductAssoc.groovy, EditProductContent.groovy, EditProductContentContent.groovy, EditProductInventoryItems.groovy
>
>
> I have tried to convert some bsh script of product screens and seems to me groovy is very more faster/readable and easy to write.
> I upload here some new scripts that has to be tested.
> I will upload later a patch for ProductScreens.xml for using the new groovy scripts.
> Thanks
> Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-1801) Conversion of some bean shell scripts to groovy

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-1801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marco Risaliti updated OFBIZ-1801:
----------------------------------

    Attachment: QuickAddVariants.groovy
                EditProductQuickAdmin.groovy

> Conversion of some bean shell scripts to groovy
> -----------------------------------------------
>
>                 Key: OFBIZ-1801
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1801
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: ApplyFeaturesFromCategory.groovy, ApplyFeaturesFromGroup.groovy, EditProductAssoc.groovy, EditProductContent.groovy, EditProductContentContent.groovy, EditProductInventoryItems.groovy, EditProductQuickAdmin.groovy, QuickAddVariants.groovy
>
>
> I have tried to convert some bsh script of product screens and seems to me groovy is very more faster/readable and easy to write.
> I upload here some new scripts that has to be tested.
> I will upload later a patch for ProductScreens.xml for using the new groovy scripts.
> Thanks
> Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1801) Conversion of some bean shell scripts to groovy

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12599371#action_12599371 ]

Scott Gray commented on OFBIZ-1801:
-----------------------------------

Hi Marco

If they work fine then I would just go ahead and commit them rather than uploading them to jira.  

Also I'm worried about losing the svn change history of the bsh files, I think if we simply rename (rather than replace) the bsh files then the history will be preserved.

> Conversion of some bean shell scripts to groovy
> -----------------------------------------------
>
>                 Key: OFBIZ-1801
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1801
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: ApplyFeaturesFromCategory.groovy, ApplyFeaturesFromGroup.groovy, EditProductAssoc.groovy, EditProductContent.groovy, EditProductContentContent.groovy, EditProductInventoryItems.groovy, EditProductQuickAdmin.groovy, QuickAddVariants.groovy
>
>
> I have tried to convert some bsh script of product screens and seems to me groovy is very more faster/readable and easy to write.
> I upload here some new scripts that has to be tested.
> I will upload later a patch for ProductScreens.xml for using the new groovy scripts.
> Thanks
> Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1801) Conversion of some bean shell scripts to groovy

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12599381#action_12599381 ]

Marco Risaliti commented on OFBIZ-1801:
---------------------------------------

Hi Scott,

I have tested all those new groovy scripts except EditProductContentContent.groovy because there is an issue into the screen but actually I have not the possibility to correct it.
I agree with you to replace the content of the bsh script and then rename the file from bsh to groovy and I didn't know if all the community agree with us.
I cannot do it now a patch for this but I can do it on the next days if I found the time to do it.

Thanks
Marco


> Conversion of some bean shell scripts to groovy
> -----------------------------------------------
>
>                 Key: OFBIZ-1801
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1801
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: ApplyFeaturesFromCategory.groovy, ApplyFeaturesFromGroup.groovy, EditProductAssoc.groovy, EditProductContent.groovy, EditProductContentContent.groovy, EditProductInventoryItems.groovy, EditProductQuickAdmin.groovy, QuickAddVariants.groovy
>
>
> I have tried to convert some bsh script of product screens and seems to me groovy is very more faster/readable and easy to write.
> I upload here some new scripts that has to be tested.
> I will upload later a patch for ProductScreens.xml for using the new groovy scripts.
> Thanks
> Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1801) Conversion of some bean shell scripts to groovy

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12599382#action_12599382 ]

Jacopo Cappellato commented on OFBIZ-1801:
------------------------------------------

Scott,

I agree with you about using svn rename for the first pass migration.




> Conversion of some bean shell scripts to groovy
> -----------------------------------------------
>
>                 Key: OFBIZ-1801
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1801
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: ApplyFeaturesFromCategory.groovy, ApplyFeaturesFromGroup.groovy, EditProductAssoc.groovy, EditProductContent.groovy, EditProductContentContent.groovy, EditProductInventoryItems.groovy, EditProductQuickAdmin.groovy, QuickAddVariants.groovy
>
>
> I have tried to convert some bsh script of product screens and seems to me groovy is very more faster/readable and easy to write.
> I upload here some new scripts that has to be tested.
> I will upload later a patch for ProductScreens.xml for using the new groovy scripts.
> Thanks
> Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1801) Conversion of some bean shell scripts to groovy

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12599427#action_12599427 ]

Jacques Le Roux commented on OFBIZ-1801:
----------------------------------------

Yes, I agree we should keep history and renaming is a solution

> Conversion of some bean shell scripts to groovy
> -----------------------------------------------
>
>                 Key: OFBIZ-1801
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1801
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: ApplyFeaturesFromCategory.groovy, ApplyFeaturesFromGroup.groovy, EditProductAssoc.groovy, EditProductContent.groovy, EditProductContentContent.groovy, EditProductInventoryItems.groovy, EditProductQuickAdmin.groovy, QuickAddVariants.groovy
>
>
> I have tried to convert some bsh script of product screens and seems to me groovy is very more faster/readable and easy to write.
> I upload here some new scripts that has to be tested.
> I will upload later a patch for ProductScreens.xml for using the new groovy scripts.
> Thanks
> Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1801) Conversion of some bean shell scripts to groovy

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12599505#action_12599505 ]

Marco Risaliti commented on OFBIZ-1801:
---------------------------------------

Convert EditProductAssoc.bsh to groovy into trunk rev. 659655

> Conversion of some bean shell scripts to groovy
> -----------------------------------------------
>
>                 Key: OFBIZ-1801
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1801
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: ApplyFeaturesFromCategory.groovy, ApplyFeaturesFromGroup.groovy, EditProductAssoc.groovy, EditProductContent.groovy, EditProductContentContent.groovy, EditProductInventoryItems.groovy, EditProductQuickAdmin.groovy, QuickAddVariants.groovy
>
>
> I have tried to convert some bsh script of product screens and seems to me groovy is very more faster/readable and easy to write.
> I upload here some new scripts that has to be tested.
> I will upload later a patch for ProductScreens.xml for using the new groovy scripts.
> Thanks
> Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1801) Conversion of some bean shell scripts to groovy

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12599509#action_12599509 ]

Scott Gray commented on OFBIZ-1801:
-----------------------------------

> Convert EditProductAssoc.bsh to groovy into trunk rev. 659655

Looks good Marco, sorry if I was stating the obvious about renaming vs replacing :-)

> Conversion of some bean shell scripts to groovy
> -----------------------------------------------
>
>                 Key: OFBIZ-1801
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1801
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: ApplyFeaturesFromCategory.groovy, ApplyFeaturesFromGroup.groovy, EditProductAssoc.groovy, EditProductContent.groovy, EditProductContentContent.groovy, EditProductInventoryItems.groovy, EditProductQuickAdmin.groovy, QuickAddVariants.groovy
>
>
> I have tried to convert some bsh script of product screens and seems to me groovy is very more faster/readable and easy to write.
> I upload here some new scripts that has to be tested.
> I will upload later a patch for ProductScreens.xml for using the new groovy scripts.
> Thanks
> Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1801) Conversion of some bean shell scripts to groovy

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12600254#action_12600254 ]

Marco Risaliti commented on OFBIZ-1801:
---------------------------------------

Converted QuickAddVariants.bsh to groovy into trunk rev. 660649

> Conversion of some bean shell scripts to groovy
> -----------------------------------------------
>
>                 Key: OFBIZ-1801
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1801
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: ApplyFeaturesFromCategory.groovy, ApplyFeaturesFromGroup.groovy, EditProductAssoc.groovy, EditProductContent.groovy, EditProductContentContent.groovy, EditProductInventoryItems.groovy, EditProductQuickAdmin.groovy, QuickAddVariants.groovy
>
>
> I have tried to convert some bsh script of product screens and seems to me groovy is very more faster/readable and easy to write.
> I upload here some new scripts that has to be tested.
> I will upload later a patch for ProductScreens.xml for using the new groovy scripts.
> Thanks
> Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1801) Conversion of some bean shell scripts to groovy

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12600276#action_12600276 ]

Marco Risaliti commented on OFBIZ-1801:
---------------------------------------

Converted EditProductInventoryItems.bsh to groovy into trunk rev. 660703

> Conversion of some bean shell scripts to groovy
> -----------------------------------------------
>
>                 Key: OFBIZ-1801
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1801
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: ApplyFeaturesFromCategory.groovy, ApplyFeaturesFromGroup.groovy, EditProductAssoc.groovy, EditProductContent.groovy, EditProductContentContent.groovy, EditProductInventoryItems.groovy, EditProductQuickAdmin.groovy, QuickAddVariants.groovy
>
>
> I have tried to convert some bsh script of product screens and seems to me groovy is very more faster/readable and easy to write.
> I upload here some new scripts that has to be tested.
> I will upload later a patch for ProductScreens.xml for using the new groovy scripts.
> Thanks
> Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1801) Conversion of some bean shell scripts to groovy

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12600285#action_12600285 ]

Marco Risaliti commented on OFBIZ-1801:
---------------------------------------

Converted EditProductQuickAdmin.bsh to groovy into trunk rev. 660723 & 660730.

> Conversion of some bean shell scripts to groovy
> -----------------------------------------------
>
>                 Key: OFBIZ-1801
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1801
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: ApplyFeaturesFromCategory.groovy, ApplyFeaturesFromGroup.groovy, EditProductAssoc.groovy, EditProductContent.groovy, EditProductContentContent.groovy, EditProductInventoryItems.groovy, EditProductQuickAdmin.groovy, QuickAddVariants.groovy
>
>
> I have tried to convert some bsh script of product screens and seems to me groovy is very more faster/readable and easy to write.
> I upload here some new scripts that has to be tested.
> I will upload later a patch for ProductScreens.xml for using the new groovy scripts.
> Thanks
> Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1801) Conversion of some bean shell scripts to groovy

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12600288#action_12600288 ]

Marco Risaliti commented on OFBIZ-1801:
---------------------------------------

Converted ApplyFeaturesFromCategory.bsh/ApplyFeaturesFromGroup to groovy into trunk rev. 660738.

> Conversion of some bean shell scripts to groovy
> -----------------------------------------------
>
>                 Key: OFBIZ-1801
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1801
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: ApplyFeaturesFromCategory.groovy, ApplyFeaturesFromGroup.groovy, EditProductAssoc.groovy, EditProductContent.groovy, EditProductContentContent.groovy, EditProductInventoryItems.groovy, EditProductQuickAdmin.groovy, QuickAddVariants.groovy
>
>
> I have tried to convert some bsh script of product screens and seems to me groovy is very more faster/readable and easy to write.
> I upload here some new scripts that has to be tested.
> I will upload later a patch for ProductScreens.xml for using the new groovy scripts.
> Thanks
> Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1801) Conversion of some bean shell scripts to groovy

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12600900#action_12600900 ]

Marco Risaliti commented on OFBIZ-1801:
---------------------------------------

 Converted EditProductContent.bsh to groovy into trunk rev. 661449.

> Conversion of some bean shell scripts to groovy
> -----------------------------------------------
>
>                 Key: OFBIZ-1801
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1801
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: ApplyFeaturesFromCategory.groovy, ApplyFeaturesFromGroup.groovy, EditProductAssoc.groovy, EditProductContent.groovy, EditProductContentContent.groovy, EditProductInventoryItems.groovy, EditProductQuickAdmin.groovy, QuickAddVariants.groovy
>
>
> I have tried to convert some bsh script of product screens and seems to me groovy is very more faster/readable and easy to write.
> I upload here some new scripts that has to be tested.
> I will upload later a patch for ProductScreens.xml for using the new groovy scripts.
> Thanks
> Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1801) Conversion of some bean shell scripts to groovy

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12601121#action_12601121 ]

Ashish Vijaywargiya commented on OFBIZ-1801:
--------------------------------------------

Macro,Scott & Others,

Since last few days I was looking on the commit notification on Groovy conversion.
Now I can say that I am comfortable in doing development in Groovy.
I am very interested to contribute in this effort.

Is it ok if we work on Party & then Manufacturing modules ?
This will really help us to learn something good in Groovy.

--
Ashish Vijaywargiya

> Conversion of some bean shell scripts to groovy
> -----------------------------------------------
>
>                 Key: OFBIZ-1801
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1801
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: ApplyFeaturesFromCategory.groovy, ApplyFeaturesFromGroup.groovy, EditProductAssoc.groovy, EditProductContent.groovy, EditProductContentContent.groovy, EditProductInventoryItems.groovy, EditProductQuickAdmin.groovy, QuickAddVariants.groovy
>
>
> I have tried to convert some bsh script of product screens and seems to me groovy is very more faster/readable and easy to write.
> I upload here some new scripts that has to be tested.
> I will upload later a patch for ProductScreens.xml for using the new groovy scripts.
> Thanks
> Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1801) Conversion of some bean shell scripts to groovy

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12601125#action_12601125 ]

Scott Gray commented on OFBIZ-1801:
-----------------------------------

Sounds great!  I'm working on accounting and I think Marco is working through product but I'll let him confirm what his plans are.

> Conversion of some bean shell scripts to groovy
> -----------------------------------------------
>
>                 Key: OFBIZ-1801
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1801
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: ApplyFeaturesFromCategory.groovy, ApplyFeaturesFromGroup.groovy, EditProductAssoc.groovy, EditProductContent.groovy, EditProductContentContent.groovy, EditProductInventoryItems.groovy, EditProductQuickAdmin.groovy, QuickAddVariants.groovy
>
>
> I have tried to convert some bsh script of product screens and seems to me groovy is very more faster/readable and easy to write.
> I upload here some new scripts that has to be tested.
> I will upload later a patch for ProductScreens.xml for using the new groovy scripts.
> Thanks
> Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1801) Conversion of some bean shell scripts to groovy

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12601142#action_12601142 ]

Marco Risaliti commented on OFBIZ-1801:
---------------------------------------

Hi Ashish and Scott,

I'm working only in the product applications so would be great if you are working on accounting,  party & manufacturing.

Thanks
Marco

> Conversion of some bean shell scripts to groovy
> -----------------------------------------------
>
>                 Key: OFBIZ-1801
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1801
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: ApplyFeaturesFromCategory.groovy, ApplyFeaturesFromGroup.groovy, EditProductAssoc.groovy, EditProductContent.groovy, EditProductContentContent.groovy, EditProductInventoryItems.groovy, EditProductQuickAdmin.groovy, QuickAddVariants.groovy
>
>
> I have tried to convert some bsh script of product screens and seems to me groovy is very more faster/readable and easy to write.
> I upload here some new scripts that has to be tested.
> I will upload later a patch for ProductScreens.xml for using the new groovy scripts.
> Thanks
> Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1801) Conversion of some bean shell scripts to groovy

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12601342#action_12601342 ]

Marco Risaliti commented on OFBIZ-1801:
---------------------------------------

Converted EditFeatureCategoryFeatures.bsh/EditFeatureGroups.bsh/QuickAddProductFeatures.bsh to groovy into trunk rev. 661449.

> Conversion of some bean shell scripts to groovy
> -----------------------------------------------
>
>                 Key: OFBIZ-1801
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1801
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: ApplyFeaturesFromCategory.groovy, ApplyFeaturesFromGroup.groovy, EditProductAssoc.groovy, EditProductContent.groovy, EditProductContentContent.groovy, EditProductInventoryItems.groovy, EditProductQuickAdmin.groovy, QuickAddVariants.groovy
>
>
> I have tried to convert some bsh script of product screens and seems to me groovy is very more faster/readable and easy to write.
> I upload here some new scripts that has to be tested.
> I will upload later a patch for ProductScreens.xml for using the new groovy scripts.
> Thanks
> Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1801) Conversion of some bean shell scripts to groovy

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12601343#action_12601343 ]

Marco Risaliti commented on OFBIZ-1801:
---------------------------------------

SORRY, Converted EditFeatureCategoryFeatures.bsh/EditFeatureGroups.bsh/QuickAddProductFeatures.bsh to groovy into trunk rev. 661941.



> Conversion of some bean shell scripts to groovy
> -----------------------------------------------
>
>                 Key: OFBIZ-1801
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1801
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: ApplyFeaturesFromCategory.groovy, ApplyFeaturesFromGroup.groovy, EditProductAssoc.groovy, EditProductContent.groovy, EditProductContentContent.groovy, EditProductInventoryItems.groovy, EditProductQuickAdmin.groovy, QuickAddVariants.groovy
>
>
> I have tried to convert some bsh script of product screens and seems to me groovy is very more faster/readable and easy to write.
> I upload here some new scripts that has to be tested.
> I will upload later a patch for ProductScreens.xml for using the new groovy scripts.
> Thanks
> Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

12