[jira] Created: (OFBIZ-1825) Colors and localisation for the calendar
Locked
1234
1234
[jira] Commented: (OFBIZ-1825) Colors and localisation for the calendar
 
|
[ https://issues.apache.org/jira/browse/OFBIZ-1825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784257#action_12784257 ] Todor Spasov commented on OFBIZ-1825: ------------------------------------- Hello Sascha and Jacques, When i was reviewing the previous calendar localisation of Marco Ruocco i saw that two things must be done. The first one is, as Sascha says now, the js part and the second is the service engine part. The implementation was simple js and a complex rendering code in the form widget and ObjectType's simpleTypeConvert(). The latter is used to let services correctly parse localised date/time to java object (Timestamp). Using Adrian Crum's latest addition - the converter this part could easily be completed. But there is one con to following this approach - you have to change all java events and groovies because they have to deal with the unparsed localised string for the date/time that arrives as a String there. Services use ObjectType.simpleTypeConvert(). If we make the form widget render one hidden field (with our original field name e.g. fromDate) that holds the returned date from the js calendar in the standard format and another that is used to display the date in the locale format then it could be possible not to touch ofbiz code (apart from the date-time renderer and *all ftls :D to render both fields ). It has a disadvantage since we only show a display string with the date that is not editable, so the user can't just type the date he wants, instead he must always use the calendar. WDYT? Thanks, Todor > Colors and localisation for the calendar > ---------------------------------------- > > Key: OFBIZ-1825 > URL: https://issues.apache.org/jira/browse/OFBIZ-1825 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Jacques Le Roux > Assignee: Jacques Le Roux > Priority: Minor > Fix For: Release Branch 9.04 > > Attachments: calendar.patch, calendar_sequence.patch, calendarDateSelectColor.patch, calendarDateSelectColor.patch, calendarModified.patch, CommonScreens.patch, Existing.jpg, LocalizedDate_it.patch, Proposition.jpg, WE_CAL.gif > > > I tried to change the calendar colors, to be more "in the OFBiz way". Please let me you know what you think. > I also changed some colors to respect our CSS best practices (no color names). > Here are some remarks : > Colors > * I kept the 3 chars scheme when it's was obvious. For instance we don't need to set #000000 or #ffffff when actually #000 or #fff is sufficient. > * I used Wikipedia as reference http://en.wikipedia.org/wiki/Web_colors for choising colors. While doing this change I wondered if we could not authorise and even recommend to use sandard names for colors as shown in Wikipedia page. I found it easier to recall a color by its names than by an hexa number...! As long as we would use this Wikipedia reference I think it could be possible to use names instead of hexa, WDYT ? > * The days initials are not centered but at left (It's late and I did not found the reason) > We need to provide a localisation mean. From http://electronicholas.com/calendar?style=default&format=natural it should not be too hard. I propose a simple way, maybe we can do better > * More calendar formats in a calendar.properties file (like the euro or american ones) > * For the moment I think all string are harcoded in calendar_date_select.js > Date.weekdays = $w("S M T W T F S"); > Date.first_day_of_week = 0; > Date.months = $w("January February March April May June July August September October November December" ); > _translations = { > "OK": "OK", > "Now": "Now", > "Today": "Today" > } > A very simple way (but not very clever I must admit) could be to set a property for the language to use in calendar.properties file and use it in a switch statement with "hardcoded" strings in calendar_date_select.js. Is anybody aware of better ways to do that in Javascript or Prototype ? > BTW I think we should delete calendarstyles.css and calendarTable.css. If it's ok, I will do it when I will upate the attached patch later. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-1825) Colors and localisation for the calendar
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp updated OFBIZ-1825: ----------------------------------- Attachment: calendar_I18n.patch Hi, here is my first idea to internationalize the calendar. I moved the calendar to a sepparte folder. So there is one place for all the different locale and format files. An Ajax Request gets the User Locale and loads a *.js file with the Date Format / Language information (if nothing is found english is set as default). For now the Calendar returns a sortable date format to the input field!! Maybe someone can have a looks, but for me it's the simpelst solution to internationalize the calendar. BTW: i uppdaded the calendar to the current version :-) So long Sascha > Colors and localisation for the calendar > ---------------------------------------- > > Key: OFBIZ-1825 > URL: https://issues.apache.org/jira/browse/OFBIZ-1825 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Jacques Le Roux > Assignee: Jacques Le Roux > Priority: Minor > Fix For: Release Branch 9.04 > > Attachments: calendar.patch, calendar_I18n.patch, calendar_sequence.patch, calendarDateSelectColor.patch, calendarDateSelectColor.patch, calendarModified.patch, CommonScreens.patch, Existing.jpg, LocalizedDate_it.patch, Proposition.jpg, WE_CAL.gif > > > I tried to change the calendar colors, to be more "in the OFBiz way". Please let me you know what you think. > I also changed some colors to respect our CSS best practices (no color names). > Here are some remarks : > Colors > * I kept the 3 chars scheme when it's was obvious. For instance we don't need to set #000000 or #ffffff when actually #000 or #fff is sufficient. > * I used Wikipedia as reference http://en.wikipedia.org/wiki/Web_colors for choising colors. While doing this change I wondered if we could not authorise and even recommend to use sandard names for colors as shown in Wikipedia page. I found it easier to recall a color by its names than by an hexa number...! As long as we would use this Wikipedia reference I think it could be possible to use names instead of hexa, WDYT ? > * The days initials are not centered but at left (It's late and I did not found the reason) > We need to provide a localisation mean. From http://electronicholas.com/calendar?style=default&format=natural it should not be too hard. I propose a simple way, maybe we can do better > * More calendar formats in a calendar.properties file (like the euro or american ones) > * For the moment I think all string are harcoded in calendar_date_select.js > Date.weekdays = $w("S M T W T F S"); > Date.first_day_of_week = 0; > Date.months = $w("January February March April May June July August September October November December" ); > _translations = { > "OK": "OK", > "Now": "Now", > "Today": "Today" > } > A very simple way (but not very clever I must admit) could be to set a property for the language to use in calendar.properties file and use it in a switch statement with "hardcoded" strings in calendar_date_select.js. Is anybody aware of better ways to do that in Javascript or Prototype ? > BTW I think we should delete calendarstyles.css and calendarTable.css. If it's ok, I will do it when I will upate the attached patch later. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1825) Colors and localisation for the calendar
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784580#action_12784580 ] Jacques Le Roux commented on OFBIZ-1825: ---------------------------------------- Hi Sascha, I just quickly tested and I find one issue : the Calendar does not return a sortable date format to the input field. Else it seems to works well (I added "Clear": "Init" to _translations in js.fr) > Colors and localisation for the calendar > ---------------------------------------- > > Key: OFBIZ-1825 > URL: https://issues.apache.org/jira/browse/OFBIZ-1825 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Jacques Le Roux > Assignee: Jacques Le Roux > Priority: Minor > Fix For: Release Branch 9.04 > > Attachments: calendar.patch, calendar_I18n.patch, calendar_sequence.patch, calendarDateSelectColor.patch, calendarDateSelectColor.patch, calendarModified.patch, CommonScreens.patch, Existing.jpg, LocalizedDate_it.patch, Proposition.jpg, WE_CAL.gif > > > I tried to change the calendar colors, to be more "in the OFBiz way". Please let me you know what you think. > I also changed some colors to respect our CSS best practices (no color names). > Here are some remarks : > Colors > * I kept the 3 chars scheme when it's was obvious. For instance we don't need to set #000000 or #ffffff when actually #000 or #fff is sufficient. > * I used Wikipedia as reference http://en.wikipedia.org/wiki/Web_colors for choising colors. While doing this change I wondered if we could not authorise and even recommend to use sandard names for colors as shown in Wikipedia page. I found it easier to recall a color by its names than by an hexa number...! As long as we would use this Wikipedia reference I think it could be possible to use names instead of hexa, WDYT ? > * The days initials are not centered but at left (It's late and I did not found the reason) > We need to provide a localisation mean. From http://electronicholas.com/calendar?style=default&format=natural it should not be too hard. I propose a simple way, maybe we can do better > * More calendar formats in a calendar.properties file (like the euro or american ones) > * For the moment I think all string are harcoded in calendar_date_select.js > Date.weekdays = $w("S M T W T F S"); > Date.first_day_of_week = 0; > Date.months = $w("January February March April May June July August September October November December" ); > _translations = { > "OK": "OK", > "Now": "Now", > "Today": "Today" > } > A very simple way (but not very clever I must admit) could be to set a property for the language to use in calendar.properties file and use it in a switch statement with "hardcoded" strings in calendar_date_select.js. Is anybody aware of better ways to do that in Javascript or Prototype ? > BTW I think we should delete calendarstyles.css and calendarTable.css. If it's ok, I will do it when I will upate the attached patch later. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1825) Colors and localisation for the calendar
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784581#action_12784581 ] Jacques Le Roux commented on OFBIZ-1825: ---------------------------------------- Sortable date format, something like we have currently : 2009-12-02 2:27:50.0 > Colors and localisation for the calendar > ---------------------------------------- > > Key: OFBIZ-1825 > URL: https://issues.apache.org/jira/browse/OFBIZ-1825 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Jacques Le Roux > Assignee: Jacques Le Roux > Priority: Minor > Fix For: Release Branch 9.04 > > Attachments: calendar.patch, calendar_I18n.patch, calendar_sequence.patch, calendarDateSelectColor.patch, calendarDateSelectColor.patch, calendarModified.patch, CommonScreens.patch, Existing.jpg, LocalizedDate_it.patch, Proposition.jpg, WE_CAL.gif > > > I tried to change the calendar colors, to be more "in the OFBiz way". Please let me you know what you think. > I also changed some colors to respect our CSS best practices (no color names). > Here are some remarks : > Colors > * I kept the 3 chars scheme when it's was obvious. For instance we don't need to set #000000 or #ffffff when actually #000 or #fff is sufficient. > * I used Wikipedia as reference http://en.wikipedia.org/wiki/Web_colors for choising colors. While doing this change I wondered if we could not authorise and even recommend to use sandard names for colors as shown in Wikipedia page. I found it easier to recall a color by its names than by an hexa number...! As long as we would use this Wikipedia reference I think it could be possible to use names instead of hexa, WDYT ? > * The days initials are not centered but at left (It's late and I did not found the reason) > We need to provide a localisation mean. From http://electronicholas.com/calendar?style=default&format=natural it should not be too hard. I propose a simple way, maybe we can do better > * More calendar formats in a calendar.properties file (like the euro or american ones) > * For the moment I think all string are harcoded in calendar_date_select.js > Date.weekdays = $w("S M T W T F S"); > Date.first_day_of_week = 0; > Date.months = $w("January February March April May June July August September October November December" ); > _translations = { > "OK": "OK", > "Now": "Now", > "Today": "Today" > } > A very simple way (but not very clever I must admit) could be to set a property for the language to use in calendar.properties file and use it in a switch statement with "hardcoded" strings in calendar_date_select.js. Is anybody aware of better ways to do that in Javascript or Prototype ? > BTW I think we should delete calendarstyles.css and calendarTable.css. If it's ok, I will do it when I will upate the attached patch later. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-1825) Colors and localisation for the calendar
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp updated OFBIZ-1825: ----------------------------------- Attachment: calendar_I18n.patch Hi, yeah Jacques stupid mistake, i forgott to update the code before submit it :-( I made a few changes. Because i realized, that it was not the simpelst way i choosed. Now there is no Ajax Request anymore. We don't need an extra Service (and the Java overhead). I load the l18n data directly after the calendar_data_select.js in the common screen. What do you think? Cu Sascha > Colors and localisation for the calendar > ---------------------------------------- > > Key: OFBIZ-1825 > URL: https://issues.apache.org/jira/browse/OFBIZ-1825 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Jacques Le Roux > Assignee: Jacques Le Roux > Priority: Minor > Fix For: Release Branch 9.04 > > Attachments: calendar.patch, calendar_I18n.patch, calendar_I18n.patch, calendar_sequence.patch, calendarDateSelectColor.patch, calendarDateSelectColor.patch, calendarModified.patch, CommonScreens.patch, Existing.jpg, LocalizedDate_it.patch, Proposition.jpg, WE_CAL.gif > > > I tried to change the calendar colors, to be more "in the OFBiz way". Please let me you know what you think. > I also changed some colors to respect our CSS best practices (no color names). > Here are some remarks : > Colors > * I kept the 3 chars scheme when it's was obvious. For instance we don't need to set #000000 or #ffffff when actually #000 or #fff is sufficient. > * I used Wikipedia as reference http://en.wikipedia.org/wiki/Web_colors for choising colors. While doing this change I wondered if we could not authorise and even recommend to use sandard names for colors as shown in Wikipedia page. I found it easier to recall a color by its names than by an hexa number...! As long as we would use this Wikipedia reference I think it could be possible to use names instead of hexa, WDYT ? > * The days initials are not centered but at left (It's late and I did not found the reason) > We need to provide a localisation mean. From http://electronicholas.com/calendar?style=default&format=natural it should not be too hard. I propose a simple way, maybe we can do better > * More calendar formats in a calendar.properties file (like the euro or american ones) > * For the moment I think all string are harcoded in calendar_date_select.js > Date.weekdays = $w("S M T W T F S"); > Date.first_day_of_week = 0; > Date.months = $w("January February March April May June July August September October November December" ); > _translations = { > "OK": "OK", > "Now": "Now", > "Today": "Today" > } > A very simple way (but not very clever I must admit) could be to set a property for the language to use in calendar.properties file and use it in a switch statement with "hardcoded" strings in calendar_date_select.js. Is anybody aware of better ways to do that in Javascript or Prototype ? > BTW I think we should delete calendarstyles.css and calendarTable.css. If it's ok, I will do it when I will upate the attached patch later. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1825) Colors and localisation for the calendar
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784814#action_12784814 ] Jacques Le Roux commented on OFBIZ-1825: ---------------------------------------- Sorry Sascha, Now not only the the Calendar does not return a sortable date format to the input field; but it does not work in French (shows in English) when you 1st load. If you switch from French to English and back to French it's ok. > Colors and localisation for the calendar > ---------------------------------------- > > Key: OFBIZ-1825 > URL: https://issues.apache.org/jira/browse/OFBIZ-1825 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Jacques Le Roux > Assignee: Jacques Le Roux > Priority: Minor > Fix For: Release Branch 9.04 > > Attachments: calendar.patch, calendar_I18n.patch, calendar_I18n.patch, calendar_sequence.patch, calendarDateSelectColor.patch, calendarDateSelectColor.patch, calendarModified.patch, CommonScreens.patch, Existing.jpg, LocalizedDate_it.patch, Proposition.jpg, WE_CAL.gif > > > I tried to change the calendar colors, to be more "in the OFBiz way". Please let me you know what you think. > I also changed some colors to respect our CSS best practices (no color names). > Here are some remarks : > Colors > * I kept the 3 chars scheme when it's was obvious. For instance we don't need to set #000000 or #ffffff when actually #000 or #fff is sufficient. > * I used Wikipedia as reference http://en.wikipedia.org/wiki/Web_colors for choising colors. While doing this change I wondered if we could not authorise and even recommend to use sandard names for colors as shown in Wikipedia page. I found it easier to recall a color by its names than by an hexa number...! As long as we would use this Wikipedia reference I think it could be possible to use names instead of hexa, WDYT ? > * The days initials are not centered but at left (It's late and I did not found the reason) > We need to provide a localisation mean. From http://electronicholas.com/calendar?style=default&format=natural it should not be too hard. I propose a simple way, maybe we can do better > * More calendar formats in a calendar.properties file (like the euro or american ones) > * For the moment I think all string are harcoded in calendar_date_select.js > Date.weekdays = $w("S M T W T F S"); > Date.first_day_of_week = 0; > Date.months = $w("January February March April May June July August September October November December" ); > _translations = { > "OK": "OK", > "Now": "Now", > "Today": "Today" > } > A very simple way (but not very clever I must admit) could be to set a property for the language to use in calendar.properties file and use it in a switch statement with "hardcoded" strings in calendar_date_select.js. Is anybody aware of better ways to do that in Javascript or Prototype ? > BTW I think we should delete calendarstyles.css and calendarTable.css. If it's ok, I will do it when I will upate the attached patch later. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1825) Colors and localisation for the calendar
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784816#action_12784816 ] Jacques Le Roux commented on OFBIZ-1825: ---------------------------------------- Oops, I applied the wrong patch. Seems god so far :) > Colors and localisation for the calendar > ---------------------------------------- > > Key: OFBIZ-1825 > URL: https://issues.apache.org/jira/browse/OFBIZ-1825 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Jacques Le Roux > Assignee: Jacques Le Roux > Priority: Minor > Fix For: Release Branch 9.04 > > Attachments: calendar.patch, calendar_I18n.patch, calendar_I18n.patch, calendar_sequence.patch, calendarDateSelectColor.patch, calendarDateSelectColor.patch, calendarModified.patch, CommonScreens.patch, Existing.jpg, LocalizedDate_it.patch, Proposition.jpg, WE_CAL.gif > > > I tried to change the calendar colors, to be more "in the OFBiz way". Please let me you know what you think. > I also changed some colors to respect our CSS best practices (no color names). > Here are some remarks : > Colors > * I kept the 3 chars scheme when it's was obvious. For instance we don't need to set #000000 or #ffffff when actually #000 or #fff is sufficient. > * I used Wikipedia as reference http://en.wikipedia.org/wiki/Web_colors for choising colors. While doing this change I wondered if we could not authorise and even recommend to use sandard names for colors as shown in Wikipedia page. I found it easier to recall a color by its names than by an hexa number...! As long as we would use this Wikipedia reference I think it could be possible to use names instead of hexa, WDYT ? > * The days initials are not centered but at left (It's late and I did not found the reason) > We need to provide a localisation mean. From http://electronicholas.com/calendar?style=default&format=natural it should not be too hard. I propose a simple way, maybe we can do better > * More calendar formats in a calendar.properties file (like the euro or american ones) > * For the moment I think all string are harcoded in calendar_date_select.js > Date.weekdays = $w("S M T W T F S"); > Date.first_day_of_week = 0; > Date.months = $w("January February March April May June July August September October November December" ); > _translations = { > "OK": "OK", > "Now": "Now", > "Today": "Today" > } > A very simple way (but not very clever I must admit) could be to set a property for the language to use in calendar.properties file and use it in a switch statement with "hardcoded" strings in calendar_date_select.js. Is anybody aware of better ways to do that in Javascript or Prototype ? > BTW I think we should delete calendarstyles.css and calendarTable.css. If it's ok, I will do it when I will upate the attached patch later. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1825) Colors and localisation for the calendar
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784821#action_12784821 ] Sascha Rodekamp commented on OFBIZ-1825: ---------------------------------------- hehe ok :-) fine! when the calendar works. What will be the next step? > Colors and localisation for the calendar > ---------------------------------------- > > Key: OFBIZ-1825 > URL: https://issues.apache.org/jira/browse/OFBIZ-1825 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Jacques Le Roux > Assignee: Jacques Le Roux > Priority: Minor > Fix For: Release Branch 9.04 > > Attachments: calendar.patch, calendar_I18n.patch, calendar_I18n.patch, calendar_sequence.patch, calendarDateSelectColor.patch, calendarDateSelectColor.patch, calendarModified.patch, CommonScreens.patch, Existing.jpg, LocalizedDate_it.patch, Proposition.jpg, WE_CAL.gif > > > I tried to change the calendar colors, to be more "in the OFBiz way". Please let me you know what you think. > I also changed some colors to respect our CSS best practices (no color names). > Here are some remarks : > Colors > * I kept the 3 chars scheme when it's was obvious. For instance we don't need to set #000000 or #ffffff when actually #000 or #fff is sufficient. > * I used Wikipedia as reference http://en.wikipedia.org/wiki/Web_colors for choising colors. While doing this change I wondered if we could not authorise and even recommend to use sandard names for colors as shown in Wikipedia page. I found it easier to recall a color by its names than by an hexa number...! As long as we would use this Wikipedia reference I think it could be possible to use names instead of hexa, WDYT ? > * The days initials are not centered but at left (It's late and I did not found the reason) > We need to provide a localisation mean. From http://electronicholas.com/calendar?style=default&format=natural it should not be too hard. I propose a simple way, maybe we can do better > * More calendar formats in a calendar.properties file (like the euro or american ones) > * For the moment I think all string are harcoded in calendar_date_select.js > Date.weekdays = $w("S M T W T F S"); > Date.first_day_of_week = 0; > Date.months = $w("January February March April May June July August September October November December" ); > _translations = { > "OK": "OK", > "Now": "Now", > "Today": "Today" > } > A very simple way (but not very clever I must admit) could be to set a property for the language to use in calendar.properties file and use it in a switch statement with "hardcoded" strings in calendar_date_select.js. Is anybody aware of better ways to do that in Javascript or Prototype ? > BTW I think we should delete calendarstyles.css and calendarTable.css. If it's ok, I will do it when I will upate the attached patch later. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Closed: (OFBIZ-1825) Colors and localisation for the calendar
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-1825. ---------------------------------- Resolution: Fixed Fix Version/s: (was: Release Branch 9.04) SVN trunk Thanks Sascha, It's great to see this done after so long time. Well done, simple and clear implementation. Do you speak nine languages? ;) Your patch is in trunk at r886143 I have just changed the path to calendar_date_select.js in the LICENCE file (and finally replaced Init by Effacer in French) If someone needs it in R9.04 it's easy to backport (just 2 small conflicts in eCommerce CommonScreens.xml > Colors and localisation for the calendar > ---------------------------------------- > > Key: OFBIZ-1825 > URL: https://issues.apache.org/jira/browse/OFBIZ-1825 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Jacques Le Roux > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: calendar.patch, calendar_I18n.patch, calendar_I18n.patch, calendar_sequence.patch, calendarDateSelectColor.patch, calendarDateSelectColor.patch, calendarModified.patch, CommonScreens.patch, Existing.jpg, LocalizedDate_it.patch, Proposition.jpg, WE_CAL.gif > > > I tried to change the calendar colors, to be more "in the OFBiz way". Please let me you know what you think. > I also changed some colors to respect our CSS best practices (no color names). > Here are some remarks : > Colors > * I kept the 3 chars scheme when it's was obvious. For instance we don't need to set #000000 or #ffffff when actually #000 or #fff is sufficient. > * I used Wikipedia as reference http://en.wikipedia.org/wiki/Web_colors for choising colors. While doing this change I wondered if we could not authorise and even recommend to use sandard names for colors as shown in Wikipedia page. I found it easier to recall a color by its names than by an hexa number...! As long as we would use this Wikipedia reference I think it could be possible to use names instead of hexa, WDYT ? > * The days initials are not centered but at left (It's late and I did not found the reason) > We need to provide a localisation mean. From http://electronicholas.com/calendar?style=default&format=natural it should not be too hard. I propose a simple way, maybe we can do better > * More calendar formats in a calendar.properties file (like the euro or american ones) > * For the moment I think all string are harcoded in calendar_date_select.js > Date.weekdays = $w("S M T W T F S"); > Date.first_day_of_week = 0; > Date.months = $w("January February March April May June July August September October November December" ); > _translations = { > "OK": "OK", > "Now": "Now", > "Today": "Today" > } > A very simple way (but not very clever I must admit) could be to set a property for the language to use in calendar.properties file and use it in a switch statement with "hardcoded" strings in calendar_date_select.js. Is anybody aware of better ways to do that in Javascript or Prototype ? > BTW I think we should delete calendarstyles.css and calendarTable.css. If it's ok, I will do it when I will upate the attached patch later. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1825) Colors and localisation for the calendar
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784834#action_12784834 ] Jacques Le Roux commented on OFBIZ-1825: ---------------------------------------- Hey Sascha, Please give me some rest ;) > Colors and localisation for the calendar > ---------------------------------------- > > Key: OFBIZ-1825 > URL: https://issues.apache.org/jira/browse/OFBIZ-1825 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Jacques Le Roux > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: calendar.patch, calendar_I18n.patch, calendar_I18n.patch, calendar_sequence.patch, calendarDateSelectColor.patch, calendarDateSelectColor.patch, calendarModified.patch, CommonScreens.patch, Existing.jpg, LocalizedDate_it.patch, Proposition.jpg, WE_CAL.gif > > > I tried to change the calendar colors, to be more "in the OFBiz way". Please let me you know what you think. > I also changed some colors to respect our CSS best practices (no color names). > Here are some remarks : > Colors > * I kept the 3 chars scheme when it's was obvious. For instance we don't need to set #000000 or #ffffff when actually #000 or #fff is sufficient. > * I used Wikipedia as reference http://en.wikipedia.org/wiki/Web_colors for choising colors. While doing this change I wondered if we could not authorise and even recommend to use sandard names for colors as shown in Wikipedia page. I found it easier to recall a color by its names than by an hexa number...! As long as we would use this Wikipedia reference I think it could be possible to use names instead of hexa, WDYT ? > * The days initials are not centered but at left (It's late and I did not found the reason) > We need to provide a localisation mean. From http://electronicholas.com/calendar?style=default&format=natural it should not be too hard. I propose a simple way, maybe we can do better > * More calendar formats in a calendar.properties file (like the euro or american ones) > * For the moment I think all string are harcoded in calendar_date_select.js > Date.weekdays = $w("S M T W T F S"); > Date.first_day_of_week = 0; > Date.months = $w("January February March April May June July August September October November December" ); > _translations = { > "OK": "OK", > "Now": "Now", > "Today": "Today" > } > A very simple way (but not very clever I must admit) could be to set a property for the language to use in calendar.properties file and use it in a switch statement with "hardcoded" strings in calendar_date_select.js. Is anybody aware of better ways to do that in Javascript or Prototype ? > BTW I think we should delete calendarstyles.css and calendarTable.css. If it's ok, I will do it when I will upate the attached patch later. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1825) Colors and localisation for the calendar
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784841#action_12784841 ] Sascha Rodekamp commented on OFBIZ-1825: ---------------------------------------- hehe Jacques, nope but google does ;-) > Colors and localisation for the calendar > ---------------------------------------- > > Key: OFBIZ-1825 > URL: https://issues.apache.org/jira/browse/OFBIZ-1825 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Jacques Le Roux > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: calendar.patch, calendar_I18n.patch, calendar_I18n.patch, calendar_sequence.patch, calendarDateSelectColor.patch, calendarDateSelectColor.patch, calendarModified.patch, CommonScreens.patch, Existing.jpg, LocalizedDate_it.patch, Proposition.jpg, WE_CAL.gif > > > I tried to change the calendar colors, to be more "in the OFBiz way". Please let me you know what you think. > I also changed some colors to respect our CSS best practices (no color names). > Here are some remarks : > Colors > * I kept the 3 chars scheme when it's was obvious. For instance we don't need to set #000000 or #ffffff when actually #000 or #fff is sufficient. > * I used Wikipedia as reference http://en.wikipedia.org/wiki/Web_colors for choising colors. While doing this change I wondered if we could not authorise and even recommend to use sandard names for colors as shown in Wikipedia page. I found it easier to recall a color by its names than by an hexa number...! As long as we would use this Wikipedia reference I think it could be possible to use names instead of hexa, WDYT ? > * The days initials are not centered but at left (It's late and I did not found the reason) > We need to provide a localisation mean. From http://electronicholas.com/calendar?style=default&format=natural it should not be too hard. I propose a simple way, maybe we can do better > * More calendar formats in a calendar.properties file (like the euro or american ones) > * For the moment I think all string are harcoded in calendar_date_select.js > Date.weekdays = $w("S M T W T F S"); > Date.first_day_of_week = 0; > Date.months = $w("January February March April May June July August September October November December" ); > _translations = { > "OK": "OK", > "Now": "Now", > "Today": "Today" > } > A very simple way (but not very clever I must admit) could be to set a property for the language to use in calendar.properties file and use it in a switch statement with "hardcoded" strings in calendar_date_select.js. Is anybody aware of better ways to do that in Javascript or Prototype ? > BTW I think we should delete calendarstyles.css and calendarTable.css. If it's ok, I will do it when I will upate the attached patch later. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1825) Colors and localisation for the calendar
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12785224#action_12785224 ] Jacques Le Roux commented on OFBIZ-1825: ---------------------------------------- Sascha, I thought that maybe you could find some ideas to work on [here|http://cwiki.apache.org/confluence/display/OFBADMIN/New+Features+Roadmap+-+Living+Document#NewFeaturesRoadmap-LivingDocument-Quickeranintuitiveaccesstobasicfunctionnalities(creation,etc.)] > Colors and localisation for the calendar > ---------------------------------------- > > Key: OFBIZ-1825 > URL: https://issues.apache.org/jira/browse/OFBIZ-1825 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Jacques Le Roux > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: calendar.patch, calendar_I18n.patch, calendar_I18n.patch, calendar_sequence.patch, calendarDateSelectColor.patch, calendarDateSelectColor.patch, calendarModified.patch, CommonScreens.patch, Existing.jpg, LocalizedDate_it.patch, Proposition.jpg, WE_CAL.gif > > > I tried to change the calendar colors, to be more "in the OFBiz way". Please let me you know what you think. > I also changed some colors to respect our CSS best practices (no color names). > Here are some remarks : > Colors > * I kept the 3 chars scheme when it's was obvious. For instance we don't need to set #000000 or #ffffff when actually #000 or #fff is sufficient. > * I used Wikipedia as reference http://en.wikipedia.org/wiki/Web_colors for choising colors. While doing this change I wondered if we could not authorise and even recommend to use sandard names for colors as shown in Wikipedia page. I found it easier to recall a color by its names than by an hexa number...! As long as we would use this Wikipedia reference I think it could be possible to use names instead of hexa, WDYT ? > * The days initials are not centered but at left (It's late and I did not found the reason) > We need to provide a localisation mean. From http://electronicholas.com/calendar?style=default&format=natural it should not be too hard. I propose a simple way, maybe we can do better > * More calendar formats in a calendar.properties file (like the euro or american ones) > * For the moment I think all string are harcoded in calendar_date_select.js > Date.weekdays = $w("S M T W T F S"); > Date.first_day_of_week = 0; > Date.months = $w("January February March April May June July August September October November December" ); > _translations = { > "OK": "OK", > "Now": "Now", > "Today": "Today" > } > A very simple way (but not very clever I must admit) could be to set a property for the language to use in calendar.properties file and use it in a switch statement with "hardcoded" strings in calendar_date_select.js. Is anybody aware of better ways to do that in Javascript or Prototype ? > BTW I think we should delete calendarstyles.css and calendarTable.css. If it's ok, I will do it when I will upate the attached patch later. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1825) Colors and localisation for the calendar
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12785230#action_12785230 ] Sascha Rodekamp commented on OFBIZ-1825: ---------------------------------------- Hey Jacques, and good morning. ok i will have a look. I have some ideas to improve the UI, too. But before i have to preparade my oral diploma exams for next week. :-) (btw: i wrote about OFBiz) Have a nice day ;) Sascha > Colors and localisation for the calendar > ---------------------------------------- > > Key: OFBIZ-1825 > URL: https://issues.apache.org/jira/browse/OFBIZ-1825 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Jacques Le Roux > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: calendar.patch, calendar_I18n.patch, calendar_I18n.patch, calendar_sequence.patch, calendarDateSelectColor.patch, calendarDateSelectColor.patch, calendarModified.patch, CommonScreens.patch, Existing.jpg, LocalizedDate_it.patch, Proposition.jpg, WE_CAL.gif > > > I tried to change the calendar colors, to be more "in the OFBiz way". Please let me you know what you think. > I also changed some colors to respect our CSS best practices (no color names). > Here are some remarks : > Colors > * I kept the 3 chars scheme when it's was obvious. For instance we don't need to set #000000 or #ffffff when actually #000 or #fff is sufficient. > * I used Wikipedia as reference http://en.wikipedia.org/wiki/Web_colors for choising colors. While doing this change I wondered if we could not authorise and even recommend to use sandard names for colors as shown in Wikipedia page. I found it easier to recall a color by its names than by an hexa number...! As long as we would use this Wikipedia reference I think it could be possible to use names instead of hexa, WDYT ? > * The days initials are not centered but at left (It's late and I did not found the reason) > We need to provide a localisation mean. From http://electronicholas.com/calendar?style=default&format=natural it should not be too hard. I propose a simple way, maybe we can do better > * More calendar formats in a calendar.properties file (like the euro or american ones) > * For the moment I think all string are harcoded in calendar_date_select.js > Date.weekdays = $w("S M T W T F S"); > Date.first_day_of_week = 0; > Date.months = $w("January February March April May June July August September October November December" ); > _translations = { > "OK": "OK", > "Now": "Now", > "Today": "Today" > } > A very simple way (but not very clever I must admit) could be to set a property for the language to use in calendar.properties file and use it in a switch statement with "hardcoded" strings in calendar_date_select.js. Is anybody aware of better ways to do that in Javascript or Prototype ? > BTW I think we should delete calendarstyles.css and calendarTable.css. If it's ok, I will do it when I will upate the attached patch later. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1825) Colors and localisation for the calendar
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12785234#action_12785234 ] Jacques Le Roux commented on OFBIZ-1825: ---------------------------------------- Good luck Sascha! > Colors and localisation for the calendar > ---------------------------------------- > > Key: OFBIZ-1825 > URL: https://issues.apache.org/jira/browse/OFBIZ-1825 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Jacques Le Roux > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: calendar.patch, calendar_I18n.patch, calendar_I18n.patch, calendar_sequence.patch, calendarDateSelectColor.patch, calendarDateSelectColor.patch, calendarModified.patch, CommonScreens.patch, Existing.jpg, LocalizedDate_it.patch, Proposition.jpg, WE_CAL.gif > > > I tried to change the calendar colors, to be more "in the OFBiz way". Please let me you know what you think. > I also changed some colors to respect our CSS best practices (no color names). > Here are some remarks : > Colors > * I kept the 3 chars scheme when it's was obvious. For instance we don't need to set #000000 or #ffffff when actually #000 or #fff is sufficient. > * I used Wikipedia as reference http://en.wikipedia.org/wiki/Web_colors for choising colors. While doing this change I wondered if we could not authorise and even recommend to use sandard names for colors as shown in Wikipedia page. I found it easier to recall a color by its names than by an hexa number...! As long as we would use this Wikipedia reference I think it could be possible to use names instead of hexa, WDYT ? > * The days initials are not centered but at left (It's late and I did not found the reason) > We need to provide a localisation mean. From http://electronicholas.com/calendar?style=default&format=natural it should not be too hard. I propose a simple way, maybe we can do better > * More calendar formats in a calendar.properties file (like the euro or american ones) > * For the moment I think all string are harcoded in calendar_date_select.js > Date.weekdays = $w("S M T W T F S"); > Date.first_day_of_week = 0; > Date.months = $w("January February March April May June July August September October November December" ); > _translations = { > "OK": "OK", > "Now": "Now", > "Today": "Today" > } > A very simple way (but not very clever I must admit) could be to set a property for the language to use in calendar.properties file and use it in a switch statement with "hardcoded" strings in calendar_date_select.js. Is anybody aware of better ways to do that in Javascript or Prototype ? > BTW I think we should delete calendarstyles.css and calendarTable.css. If it's ok, I will do it when I will upate the attached patch later. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1825) Colors and localisation for the calendar
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12785243#action_12785243 ] Jacques Le Roux commented on OFBIZ-1825: ---------------------------------------- A bug has been fixed in r886723 Sascha I wonder why you put the ! in ${parameters.userLogin.lastLocale!} in main.ftl and also why I did not spot it though I thought that js file may be missing with some languages. But as my tests were ok (even with hi_IN which is weird now...) I did not care :/ Not a big deal but surprising > Colors and localisation for the calendar > ---------------------------------------- > > Key: OFBIZ-1825 > URL: https://issues.apache.org/jira/browse/OFBIZ-1825 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Jacques Le Roux > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: calendar.patch, calendar_I18n.patch, calendar_I18n.patch, calendar_sequence.patch, calendarDateSelectColor.patch, calendarDateSelectColor.patch, calendarModified.patch, CommonScreens.patch, Existing.jpg, LocalizedDate_it.patch, Proposition.jpg, WE_CAL.gif > > > I tried to change the calendar colors, to be more "in the OFBiz way". Please let me you know what you think. > I also changed some colors to respect our CSS best practices (no color names). > Here are some remarks : > Colors > * I kept the 3 chars scheme when it's was obvious. For instance we don't need to set #000000 or #ffffff when actually #000 or #fff is sufficient. > * I used Wikipedia as reference http://en.wikipedia.org/wiki/Web_colors for choising colors. While doing this change I wondered if we could not authorise and even recommend to use sandard names for colors as shown in Wikipedia page. I found it easier to recall a color by its names than by an hexa number...! As long as we would use this Wikipedia reference I think it could be possible to use names instead of hexa, WDYT ? > * The days initials are not centered but at left (It's late and I did not found the reason) > We need to provide a localisation mean. From http://electronicholas.com/calendar?style=default&format=natural it should not be too hard. I propose a simple way, maybe we can do better > * More calendar formats in a calendar.properties file (like the euro or american ones) > * For the moment I think all string are harcoded in calendar_date_select.js > Date.weekdays = $w("S M T W T F S"); > Date.first_day_of_week = 0; > Date.months = $w("January February March April May June July August September October November December" ); > _translations = { > "OK": "OK", > "Now": "Now", > "Today": "Today" > } > A very simple way (but not very clever I must admit) could be to set a property for the language to use in calendar.properties file and use it in a switch statement with "hardcoded" strings in calendar_date_select.js. Is anybody aware of better ways to do that in Javascript or Prototype ? > BTW I think we should delete calendarstyles.css and calendarTable.css. If it's ok, I will do it when I will upate the attached patch later. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1825) Colors and localisation for the calendar
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12785246#action_12785246 ] Jacques Le Roux commented on OFBIZ-1825: ---------------------------------------- Browser cache was the reason (I should have think about it since it was related to javascript) > Colors and localisation for the calendar > ---------------------------------------- > > Key: OFBIZ-1825 > URL: https://issues.apache.org/jira/browse/OFBIZ-1825 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Jacques Le Roux > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: calendar.patch, calendar_I18n.patch, calendar_I18n.patch, calendar_sequence.patch, calendarDateSelectColor.patch, calendarDateSelectColor.patch, calendarModified.patch, CommonScreens.patch, Existing.jpg, LocalizedDate_it.patch, Proposition.jpg, WE_CAL.gif > > > I tried to change the calendar colors, to be more "in the OFBiz way". Please let me you know what you think. > I also changed some colors to respect our CSS best practices (no color names). > Here are some remarks : > Colors > * I kept the 3 chars scheme when it's was obvious. For instance we don't need to set #000000 or #ffffff when actually #000 or #fff is sufficient. > * I used Wikipedia as reference http://en.wikipedia.org/wiki/Web_colors for choising colors. While doing this change I wondered if we could not authorise and even recommend to use sandard names for colors as shown in Wikipedia page. I found it easier to recall a color by its names than by an hexa number...! As long as we would use this Wikipedia reference I think it could be possible to use names instead of hexa, WDYT ? > * The days initials are not centered but at left (It's late and I did not found the reason) > We need to provide a localisation mean. From http://electronicholas.com/calendar?style=default&format=natural it should not be too hard. I propose a simple way, maybe we can do better > * More calendar formats in a calendar.properties file (like the euro or american ones) > * For the moment I think all string are harcoded in calendar_date_select.js > Date.weekdays = $w("S M T W T F S"); > Date.first_day_of_week = 0; > Date.months = $w("January February March April May June July August September October November December" ); > _translations = { > "OK": "OK", > "Now": "Now", > "Today": "Today" > } > A very simple way (but not very clever I must admit) could be to set a property for the language to use in calendar.properties file and use it in a switch statement with "hardcoded" strings in calendar_date_select.js. Is anybody aware of better ways to do that in Javascript or Prototype ? > BTW I think we should delete calendarstyles.css and calendarTable.css. If it's ok, I will do it when I will upate the attached patch later. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1825) Colors and localisation for the calendar
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12785257#action_12785257 ] Sascha Rodekamp commented on OFBIZ-1825: ---------------------------------------- hehe ok no problem > Colors and localisation for the calendar > ---------------------------------------- > > Key: OFBIZ-1825 > URL: https://issues.apache.org/jira/browse/OFBIZ-1825 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Jacques Le Roux > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: calendar.patch, calendar_I18n.patch, calendar_I18n.patch, calendar_sequence.patch, calendarDateSelectColor.patch, calendarDateSelectColor.patch, calendarModified.patch, CommonScreens.patch, Existing.jpg, LocalizedDate_it.patch, Proposition.jpg, WE_CAL.gif > > > I tried to change the calendar colors, to be more "in the OFBiz way". Please let me you know what you think. > I also changed some colors to respect our CSS best practices (no color names). > Here are some remarks : > Colors > * I kept the 3 chars scheme when it's was obvious. For instance we don't need to set #000000 or #ffffff when actually #000 or #fff is sufficient. > * I used Wikipedia as reference http://en.wikipedia.org/wiki/Web_colors for choising colors. While doing this change I wondered if we could not authorise and even recommend to use sandard names for colors as shown in Wikipedia page. I found it easier to recall a color by its names than by an hexa number...! As long as we would use this Wikipedia reference I think it could be possible to use names instead of hexa, WDYT ? > * The days initials are not centered but at left (It's late and I did not found the reason) > We need to provide a localisation mean. From http://electronicholas.com/calendar?style=default&format=natural it should not be too hard. I propose a simple way, maybe we can do better > * More calendar formats in a calendar.properties file (like the euro or american ones) > * For the moment I think all string are harcoded in calendar_date_select.js > Date.weekdays = $w("S M T W T F S"); > Date.first_day_of_week = 0; > Date.months = $w("January February March April May June July August September October November December" ); > _translations = { > "OK": "OK", > "Now": "Now", > "Today": "Today" > } > A very simple way (but not very clever I must admit) could be to set a property for the language to use in calendar.properties file and use it in a switch statement with "hardcoded" strings in calendar_date_select.js. Is anybody aware of better ways to do that in Javascript or Prototype ? > BTW I think we should delete calendarstyles.css and calendarTable.css. If it's ok, I will do it when I will upate the attached patch later. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1825) Colors and localisation for the calendar
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12785910#action_12785910 ] Jacques Le Roux commented on OFBIZ-1825: ---------------------------------------- A new fix in r887166, following [this thread|http://markmail.org/message/oozkxcgezgahosru] > Colors and localisation for the calendar > ---------------------------------------- > > Key: OFBIZ-1825 > URL: https://issues.apache.org/jira/browse/OFBIZ-1825 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Jacques Le Roux > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: calendar.patch, calendar_I18n.patch, calendar_I18n.patch, calendar_sequence.patch, calendarDateSelectColor.patch, calendarDateSelectColor.patch, calendarModified.patch, CommonScreens.patch, Existing.jpg, LocalizedDate_it.patch, Proposition.jpg, WE_CAL.gif > > > I tried to change the calendar colors, to be more "in the OFBiz way". Please let me you know what you think. > I also changed some colors to respect our CSS best practices (no color names). > Here are some remarks : > Colors > * I kept the 3 chars scheme when it's was obvious. For instance we don't need to set #000000 or #ffffff when actually #000 or #fff is sufficient. > * I used Wikipedia as reference http://en.wikipedia.org/wiki/Web_colors for choising colors. While doing this change I wondered if we could not authorise and even recommend to use sandard names for colors as shown in Wikipedia page. I found it easier to recall a color by its names than by an hexa number...! As long as we would use this Wikipedia reference I think it could be possible to use names instead of hexa, WDYT ? > * The days initials are not centered but at left (It's late and I did not found the reason) > We need to provide a localisation mean. From http://electronicholas.com/calendar?style=default&format=natural it should not be too hard. I propose a simple way, maybe we can do better > * More calendar formats in a calendar.properties file (like the euro or american ones) > * For the moment I think all string are harcoded in calendar_date_select.js > Date.weekdays = $w("S M T W T F S"); > Date.first_day_of_week = 0; > Date.months = $w("January February March April May June July August September October November December" ); > _translations = { > "OK": "OK", > "Now": "Now", > "Today": "Today" > } > A very simple way (but not very clever I must admit) could be to set a property for the language to use in calendar.properties file and use it in a switch statement with "hardcoded" strings in calendar_date_select.js. Is anybody aware of better ways to do that in Javascript or Prototype ? > BTW I think we should delete calendarstyles.css and calendarTable.css. If it's ok, I will do it when I will upate the attached patch later. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1825) Colors and localisation for the calendar
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12786374#action_12786374 ] Jacques Le Roux commented on OFBIZ-1825: ---------------------------------------- Last fix at r887454 > Colors and localisation for the calendar > ---------------------------------------- > > Key: OFBIZ-1825 > URL: https://issues.apache.org/jira/browse/OFBIZ-1825 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Jacques Le Roux > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: calendar.patch, calendar_I18n.patch, calendar_I18n.patch, calendar_sequence.patch, calendarDateSelectColor.patch, calendarDateSelectColor.patch, calendarModified.patch, CommonScreens.patch, Existing.jpg, LocalizedDate_it.patch, Proposition.jpg, WE_CAL.gif > > > I tried to change the calendar colors, to be more "in the OFBiz way". Please let me you know what you think. > I also changed some colors to respect our CSS best practices (no color names). > Here are some remarks : > Colors > * I kept the 3 chars scheme when it's was obvious. For instance we don't need to set #000000 or #ffffff when actually #000 or #fff is sufficient. > * I used Wikipedia as reference http://en.wikipedia.org/wiki/Web_colors for choising colors. While doing this change I wondered if we could not authorise and even recommend to use sandard names for colors as shown in Wikipedia page. I found it easier to recall a color by its names than by an hexa number...! As long as we would use this Wikipedia reference I think it could be possible to use names instead of hexa, WDYT ? > * The days initials are not centered but at left (It's late and I did not found the reason) > We need to provide a localisation mean. From http://electronicholas.com/calendar?style=default&format=natural it should not be too hard. I propose a simple way, maybe we can do better > * More calendar formats in a calendar.properties file (like the euro or american ones) > * For the moment I think all string are harcoded in calendar_date_select.js > Date.weekdays = $w("S M T W T F S"); > Date.first_day_of_week = 0; > Date.months = $w("January February March April May June July August September October November December" ); > _translations = { > "OK": "OK", > "Now": "Now", > "Today": "Today" > } > A very simple way (but not very clever I must admit) could be to set a property for the language to use in calendar.properties file and use it in a switch statement with "hardcoded" strings in calendar_date_select.js. Is anybody aware of better ways to do that in Javascript or Prototype ? > BTW I think we should delete calendarstyles.css and calendarTable.css. If it's ok, I will do it when I will upate the attached patch later. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1825) Colors and localisation for the calendar
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12786530#action_12786530 ] Jacques Le Roux commented on OFBIZ-1825: ---------------------------------------- Here is an [interesting thread about the calendar and milliseconds|http://markmail.org/message/l5uszww5u4qjyoph]. I note here is as it's easier for me to remember > Colors and localisation for the calendar > ---------------------------------------- > > Key: OFBIZ-1825 > URL: https://issues.apache.org/jira/browse/OFBIZ-1825 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Jacques Le Roux > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: calendar.patch, calendar_I18n.patch, calendar_I18n.patch, calendar_sequence.patch, calendarDateSelectColor.patch, calendarDateSelectColor.patch, calendarModified.patch, CommonScreens.patch, Existing.jpg, LocalizedDate_it.patch, Proposition.jpg, WE_CAL.gif > > > I tried to change the calendar colors, to be more "in the OFBiz way". Please let me you know what you think. > I also changed some colors to respect our CSS best practices (no color names). > Here are some remarks : > Colors > * I kept the 3 chars scheme when it's was obvious. For instance we don't need to set #000000 or #ffffff when actually #000 or #fff is sufficient. > * I used Wikipedia as reference http://en.wikipedia.org/wiki/Web_colors for choising colors. While doing this change I wondered if we could not authorise and even recommend to use sandard names for colors as shown in Wikipedia page. I found it easier to recall a color by its names than by an hexa number...! As long as we would use this Wikipedia reference I think it could be possible to use names instead of hexa, WDYT ? > * The days initials are not centered but at left (It's late and I did not found the reason) > We need to provide a localisation mean. From http://electronicholas.com/calendar?style=default&format=natural it should not be too hard. I propose a simple way, maybe we can do better > * More calendar formats in a calendar.properties file (like the euro or american ones) > * For the moment I think all string are harcoded in calendar_date_select.js > Date.weekdays = $w("S M T W T F S"); > Date.first_day_of_week = 0; > Date.months = $w("January February March April May June July August September October November December" ); > _translations = { > "OK": "OK", > "Now": "Now", > "Today": "Today" > } > A very simple way (but not very clever I must admit) could be to set a property for the language to use in calendar.properties file and use it in a switch statement with "hardcoded" strings in calendar_date_select.js. Is anybody aware of better ways to do that in Javascript or Prototype ? > BTW I think we should delete calendarstyles.css and calendarTable.css. If it's ok, I will do it when I will upate the attached patch later. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |