[jira] Created: (OFBIZ-1851) Sandbox: Fixed Asset Meter Reading Improvement

[Nicolas Malin (Jira)]

Sandbox: Fixed Asset Meter Reading Improvement
----------------------------------------------

                 Key: OFBIZ-1851
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1851
             Project: OFBiz
          Issue Type: Improvement
          Components: accounting
            Reporter: Adrian Crum
            Priority: Minor


The current fixed asset meter reading logic is set up to only allow a meter reading when a fixed asset maintenance is created. This improvement would remove that requirement and make the connection to a maintenance optional.


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-1851:
-------------------------------

    Attachment: meter_reading.patch

The attached patch demonstrates the change.

If there are no objections, then I will commit this, and then start working on code to create maintenance tasks when meter readings cross a maintenance threshold.

Comments are welcome.

> Sandbox: Fixed Asset Meter Reading Improvement
> ----------------------------------------------
>
>                 Key: OFBIZ-1851
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1851
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: meter_reading.patch
>
>
> The current fixed asset meter reading logic is set up to only allow a meter reading when a fixed asset maintenance is created. This improvement would remove that requirement and make the connection to a maintenance optional.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12608139#action_12608139 ]

David E. Jones commented on OFBIZ-1851:
---------------------------------------

Yeah, I object a bit. I don't like the idea of killing the FixedAssetMaintMeter entity as its role in the maintenance stuff is pretty important and this change makes certain things difficult (or impossible?) like determining when the next maintenance is needed.

I'd prefer to see an additional entity for general purpose readings, like this:

FixedAssetMeterReading
fixedAssetId*
productMeterTypeId*
readingDate*
readingReasonEnumId (could be optional; use begin reading, use end reading, calendar/scheduled reading, etc)
meterValue
workEffortId (if the reading was done before or after a certain work effort)

I think it is different enough from the MaintMeter entity to justify a separate one. There are also legacy and existing code reasons to keep them distinct.  However we model it, there is a need to have one or more meter readings associated with a maintenance, and having a tighter data model for that is helpful.

Even if we combined them, we should key off the readingDate and not the meterValue. I think I see your reason for using the meterValue (it _should_ always be changing), but it might not change while time always will. For periodic readings if the asset was not used it would be the same.

> Sandbox: Fixed Asset Meter Reading Improvement
> ----------------------------------------------
>
>                 Key: OFBIZ-1851
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1851
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: meter_reading.patch
>
>
> The current fixed asset meter reading logic is set up to only allow a meter reading when a fixed asset maintenance is created. This improvement would remove that requirement and make the connection to a maintenance optional.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12608155#action_12608155 ]

Adrian Crum commented on OFBIZ-1851:
------------------------------------

David,

I understand there are existing installations using fixed asset maintenance (our company is one of them) and I have been sensitive to backwards compatibility. In my recent work on the Asset Maintenance component I have made sure that all existing functionality remains intact, while building out additional features.

The same holds true with this patch. I added the ability to enter meter readings that are not attached to a maintenance. I haven't taken any existing functionality away. If this patch makes it impossible to determine when the next maintenance is needed, then that problem exists without the patch.

Anyways, I'll make some of the changes you suggested here and on the mailing list, then I'll submit another patch.

> Sandbox: Fixed Asset Meter Reading Improvement
> ----------------------------------------------
>
>                 Key: OFBIZ-1851
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1851
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: meter_reading.patch
>
>
> The current fixed asset meter reading logic is set up to only allow a meter reading when a fixed asset maintenance is created. This improvement would remove that requirement and make the connection to a maintenance optional.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12608158#action_12608158 ]

David E. Jones commented on OFBIZ-1851:
---------------------------------------

Dude, read, research, and think before you write. This is a waste of time.

> Sandbox: Fixed Asset Meter Reading Improvement
> ----------------------------------------------
>
>                 Key: OFBIZ-1851
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1851
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: meter_reading.patch
>
>
> The current fixed asset meter reading logic is set up to only allow a meter reading when a fixed asset maintenance is created. This improvement would remove that requirement and make the connection to a maintenance optional.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12608184#action_12608184 ]

Anil K Patel commented on OFBIZ-1851:
-------------------------------------

Adrian,
I have used this app Where our company had their own Re-Fueling stations. Every time driver refueled  they also entered Odometer reading. Once a day a process was run to download data from dispensers and uploaded data in Ofbiz.

I did not see problems with current data model for supporting so often meter reading recordings. I am saying all this because I think we don't need any major change in current model.

> Sandbox: Fixed Asset Meter Reading Improvement
> ----------------------------------------------
>
>                 Key: OFBIZ-1851
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1851
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: meter_reading.patch
>
>
> The current fixed asset meter reading logic is set up to only allow a meter reading when a fixed asset maintenance is created. This improvement would remove that requirement and make the connection to a maintenance optional.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12608195#action_12608195 ]

Anil K Patel commented on OFBIZ-1851:
-------------------------------------

Contents from David's email back when I did implementation.


On the ProductMaint entity these fields are meant to represent the interval at which the maintenance represented by the record needs to be performed, like once every 3,000 miles, or once every 100 hours, or whatever. If there is a meter configured it should be associated with that meter using the intervalMeterType.

On the FixedAssetMaint entity, which is a record of maintenance done (whereas on the product one it is a schedule for maintenance needing to be done), those fields would represent the actual numbers for the instance in which the maintenance was done, and are meant to come from whatever meter on the asset that is used to determine when that particular maintenance is needed, like the mile meter or hour meter as mentioned above.

Other meter readings can be attached to the FixedAssetMaint record, but these primary meter fields and values are what would be used to determine the next time that maintenance needs to be done so are fields on the main record rather than something joined in on another entity.

I hope that clears up the use and such that I had in mind for these. If there is a particular part of this that I still haven't explained adequately, please let me know.

-David


Anil K Patel wrote:

> David,
> I am little bit confused about use of following fields in
> FixedAssetMaint table.
> Interval Quantity          
> Interval Uom          
> Interval Meter Type
>
> We have similar fields in ProductMaint table also.
>
> Regards
> Anil Patel
>

> Sandbox: Fixed Asset Meter Reading Improvement
> ----------------------------------------------
>
>                 Key: OFBIZ-1851
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1851
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: meter_reading.patch
>
>
> The current fixed asset meter reading logic is set up to only allow a meter reading when a fixed asset maintenance is created. This improvement would remove that requirement and make the connection to a maintenance optional.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-1851:
-------------------------------

    Attachment: meter_reading.patch

Improved meter_reading.patch file - now includes David's suggestions.

I don't know how to set up an automatic service to move data from the old entity to the new one. If anyone could point me in the right direction it would be greatly appreciated!

> Sandbox: Fixed Asset Meter Reading Improvement
> ----------------------------------------------
>
>                 Key: OFBIZ-1851
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1851
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: meter_reading.patch, meter_reading.patch
>
>
> The current fixed asset meter reading logic is set up to only allow a meter reading when a fixed asset maintenance is created. This improvement would remove that requirement and make the connection to a maintenance optional.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12608515#action_12608515 ]

Adrian Crum commented on OFBIZ-1851:
------------------------------------

Anil,

Thank you very much for the email - that was the piece of data that was missing.

I don't see where a ProductMaint can be created in the Asset Maintenance or Fixed Asset components. Did anyone ever create a UI for that?

> Sandbox: Fixed Asset Meter Reading Improvement
> ----------------------------------------------
>
>                 Key: OFBIZ-1851
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1851
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: meter_reading.patch, meter_reading.patch
>
>
> The current fixed asset meter reading logic is set up to only allow a meter reading when a fixed asset maintenance is created. This improvement would remove that requirement and make the connection to a maintenance optional.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12608577#action_12608577 ]

Anil K Patel commented on OFBIZ-1851:
-------------------------------------

yes there is UI for it in Product screen set.
Regards
Anil Patel

> Sandbox: Fixed Asset Meter Reading Improvement
> ----------------------------------------------
>
>                 Key: OFBIZ-1851
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1851
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: meter_reading.patch, meter_reading.patch
>
>
> The current fixed asset meter reading logic is set up to only allow a meter reading when a fixed asset maintenance is created. This improvement would remove that requirement and make the connection to a maintenance optional.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-1851:
-------------------------------

    Attachment: meter_reading.patch

Improved patch. Now includes entity migration service.

> Sandbox: Fixed Asset Meter Reading Improvement
> ----------------------------------------------
>
>                 Key: OFBIZ-1851
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1851
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: meter_reading.patch, meter_reading.patch, meter_reading.patch
>
>
> The current fixed asset meter reading logic is set up to only allow a meter reading when a fixed asset maintenance is created. This improvement would remove that requirement and make the connection to a maintenance optional.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12610083#action_12610083 ]

Adrian Crum commented on OFBIZ-1851:
------------------------------------

Bump.

This issue is a week old now. I'd like to get these changes committed.

> Sandbox: Fixed Asset Meter Reading Improvement
> ----------------------------------------------
>
>                 Key: OFBIZ-1851
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1851
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: meter_reading.patch, meter_reading.patch, meter_reading.patch
>
>
> The current fixed asset meter reading logic is set up to only allow a meter reading when a fixed asset maintenance is created. This improvement would remove that requirement and make the connection to a maintenance optional.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum closed OFBIZ-1851.
------------------------------

    Resolution: Fixed

Fixed, rev 673842.

> Sandbox: Fixed Asset Meter Reading Improvement
> ----------------------------------------------
>
>                 Key: OFBIZ-1851
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1851
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: meter_reading.patch, meter_reading.patch, meter_reading.patch
>
>
> The current fixed asset meter reading logic is set up to only allow a meter reading when a fixed asset maintenance is created. This improvement would remove that requirement and make the connection to a maintenance optional.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.