[jira] Created: (OFBIZ-1881) Using FindScreenDecorator in Content Application

[Nicolas Malin (Jira)]

Using FindScreenDecorator in Content Application
------------------------------------------------

                 Key: OFBIZ-1881
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1881
             Project: OFBiz
          Issue Type: Improvement
          Components: content
    Affects Versions: SVN trunk
            Reporter: Bruno Busco
         Attachments: FindScreenDecorator_content.patch

Please find attached a patch to use the FindScreenDecorator in Content Application

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco updated OFBIZ-1881:
-------------------------------

    Attachment: FindScreenDecorator_content.patch

> Using FindScreenDecorator in Content Application
> ------------------------------------------------
>
>                 Key: OFBIZ-1881
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1881
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: content
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>         Attachments: FindScreenDecorator_content.patch
>
>
> Please find attached a patch to use the FindScreenDecorator in Content Application

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco updated OFBIZ-1881:
-------------------------------

    Attachment: FindScreenDecorator_content_1.patch

An improved patch (FindScreenDecorator_content_1.patch) has been attached.
- Several screens have been improved with ajax pagination.
- A duplication of the file ContentForms.xml has been removed

> Using FindScreenDecorator in Content Application
> ------------------------------------------------
>
>                 Key: OFBIZ-1881
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1881
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: content
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>         Attachments: FindScreenDecorator_content.patch, FindScreenDecorator_content_1.patch
>
>
> Please find attached a patch to use the FindScreenDecorator in Content Application

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco updated OFBIZ-1881:
-------------------------------

    Attachment: AjaxPagination.patch

> Using FindScreenDecorator in Content Application
> ------------------------------------------------
>
>                 Key: OFBIZ-1881
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1881
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: content
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>         Attachments: AjaxPagination.patch, DuplicationRemoved.patch, FindScreenDecorator.patch
>
>
> Please find attached a patch to use the FindScreenDecorator in Content Application

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco updated OFBIZ-1881:
-------------------------------

    Attachment:     (was: FindScreenDecorator_content_1.patch)

> Using FindScreenDecorator in Content Application
> ------------------------------------------------
>
>                 Key: OFBIZ-1881
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1881
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: content
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>         Attachments: AjaxPagination.patch, DuplicationRemoved.patch, FindScreenDecorator.patch
>
>
> Please find attached a patch to use the FindScreenDecorator in Content Application

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco updated OFBIZ-1881:
-------------------------------

    Attachment: FindScreenDecorator.patch

> Using FindScreenDecorator in Content Application
> ------------------------------------------------
>
>                 Key: OFBIZ-1881
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1881
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: content
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>         Attachments: AjaxPagination.patch, DuplicationRemoved.patch, FindScreenDecorator.patch
>
>
> Please find attached a patch to use the FindScreenDecorator in Content Application

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco updated OFBIZ-1881:
-------------------------------

    Attachment:     (was: FindScreenDecorator_content.patch)

> Using FindScreenDecorator in Content Application
> ------------------------------------------------
>
>                 Key: OFBIZ-1881
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1881
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: content
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>         Attachments: AjaxPagination.patch, DuplicationRemoved.patch, FindScreenDecorator.patch
>
>
> Please find attached a patch to use the FindScreenDecorator in Content Application

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco updated OFBIZ-1881:
-------------------------------

    Attachment: DuplicationRemoved.patch

> Using FindScreenDecorator in Content Application
> ------------------------------------------------
>
>                 Key: OFBIZ-1881
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1881
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: content
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>         Attachments: AjaxPagination.patch, DuplicationRemoved.patch, FindScreenDecorator.patch
>
>
> Please find attached a patch to use the FindScreenDecorator in Content Application

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616648#action_12616648 ]

Bruno Busco commented on OFBIZ-1881:
------------------------------------

Following Adrian suggestion about patch guidelines in Dev ML i decided to split the previous attached patch into three simpler patches.

- DuplicationRemoved.patch is a (trivial) bug fix that removes a viewmap duplication in the controller.xml file and removes a not used copy of ContentForms.xml file located in webapp folder.

- AjaxPagination.patch activates the Ajax pagination on several forms

- FindScreenDecorator.patch make several screens use the FindScreenDecorator

> Using FindScreenDecorator in Content Application
> ------------------------------------------------
>
>                 Key: OFBIZ-1881
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1881
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: content
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>         Attachments: AjaxPagination.patch, DuplicationRemoved.patch, FindScreenDecorator.patch
>
>
> Please find attached a patch to use the FindScreenDecorator in Content Application

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reassigned OFBIZ-1881:
--------------------------------------

    Assignee: Jacques Le Roux

> Using FindScreenDecorator in Content Application
> ------------------------------------------------
>
>                 Key: OFBIZ-1881
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1881
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: content
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>            Assignee: Jacques Le Roux
>         Attachments: AjaxPagination.patch, DuplicationRemoved.patch, FindScreenDecorator.patch
>
>
> Please find attached a patch to use the FindScreenDecorator in Content Application

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616660#action_12616660 ]

Jacques Le Roux commented on OFBIZ-1881:
----------------------------------------

This is a good thing, thanks Bruno

> Using FindScreenDecorator in Content Application
> ------------------------------------------------
>
>                 Key: OFBIZ-1881
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1881
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: content
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>         Attachments: AjaxPagination.patch, DuplicationRemoved.patch, FindScreenDecorator.patch
>
>
> Please find attached a patch to use the FindScreenDecorator in Content Application

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-1881.
----------------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk

Bruno,

I committed your patches in trunk

FindScreenDecorator.patch revision: 680088  
DuplicationRemoved.patch revision: 680089  
AjaxPagination.patch revision: 680092  

About Ajax Pagination  : I see it's well done and works without issues, but please what does it brings to us in content cases? I searched to understand but found nothing clear.

Thanks

> Using FindScreenDecorator in Content Application
> ------------------------------------------------
>
>                 Key: OFBIZ-1881
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1881
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: content
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: AjaxPagination.patch, DuplicationRemoved.patch, FindScreenDecorator.patch
>
>
> Please find attached a patch to use the FindScreenDecorator in Content Application

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617288#action_12617288 ]

Bruno Busco commented on OFBIZ-1881:
------------------------------------

Jacques,
I think that we are in the process of standardizing the UI all over Ofbiz. The ajax pagination should IMO be used everywhere at least I undestood this.

The advandage is, of course, a faster update, the page does not scroll back to the very beginning after each pagination, less data traffic on the server.
All this gives a better feeling to the user.

BTW if we are against the spreading of the ajax pagination all over Ofbiz it is better to point that out because otherwise I will submit other patches with similar changes following the pattern.

If this is not desired I will save time for other tasks.

Thanks

> Using FindScreenDecorator in Content Application
> ------------------------------------------------
>
>                 Key: OFBIZ-1881
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1881
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: content
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: AjaxPagination.patch, DuplicationRemoved.patch, FindScreenDecorator.patch
>
>
> Please find attached a patch to use the FindScreenDecorator in Content Application

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617291#action_12617291 ]

Jacques Le Roux commented on OFBIZ-1881:
----------------------------------------

OK, it's cool with me

> Using FindScreenDecorator in Content Application
> ------------------------------------------------
>
>                 Key: OFBIZ-1881
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1881
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: content
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: AjaxPagination.patch, DuplicationRemoved.patch, FindScreenDecorator.patch
>
>
> Please find attached a patch to use the FindScreenDecorator in Content Application

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco updated OFBIZ-1881:
-------------------------------

    Attachment: SurveyScreen.patch

Jacques,
I realized that, for some reason the SurveyScreen change was not inluded in the patch I submitted and so now the pagination is not working on that screen.
Please find attached the new SurveyScreen.patch with the fix.
(It includes also a duplication removal in the container.xml)

> Using FindScreenDecorator in Content Application
> ------------------------------------------------
>
>                 Key: OFBIZ-1881
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1881
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: content
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: AjaxPagination.patch, DuplicationRemoved.patch, FindScreenDecorator.patch, SurveyScreen.patch
>
>
> Please find attached a patch to use the FindScreenDecorator in Content Application

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617403#action_12617403 ]

Jacques Le Roux commented on OFBIZ-1881:
----------------------------------------

Thanks Bruno,

Your fixing patch is in trunk revision: 680312  

> Using FindScreenDecorator in Content Application
> ------------------------------------------------
>
>                 Key: OFBIZ-1881
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1881
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: content
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: AjaxPagination.patch, DuplicationRemoved.patch, FindScreenDecorator.patch, SurveyScreen.patch
>
>
> Please find attached a patch to use the FindScreenDecorator in Content Application

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.