[jira] Created: (OFBIZ-1915) Improving request redirects

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (OFBIZ-1915) Improving request redirects

Nicolas Malin (Jira)
Improving request redirects
---------------------------

                 Key: OFBIZ-1915
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1915
             Project: OFBiz
          Issue Type: Improvement
          Components: framework
    Affects Versions: SVN trunk
            Reporter: Wickersheimer Jeremy
            Priority: Minor
             Fix For: SVN trunk


There are some issues with request-redirect and request-redirect-noparam, the former does not work very well with service multi and most of the time we do not need all the parameters to be in the redirected query, the later is a bit too radical.

This is something that i have been thinking for a while when running into these two kind of issues:
 - when i want to redirect to a viewXXX page, i just want to have the XXXId in my redirect
 - after i create an entity i want to redirect to the viewXXX page with the XXXId visible in the query

This patch i how we dealt with those in Opentaps, so maybe you are interested in applying to Ofbiz as well.

The end result is nicer and more user friendly redirects.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-1915) Improving request redirects

Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-1915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wickersheimer Jeremy updated OFBIZ-1915:
----------------------------------------

    Attachment: redirect.patch

> Improving request redirects
> ---------------------------
>
>                 Key: OFBIZ-1915
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1915
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: redirect.patch
>
>
> There are some issues with request-redirect and request-redirect-noparam, the former does not work very well with service multi and most of the time we do not need all the parameters to be in the redirected query, the later is a bit too radical.
> This is something that i have been thinking for a while when running into these two kind of issues:
>  - when i want to redirect to a viewXXX page, i just want to have the XXXId in my redirect
>  - after i create an entity i want to redirect to the viewXXX page with the XXXId visible in the query
> This patch i how we dealt with those in Opentaps, so maybe you are interested in applying to Ofbiz as well.
> The end result is nicer and more user friendly redirects.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1915) Improving request redirects

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12621350#action_12621350 ]

Wickersheimer Jeremy commented on OFBIZ-1915:
---------------------------------------------

There is how it works in the controller.xml:

If you have a request that edit an entity, you can redirect to the view with: (what it does is like request-redirect but only includes the allowed parameters)

        <response name="success" type="request-redirect-filterparam" value="viewXXX" allowed-params="XXXId"/>

If a request is creating an entity then you can redirect to its view with its Id (it simply gets the parameters from the response attributes)

        <response name="success" type="request-redirect-filterparam" value="viewXXX" allowed-attributes="XXXId"/>

Both allowed-params and allowed-attribute can be used in the same redirect if needed but i did not have a use case for that yet.

> Improving request redirects
> ---------------------------
>
>                 Key: OFBIZ-1915
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1915
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: redirect.patch
>
>
> There are some issues with request-redirect and request-redirect-noparam, the former does not work very well with service multi and most of the time we do not need all the parameters to be in the redirected query, the later is a bit too radical.
> This is something that i have been thinking for a while when running into these two kind of issues:
>  - when i want to redirect to a viewXXX page, i just want to have the XXXId in my redirect
>  - after i create an entity i want to redirect to the viewXXX page with the XXXId visible in the query
> This patch i how we dealt with those in Opentaps, so maybe you are interested in applying to Ofbiz as well.
> The end result is nicer and more user friendly redirects.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Assigned: (OFBIZ-1915) Improving request redirects

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-1915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Si Chen reassigned OFBIZ-1915:
------------------------------

    Assignee: Si Chen

> Improving request redirects
> ---------------------------
>
>                 Key: OFBIZ-1915
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1915
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Assignee: Si Chen
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: redirect.patch
>
>
> There are some issues with request-redirect and request-redirect-noparam, the former does not work very well with service multi and most of the time we do not need all the parameters to be in the redirected query, the later is a bit too radical.
> This is something that i have been thinking for a while when running into these two kind of issues:
>  - when i want to redirect to a viewXXX page, i just want to have the XXXId in my redirect
>  - after i create an entity i want to redirect to the viewXXX page with the XXXId visible in the query
> This patch i how we dealt with those in Opentaps, so maybe you are interested in applying to Ofbiz as well.
> The end result is nicer and more user friendly redirects.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1915) Improving request redirects

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12621498#action_12621498 ]

Si Chen commented on OFBIZ-1915:
--------------------------------

I will commit this if nobody has any comments

> Improving request redirects
> ---------------------------
>
>                 Key: OFBIZ-1915
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1915
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Assignee: Si Chen
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: redirect.patch
>
>
> There are some issues with request-redirect and request-redirect-noparam, the former does not work very well with service multi and most of the time we do not need all the parameters to be in the redirected query, the later is a bit too radical.
> This is something that i have been thinking for a while when running into these two kind of issues:
>  - when i want to redirect to a viewXXX page, i just want to have the XXXId in my redirect
>  - after i create an entity i want to redirect to the viewXXX page with the XXXId visible in the query
> This patch i how we dealt with those in Opentaps, so maybe you are interested in applying to Ofbiz as well.
> The end result is nicer and more user friendly redirects.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1915) Improving request redirects

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12621736#action_12621736 ]

David E. Jones commented on OFBIZ-1915:
---------------------------------------


This is an interesting enhancement.

One strange thing about it is that the functionality is enabled with a new response type, but then that new response type is configured through attributes added to the "response" element itself, even though that are not used for anything else.

I'm not sure what the best solution is to this issue, but we should at least document these attributes well so that people know that they don't apply to other response types (even though it might make sense for them to...).

-David

> Improving request redirects
> ---------------------------
>
>                 Key: OFBIZ-1915
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1915
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Assignee: Si Chen
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: redirect.patch
>
>
> There are some issues with request-redirect and request-redirect-noparam, the former does not work very well with service multi and most of the time we do not need all the parameters to be in the redirected query, the later is a bit too radical.
> This is something that i have been thinking for a while when running into these two kind of issues:
>  - when i want to redirect to a viewXXX page, i just want to have the XXXId in my redirect
>  - after i create an entity i want to redirect to the viewXXX page with the XXXId visible in the query
> This patch i how we dealt with those in Opentaps, so maybe you are interested in applying to Ofbiz as well.
> The end result is nicer and more user friendly redirects.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1915) Improving request redirects

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622378#action_12622378 ]

Si Chen commented on OFBIZ-1915:
--------------------------------

do you want me to put some more comments into the xsd file then?

> Improving request redirects
> ---------------------------
>
>                 Key: OFBIZ-1915
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1915
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Assignee: Si Chen
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: redirect.patch
>
>
> There are some issues with request-redirect and request-redirect-noparam, the former does not work very well with service multi and most of the time we do not need all the parameters to be in the redirected query, the later is a bit too radical.
> This is something that i have been thinking for a while when running into these two kind of issues:
>  - when i want to redirect to a viewXXX page, i just want to have the XXXId in my redirect
>  - after i create an entity i want to redirect to the viewXXX page with the XXXId visible in the query
> This patch i how we dealt with those in Opentaps, so maybe you are interested in applying to Ofbiz as well.
> The end result is nicer and more user friendly redirects.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1915) Improving request redirects

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622426#action_12622426 ]

Jacques Le Roux commented on OFBIZ-1915:
----------------------------------------

Hi Si,

Yes sure, they are always welcome !

> Improving request redirects
> ---------------------------
>
>                 Key: OFBIZ-1915
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1915
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Assignee: Si Chen
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: redirect.patch
>
>
> There are some issues with request-redirect and request-redirect-noparam, the former does not work very well with service multi and most of the time we do not need all the parameters to be in the redirected query, the later is a bit too radical.
> This is something that i have been thinking for a while when running into these two kind of issues:
>  - when i want to redirect to a viewXXX page, i just want to have the XXXId in my redirect
>  - after i create an entity i want to redirect to the viewXXX page with the XXXId visible in the query
> This patch i how we dealt with those in Opentaps, so maybe you are interested in applying to Ofbiz as well.
> The end result is nicer and more user friendly redirects.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (OFBIZ-1915) Improving request redirects

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-1915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Si Chen closed OFBIZ-1915.
--------------------------

    Resolution: Fixed

> Improving request redirects
> ---------------------------
>
>                 Key: OFBIZ-1915
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1915
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Assignee: Si Chen
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: redirect.patch
>
>
> There are some issues with request-redirect and request-redirect-noparam, the former does not work very well with service multi and most of the time we do not need all the parameters to be in the redirected query, the later is a bit too radical.
> This is something that i have been thinking for a while when running into these two kind of issues:
>  - when i want to redirect to a viewXXX page, i just want to have the XXXId in my redirect
>  - after i create an entity i want to redirect to the viewXXX page with the XXXId visible in the query
> This patch i how we dealt with those in Opentaps, so maybe you are interested in applying to Ofbiz as well.
> The end result is nicer and more user friendly redirects.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.