[jira] Created: (OFBIZ-1919) Collapsible MASTHEAD

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
15 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (OFBIZ-1919) Collapsible MASTHEAD

Nicolas Malin (Jira)
Collapsible MASTHEAD
--------------------

                 Key: OFBIZ-1919
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1919
             Project: OFBiz
          Issue Type: New Feature
          Components: framework
    Affects Versions: SVN trunk
            Reporter: Bruno Busco
            Priority: Minor


The attached patch implements a collapsible Master Header.
The idea is to use a userPreference setting to save how the user prefers to configure the screen:
with the standard header or with a compact version that let to have more space on screen.


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-1919) Collapsible MASTHEAD

Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-1919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco updated OFBIZ-1919:
-------------------------------

    Attachment: collapsible_masthead.patch

> Collapsible MASTHEAD
> --------------------
>
>                 Key: OFBIZ-1919
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1919
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>            Priority: Minor
>         Attachments: collapsible_masthead.patch
>
>
> The attached patch implements a collapsible Master Header.
> The idea is to use a userPreference setting to save how the user prefers to configure the screen:
> with the standard header or with a compact version that let to have more space on screen.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1919) Collapsible MASTHEAD

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622459#action_12622459 ]

Jacques Le Roux commented on OFBIZ-1919:
----------------------------------------

Hi Bruno,

But how do you set the user preferences ? BTW I wonder if we should not have this by default as the user may or not collapse at wil using the +- buttons

> Collapsible MASTHEAD
> --------------------
>
>                 Key: OFBIZ-1919
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1919
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>            Priority: Minor
>         Attachments: collapsible_masthead.patch
>
>
> The attached patch implements a collapsible Master Header.
> The idea is to use a userPreference setting to save how the user prefers to configure the screen:
> with the standard header or with a compact version that let to have more space on screen.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1919) Collapsible MASTHEAD

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622469#action_12622469 ]

Bruno Busco commented on OFBIZ-1919:
------------------------------------

Hi Jacques,
by default the header is expanded (it appears like usual) and the standard "-" icon is displayed also.
When the user clicks on the "-" icon the "COMPACTHEADER" UserPreference is created, if it did not exist, and is set to "Y".
Whenever the header is rendered a check on the COMPACTHEADER UserPreference is done to switch between the two possible headers.
So there is no need to set the UserPreference manually, it is automatically set when the header is collapsed/expanded.
The UserPrefernce is used to remember how the user has left the header when it logs out and in again.


> Collapsible MASTHEAD
> --------------------
>
>                 Key: OFBIZ-1919
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1919
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>            Priority: Minor
>         Attachments: collapsible_masthead.patch
>
>
> The attached patch implements a collapsible Master Header.
> The idea is to use a userPreference setting to save how the user prefers to configure the screen:
> with the standard header or with a compact version that let to have more space on screen.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1919) Collapsible MASTHEAD

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622506#action_12622506 ]

Jacques Le Roux commented on OFBIZ-1919:
----------------------------------------

Sorry to have disturbed you, maybe it was a cache issue, I reloaded and it was there, fine...
Still the user preferences access issue but this is not related to this patch but how My Page is working
I will commit soon if nobody see a problem.

> Collapsible MASTHEAD
> --------------------
>
>                 Key: OFBIZ-1919
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1919
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>            Priority: Minor
>         Attachments: collapsible_masthead.patch
>
>
> The attached patch implements a collapsible Master Header.
> The idea is to use a userPreference setting to save how the user prefers to configure the screen:
> with the standard header or with a compact version that let to have more space on screen.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1919) Collapsible MASTHEAD

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622590#action_12622590 ]

Adrian Crum commented on OFBIZ-1919:
------------------------------------

There is a setUserPreference request map in common-controller.xml - there is no need to use the MyPage URL.

We already have a collapsed and expanded CSS style - there is no need to add another one.

I would like to hear what others have to say about which information should be visible when the masthead is collapsed.


> Collapsible MASTHEAD
> --------------------
>
>                 Key: OFBIZ-1919
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1919
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>            Priority: Minor
>         Attachments: collapsible_masthead.patch
>
>
> The attached patch implements a collapsible Master Header.
> The idea is to use a userPreference setting to save how the user prefers to configure the screen:
> with the standard header or with a compact version that let to have more space on screen.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1919) Collapsible MASTHEAD

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622599#action_12622599 ]

Adrian Crum commented on OFBIZ-1919:
------------------------------------

Ah, we don't have generic expand and collapse CSS styles. My apologies.

I'll submit an updated patch.


> Collapsible MASTHEAD
> --------------------
>
>                 Key: OFBIZ-1919
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1919
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>            Priority: Minor
>         Attachments: collapsible_masthead.patch
>
>
> The attached patch implements a collapsible Master Header.
> The idea is to use a userPreference setting to save how the user prefers to configure the screen:
> with the standard header or with a compact version that let to have more space on screen.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-1919) Collapsible MASTHEAD

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-1919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-1919:
-------------------------------

    Attachment: collapsible_masthead.patch

Updated patch.

> Collapsible MASTHEAD
> --------------------
>
>                 Key: OFBIZ-1919
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1919
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>            Priority: Minor
>         Attachments: collapsible_masthead.patch, collapsible_masthead.patch
>
>
> The attached patch implements a collapsible Master Header.
> The idea is to use a userPreference setting to save how the user prefers to configure the screen:
> with the standard header or with a compact version that let to have more space on screen.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1919) Collapsible MASTHEAD

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622838#action_12622838 ]

Bruno Busco commented on OFBIZ-1919:
------------------------------------

Hi Adrian,
thank you for reviewing and updating the collapsible_header patch.
Now it has much better code.

You have also removed the link to the viewprofile page.
In order to discuss about the links to have in the compact header I will open a discussion thread in the DEV ML.


> Collapsible MASTHEAD
> --------------------
>
>                 Key: OFBIZ-1919
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1919
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>            Priority: Minor
>         Attachments: collapsible_masthead.patch, collapsible_masthead.patch
>
>
> The attached patch implements a collapsible Master Header.
> The idea is to use a userPreference setting to save how the user prefers to configure the screen:
> with the standard header or with a compact version that let to have more space on screen.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1919) Collapsible MASTHEAD

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622884#action_12622884 ]

Adrian Crum commented on OFBIZ-1919:
------------------------------------

Bruno,

I removed links that are not in common-controller.xml because there is no guarantee they will exist.

Let's stay focused on the task that is defined in this issue - collapsing the masthead. New links, screens, etc can be addressed in another issue.


> Collapsible MASTHEAD
> --------------------
>
>                 Key: OFBIZ-1919
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1919
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>            Priority: Minor
>         Attachments: collapsible_masthead.patch, collapsible_masthead.patch
>
>
> The attached patch implements a collapsible Master Header.
> The idea is to use a userPreference setting to save how the user prefers to configure the screen:
> with the standard header or with a compact version that let to have more space on screen.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Assigned: (OFBIZ-1919) Collapsible MASTHEAD

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-1919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum reassigned OFBIZ-1919:
----------------------------------

    Assignee: Adrian Crum

> Collapsible MASTHEAD
> --------------------
>
>                 Key: OFBIZ-1919
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1919
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>            Assignee: Adrian Crum
>            Priority: Minor
>         Attachments: collapsible_masthead.patch, collapsible_masthead.patch
>
>
> The attached patch implements a collapsible Master Header.
> The idea is to use a userPreference setting to save how the user prefers to configure the screen:
> with the standard header or with a compact version that let to have more space on screen.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (OFBIZ-1919) Collapsible MASTHEAD

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-1919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum closed OFBIZ-1919.
------------------------------

    Resolution: Fixed

Fixed, rev 686515.


> Collapsible MASTHEAD
> --------------------
>
>                 Key: OFBIZ-1919
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1919
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>            Assignee: Adrian Crum
>            Priority: Minor
>         Attachments: collapsible_masthead.patch, collapsible_masthead.patch
>
>
> The attached patch implements a collapsible Master Header.
> The idea is to use a userPreference setting to save how the user prefers to configure the screen:
> with the standard header or with a compact version that let to have more space on screen.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

Re: [jira] Closed: (OFBIZ-1919) Collapsible MASTHEAD

Enrique Ruibal
Very simple and functional enhancement...excelent!
JIRA jira@apache.org wrote
[ https://issues.apache.org/jira/browse/OFBIZ-1919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum closed OFBIZ-1919. ------------------------------ Resolution: Fixed Fixed, rev 686515. > Collapsible MASTHEAD > -------------------- > > Key: OFBIZ-1919 > URL: https://issues.apache.org/jira/browse/OFBIZ-1919 > Project: OFBiz > Issue Type: New Feature > Components: framework > Affects Versions: SVN trunk > Reporter: Bruno Busco > Assignee: Adrian Crum > Priority: Minor > Attachments: collapsible_masthead.patch, collapsible_masthead.patch > > > The attached patch implements a collapsible Master Header. > The idea is to use a userPreference setting to save how the user prefers to configure the screen: > with the standard header or with a compact version that let to have more space on screen. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1919) Collapsible MASTHEAD

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623969#action_12623969 ]

BJ Freeman commented on OFBIZ-1919:
-----------------------------------

Looks like more work

senario1:
do a find pary and show any number of records.
then click on the colapeable header
all the records disappear

senario2
go to any menu below the main menu
then click on the colapsable header
you are broght back to the top menus.

> Collapsible MASTHEAD
> --------------------
>
>                 Key: OFBIZ-1919
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1919
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>            Assignee: Adrian Crum
>            Priority: Minor
>         Attachments: collapsible_masthead.patch, collapsible_masthead.patch
>
>
> The attached patch implements a collapsible Master Header.
> The idea is to use a userPreference setting to save how the user prefers to configure the screen:
> with the standard header or with a compact version that let to have more space on screen.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1919) Collapsible MASTHEAD

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623982#action_12623982 ]

Jacques Le Roux commented on OFBIZ-1919:
----------------------------------------

This is not new : we have the same type of behaviour when we switch languages...

> Collapsible MASTHEAD
> --------------------
>
>                 Key: OFBIZ-1919
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1919
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>            Assignee: Adrian Crum
>            Priority: Minor
>         Attachments: collapsible_masthead.patch, collapsible_masthead.patch
>
>
> The attached patch implements a collapsible Master Header.
> The idea is to use a userPreference setting to save how the user prefers to configure the screen:
> with the standard header or with a compact version that let to have more space on screen.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.