[jira] Created: (OFBIZ-1923) Add geolocation to data model.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12624079#action_12624079 ]

David E. Jones commented on OFBIZ-1923:
---------------------------------------

For the Container entity: a Facility may not move but a Container typically will. Whatever is done, the geoPointId should not be on the Container itself. I would recommend just not worrying about it at this point because Containers aren't used much in OFBiz yet. Also, when a Container is in a Facility you can look up the geoPointId of the Facility. Otherwise, you would need a ContainerGeoPoint entity to keep track of a series of points over time like the others.

On a side note, wasn't a big point of all of this to have a lat/long on a postal address? I don't see anything like that in this data model patch, so I'm not sure what you're thinking along those lines. I'd recommend adding a geoPointId to the PostalAddress entity (and not the ContactMech entity as this does not apply to all ContactMechs).

-David

> Add geolocation to data model.
> ------------------------------
>
>                 Key: OFBIZ-1923
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1923
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: accounting, framework, party, product
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: GeopointDataModel.patch, GeopointDataModel.patch, GeopointDataModel.patch
>
>
> The attached patch is enhancing the current data model following last David's suggestion after some exchanges on dev ML. I just added a geoPointId to Container.
> I finally used float for latitude, longitude and elevation, instead of creating a new degree field type (numeric 18,6).
> Any comments are welcome.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-1923:
-----------------------------------

    Attachment: GeopointDataModel.patch

David,

In this new version I have added a ContainerGeoPoint since, as you pointed out, it makes much more sense.
I have also added a relationship from PostalAddress to GeoPoint. I don't know why I missed this one. Too obvious, while searching for ones that may be missing, I guess :o)

> Add geolocation to data model.
> ------------------------------
>
>                 Key: OFBIZ-1923
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1923
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: accounting, framework, party, product
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: GeopointDataModel.patch, GeopointDataModel.patch, GeopointDataModel.patch, GeopointDataModel.patch
>
>
> The attached patch is enhancing the current data model following last David's suggestion after some exchanges on dev ML. I just added a geoPointId to Container.
> I finally used float for latitude, longitude and elevation, instead of creating a new degree field type (numeric 18,6).
> Any comments are welcome.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-1923:
-----------------------------------

    Attachment: GeopointDataModel.patch

Updated patch with only GeoLocation changes (the AgreementEmploymentAppl switch is now in OFBiz)

> Add geolocation to data model.
> ------------------------------
>
>                 Key: OFBIZ-1923
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1923
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: accounting, framework, party, product
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: GeopointDataModel.patch, GeopointDataModel.patch, GeopointDataModel.patch, GeopointDataModel.patch, GeopointDataModel.patch
>
>
> The attached patch is enhancing the current data model following last David's suggestion after some exchanges on dev ML. I just added a geoPointId to Container.
> I finally used float for latitude, longitude and elevation, instead of creating a new degree field type (numeric 18,6).
> Any comments are welcome.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-1923:
-----------------------------------

    Attachment: GeloLocation.patch

A more complete patch with a 1st demonstration of use in Party Profile. It could be yet commited and enhanced later. Please review and test, thanks

> Add geolocation to data model.
> ------------------------------
>
>                 Key: OFBIZ-1923
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1923
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: accounting, framework, party, product
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: GeloLocation.patch, GeopointDataModel.patch, GeopointDataModel.patch, GeopointDataModel.patch, GeopointDataModel.patch, GeopointDataModel.patch
>
>
> The attached patch is enhancing the current data model following last David's suggestion after some exchanges on dev ML. I just added a geoPointId to Container.
> I finally used float for latitude, longitude and elevation, instead of creating a new degree field type (numeric 18,6).
> Any comments are welcome.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-1923:
-----------------------------------

    Attachment: GeloLocation.patch

In the previous patch I forgot the uomId for elevation and I fixed also some typo in view-entities definitions

> Add geolocation to data model.
> ------------------------------
>
>                 Key: OFBIZ-1923
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1923
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: accounting, framework, party, product
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: GeloLocation.patch, GeloLocation.patch, GeopointDataModel.patch, GeopointDataModel.patch, GeopointDataModel.patch, GeopointDataModel.patch, GeopointDataModel.patch
>
>
> The attached patch is enhancing the current data model following last David's suggestion after some exchanges on dev ML. I just added a geoPointId to Container.
> I finally used float for latitude, longitude and elevation, instead of creating a new degree field type (numeric 18,6).
> Any comments are welcome.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco updated OFBIZ-1923:
-------------------------------

    Fix Version/s:     (was: SVN trunk)
                   OFBIZ 9.3

> Add geolocation to data model.
> ------------------------------
>
>                 Key: OFBIZ-1923
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1923
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: accounting, framework, party, product
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>             Fix For: OFBIZ 9.3
>
>         Attachments: GeloLocation.patch, GeloLocation.patch, GeopointDataModel.patch, GeopointDataModel.patch, GeopointDataModel.patch, GeopointDataModel.patch, GeopointDataModel.patch
>
>
> The attached patch is enhancing the current data model following last David's suggestion after some exchanges on dev ML. I just added a geoPointId to Container.
> I finally used float for latitude, longitude and elevation, instead of creating a new degree field type (numeric 18,6).
> Any comments are welcome.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12664937#action_12664937 ]

Jacques Le Roux commented on OFBIZ-1923:
----------------------------------------

I will add Postal Addresses, Facilites, Containers, and Fixed Assets examples later... Any help welcome...

> Add geolocation to data model.
> ------------------------------
>
>                 Key: OFBIZ-1923
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1923
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: accounting, framework, party, product
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>             Fix For: Release Branch 9.3
>
>         Attachments: GeloLocation.patch, GeloLocation.patch, GeopointDataModel.patch, GeopointDataModel.patch, GeopointDataModel.patch, GeopointDataModel.patch, GeopointDataModel.patch
>
>
> The attached patch is enhancing the current data model following last David's suggestion after some exchanges on dev ML. I just added a geoPointId to Container.
> I finally used float for latitude, longitude and elevation, instead of creating a new degree field type (numeric 18,6).
> Any comments are welcome.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-1923.
----------------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk

I have commited last changes in revision 738452

> Add geolocation to data model.
> ------------------------------
>
>                 Key: OFBIZ-1923
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1923
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: accounting, framework, party, product
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk, Release Branch 9.3
>
>         Attachments: GeloLocation.patch, GeloLocation.patch, GeopointDataModel.patch, GeopointDataModel.patch, GeopointDataModel.patch, GeopointDataModel.patch, GeopointDataModel.patch
>
>
> The attached patch is enhancing the current data model following last David's suggestion after some exchanges on dev ML. I just added a geoPointId to Container.
> I finally used float for latitude, longitude and elevation, instead of creating a new degree field type (numeric 18,6).
> Any comments are welcome.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.