[jira] Created: (OFBIZ-1932) Allow real use of iterate-section in widget

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (OFBIZ-1932) Allow real use of iterate-section in widget

Nicolas Malin (Jira)
Allow real use of iterate-section in widget
-------------------------------------------

                 Key: OFBIZ-1932
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1932
             Project: OFBiz
          Issue Type: Improvement
          Components: ALL COMPONENTS
    Affects Versions: SVN trunk
            Reporter: Jacques Le Roux
            Assignee: Jacques Le Roux
            Priority: Minor


Maybe I missed something, but as I asked on ML and got no answers, maybe somehting is missing

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-1932) Allow real use of iterate-section in widget

Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-1932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-1932:
-----------------------------------

    Description:
Maybe I missed something, but as I asked on ML and got no answers, maybe something is missing.

So I wrote this little patch.
It works (to have a look : create at least 4 fin accounts affected to admin, f.e.) but give this error message back
   org.ofbiz.webapp.event.EventHandlerException: Unknown handler type:

This is because I have to pass the partyId to the view-profile redirected request which contains the screenlet Finaccount.
So I wrote
    <iterate-section entry-name="ownedFinAccount"  paginate="true" paginate-target="FinAccounts?partyId=${parameters.partyId}" view-size="3"  list-name="ownedFinAccountList">

I would like to properly and safely allow to pass a parameter in paginate-target. And before doing any changes in RequestHandler.java I'd like to know if I have not missed something obvious or if there is another best practice to use effectively iterate-section in widget.

If not, advices on how to do that are welcome, before I trace in RequestHandler.java

Thanks

  was:Maybe I missed something, but as I asked on ML and got no answers, maybe somehting is missing


> Allow real use of iterate-section in widget
> -------------------------------------------
>
>                 Key: OFBIZ-1932
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1932
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Minor
>
> Maybe I missed something, but as I asked on ML and got no answers, maybe something is missing.
> So I wrote this little patch.
> It works (to have a look : create at least 4 fin accounts affected to admin, f.e.) but give this error message back
>    org.ofbiz.webapp.event.EventHandlerException: Unknown handler type:
> This is because I have to pass the partyId to the view-profile redirected request which contains the screenlet Finaccount.
> So I wrote
>     <iterate-section entry-name="ownedFinAccount"  paginate="true" paginate-target="FinAccounts?partyId=${parameters.partyId}" view-size="3"  list-name="ownedFinAccountList">
> I would like to properly and safely allow to pass a parameter in paginate-target. And before doing any changes in RequestHandler.java I'd like to know if I have not missed something obvious or if there is another best practice to use effectively iterate-section in widget.
> If not, advices on how to do that are welcome, before I trace in RequestHandler.java
> Thanks

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-1932) Allow real use of iterate-section in widget

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-1932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-1932:
-----------------------------------

    Attachment: iterate-section.patch

Patch iterate-section.patch not intended to be commited yet, for demonstration purpose only

> Allow real use of iterate-section in widget
> -------------------------------------------
>
>                 Key: OFBIZ-1932
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1932
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: iterate-section.patch
>
>
> Maybe I missed something, but as I asked on ML and got no answers, maybe something is missing.
> So I wrote this little patch.
> It works (to have a look : create at least 4 fin accounts affected to admin, f.e.) but give this error message back
>    org.ofbiz.webapp.event.EventHandlerException: Unknown handler type:
> This is because I have to pass the partyId to the view-profile redirected request which contains the screenlet Finaccount.
> So I wrote
>     <iterate-section entry-name="ownedFinAccount"  paginate="true" paginate-target="FinAccounts?partyId=${parameters.partyId}" view-size="3"  list-name="ownedFinAccountList">
> I would like to properly and safely allow to pass a parameter in paginate-target. And before doing any changes in RequestHandler.java I'd like to know if I have not missed something obvious or if there is another best practice to use effectively iterate-section in widget.
> If not, advices on how to do that are welcome, before I trace in RequestHandler.java
> Thanks

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1932) Allow real use of iterate-section in widget

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625276#action_12625276 ]

Bilgin Ibryam commented on OFBIZ-1932:
--------------------------------------

Jacques,

I think you can use iterate-section w/o adding new request-map entries like this  "paginate-target="viewprofile?partyId=${parameters.partyId}" .
Here is an example of how it is used in BlogScreens.xml          
 <iterate-section list-name="blogList" entry-name="blog" view-size="${blogViewSize}" paginate="true" paginate-target="MainBlog?blogContentId=${blogContentId}&amp;ownerContentId=${parameters.ownerContentId}">
 
But there is another more general issue:
If a page has more than one paginations (view profile has one in "Financial Account Summary " and one in "Shipper Account" ) the pagination numbers become wrong, as both paginations use VIEW_SIZE and VIEW_INDEX parameters from the request.

Bilgin

> Allow real use of iterate-section in widget
> -------------------------------------------
>
>                 Key: OFBIZ-1932
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1932
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: iterate-section.patch
>
>
> Maybe I missed something, but as I asked on ML and got no answers, maybe something is missing.
> So I wrote this little patch.
> It works (to have a look : create at least 4 fin accounts affected to admin, f.e.) but give this error message back
>    org.ofbiz.webapp.event.EventHandlerException: Unknown handler type:
> This is because I have to pass the partyId to the view-profile redirected request which contains the screenlet Finaccount.
> So I wrote
>     <iterate-section entry-name="ownedFinAccount"  paginate="true" paginate-target="FinAccounts?partyId=${parameters.partyId}" view-size="3"  list-name="ownedFinAccountList">
> I would like to properly and safely allow to pass a parameter in paginate-target. And before doing any changes in RequestHandler.java I'd like to know if I have not missed something obvious or if there is another best practice to use effectively iterate-section in widget.
> If not, advices on how to do that are welcome, before I trace in RequestHandler.java
> Thanks

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1932) Allow real use of iterate-section in widget

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625297#action_12625297 ]

Jacques Le Roux commented on OFBIZ-1932:
----------------------------------------

Hi BIlgin,

Thanks for the tip. The issue you pointed out is why I did no try using viewprofile as paginate-target. I thought it shoud be related to the screenlet.
I will wait for a solution to the issue you raised before committing my changes enhanced by your tip and something for "Shipper Account" screenlet too.
I think that 3 instance is enough for a screenlet actually.

> Allow real use of iterate-section in widget
> -------------------------------------------
>
>                 Key: OFBIZ-1932
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1932
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: iterate-section.patch
>
>
> Maybe I missed something, but as I asked on ML and got no answers, maybe something is missing.
> So I wrote this little patch.
> It works (to have a look : create at least 4 fin accounts affected to admin, f.e.) but give this error message back
>    org.ofbiz.webapp.event.EventHandlerException: Unknown handler type:
> This is because I have to pass the partyId to the view-profile redirected request which contains the screenlet Finaccount.
> So I wrote
>     <iterate-section entry-name="ownedFinAccount"  paginate="true" paginate-target="FinAccounts?partyId=${parameters.partyId}" view-size="3"  list-name="ownedFinAccountList">
> I would like to properly and safely allow to pass a parameter in paginate-target. And before doing any changes in RequestHandler.java I'd like to know if I have not missed something obvious or if there is another best practice to use effectively iterate-section in widget.
> If not, advices on how to do that are welcome, before I trace in RequestHandler.java
> Thanks

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1932) Allow real use of iterate-section in widget

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625302#action_12625302 ]

Jacques Le Roux commented on OFBIZ-1932:
----------------------------------------

Mmm... and ShipperAccount is not using the same scheme. It's not an iterate-section but a call to the list form ListCarrierAccounts. So I guess the solution is not around iterate-section but more global for list forms included in a page...

> Allow real use of iterate-section in widget
> -------------------------------------------
>
>                 Key: OFBIZ-1932
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1932
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: iterate-section.patch
>
>
> Maybe I missed something, but as I asked on ML and got no answers, maybe something is missing.
> So I wrote this little patch.
> It works (to have a look : create at least 4 fin accounts affected to admin, f.e.) but give this error message back
>    org.ofbiz.webapp.event.EventHandlerException: Unknown handler type:
> This is because I have to pass the partyId to the view-profile redirected request which contains the screenlet Finaccount.
> So I wrote
>     <iterate-section entry-name="ownedFinAccount"  paginate="true" paginate-target="FinAccounts?partyId=${parameters.partyId}" view-size="3"  list-name="ownedFinAccountList">
> I would like to properly and safely allow to pass a parameter in paginate-target. And before doing any changes in RequestHandler.java I'd like to know if I have not missed something obvious or if there is another best practice to use effectively iterate-section in widget.
> If not, advices on how to do that are welcome, before I trace in RequestHandler.java
> Thanks

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1932) Allow real use of iterate-section in widget

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625321#action_12625321 ]

Jacques Le Roux commented on OFBIZ-1932:
----------------------------------------

Finally I decided to commit my changes+Bilgin's tip, at least the "Financial Account Summary "  screenlet will function correctly for now
Commited in revision: 688697  


> Allow real use of iterate-section in widget
> -------------------------------------------
>
>                 Key: OFBIZ-1932
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1932
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: iterate-section.patch
>
>
> Maybe I missed something, but as I asked on ML and got no answers, maybe something is missing.
> So I wrote this little patch.
> It works (to have a look : create at least 4 fin accounts affected to admin, f.e.) but give this error message back
>    org.ofbiz.webapp.event.EventHandlerException: Unknown handler type:
> This is because I have to pass the partyId to the view-profile redirected request which contains the screenlet Finaccount.
> So I wrote
>     <iterate-section entry-name="ownedFinAccount"  paginate="true" paginate-target="FinAccounts?partyId=${parameters.partyId}" view-size="3"  list-name="ownedFinAccountList">
> I would like to properly and safely allow to pass a parameter in paginate-target. And before doing any changes in RequestHandler.java I'd like to know if I have not missed something obvious or if there is another best practice to use effectively iterate-section in widget.
> If not, advices on how to do that are welcome, before I trace in RequestHandler.java
> Thanks

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-1932) Allow multi-pagination in a page (see Bilgin comment below)

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-1932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-1932:
-----------------------------------

    Description:
Maybe I missed something, but as I asked on ML and got no answers, maybe something is missing.

So I wrote this little patch.
It works (to have a look : create at least 4 fin accounts affected to admin, f.e.) but give this error message back
   org.ofbiz.webapp.event.EventHandlerException: Unknown handler type:

This is because I have to pass the partyId to the view-profile redirected request which contains the screenlet Finaccount.
So I wrote
    <iterate-section entry-name="ownedFinAccount"  paginate="true" paginate-target="FinAccounts?partyId=${parameters.partyId}" view-size="3"  list-name="ownedFinAccountList">

I would like to properly and safely allow to pass a parameter in paginate-target. And before doing any changes in RequestHandler.java I'd like to know if I have not missed something obvious or if there is another best practice to use effectively iterate-section in widget.

If not, advices on how to do that are welcome, before I trace in RequestHandler.java

Thanks



  was:
Maybe I missed something, but as I asked on ML and got no answers, maybe something is missing.

So I wrote this little patch.
It works (to have a look : create at least 4 fin accounts affected to admin, f.e.) but give this error message back
   org.ofbiz.webapp.event.EventHandlerException: Unknown handler type:

This is because I have to pass the partyId to the view-profile redirected request which contains the screenlet Finaccount.
So I wrote
    <iterate-section entry-name="ownedFinAccount"  paginate="true" paginate-target="FinAccounts?partyId=${parameters.partyId}" view-size="3"  list-name="ownedFinAccountList">

I would like to properly and safely allow to pass a parameter in paginate-target. And before doing any changes in RequestHandler.java I'd like to know if I have not missed something obvious or if there is another best practice to use effectively iterate-section in widget.

If not, advices on how to do that are welcome, before I trace in RequestHandler.java

Thanks

        Summary: Allow multi-pagination in a page (see Bilgin comment below)  (was: Allow real use of iterate-section in widget)

> Allow multi-pagination in a page (see Bilgin comment below)
> -----------------------------------------------------------
>
>                 Key: OFBIZ-1932
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1932
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: iterate-section.patch
>
>
> Maybe I missed something, but as I asked on ML and got no answers, maybe something is missing.
> So I wrote this little patch.
> It works (to have a look : create at least 4 fin accounts affected to admin, f.e.) but give this error message back
>    org.ofbiz.webapp.event.EventHandlerException: Unknown handler type:
> This is because I have to pass the partyId to the view-profile redirected request which contains the screenlet Finaccount.
> So I wrote
>     <iterate-section entry-name="ownedFinAccount"  paginate="true" paginate-target="FinAccounts?partyId=${parameters.partyId}" view-size="3"  list-name="ownedFinAccountList">
> I would like to properly and safely allow to pass a parameter in paginate-target. And before doing any changes in RequestHandler.java I'd like to know if I have not missed something obvious or if there is another best practice to use effectively iterate-section in widget.
> If not, advices on how to do that are welcome, before I trace in RequestHandler.java
> Thanks

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (OFBIZ-1932) Allow multi-pagination in a page (see Bilgin comment below)

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-1932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-1932.
----------------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk

FInally I prefer to open a new issue as this one was an improvement and Bilgin discovered a bug

> Allow multi-pagination in a page (see Bilgin comment below)
> -----------------------------------------------------------
>
>                 Key: OFBIZ-1932
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1932
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: iterate-section.patch
>
>
> Maybe I missed something, but as I asked on ML and got no answers, maybe something is missing.
> So I wrote this little patch.
> It works (to have a look : create at least 4 fin accounts affected to admin, f.e.) but give this error message back
>    org.ofbiz.webapp.event.EventHandlerException: Unknown handler type:
> This is because I have to pass the partyId to the view-profile redirected request which contains the screenlet Finaccount.
> So I wrote
>     <iterate-section entry-name="ownedFinAccount"  paginate="true" paginate-target="FinAccounts?partyId=${parameters.partyId}" view-size="3"  list-name="ownedFinAccountList">
> I would like to properly and safely allow to pass a parameter in paginate-target. And before doing any changes in RequestHandler.java I'd like to know if I have not missed something obvious or if there is another best practice to use effectively iterate-section in widget.
> If not, advices on how to do that are welcome, before I trace in RequestHandler.java
> Thanks

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.