[
https://issues.apache.org/jira/browse/OFBIZ-1954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634567#action_12634567 ]
Jacques Le Roux commented on OFBIZ-1954:
----------------------------------------
Dimitri,
I just had a look at the check done by HTMLValidator plugin in FF3.
This is what I got on
https://localhost:8443/catalog/control/EditProduct?productId=GZ-1001 (revision 698830)
{noformat}
Result: 15 erreurs / 4 avertissements
line 14 column 91 - Erreur: duplicate specification of attribute "type"
line 15 column 95 - Erreur: duplicate specification of attribute "type"
line 16 column 79 - Erreur: duplicate specification of attribute "type"
line 17 column 81 - Erreur: duplicate specification of attribute "type"
line 18 column 90 - Erreur: duplicate specification of attribute "type"
line 128 column 97 - Avertissement: cannot generate system identifier for general entity "PAGING"
line 128 column 97 - Erreur: general entity "PAGING" not defined and no default entity
line 128 column 103 - Erreur: reference to entity "PAGING" for which no system identifier could be generated
line 128 column 96 - Info: entity was defined here
line 317 column 86 - Avertissement: cannot generate system identifier for general entity "showAllFacilities"
line 317 column 86 - Erreur: general entity "showAllFacilities" not defined and no default entity
line 317 column 103 - Erreur: reference to entity "showAllFacilities" for which no system identifier could be generated
line 317 column 85 - Info: entity was defined here
line 337 column 82 - Erreur: required attribute "alt" not specified
line 342 column 74 - Avertissement: cannot generate system identifier for general entity "externalLoginKey"
line 342 column 74 - Erreur: general entity "externalLoginKey" not defined and no default entity
line 342 column 90 - Erreur: reference to entity "externalLoginKey" for which no system identifier could be generated
line 342 column 73 - Info: entity was defined here
line 343 column 98 - Avertissement: cannot generate system identifier for general entity "productName"
line 343 column 98 - Erreur: general entity "productName" not defined and no default entity
line 343 column 109 - Erreur: reference to entity "productName" for which no system identifier could be generated
line 343 column 97 - Info: entity was defined here
line 355 column 107 - Erreur: there is no attribute "onSubmit"
{noformat}
* The alt attribute would be a plus without doubts
* We have no error for images/borders as we use transitionnal mode for now and I did not check but I trust you
* Obviously we need more work to be even transitional OK, but this seems not too annoying
Please make your patches from OFBIZ_HOME
I tried your patch but without any other changes in code I got an NPE error.
{code}
java.lang.NullPointerException
org.ofbiz.widget.screen.ModelScreenWidget$Image.getAlt(ModelScreenWidget.java:1489)
org.ofbiz.widget.html.HtmlScreenRenderer.renderImage(HtmlScreenRenderer.java:571)
{code}
I did not look further.
Note your patch was merged (but without issues).
> Generate alt-attribute in the image element
> -------------------------------------------
>
> Key: OFBIZ-1954
> URL:
https://issues.apache.org/jira/browse/OFBIZ-1954> Project: OFBiz
> Issue Type: New Feature
> Components: framework
> Reporter: Dimitri Unruh
> Attachments: widget.patch
>
>
> This patch allows you to set an alt attribute for the image element.
> Also it removes the default border setting to 0.
> Border attibute for imges is not allowed in xhtml1.0 strict.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Locked
