[jira] Created: (OFBIZ-1971) Java Source Checkstyle Conformance and Source QA Tools

[Nicolas Malin (Jira)]

Java Source Checkstyle Conformance and Source QA Tools
------------------------------------------------------

                 Key: OFBIZ-1971
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1971
             Project: OFBiz
          Issue Type: Wish
          Components: ALL COMPONENTS
         Environment: Java source compilation.
            Reporter: Mike Bachrynowski
            Priority: Minor


Is there a chance that future releases might be updated to conform to a particular Checkstyle http://checkstyle.sourceforge.net/.  Initially, by default, checkstyle should perhaps not be applied.
I could supply a version of "checkstyle.xml" that I use but this does enforce "generics".  

Other code quality tools such as JDepend http://clarkware.com/software/JDepend.html
and JavaNCSS http://www.kclee.de/clemens/java/javancss/ or similar might be used both for technical reasons and as an aide to sell the use of OfBiz.

Finally in testing web applications I usually create a full set of JMeter test plans.  Is there a place within the build for JMeter (run from Ant) to test out the demo applications.


 

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634878#action_12634878 ]

Adrian Crum commented on OFBIZ-1971:
------------------------------------

It would be better to discuss this on the dev mailing list, so that a an agreement can be made on what profiling/code cleanup tool the community as a whole would prefer.

Presently, code is submitted by a wide assortment of contributors. Some contributors use profiling/code cleanup tools, some don't. We already have contributor best practices established - http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices. Getting the community to standardize on a single tool (or set of tools) to enforce the best practices would be a worthy goal, but I'm not too optimistic about its success.

> Java Source Checkstyle Conformance and Source QA Tools
> ------------------------------------------------------
>
>                 Key: OFBIZ-1971
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1971
>             Project: OFBiz
>          Issue Type: Wish
>          Components: ALL COMPONENTS
>         Environment: Java source compilation.
>            Reporter: Mike Bachrynowski
>            Priority: Minor
>   Original Estimate: 672h
>  Remaining Estimate: 672h
>
> Is there a chance that future releases might be updated to conform to a particular Checkstyle http://checkstyle.sourceforge.net/.  Initially, by default, checkstyle should perhaps not be applied.
> I could supply a version of "checkstyle.xml" that I use but this does enforce "generics".  
> Other code quality tools such as JDepend http://clarkware.com/software/JDepend.html
> and JavaNCSS http://www.kclee.de/clemens/java/javancss/ or similar might be used both for technical reasons and as an aide to sell the use of OfBiz.
> Finally in testing web applications I usually create a full set of JMeter test plans.  Is there a place within the build for JMeter (run from Ant) to test out the demo applications.
>  

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634892#action_12634892 ]

BJ Freeman commented on OFBIZ-1971:
-----------------------------------

those using Eclipse have the formatting features built in.
I am not sure Jdpends and JavanCss understands Entity or Service engines.
so it would be limited to Code which is not really object oriented.

> Java Source Checkstyle Conformance and Source QA Tools
> ------------------------------------------------------
>
>                 Key: OFBIZ-1971
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1971
>             Project: OFBiz
>          Issue Type: Wish
>          Components: ALL COMPONENTS
>         Environment: Java source compilation.
>            Reporter: Mike Bachrynowski
>            Priority: Minor
>   Original Estimate: 672h
>  Remaining Estimate: 672h
>
> Is there a chance that future releases might be updated to conform to a particular Checkstyle http://checkstyle.sourceforge.net/.  Initially, by default, checkstyle should perhaps not be applied.
> I could supply a version of "checkstyle.xml" that I use but this does enforce "generics".  
> Other code quality tools such as JDepend http://clarkware.com/software/JDepend.html
> and JavaNCSS http://www.kclee.de/clemens/java/javancss/ or similar might be used both for technical reasons and as an aide to sell the use of OfBiz.
> Finally in testing web applications I usually create a full set of JMeter test plans.  Is there a place within the build for JMeter (run from Ant) to test out the demo applications.
>  

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634907#action_12634907 ]

BJ Freeman commented on OFBIZ-1971:
-----------------------------------

As an additional thought
Webtools artifacts is a good step to how things relate
Logs already have a lot of timing information.
Seems the only thing needed is a way to marry all this together to give profiles reports.
Maybe even have it run in the sandbox with an entity that stores the parameters and check to see if they are in or out.

> Java Source Checkstyle Conformance and Source QA Tools
> ------------------------------------------------------
>
>                 Key: OFBIZ-1971
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1971
>             Project: OFBiz
>          Issue Type: Wish
>          Components: ALL COMPONENTS
>         Environment: Java source compilation.
>            Reporter: Mike Bachrynowski
>            Priority: Minor
>   Original Estimate: 672h
>  Remaining Estimate: 672h
>
> Is there a chance that future releases might be updated to conform to a particular Checkstyle http://checkstyle.sourceforge.net/.  Initially, by default, checkstyle should perhaps not be applied.
> I could supply a version of "checkstyle.xml" that I use but this does enforce "generics".  
> Other code quality tools such as JDepend http://clarkware.com/software/JDepend.html
> and JavaNCSS http://www.kclee.de/clemens/java/javancss/ or similar might be used both for technical reasons and as an aide to sell the use of OfBiz.
> Finally in testing web applications I usually create a full set of JMeter test plans.  Is there a place within the build for JMeter (run from Ant) to test out the demo applications.
>  

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.