OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-2000) Added check availability functionality on new create profile page of e commerce.

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

51 messages Options

123

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2000) Added check availability functionality on new create profile page of e commerce.

[ https://issues.apache.org/jira/browse/OFBIZ-2000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12783102#action_12783102 ]

Jacques Le Roux commented on OFBIZ-2000:
----------------------------------------

Hi Rishi,

Yes, having only one piece of code should be better. For js code, if it's specific to this page I can't see any harm to put it there.

In this file I discovered this comment which is great and it would be even better if we could put thisi in the contributor best practices. Maybe also we should refactor the contributor best practices page because it tends to become a bit long. We could split it in sub-pages for instance...

<#------------------------------------------------------------------------------
NOTE: all page headings should start with an h2 tag, not an H1 tag, as
there should generally always only be one h1 tag on the page and that
will generally always be reserved for the logo at the top of the page.
------------------------------------------------------------------------------->

Thanks for your help guys (and ladyes maybe) !

> Added check availability functionality on new create profile page of e commerce.
> --------------------------------------------------------------------------------
>
> Key: OFBIZ-2000
> URL: https://issues.apache.org/jira/browse/OFBIZ-2000
> Project: OFBiz
> Issue Type: New Feature
> Components: specialpurpose/ecommerce
> Reporter: Rishi Solanki
> Priority: Minor
> Attachments: CheckAvailUsername.patch, CheckAvailUsername.patch, CheckAvailUserName.patch, CheckAvailUserName.patch, CheckAvailUserName.patch, CheckAvailUserName.patch, CheckAvailUserName.patch, FOR_TEST_OFBIZ-2000.patch, OFBIZ-2000.patch
>
>
> After adding this functionality while creating a profile from e commerce new profile pages, user will be able to check his/her selected userLoginId is availabel or not. Instead after submitting the whole form can check it just by clicking on a check availability link. For this implementation can use Ajax.request for submitting the user name and finally getting back the error list from the server. If got the error appear it else hide.
> Affected files for this feature are ;
> CustomerEvents.xml ----> ecommerce
> profile.js ---> ecommerce
> NewCustomer.ftl ---> ecommerce (for new one)
> Regards
> - Rishi Solanki

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2000) Added check availability functionality on new create profile page of e commerce.

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12783103#action_12783103 ]

Rishi Solanki commented on OFBIZ-2000:
--------------------------------------

Thanks Jacques,
+1 for contributors best practices.
But girls in Hwm feels bad because you gave your thanks to ladies. ;-)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2000) Added check availability functionality on new create profile page of e commerce.

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12783122#action_12783122 ]

Jacques Le Roux commented on OFBIZ-2000:
----------------------------------------

I thought about the word girls before, but to be polite I used the word ladies :)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2000) Added check availability functionality on new create profile page of e commerce.

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12783124#action_12783124 ]

Ashish Vijaywargiya commented on OFBIZ-2000:
--------------------------------------------

:)

--
Ashish

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-2000) Added check availability functionality on new create profile page of e commerce.

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Deepak Dixit updated OFBIZ-2000:
--------------------------------

Attachment: OFBIZ_2000.patch

Here is the updated patch,
Now this functionality is available for current New Customer page.

> Added check availability functionality on new create profile page of e commerce.
> --------------------------------------------------------------------------------
>
> Key: OFBIZ-2000
> URL: https://issues.apache.org/jira/browse/OFBIZ-2000
> Project: OFBiz
> Issue Type: New Feature
> Components: specialpurpose/ecommerce
> Reporter: Rishi Solanki
> Priority: Minor
> Attachments: CheckAvailUsername.patch, CheckAvailUsername.patch, CheckAvailUserName.patch, CheckAvailUserName.patch, CheckAvailUserName.patch, CheckAvailUserName.patch, CheckAvailUserName.patch, FOR_TEST_OFBIZ-2000.patch, OFBIZ-2000.patch, OFBIZ_2000.patch
>
>
> After adding this functionality while creating a profile from e commerce new profile pages, user will be able to check his/her selected userLoginId is availabel or not. Instead after submitting the whole form can check it just by clicking on a check availability link. For this implementation can use Ajax.request for submitting the user name and finally getting back the error list from the server. If got the error appear it else hide.
> Affected files for this feature are ;
> CustomerEvents.xml ----> ecommerce
> profile.js ---> ecommerce
> NewCustomer.ftl ---> ecommerce (for new one)
> Regards
> - Rishi Solanki

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2000) Added check availability functionality on new create profile page of e commerce.

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784081#action_12784081 ]

Rishi Solanki commented on OFBIZ-2000:
--------------------------------------

Hey Jacques,
This issue is waiting for your action, please have a look at the functionality and patch attached.

> Added check availability functionality on new create profile page of e commerce.
> --------------------------------------------------------------------------------
>
> Key: OFBIZ-2000
> URL: https://issues.apache.org/jira/browse/OFBIZ-2000
> Project: OFBiz
> Issue Type: New Feature
> Components: specialpurpose/ecommerce
> Reporter: Rishi Solanki
> Priority: Minor
> Attachments: CheckAvailUsername.patch, CheckAvailUsername.patch, CheckAvailUserName.patch, CheckAvailUserName.patch, CheckAvailUserName.patch, CheckAvailUserName.patch, CheckAvailUserName.patch, FOR_TEST_OFBIZ-2000.patch, OFBIZ-2000.patch, OFBIZ_2000.patch
>
>
> After adding this functionality while creating a profile from e commerce new profile pages, user will be able to check his/her selected userLoginId is availabel or not. Instead after submitting the whole form can check it just by clicking on a check availability link. For this implementation can use Ajax.request for submitting the user name and finally getting back the error list from the server. If got the error appear it else hide.
> Affected files for this feature are ;
> CustomerEvents.xml ----> ecommerce
> profile.js ---> ecommerce
> NewCustomer.ftl ---> ecommerce (for new one)
> Regards
> - Rishi Solanki

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-2000) Added check availability functionality on new create profile page of e commerce.

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-2000:
-----------------------------------

Attachment: Old profile Ajaxified.jpg

Thanks for the reminder Rishi,

Here (Old profile Ajaxified screen copy) what I get whn I validate without any fiels filled.

Some remarks

# not sure why and I guess not really related to this issue but despite the language is English I see some French :(
# There is some kind of redundancy : I think we could remove the error messages above the fiels now that we have them besides them. But then one more time I ask them to be more visible. I suggest to color them in red or at least to be bolded
# Should we be able to create an account without Contact Number ? I guess so because al we need for a webstore is an email, but I know in other places a Contact Number is mandatory...

> Added check availability functionality on new create profile page of e commerce.
> --------------------------------------------------------------------------------
>
> Key: OFBIZ-2000
> URL: https://issues.apache.org/jira/browse/OFBIZ-2000
> Project: OFBiz
> Issue Type: New Feature
> Components: specialpurpose/ecommerce
> Reporter: Rishi Solanki
> Priority: Minor
> Attachments: CheckAvailUsername.patch, CheckAvailUsername.patch, CheckAvailUserName.patch, CheckAvailUserName.patch, CheckAvailUserName.patch, CheckAvailUserName.patch, CheckAvailUserName.patch, FOR_TEST_OFBIZ-2000.patch, OFBIZ-2000.patch, OFBIZ_2000.patch, Old profile Ajaxified.jpg
>
>
> After adding this functionality while creating a profile from e commerce new profile pages, user will be able to check his/her selected userLoginId is availabel or not. Instead after submitting the whole form can check it just by clicking on a check availability link. For this implementation can use Ajax.request for submitting the user name and finally getting back the error list from the server. If got the error appear it else hide.
> Affected files for this feature are ;
> CustomerEvents.xml ----> ecommerce
> profile.js ---> ecommerce
> NewCustomer.ftl ---> ecommerce (for new one)
> Regards
> - Rishi Solanki

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2000) Added check availability functionality on new create profile page of e commerce.

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12786865#action_12786865 ]

Rishi Solanki commented on OFBIZ-2000:
--------------------------------------

Hi Jacques,
I remember, the color scheme for error message and UI were fine previously, they are scattered due to some later contribution. About the redundancy in error message we can show the particular message on the top instead of showing it on the field level. The redudancy will be remove once we add the client side validation on form submission. The form will not submit if user login is not available for create.
IMO, For the UI fixes and color scheme change we can create another issue on which we can work timely, as the color scheme for error message is not affect only to this UI. Let me know if it looks fine to you so we will upload the patch with no redundancy in the error message and validated form.

> Added check availability functionality on new create profile page of e commerce.
> --------------------------------------------------------------------------------
>
> Key: OFBIZ-2000
> URL: https://issues.apache.org/jira/browse/OFBIZ-2000
> Project: OFBiz
> Issue Type: New Feature
> Components: specialpurpose/ecommerce
> Reporter: Rishi Solanki
> Priority: Minor
> Attachments: CheckAvailUsername.patch, CheckAvailUsername.patch, CheckAvailUserName.patch, CheckAvailUserName.patch, CheckAvailUserName.patch, CheckAvailUserName.patch, CheckAvailUserName.patch, FOR_TEST_OFBIZ-2000.patch, OFBIZ-2000.patch, OFBIZ_2000.patch, Old profile Ajaxified.jpg
>
>
> After adding this functionality while creating a profile from e commerce new profile pages, user will be able to check his/her selected userLoginId is availabel or not. Instead after submitting the whole form can check it just by clicking on a check availability link. For this implementation can use Ajax.request for submitting the user name and finally getting back the error list from the server. If got the error appear it else hide.
> Affected files for this feature are ;
> CustomerEvents.xml ----> ecommerce
> profile.js ---> ecommerce
> NewCustomer.ftl ---> ecommerce (for new one)
> Regards
> - Rishi Solanki

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Assigned: (OFBIZ-2000) Added check availability functionality on new create profile page of e commerce.

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reassigned OFBIZ-2000:
--------------------------------------

Assignee: Jacques Le Roux

> Added check availability functionality on new create profile page of e commerce.
> --------------------------------------------------------------------------------
>
> Key: OFBIZ-2000
> URL: https://issues.apache.org/jira/browse/OFBIZ-2000
> Project: OFBiz
> Issue Type: New Feature
> Components: specialpurpose/ecommerce
> Reporter: Rishi Solanki
> Assignee: Jacques Le Roux
> Priority: Minor
> Attachments: CheckAvailUsername.patch, CheckAvailUsername.patch, CheckAvailUserName.patch, CheckAvailUserName.patch, CheckAvailUserName.patch, CheckAvailUserName.patch, CheckAvailUserName.patch, FOR_TEST_OFBIZ-2000.patch, OFBIZ-2000.patch, OFBIZ_2000.patch, Old profile Ajaxified.jpg
>
>
> After adding this functionality while creating a profile from e commerce new profile pages, user will be able to check his/her selected userLoginId is availabel or not. Instead after submitting the whole form can check it just by clicking on a check availability link. For this implementation can use Ajax.request for submitting the user name and finally getting back the error list from the server. If got the error appear it else hide.
> Affected files for this feature are ;
> CustomerEvents.xml ----> ecommerce
> profile.js ---> ecommerce
> NewCustomer.ftl ---> ecommerce (for new one)
> Regards
> - Rishi Solanki

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2000) Added check availability functionality on new create profile page of e commerce.

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12919622#action_12919622 ]

Jacques Le Roux commented on OFBIZ-2000:
----------------------------------------

Hi Rishi,

Sorry to be so late on this. I just checked, the patch is still applicable. If you could provide a new patch with the changes you explained above this would be very cool. This is in orde to close OFBIZ-3978 where this feature will miss else.

Thanks

> Added check availability functionality on new create profile page of e commerce.
> --------------------------------------------------------------------------------
>
> Key: OFBIZ-2000
> URL: https://issues.apache.org/jira/browse/OFBIZ-2000
> Project: OFBiz
> Issue Type: New Feature
> Components: specialpurpose/ecommerce
> Reporter: Rishi Solanki
> Assignee: Jacques Le Roux
> Priority: Minor
> Attachments: CheckAvailUsername.patch, CheckAvailUsername.patch, CheckAvailUserName.patch, CheckAvailUserName.patch, CheckAvailUserName.patch, CheckAvailUserName.patch, CheckAvailUserName.patch, FOR_TEST_OFBIZ-2000.patch, OFBIZ-2000.patch, OFBIZ_2000.patch, Old profile Ajaxified.jpg
>
>
> After adding this functionality while creating a profile from e commerce new profile pages, user will be able to check his/her selected userLoginId is availabel or not. Instead after submitting the whole form can check it just by clicking on a check availability link. For this implementation can use Ajax.request for submitting the user name and finally getting back the error list from the server. If got the error appear it else hide.
> Affected files for this feature are ;
> CustomerEvents.xml ----> ecommerce
> profile.js ---> ecommerce
> NewCustomer.ftl ---> ecommerce (for new one)
> Regards
> - Rishi Solanki

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2000) Added check availability functionality on new create profile page of e commerce.

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12919722#action_12919722 ]

Rishi Solanki commented on OFBIZ-2000:
--------------------------------------

Hi Jacques,
I'll be bit engaged in this week, will try to provide patch this weekend. Thanks for taking care.

> Added check availability functionality on new create profile page of e commerce.
> --------------------------------------------------------------------------------
>
> Key: OFBIZ-2000
> URL: https://issues.apache.org/jira/browse/OFBIZ-2000
> Project: OFBiz
> Issue Type: New Feature
> Components: specialpurpose/ecommerce
> Reporter: Rishi Solanki
> Assignee: Jacques Le Roux
> Priority: Minor
> Attachments: CheckAvailUsername.patch, CheckAvailUsername.patch, CheckAvailUserName.patch, CheckAvailUserName.patch, CheckAvailUserName.patch, CheckAvailUserName.patch, CheckAvailUserName.patch, FOR_TEST_OFBIZ-2000.patch, OFBIZ-2000.patch, OFBIZ_2000.patch, Old profile Ajaxified.jpg
>
>
> After adding this functionality while creating a profile from e commerce new profile pages, user will be able to check his/her selected userLoginId is availabel or not. Instead after submitting the whole form can check it just by clicking on a check availability link. For this implementation can use Ajax.request for submitting the user name and finally getting back the error list from the server. If got the error appear it else hide.
> Affected files for this feature are ;
> CustomerEvents.xml ----> ecommerce
> profile.js ---> ecommerce
> NewCustomer.ftl ---> ecommerce (for new one)
> Regards
> - Rishi Solanki

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

123