There is no way to define the timeout of the transaction used by ServiceMultiEventHandler
----------------------------------------------------------------------------------------- Key: OFBIZ-201 URL: http://issues.apache.org/jira/browse/OFBIZ-201 Project: OFBiz (The Open for Business Project) Issue Type: Improvement Components: framework Affects Versions: SVN trunk Environment: Linux, postgresql Reporter: Peter Goron Attachments: ServiceMultiEventHandler.patch The transaction created by service-multi event handler uses the default transaction timeout (60s). I've found no way to increase this value. I think the default timeout of service-multi should be at least the timeout defined in the service definition (transaction-timeout) of the service called (see attached patch). Maybe the default value should be service's timeout multiply by rowCount ? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[ http://issues.apache.org/jira/browse/OFBIZ-201?page=comments#action_12432642 ]
Si Chen commented on OFBIZ-201: ------------------------------- Peter, I think the service-multi should be a transaction of its own, but each service should be run in its own transaction using its own time out, which should be defined in the services xml. Si > There is no way to define the timeout of the transaction used by ServiceMultiEventHandler > ----------------------------------------------------------------------------------------- > > Key: OFBIZ-201 > URL: http://issues.apache.org/jira/browse/OFBIZ-201 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Environment: Linux, postgresql > Reporter: Peter Goron > Attachments: ServiceMultiEventHandler.patch > > > The transaction created by service-multi event handler uses the default transaction timeout (60s). I've found no way to increase this value. > I think the default timeout of service-multi should be at least the timeout defined in the service definition (transaction-timeout) of the service called (see attached patch). > Maybe the default value should be service's timeout multiply by rowCount ? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-201?page=all ]
Si Chen updated OFBIZ-201: -------------------------- Attachment: ServiceMulti-Si.patch Peter, Why don't you take a look at this patch? Si > There is no way to define the timeout of the transaction used by ServiceMultiEventHandler > ----------------------------------------------------------------------------------------- > > Key: OFBIZ-201 > URL: http://issues.apache.org/jira/browse/OFBIZ-201 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Environment: Linux, postgresql > Reporter: Peter Goron > Attachments: ServiceMulti-Si.patch, ServiceMultiEventHandler.patch > > > The transaction created by service-multi event handler uses the default transaction timeout (60s). I've found no way to increase this value. > I think the default timeout of service-multi should be at least the timeout defined in the service definition (transaction-timeout) of the service called (see attached patch). > Maybe the default value should be service's timeout multiply by rowCount ? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-201?page=comments#action_12432645 ]
Si Chen commented on OFBIZ-201: ------------------------------- Also, Peter, I noticed that when you uploaded your file, you did not click on "Grant license." If you do not want to license your patches under Apache license, then we cannot include it into OFBiz. > There is no way to define the timeout of the transaction used by ServiceMultiEventHandler > ----------------------------------------------------------------------------------------- > > Key: OFBIZ-201 > URL: http://issues.apache.org/jira/browse/OFBIZ-201 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Environment: Linux, postgresql > Reporter: Peter Goron > Attachments: ServiceMulti-Si.patch, ServiceMultiEventHandler.patch > > > The transaction created by service-multi event handler uses the default transaction timeout (60s). I've found no way to increase this value. > I think the default timeout of service-multi should be at least the timeout defined in the service definition (transaction-timeout) of the service called (see attached patch). > Maybe the default value should be service's timeout multiply by rowCount ? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-201?page=comments#action_12432650 ]
Peter Goron commented on OFBIZ-201: ----------------------------------- Hi Si, I' ve attached the patch during issue creation and "Grant license" radio button has not been presented to me so I had not been able to select it. Have I missed something ? Next time, I will attach patch after issue creation. I've take a look at your patch and I'm not sure it is a good solution to remove the global transaction because it will change service-multi behavior in case of errors : - with ofbiz original code, if a row service call fails, all next row service calls will be rollbacked even in case of success. - with your patch, if a row service call fails, it will not rollback next row service calls that sucess. I'm not against your proposed change but I think the two approach are usefull and should be configurable by developer. > There is no way to define the timeout of the transaction used by ServiceMultiEventHandler > ----------------------------------------------------------------------------------------- > > Key: OFBIZ-201 > URL: http://issues.apache.org/jira/browse/OFBIZ-201 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Environment: Linux, postgresql > Reporter: Peter Goron > Attachments: ServiceMulti-Si.patch, ServiceMultiEventHandler.patch > > > The transaction created by service-multi event handler uses the default transaction timeout (60s). I've found no way to increase this value. > I think the default timeout of service-multi should be at least the timeout defined in the service definition (transaction-timeout) of the service called (see attached patch). > Maybe the default value should be service's timeout multiply by rowCount ? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-201?page=comments#action_12432654 ]
Si Chen commented on OFBIZ-201: ------------------------------- Huh - interesting point - let's ask on the dev list > There is no way to define the timeout of the transaction used by ServiceMultiEventHandler > ----------------------------------------------------------------------------------------- > > Key: OFBIZ-201 > URL: http://issues.apache.org/jira/browse/OFBIZ-201 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Environment: Linux, postgresql > Reporter: Peter Goron > Attachments: ServiceMulti-Si.patch, ServiceMultiEventHandler.patch > > > The transaction created by service-multi event handler uses the default transaction timeout (60s). I've found no way to increase this value. > I think the default timeout of service-multi should be at least the timeout defined in the service definition (transaction-timeout) of the service called (see attached patch). > Maybe the default value should be service's timeout multiply by rowCount ? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-201?page=comments#action_12432656 ]
Si Chen commented on OFBIZ-201: ------------------------------- Peter - it seems that there is supposed to be an Apache feather next to your file if it was "contributed" correctly. > There is no way to define the timeout of the transaction used by ServiceMultiEventHandler > ----------------------------------------------------------------------------------------- > > Key: OFBIZ-201 > URL: http://issues.apache.org/jira/browse/OFBIZ-201 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Environment: Linux, postgresql > Reporter: Peter Goron > Attachments: ServiceMulti-Si.patch, ServiceMultiEventHandler.patch > > > The transaction created by service-multi event handler uses the default transaction timeout (60s). I've found no way to increase this value. > I think the default timeout of service-multi should be at least the timeout defined in the service definition (transaction-timeout) of the service called (see attached patch). > Maybe the default value should be service's timeout multiply by rowCount ? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-201?page=comments#action_12432664 ]
Jacopo Cappellato commented on OFBIZ-201: ----------------------------------------- Peter, it would be really great if you could attach again your patch in order to set to Y the "Grant license" box. Thanks > There is no way to define the timeout of the transaction used by ServiceMultiEventHandler > ----------------------------------------------------------------------------------------- > > Key: OFBIZ-201 > URL: http://issues.apache.org/jira/browse/OFBIZ-201 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Environment: Linux, postgresql > Reporter: Peter Goron > Attachments: ServiceMulti-Si.patch, ServiceMultiEventHandler.patch > > > The transaction created by service-multi event handler uses the default transaction timeout (60s). I've found no way to increase this value. > I think the default timeout of service-multi should be at least the timeout defined in the service definition (transaction-timeout) of the service called (see attached patch). > Maybe the default value should be service's timeout multiply by rowCount ? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-201?page=comments#action_12432665 ]
Jacopo Cappellato commented on OFBIZ-201: ----------------------------------------- Si, Peter, this is an interesting isssue. It would be nice to make this configurable: one big transaction or one transaction for each service... Jacopo > There is no way to define the timeout of the transaction used by ServiceMultiEventHandler > ----------------------------------------------------------------------------------------- > > Key: OFBIZ-201 > URL: http://issues.apache.org/jira/browse/OFBIZ-201 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Environment: Linux, postgresql > Reporter: Peter Goron > Attachments: ServiceMulti-Si.patch, ServiceMultiEventHandler.patch > > > The transaction created by service-multi event handler uses the default transaction timeout (60s). I've found no way to increase this value. > I think the default timeout of service-multi should be at least the timeout defined in the service definition (transaction-timeout) of the service called (see attached patch). > Maybe the default value should be service's timeout multiply by rowCount ? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-201?page=all ]
Peter Goron updated OFBIZ-201: ------------------------------ Attachment: ServiceMultiEventHandler.patch resubmit my patch to grant license to ASF for inclusion > There is no way to define the timeout of the transaction used by ServiceMultiEventHandler > ----------------------------------------------------------------------------------------- > > Key: OFBIZ-201 > URL: http://issues.apache.org/jira/browse/OFBIZ-201 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Environment: Linux, postgresql > Reporter: Peter Goron > Attachments: ServiceMulti-Si.patch, ServiceMultiEventHandler.patch, ServiceMultiEventHandler.patch > > > The transaction created by service-multi event handler uses the default transaction timeout (60s). I've found no way to increase this value. > I think the default timeout of service-multi should be at least the timeout defined in the service definition (transaction-timeout) of the service called (see attached patch). > Maybe the default value should be service's timeout multiply by rowCount ? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-201?page=comments#action_12432909 ]
Si Chen commented on OFBIZ-201: ------------------------------- Peter, why don't we just do rowCount * service.transactiontimeout for now? We'll deal with the configurable stuff later? > There is no way to define the timeout of the transaction used by ServiceMultiEventHandler > ----------------------------------------------------------------------------------------- > > Key: OFBIZ-201 > URL: http://issues.apache.org/jira/browse/OFBIZ-201 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Environment: Linux, postgresql > Reporter: Peter Goron > Attachments: ServiceMulti-Si.patch, ServiceMultiEventHandler.patch, ServiceMultiEventHandler.patch > > > The transaction created by service-multi event handler uses the default transaction timeout (60s). I've found no way to increase this value. > I think the default timeout of service-multi should be at least the timeout defined in the service definition (transaction-timeout) of the service called (see attached patch). > Maybe the default value should be service's timeout multiply by rowCount ? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-201?page=comments#action_12432935 ]
Peter Goron commented on OFBIZ-201: ----------------------------------- Si, It's ok for me to just do rowCount * service.transactiontimeout for now. To be able to configure transaction behavior, I think we could use path parameter to select the transaction mode like it is done for sync/async stuff in ServiceHandler. The difficult part for me is to choose the good terms to describe transaction behaviors. What do you think of : - stop-on-error, with a global transaction (default choice in order to be backward compatible with existing stuff) - continue-on-error, with a new transaction per service call Peter > There is no way to define the timeout of the transaction used by ServiceMultiEventHandler > ----------------------------------------------------------------------------------------- > > Key: OFBIZ-201 > URL: http://issues.apache.org/jira/browse/OFBIZ-201 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Environment: Linux, postgresql > Reporter: Peter Goron > Attachments: ServiceMulti-Si.patch, ServiceMultiEventHandler.patch, ServiceMultiEventHandler.patch > > > The transaction created by service-multi event handler uses the default transaction timeout (60s). I've found no way to increase this value. > I think the default timeout of service-multi should be at least the timeout defined in the service definition (transaction-timeout) of the service called (see attached patch). > Maybe the default value should be service's timeout multiply by rowCount ? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-201?page=comments#action_12435031 ]
Si Chen commented on OFBIZ-201: ------------------------------- Peter, I'd rather we create a separate attribute for that then to use something like path which would not be very intuitive to other users. Why don't we just do the rowCount * timeout for now and wrap everything in one big transaction? > There is no way to define the timeout of the transaction used by ServiceMultiEventHandler > ----------------------------------------------------------------------------------------- > > Key: OFBIZ-201 > URL: http://issues.apache.org/jira/browse/OFBIZ-201 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Environment: Linux, postgresql > Reporter: Peter Goron > Attachments: ServiceMulti-Si.patch, ServiceMultiEventHandler.patch, ServiceMultiEventHandler.patch > > > The transaction created by service-multi event handler uses the default transaction timeout (60s). I've found no way to increase this value. > I think the default timeout of service-multi should be at least the timeout defined in the service definition (transaction-timeout) of the service called (see attached patch). > Maybe the default value should be service's timeout multiply by rowCount ? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-201?page=all ]
Peter Goron updated OFBIZ-201: ------------------------------ Attachment: ServiceMultiEventHandler-v2.patch patch with modelService.transactionTimeout*rowCount. I've been really busy these weeks and I had no free time to advance on the other part of this issue. Maybe we should open a new issue to only treat of the transaction behaviour. > There is no way to define the timeout of the transaction used by ServiceMultiEventHandler > ----------------------------------------------------------------------------------------- > > Key: OFBIZ-201 > URL: http://issues.apache.org/jira/browse/OFBIZ-201 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Environment: Linux, postgresql > Reporter: Peter Goron > Attachments: ServiceMulti-Si.patch, ServiceMultiEventHandler-v2.patch, ServiceMultiEventHandler.patch, ServiceMultiEventHandler.patch > > > The transaction created by service-multi event handler uses the default transaction timeout (60s). I've found no way to increase this value. > I think the default timeout of service-multi should be at least the timeout defined in the service definition (transaction-timeout) of the service called (see attached patch). > Maybe the default value should be service's timeout multiply by rowCount ? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-201?page=all ]
Si Chen reassigned OFBIZ-201: ----------------------------- Assignee: Si Chen > There is no way to define the timeout of the transaction used by ServiceMultiEventHandler > ----------------------------------------------------------------------------------------- > > Key: OFBIZ-201 > URL: http://issues.apache.org/jira/browse/OFBIZ-201 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Environment: Linux, postgresql > Reporter: Peter Goron > Assigned To: Si Chen > Attachments: ServiceMulti-Si.patch, ServiceMultiEventHandler-v2.patch, ServiceMultiEventHandler.patch, ServiceMultiEventHandler.patch > > > The transaction created by service-multi event handler uses the default transaction timeout (60s). I've found no way to increase this value. > I think the default timeout of service-multi should be at least the timeout defined in the service definition (transaction-timeout) of the service called (see attached patch). > Maybe the default value should be service's timeout multiply by rowCount ? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-201?page=all ]
Si Chen closed OFBIZ-201. ------------------------- Resolution: Fixed Ok, thanks! > There is no way to define the timeout of the transaction used by ServiceMultiEventHandler > ----------------------------------------------------------------------------------------- > > Key: OFBIZ-201 > URL: http://issues.apache.org/jira/browse/OFBIZ-201 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Environment: Linux, postgresql > Reporter: Peter Goron > Assigned To: Si Chen > Attachments: ServiceMulti-Si.patch, ServiceMultiEventHandler-v2.patch, ServiceMultiEventHandler.patch, ServiceMultiEventHandler.patch > > > The transaction created by service-multi event handler uses the default transaction timeout (60s). I've found no way to increase this value. > I think the default timeout of service-multi should be at least the timeout defined in the service definition (transaction-timeout) of the service called (see attached patch). > Maybe the default value should be service's timeout multiply by rowCount ? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
Free forum by Nabble | Edit this page |