[jira] Created: (OFBIZ-2021) ModelFormField.java does not use the type size to define the textField.setMaxlength

[Nicolas Malin (Jira)]

ModelFormField.java does not use the type size to define the textField.setMaxlength
-----------------------------------------------------------------------------------

                 Key: OFBIZ-2021
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2021
             Project: OFBiz
          Issue Type: Bug
          Components: framework
            Reporter: BJ Freeman


uses
                textField.setMaxlength(Integer.valueOf(60));
instead of  setting it to the size defined by the type.



--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12644506#action_12644506 ]

vu hong thuan commented on OFBIZ-2021:
--------------------------------------

I think we would specify length of field type in ModelField.java
So we can get the specified length of field type to put into ModelFormField.java.
Then we can use
textField.setMaxlength(modelField.getLength())
instead of
textField.setMaxlength(Integer.valueOf(60));

> ModelFormField.java does not use the type size to define the textField.setMaxlength
> -----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2021
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2021
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>            Reporter: BJ Freeman
>
> uses
>                 textField.setMaxlength(Integer.valueOf(60));
> instead of  setting it to the size defined by the type.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12644512#action_12644512 ]

BJ Freeman commented on OFBIZ-2021:
-----------------------------------

Modelfield.java deals with
ccInfo.columnSize
but does not make it  public value.
so
textField.setMaxlength(modelField.getcolumnSize())

any input from anyone else
do you want to make a patch?

http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices

> ModelFormField.java does not use the type size to define the textField.setMaxlength
> -----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2021
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2021
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>            Reporter: BJ Freeman
>
> uses
>                 textField.setMaxlength(Integer.valueOf(60));
> instead of  setting it to the size defined by the type.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12644558#action_12644558 ]

BJ Freeman commented on OFBIZ-2021:
-----------------------------------

also not that ModelFormField.java
will have to be re-factored to use this new information.
the if else will have to be redone, since some fields types are not the same.
then can be done by
1) removing the textField.setMaxlength(Integer.valueOf(60)); from all the if and make a new structure for max length.
this allows the display length to be grouped but the max length to be independent.
2) redo the complete if structure so that each type is handled indepedently.

any input as to what would be best.

> ModelFormField.java does not use the type size to define the textField.setMaxlength
> -----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2021
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2021
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>            Reporter: BJ Freeman
>
> uses
>                 textField.setMaxlength(Integer.valueOf(60));
> instead of  setting it to the size defined by the type.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12658432#action_12658432 ]

BJ Freeman commented on OFBIZ-2021:
-----------------------------------

any reason we can not make the widths for types configurable?

> ModelFormField.java does not use the type size to define the textField.setMaxlength
> -----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2021
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2021
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>            Reporter: BJ Freeman
>
> uses
>                 textField.setMaxlength(Integer.valueOf(60));
> instead of  setting it to the size defined by the type.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott Gray reassigned OFBIZ-2021:
---------------------------------

    Assignee: Scott Gray

> ModelFormField.java does not use the type size to define the textField.setMaxlength
> -----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2021
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2021
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>            Reporter: BJ Freeman
>            Assignee: Scott Gray
>
> uses
>                 textField.setMaxlength(Integer.valueOf(60));
> instead of  setting it to the size defined by the type.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.