[jira] Created: (OFBIZ-2042) Individual logfiles for scheduled jobs
Locked
[jira] Created: (OFBIZ-2042) Individual logfiles for scheduled jobs
 
|
Individual logfiles for scheduled jobs
-------------------------------------- Key: OFBIZ-2042 URL: https://issues.apache.org/jira/browse/OFBIZ-2042 Project: OFBiz Issue Type: New Feature Components: framework Affects Versions: SVN trunk Reporter: Philipp Hoppen Priority: Minor Fix For: SVN trunk It is useful to have the ability to see the logs of a single scheduled job on the job list. In implementation (see attached patch) the user can specify whether he wants an individual logfile or not using a checkbox when he schedules the job. The information is passed from scheduleService() in CoreEvents.java to the Dispatcher class and finally to the JobManager, where it is stored in the ownLogfile field of the JobSandbox entity. When the job runs, JobInvoker initializes the job-thread with an own ThreadGroup. PersistentServiceJob then checks for the ownLogfile field of the job and eventually initializes the logLocation (using serviceName+ timestamp value) , which is stored in another field on JobSandbox. PersistentServiceJob passes the logLocation using setLogLocation() on GenericServiceJob, which in turn calls registerCurrentThreadGroupLogger on the Debug class. Debug maintains a list of these loggers for each running job and sends them the log entries when log() is called. After the job finished the logger is unregistered. On the Job List there the ownLogfile field is displayed (useful to find out if pending jobs will generate own logfile) and eventually a link to "View Log" (which receives a jobId parameter that is checked for in LogView.groovy). in purgeOldJobs() there are some lines to check for ownLogfile and to delete the physical logfile. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-2042) Individual logfiles for scheduled jobs
|
|
[ https://issues.apache.org/jira/browse/OFBIZ-2042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philipp Hoppen updated OFBIZ-2042: ---------------------------------- Attachment: joblogging.diff patch file > Individual logfiles for scheduled jobs > -------------------------------------- > > Key: OFBIZ-2042 > URL: https://issues.apache.org/jira/browse/OFBIZ-2042 > Project: OFBiz > Issue Type: New Feature > Components: framework > Affects Versions: SVN trunk > Reporter: Philipp Hoppen > Priority: Minor > Fix For: SVN trunk > > Attachments: joblogging.diff > > > It is useful to have the ability to see the logs of a single scheduled job on the job list. > In implementation (see attached patch) the user can specify whether he wants an individual logfile or not using a checkbox when he schedules the job. The information is passed from scheduleService() in CoreEvents.java to the Dispatcher class and finally to the JobManager, where it is stored in the ownLogfile field of the JobSandbox entity. > When the job runs, JobInvoker initializes the job-thread with an own ThreadGroup. PersistentServiceJob then checks for the ownLogfile field of the job and eventually initializes the logLocation (using serviceName+ timestamp value) , which is stored in another field on JobSandbox. PersistentServiceJob passes the logLocation using setLogLocation() on GenericServiceJob, which in turn calls registerCurrentThreadGroupLogger on the Debug class. Debug maintains a list of these loggers for each running job and sends them the log entries when log() is called. After the job finished the logger is unregistered. > On the Job List there the ownLogfile field is displayed (useful to find out if pending jobs will generate own logfile) and eventually a link to "View Log" (which receives a jobId parameter that is checked for in LogView.groovy). > in purgeOldJobs() there are some lines to check for ownLogfile and to delete the physical logfile. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Closed: (OFBIZ-2042) Individual logfiles for scheduled jobs
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-2042. ---------------------------------- Resolution: Fixed Assignee: Jacques Le Roux Thanks Phillip, Your patch is in trunk rev. 719836 > Individual logfiles for scheduled jobs > -------------------------------------- > > Key: OFBIZ-2042 > URL: https://issues.apache.org/jira/browse/OFBIZ-2042 > Project: OFBiz > Issue Type: New Feature > Components: framework > Affects Versions: SVN trunk > Reporter: Philipp Hoppen > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: joblogging.diff > > > It is useful to have the ability to see the logs of a single scheduled job on the job list. > In implementation (see attached patch) the user can specify whether he wants an individual logfile or not using a checkbox when he schedules the job. The information is passed from scheduleService() in CoreEvents.java to the Dispatcher class and finally to the JobManager, where it is stored in the ownLogfile field of the JobSandbox entity. > When the job runs, JobInvoker initializes the job-thread with an own ThreadGroup. PersistentServiceJob then checks for the ownLogfile field of the job and eventually initializes the logLocation (using serviceName+ timestamp value) , which is stored in another field on JobSandbox. PersistentServiceJob passes the logLocation using setLogLocation() on GenericServiceJob, which in turn calls registerCurrentThreadGroupLogger on the Debug class. Debug maintains a list of these loggers for each running job and sends them the log entries when log() is called. After the job finished the logger is unregistered. > On the Job List there the ownLogfile field is displayed (useful to find out if pending jobs will generate own logfile) and eventually a link to "View Log" (which receives a jobId parameter that is checked for in LogView.groovy). > in purgeOldJobs() there are some lines to check for ownLogfile and to delete the physical logfile. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-2042) Individual logfiles for scheduled jobs
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12658424#action_12658424 ] Jacques Le Roux commented on OFBIZ-2042: ---------------------------------------- Sorry Phlipp, This pacth has been reverted, please see [this thread|http://www.nabble.com/Re%3A-svn-commit%3A-r719836---in--ofbiz-trunk-framework%3A-base-src-org-ofbiz-base-util--service-entitydef--service-src-org-ofbiz-service--service-src-org-ofbiz-service-job--webapp-src-org-ofbiz-webapp-event--webtools-config--webtools-webapp-webtools-WEB-INF-act...-td21109803.html] > Individual logfiles for scheduled jobs > -------------------------------------- > > Key: OFBIZ-2042 > URL: https://issues.apache.org/jira/browse/OFBIZ-2042 > Project: OFBiz > Issue Type: New Feature > Components: framework > Affects Versions: SVN trunk > Reporter: Philipp Hoppen > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: joblogging.diff > > > It is useful to have the ability to see the logs of a single scheduled job on the job list. > In implementation (see attached patch) the user can specify whether he wants an individual logfile or not using a checkbox when he schedules the job. The information is passed from scheduleService() in CoreEvents.java to the Dispatcher class and finally to the JobManager, where it is stored in the ownLogfile field of the JobSandbox entity. > When the job runs, JobInvoker initializes the job-thread with an own ThreadGroup. PersistentServiceJob then checks for the ownLogfile field of the job and eventually initializes the logLocation (using serviceName+ timestamp value) , which is stored in another field on JobSandbox. PersistentServiceJob passes the logLocation using setLogLocation() on GenericServiceJob, which in turn calls registerCurrentThreadGroupLogger on the Debug class. Debug maintains a list of these loggers for each running job and sends them the log entries when log() is called. After the job finished the logger is unregistered. > On the Job List there the ownLogfile field is displayed (useful to find out if pending jobs will generate own logfile) and eventually a link to "View Log" (which receives a jobId parameter that is checked for in LogView.groovy). > in purgeOldJobs() there are some lines to check for ownLogfile and to delete the physical logfile. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-2042) Individual logfiles for scheduled jobs
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philipp Hoppen updated OFBIZ-2042: ---------------------------------- Attachment: joblog.diff Here is an updated version of this patch. Beside updating it for the latest trunk version, I tried to fix some of the issues mentioned by Adam Heath and Jaques. It now uses InheritableThreadLocal insted of a Map to temporarly store the Log4J-Appenders. It was suggested to not use java.io.File but I had no idea how else to delete the logfiles (FlexibleLocation doesn't seem to be suited for that). What's so wrong about using java.io.File for this anyway? Further changes include some method inlining in org.ofbiz.base.util.Debug to make it a bit clearer, and I appended the jobId parameter on the "Refresh" button on /webtools/control/LogView if available. What doesn't work is to completly include the log output form services that were asynchronously called by the job service because as soon as the calling service returns, GenericServiceJob removes the Appender. > Individual logfiles for scheduled jobs > -------------------------------------- > > Key: OFBIZ-2042 > URL: https://issues.apache.org/jira/browse/OFBIZ-2042 > Project: OFBiz > Issue Type: New Feature > Components: framework > Affects Versions: SVN trunk > Reporter: Philipp Hoppen > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: joblog.diff, joblogging.diff > > > It is useful to have the ability to see the logs of a single scheduled job on the job list. > In implementation (see attached patch) the user can specify whether he wants an individual logfile or not using a checkbox when he schedules the job. The information is passed from scheduleService() in CoreEvents.java to the Dispatcher class and finally to the JobManager, where it is stored in the ownLogfile field of the JobSandbox entity. > When the job runs, JobInvoker initializes the job-thread with an own ThreadGroup. PersistentServiceJob then checks for the ownLogfile field of the job and eventually initializes the logLocation (using serviceName+ timestamp value) , which is stored in another field on JobSandbox. PersistentServiceJob passes the logLocation using setLogLocation() on GenericServiceJob, which in turn calls registerCurrentThreadGroupLogger on the Debug class. Debug maintains a list of these loggers for each running job and sends them the log entries when log() is called. After the job finished the logger is unregistered. > On the Job List there the ownLogfile field is displayed (useful to find out if pending jobs will generate own logfile) and eventually a link to "View Log" (which receives a jobId parameter that is checked for in LogView.groovy). > in purgeOldJobs() there are some lines to check for ownLogfile and to delete the physical logfile. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Reopened: (OFBIZ-2042) Individual logfiles for scheduled jobs
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philipp Hoppen reopened OFBIZ-2042: ----------------------------------- > Individual logfiles for scheduled jobs > -------------------------------------- > > Key: OFBIZ-2042 > URL: https://issues.apache.org/jira/browse/OFBIZ-2042 > Project: OFBiz > Issue Type: New Feature > Components: framework > Affects Versions: SVN trunk > Reporter: Philipp Hoppen > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: joblog.diff, joblogging.diff > > > It is useful to have the ability to see the logs of a single scheduled job on the job list. > In implementation (see attached patch) the user can specify whether he wants an individual logfile or not using a checkbox when he schedules the job. The information is passed from scheduleService() in CoreEvents.java to the Dispatcher class and finally to the JobManager, where it is stored in the ownLogfile field of the JobSandbox entity. > When the job runs, JobInvoker initializes the job-thread with an own ThreadGroup. PersistentServiceJob then checks for the ownLogfile field of the job and eventually initializes the logLocation (using serviceName+ timestamp value) , which is stored in another field on JobSandbox. PersistentServiceJob passes the logLocation using setLogLocation() on GenericServiceJob, which in turn calls registerCurrentThreadGroupLogger on the Debug class. Debug maintains a list of these loggers for each running job and sends them the log entries when log() is called. After the job finished the logger is unregistered. > On the Job List there the ownLogfile field is displayed (useful to find out if pending jobs will generate own logfile) and eventually a link to "View Log" (which receives a jobId parameter that is checked for in LogView.groovy). > in purgeOldJobs() there are some lines to check for ownLogfile and to delete the physical logfile. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-2042) Individual logfiles for scheduled jobs
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12743324#action_12743324 ] Jacques Le Roux commented on OFBIZ-2042: ---------------------------------------- Hi Philipp, I'm not sure about java.io.File, maybe Adam can give us some light. Else please remove the "Property changes on: runtime/logs" block Thanks > Individual logfiles for scheduled jobs > -------------------------------------- > > Key: OFBIZ-2042 > URL: https://issues.apache.org/jira/browse/OFBIZ-2042 > Project: OFBiz > Issue Type: New Feature > Components: framework > Affects Versions: SVN trunk > Reporter: Philipp Hoppen > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: joblog.diff, joblogging.diff > > > It is useful to have the ability to see the logs of a single scheduled job on the job list. > In implementation (see attached patch) the user can specify whether he wants an individual logfile or not using a checkbox when he schedules the job. The information is passed from scheduleService() in CoreEvents.java to the Dispatcher class and finally to the JobManager, where it is stored in the ownLogfile field of the JobSandbox entity. > When the job runs, JobInvoker initializes the job-thread with an own ThreadGroup. PersistentServiceJob then checks for the ownLogfile field of the job and eventually initializes the logLocation (using serviceName+ timestamp value) , which is stored in another field on JobSandbox. PersistentServiceJob passes the logLocation using setLogLocation() on GenericServiceJob, which in turn calls registerCurrentThreadGroupLogger on the Debug class. Debug maintains a list of these loggers for each running job and sends them the log entries when log() is called. After the job finished the logger is unregistered. > On the Job List there the ownLogfile field is displayed (useful to find out if pending jobs will generate own logfile) and eventually a link to "View Log" (which receives a jobId parameter that is checked for in LogView.groovy). > in purgeOldJobs() there are some lines to check for ownLogfile and to delete the physical logfile. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-2042) Individual logfiles for scheduled jobs
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12743662#action_12743662 ] Philipp Hoppen commented on OFBIZ-2042: --------------------------------------- Hi Jacques Thanks for looking at it. My intention with the "Property changes" was that all html-Files in runtime/logs should be ignored by SVN, not just ofbiz.html. There will be one such file per executed job with the "own logfile" option set. > Individual logfiles for scheduled jobs > -------------------------------------- > > Key: OFBIZ-2042 > URL: https://issues.apache.org/jira/browse/OFBIZ-2042 > Project: OFBiz > Issue Type: New Feature > Components: framework > Affects Versions: SVN trunk > Reporter: Philipp Hoppen > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: joblog.diff, joblogging.diff > > > It is useful to have the ability to see the logs of a single scheduled job on the job list. > In implementation (see attached patch) the user can specify whether he wants an individual logfile or not using a checkbox when he schedules the job. The information is passed from scheduleService() in CoreEvents.java to the Dispatcher class and finally to the JobManager, where it is stored in the ownLogfile field of the JobSandbox entity. > When the job runs, JobInvoker initializes the job-thread with an own ThreadGroup. PersistentServiceJob then checks for the ownLogfile field of the job and eventually initializes the logLocation (using serviceName+ timestamp value) , which is stored in another field on JobSandbox. PersistentServiceJob passes the logLocation using setLogLocation() on GenericServiceJob, which in turn calls registerCurrentThreadGroupLogger on the Debug class. Debug maintains a list of these loggers for each running job and sends them the log entries when log() is called. After the job finished the logger is unregistered. > On the Job List there the ownLogfile field is displayed (useful to find out if pending jobs will generate own logfile) and eventually a link to "View Log" (which receives a jobId parameter that is checked for in LogView.groovy). > in purgeOldJobs() there are some lines to check for ownLogfile and to delete the physical logfile. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-2042) Individual logfiles for scheduled jobs
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12743663#action_12743663 ] Jacques Le Roux commented on OFBIZ-2042: ---------------------------------------- Thanks Philipp, It makes sense indeed. I will wait a bit more to hopefully have news from Adam about the File issue, and will review completly. > Individual logfiles for scheduled jobs > -------------------------------------- > > Key: OFBIZ-2042 > URL: https://issues.apache.org/jira/browse/OFBIZ-2042 > Project: OFBiz > Issue Type: New Feature > Components: framework > Affects Versions: SVN trunk > Reporter: Philipp Hoppen > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: joblog.diff, joblogging.diff > > > It is useful to have the ability to see the logs of a single scheduled job on the job list. > In implementation (see attached patch) the user can specify whether he wants an individual logfile or not using a checkbox when he schedules the job. The information is passed from scheduleService() in CoreEvents.java to the Dispatcher class and finally to the JobManager, where it is stored in the ownLogfile field of the JobSandbox entity. > When the job runs, JobInvoker initializes the job-thread with an own ThreadGroup. PersistentServiceJob then checks for the ownLogfile field of the job and eventually initializes the logLocation (using serviceName+ timestamp value) , which is stored in another field on JobSandbox. PersistentServiceJob passes the logLocation using setLogLocation() on GenericServiceJob, which in turn calls registerCurrentThreadGroupLogger on the Debug class. Debug maintains a list of these loggers for each running job and sends them the log entries when log() is called. After the job finished the logger is unregistered. > On the Job List there the ownLogfile field is displayed (useful to find out if pending jobs will generate own logfile) and eventually a link to "View Log" (which receives a jobId parameter that is checked for in LogView.groovy). > in purgeOldJobs() there are some lines to check for ownLogfile and to delete the physical logfile. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-2042) Individual logfiles for scheduled jobs
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12786257#action_12786257 ] Jacques Le Roux commented on OFBIZ-2042: ---------------------------------------- [Related thread|http://n4.nabble.com/Re-svn-commit-r719836-in-ofbiz-trunk-framework-base-src-org-ofbiz-base-util-service-entitydef-servic-td198500.html#a198500] > Individual logfiles for scheduled jobs > -------------------------------------- > > Key: OFBIZ-2042 > URL: https://issues.apache.org/jira/browse/OFBIZ-2042 > Project: OFBiz > Issue Type: New Feature > Components: framework > Affects Versions: SVN trunk > Reporter: Philipp Hoppen > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: joblog.diff, joblogging.diff > > > It is useful to have the ability to see the logs of a single scheduled job on the job list. > In implementation (see attached patch) the user can specify whether he wants an individual logfile or not using a checkbox when he schedules the job. The information is passed from scheduleService() in CoreEvents.java to the Dispatcher class and finally to the JobManager, where it is stored in the ownLogfile field of the JobSandbox entity. > When the job runs, JobInvoker initializes the job-thread with an own ThreadGroup. PersistentServiceJob then checks for the ownLogfile field of the job and eventually initializes the logLocation (using serviceName+ timestamp value) , which is stored in another field on JobSandbox. PersistentServiceJob passes the logLocation using setLogLocation() on GenericServiceJob, which in turn calls registerCurrentThreadGroupLogger on the Debug class. Debug maintains a list of these loggers for each running job and sends them the log entries when log() is called. After the job finished the logger is unregistered. > On the Job List there the ownLogfile field is displayed (useful to find out if pending jobs will generate own logfile) and eventually a link to "View Log" (which receives a jobId parameter that is checked for in LogView.groovy). > in purgeOldJobs() there are some lines to check for ownLogfile and to delete the physical logfile. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-2042) Individual logfiles for scheduled jobs
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-2042: ----------------------------------- Attachment: joblog.patch Same file but without tabs in code. I hope to review it soon again ant to commit it with or without changes about the file/flexiblelocation (if I understand the problem) issue since I got any answers from Adam... > Individual logfiles for scheduled jobs > -------------------------------------- > > Key: OFBIZ-2042 > URL: https://issues.apache.org/jira/browse/OFBIZ-2042 > Project: OFBiz > Issue Type: New Feature > Components: framework > Affects Versions: SVN trunk > Reporter: Philipp Hoppen > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: joblog.diff, joblog.patch, joblogging.diff > > > It is useful to have the ability to see the logs of a single scheduled job on the job list. > In implementation (see attached patch) the user can specify whether he wants an individual logfile or not using a checkbox when he schedules the job. The information is passed from scheduleService() in CoreEvents.java to the Dispatcher class and finally to the JobManager, where it is stored in the ownLogfile field of the JobSandbox entity. > When the job runs, JobInvoker initializes the job-thread with an own ThreadGroup. PersistentServiceJob then checks for the ownLogfile field of the job and eventually initializes the logLocation (using serviceName+ timestamp value) , which is stored in another field on JobSandbox. PersistentServiceJob passes the logLocation using setLogLocation() on GenericServiceJob, which in turn calls registerCurrentThreadGroupLogger on the Debug class. Debug maintains a list of these loggers for each running job and sends them the log entries when log() is called. After the job finished the logger is unregistered. > On the Job List there the ownLogfile field is displayed (useful to find out if pending jobs will generate own logfile) and eventually a link to "View Log" (which receives a jobId parameter that is checked for in LogView.groovy). > in purgeOldJobs() there are some lines to check for ownLogfile and to delete the physical logfile. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |