[jira] Created: (OFBIZ-205) CustomerEvents.xml & WorkflowMapProcessor and not localized

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (OFBIZ-205) CustomerEvents.xml & WorkflowMapProcessor and not localized

Nicolas Malin (Jira)
CustomerEvents.xml & WorkflowMapProcessor and not localized
-----------------------------------------------------------

                 Key: OFBIZ-205
                 URL: http://issues.apache.org/jira/browse/OFBIZ-205
             Project: OFBiz (The Open for Business Project)
          Issue Type: Improvement
          Components: ecommerce, order, workeffort
    Affects Versions: SVN trunk
         Environment: Windows
            Reporter: Marco Risaliti
         Attachments: CustomerEvents_WorkflowMapProcessor_i18n.patch

CustomerEvents.xml & WorkflowMapProcessor and not localized, they contains hardcoded messages in english.
This patch contains solve this issue and contains also same changes due to wrong translation in Italian that I have already included in the patch for issue OFBIZ-179 but not still commit.
Once you have tested and commit this patch you can also close the old-jira issue OFBIZ-486/OFBIZ-487.

Thanks
Marco

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-205) CustomerEvents.xml & WorkflowMapProcessor and not localized

Nicolas Malin (Jira)
    [ http://issues.apache.org/jira/browse/OFBIZ-205?page=comments#action_12432766 ]
           
Jacques Le Roux commented on OFBIZ-205:
---------------------------------------

Hi Marco,

How have you planned to manage the "wrong translation in Italian" ? Does this mean that this patch must be applied after OFBIZ-179 ?

Marco I think that it will be better not to mix i18n and i10n with other changes as much as possible. You will thus avoid these kind of problems.

Jacques

> CustomerEvents.xml & WorkflowMapProcessor and not localized
> -----------------------------------------------------------
>
>                 Key: OFBIZ-205
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-205
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: ecommerce, order, workeffort
>    Affects Versions: SVN trunk
>         Environment: Windows
>            Reporter: Marco Risaliti
>         Attachments: CustomerEvents_WorkflowMapProcessor_i18n.patch
>
>
> CustomerEvents.xml & WorkflowMapProcessor and not localized, they contains hardcoded messages in english.
> This patch contains solve this issue and contains also same changes due to wrong translation in Italian that I have already included in the patch for issue OFBIZ-179 but not still commit.
> Once you have tested and commit this patch you can also close the old-jira issue OFBIZ-486/OFBIZ-487.
> Thanks
> Marco

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-205) CustomerEvents.xml & WorkflowMapProcessor and not localized

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
    [ http://issues.apache.org/jira/browse/OFBIZ-205?page=comments#action_12432855 ]
           
Marco Risaliti commented on OFBIZ-205:
--------------------------------------

Hi Jacques,

This wrong translation in Italian are already included into this patch they are only a few and they are also included in another patch for issue OFBIZ-179 but you have not to wait that this patchh has been committed.
The two patches shares only EcommerceUiLabels.properties & EcommerceUiLabels_it.properties and this patch has also new labels specific for this issue.
I'm hoping that this can be commit without problems to you.

Thanks
Marco

> CustomerEvents.xml & WorkflowMapProcessor and not localized
> -----------------------------------------------------------
>
>                 Key: OFBIZ-205
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-205
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: ecommerce, order, workeffort
>    Affects Versions: SVN trunk
>         Environment: Windows
>            Reporter: Marco Risaliti
>         Attachments: CustomerEvents_WorkflowMapProcessor_i18n.patch
>
>
> CustomerEvents.xml & WorkflowMapProcessor and not localized, they contains hardcoded messages in english.
> This patch contains solve this issue and contains also same changes due to wrong translation in Italian that I have already included in the patch for issue OFBIZ-179 but not still commit.
> Once you have tested and commit this patch you can also close the old-jira issue OFBIZ-486/OFBIZ-487.
> Thanks
> Marco

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (OFBIZ-205) CustomerEvents.xml & WorkflowMapProcessor and not localized

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
     [ http://issues.apache.org/jira/browse/OFBIZ-205?page=all ]

Jacques Le Roux closed OFBIZ-205.
---------------------------------

    Fix Version/s: SVN trunk
       Resolution: Fixed

Marco,

Yes but it would better then to extract EcommerceUiLabels.properties & EcommerceUiLabels_it.properties from the OFBIZ-179 patch. Because else there is chance that there will be conflicts when patching from OFBIZ-179.

Anyway, I already commited this in rev 440990.

To be franck, I only reviewed it but had not enough time to test. I suppose you did.

Thanks

> CustomerEvents.xml & WorkflowMapProcessor and not localized
> -----------------------------------------------------------
>
>                 Key: OFBIZ-205
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-205
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: ecommerce, order, workeffort
>    Affects Versions: SVN trunk
>         Environment: Windows
>            Reporter: Marco Risaliti
>             Fix For: SVN trunk
>
>         Attachments: CustomerEvents_WorkflowMapProcessor_i18n.patch
>
>
> CustomerEvents.xml & WorkflowMapProcessor and not localized, they contains hardcoded messages in english.
> This patch contains solve this issue and contains also same changes due to wrong translation in Italian that I have already included in the patch for issue OFBIZ-179 but not still commit.
> Once you have tested and commit this patch you can also close the old-jira issue OFBIZ-486/OFBIZ-487.
> Thanks
> Marco

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-205) CustomerEvents.xml & WorkflowMapProcessor and not localized

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
    [ http://issues.apache.org/jira/browse/OFBIZ-205?page=comments#action_12433266 ]
           
Marco Risaliti commented on OFBIZ-205:
--------------------------------------

Hi Jacques,

thanks a lot for you work.
Is it possible for you to close also the old-jira issue OFBIZ-486 and OFBIZ-487, those are related to the same problems resolved with this patch.

Thanks a lot
Marco


> CustomerEvents.xml & WorkflowMapProcessor and not localized
> -----------------------------------------------------------
>
>                 Key: OFBIZ-205
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-205
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: ecommerce, order, workeffort
>    Affects Versions: SVN trunk
>         Environment: Windows
>            Reporter: Marco Risaliti
>             Fix For: SVN trunk
>
>         Attachments: CustomerEvents_WorkflowMapProcessor_i18n.patch
>
>
> CustomerEvents.xml & WorkflowMapProcessor and not localized, they contains hardcoded messages in english.
> This patch contains solve this issue and contains also same changes due to wrong translation in Italian that I have already included in the patch for issue OFBIZ-179 but not still commit.
> Once you have tested and commit this patch you can also close the old-jira issue OFBIZ-486/OFBIZ-487.
> Thanks
> Marco

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-205) CustomerEvents.xml & WorkflowMapProcessor and not localized

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
    [ http://issues.apache.org/jira/browse/OFBIZ-205?page=comments#action_12433338 ]
           
Jacques Le Roux commented on OFBIZ-205:
---------------------------------------

Yes Marco,

Thanks for the reminder ;o)

> CustomerEvents.xml & WorkflowMapProcessor and not localized
> -----------------------------------------------------------
>
>                 Key: OFBIZ-205
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-205
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: ecommerce, order, workeffort
>    Affects Versions: SVN trunk
>         Environment: Windows
>            Reporter: Marco Risaliti
>             Fix For: SVN trunk
>
>         Attachments: CustomerEvents_WorkflowMapProcessor_i18n.patch
>
>
> CustomerEvents.xml & WorkflowMapProcessor and not localized, they contains hardcoded messages in english.
> This patch contains solve this issue and contains also same changes due to wrong translation in Italian that I have already included in the patch for issue OFBIZ-179 but not still commit.
> Once you have tested and commit this patch you can also close the old-jira issue OFBIZ-486/OFBIZ-487.
> Thanks
> Marco

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira