${env.ofbiz.home} in property files does not get resolved after FlexibleProperties class is deprecated
------------------------------------------------------------------------------------------------------ Key: OFBIZ-2066 URL: https://issues.apache.org/jira/browse/OFBIZ-2066 Project: OFBiz Issue Type: Bug Components: ALL COMPONENTS Affects Versions: SVN trunk Reporter: Mridul Pathak Priority: Minor Fix For: SVN trunk ${env.ofbiz.home} in property files doesn't get resolved anymore after FlexibleProperties calss is deprecated. This is being used mainly in following property files: 1) catalog.properties 2) payment.properties 3) jsse.properties -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[ https://issues.apache.org/jira/browse/OFBIZ-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mridul Pathak updated OFBIZ-2066: --------------------------------- Attachment: catalog-properties-fix.patch This is the first patch to fix the issue in catalog.properties file. We can keep the issue open until the bug is fixed at other places. > ${env.ofbiz.home} in property files does not get resolved after FlexibleProperties class is deprecated > ------------------------------------------------------------------------------------------------------ > > Key: OFBIZ-2066 > URL: https://issues.apache.org/jira/browse/OFBIZ-2066 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Mridul Pathak > Priority: Minor > Fix For: SVN trunk > > Attachments: catalog-properties-fix.patch > > > ${env.ofbiz.home} in property files doesn't get resolved anymore after FlexibleProperties calss is deprecated. This is being used mainly in following property files: > 1) catalog.properties > 2) payment.properties > 3) jsse.properties -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12651563#action_12651563 ] Adrian Crum commented on OFBIZ-2066: ------------------------------------ Mridul, Thank you for reporting the bug. I don't believe your patch represents the correct solution to the problem. If a property is intended to support the ${} syntax, then you only need to create a FlexibleStringExpander instance for it and then expand the property using the service context. > ${env.ofbiz.home} in property files does not get resolved after FlexibleProperties class is deprecated > ------------------------------------------------------------------------------------------------------ > > Key: OFBIZ-2066 > URL: https://issues.apache.org/jira/browse/OFBIZ-2066 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Mridul Pathak > Priority: Minor > Fix For: SVN trunk > > Attachments: catalog-properties-fix.patch > > > ${env.ofbiz.home} in property files doesn't get resolved anymore after FlexibleProperties calss is deprecated. This is being used mainly in following property files: > 1) catalog.properties > 2) payment.properties > 3) jsse.properties -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12651575#action_12651575 ] Adrian Crum commented on OFBIZ-2066: ------------------------------------ I fixed the catalog and payment properties - rev 721508. > ${env.ofbiz.home} in property files does not get resolved after FlexibleProperties class is deprecated > ------------------------------------------------------------------------------------------------------ > > Key: OFBIZ-2066 > URL: https://issues.apache.org/jira/browse/OFBIZ-2066 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Mridul Pathak > Priority: Minor > Fix For: SVN trunk > > Attachments: catalog-properties-fix.patch > > > ${env.ofbiz.home} in property files doesn't get resolved anymore after FlexibleProperties calss is deprecated. This is being used mainly in following property files: > 1) catalog.properties > 2) payment.properties > 3) jsse.properties -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12651581#action_12651581 ] Mridul Pathak commented on OFBIZ-2066: -------------------------------------- Thanks Adrian for the fix. I didn't think it that way :). > ${env.ofbiz.home} in property files does not get resolved after FlexibleProperties class is deprecated > ------------------------------------------------------------------------------------------------------ > > Key: OFBIZ-2066 > URL: https://issues.apache.org/jira/browse/OFBIZ-2066 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Mridul Pathak > Priority: Minor > Fix For: SVN trunk > > Attachments: catalog-properties-fix.patch > > > ${env.ofbiz.home} in property files doesn't get resolved anymore after FlexibleProperties calss is deprecated. This is being used mainly in following property files: > 1) catalog.properties > 2) payment.properties > 3) jsse.properties -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12651698#action_12651698 ] Mridul Pathak commented on OFBIZ-2066: -------------------------------------- Hi Adrian, I tested this fix and it doesn't seem to fix the problem :(. What I think is that we can not use FlexibleStringExpander in this case because "env.ofbiz.home" or "ofbiz.home" is not found in service context. Instead "ofbiz.home" is a System property. I think that was the reason why ${env.ofbiz.home} was handled specifically in interpolate() method of FlexibleProperties class at line 241. If in this particular case we are ending up with using System.getProperty() method, I think its better to eliminate usage of ${env.ofbiz.home}. And in that case my patch can be a solution for this. Or may be there is another better solution, and if so please suggest me the way so that I can be of help in fixing this up. > ${env.ofbiz.home} in property files does not get resolved after FlexibleProperties class is deprecated > ------------------------------------------------------------------------------------------------------ > > Key: OFBIZ-2066 > URL: https://issues.apache.org/jira/browse/OFBIZ-2066 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Mridul Pathak > Priority: Minor > Fix For: SVN trunk > > Attachments: catalog-properties-fix.patch > > > ${env.ofbiz.home} in property files doesn't get resolved anymore after FlexibleProperties calss is deprecated. This is being used mainly in following property files: > 1) catalog.properties > 2) payment.properties > 3) jsse.properties -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12651718#action_12651718 ] Adrian Crum commented on OFBIZ-2066: ------------------------------------ If a particular OFBiz property needs a system property for expansion, then the system property should be put in the context prior to expansion. > ${env.ofbiz.home} in property files does not get resolved after FlexibleProperties class is deprecated > ------------------------------------------------------------------------------------------------------ > > Key: OFBIZ-2066 > URL: https://issues.apache.org/jira/browse/OFBIZ-2066 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Mridul Pathak > Priority: Minor > Fix For: SVN trunk > > Attachments: catalog-properties-fix.patch > > > ${env.ofbiz.home} in property files doesn't get resolved anymore after FlexibleProperties calss is deprecated. This is being used mainly in following property files: > 1) catalog.properties > 2) payment.properties > 3) jsse.properties -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-2066: ------------------------------- Attachment: FlexibleStringExpander.patch Mridul, Please try the attached patch and let me know if it fixes the problem. > ${env.ofbiz.home} in property files does not get resolved after FlexibleProperties class is deprecated > ------------------------------------------------------------------------------------------------------ > > Key: OFBIZ-2066 > URL: https://issues.apache.org/jira/browse/OFBIZ-2066 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Mridul Pathak > Priority: Minor > Fix For: SVN trunk > > Attachments: catalog-properties-fix.patch, FlexibleStringExpander.patch > > > ${env.ofbiz.home} in property files doesn't get resolved anymore after FlexibleProperties calss is deprecated. This is being used mainly in following property files: > 1) catalog.properties > 2) payment.properties > 3) jsse.properties -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-2066: ------------------------------- Attachment: FlexibleStringExpander.patch > ${env.ofbiz.home} in property files does not get resolved after FlexibleProperties class is deprecated > ------------------------------------------------------------------------------------------------------ > > Key: OFBIZ-2066 > URL: https://issues.apache.org/jira/browse/OFBIZ-2066 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Mridul Pathak > Priority: Minor > Fix For: SVN trunk > > Attachments: catalog-properties-fix.patch, FlexibleStringExpander.patch > > > ${env.ofbiz.home} in property files doesn't get resolved anymore after FlexibleProperties calss is deprecated. This is being used mainly in following property files: > 1) catalog.properties > 2) payment.properties > 3) jsse.properties -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-2066: ------------------------------- Attachment: (was: FlexibleStringExpander.patch) > ${env.ofbiz.home} in property files does not get resolved after FlexibleProperties class is deprecated > ------------------------------------------------------------------------------------------------------ > > Key: OFBIZ-2066 > URL: https://issues.apache.org/jira/browse/OFBIZ-2066 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Mridul Pathak > Priority: Minor > Fix For: SVN trunk > > Attachments: catalog-properties-fix.patch, FlexibleStringExpander.patch > > > ${env.ofbiz.home} in property files doesn't get resolved anymore after FlexibleProperties calss is deprecated. This is being used mainly in following property files: > 1) catalog.properties > 2) payment.properties > 3) jsse.properties -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-2066: ------------------------------- Attachment: FlexibleStringExpander.patch Updated patch - previous patch overlooked the substring. > ${env.ofbiz.home} in property files does not get resolved after FlexibleProperties class is deprecated > ------------------------------------------------------------------------------------------------------ > > Key: OFBIZ-2066 > URL: https://issues.apache.org/jira/browse/OFBIZ-2066 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Mridul Pathak > Priority: Minor > Fix For: SVN trunk > > Attachments: catalog-properties-fix.patch, FlexibleStringExpander.patch, FlexibleStringExpander.patch > > > ${env.ofbiz.home} in property files doesn't get resolved anymore after FlexibleProperties calss is deprecated. This is being used mainly in following property files: > 1) catalog.properties > 2) payment.properties > 3) jsse.properties -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12651948#action_12651948 ] Mridul Pathak commented on OFBIZ-2066: -------------------------------------- Adrian, I tested the new patch and it definitely fixes the problem and is ready to go in. Thanks. > ${env.ofbiz.home} in property files does not get resolved after FlexibleProperties class is deprecated > ------------------------------------------------------------------------------------------------------ > > Key: OFBIZ-2066 > URL: https://issues.apache.org/jira/browse/OFBIZ-2066 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Mridul Pathak > Priority: Minor > Fix For: SVN trunk > > Attachments: catalog-properties-fix.patch, FlexibleStringExpander.patch, FlexibleStringExpander.patch > > > ${env.ofbiz.home} in property files doesn't get resolved anymore after FlexibleProperties calss is deprecated. This is being used mainly in following property files: > 1) catalog.properties > 2) payment.properties > 3) jsse.properties -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12652036#action_12652036 ] Adrian Crum commented on OFBIZ-2066: ------------------------------------ Patch committed in rev 722104. I'm leaving this issue open because there may be more instances of this bug. > ${env.ofbiz.home} in property files does not get resolved after FlexibleProperties class is deprecated > ------------------------------------------------------------------------------------------------------ > > Key: OFBIZ-2066 > URL: https://issues.apache.org/jira/browse/OFBIZ-2066 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Mridul Pathak > Priority: Minor > Fix For: SVN trunk > > Attachments: catalog-properties-fix.patch, FlexibleStringExpander.patch, FlexibleStringExpander.patch > > > ${env.ofbiz.home} in property files doesn't get resolved anymore after FlexibleProperties calss is deprecated. This is being used mainly in following property files: > 1) catalog.properties > 2) payment.properties > 3) jsse.properties -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12652148#action_12652148 ] David E. Jones commented on OFBIZ-2066: --------------------------------------- On a semantic note... would this really be a bug? It looks like the functionality desired was not implemented, so it's not really a "bug" (ie an implementation that does not work) but rather a new feature, based on an expectation of something that "should" be there but isn't yet. Does that sound correct? > ${env.ofbiz.home} in property files does not get resolved after FlexibleProperties class is deprecated > ------------------------------------------------------------------------------------------------------ > > Key: OFBIZ-2066 > URL: https://issues.apache.org/jira/browse/OFBIZ-2066 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Mridul Pathak > Priority: Minor > Fix For: SVN trunk > > Attachments: catalog-properties-fix.patch, FlexibleStringExpander.patch, FlexibleStringExpander.patch > > > ${env.ofbiz.home} in property files doesn't get resolved anymore after FlexibleProperties calss is deprecated. This is being used mainly in following property files: > 1) catalog.properties > 2) payment.properties > 3) jsse.properties -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12652161#action_12652161 ] Adrian Crum commented on OFBIZ-2066: ------------------------------------ From my perspective, it is a bug I introduced when I deprecated the FlexibleProperties class. I didn't notice at the time that the class was performing some property expression expansions "behind the scenes" - so this bug appeared. FlexibleStringExpander now handles the expression expansion that was in FlexibleProperties, but there might be places in the project where FlexibleStringExpander needs to be used. > ${env.ofbiz.home} in property files does not get resolved after FlexibleProperties class is deprecated > ------------------------------------------------------------------------------------------------------ > > Key: OFBIZ-2066 > URL: https://issues.apache.org/jira/browse/OFBIZ-2066 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Mridul Pathak > Priority: Minor > Fix For: SVN trunk > > Attachments: catalog-properties-fix.patch, FlexibleStringExpander.patch, FlexibleStringExpander.patch > > > ${env.ofbiz.home} in property files doesn't get resolved anymore after FlexibleProperties calss is deprecated. This is being used mainly in following property files: > 1) catalog.properties > 2) payment.properties > 3) jsse.properties -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12652255#action_12652255 ] David E. Jones commented on OFBIZ-2066: --------------------------------------- I see. Thanks for taking care of this Adrian. > ${env.ofbiz.home} in property files does not get resolved after FlexibleProperties class is deprecated > ------------------------------------------------------------------------------------------------------ > > Key: OFBIZ-2066 > URL: https://issues.apache.org/jira/browse/OFBIZ-2066 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Mridul Pathak > Priority: Minor > Fix For: SVN trunk > > Attachments: catalog-properties-fix.patch, FlexibleStringExpander.patch, FlexibleStringExpander.patch > > > ${env.ofbiz.home} in property files doesn't get resolved anymore after FlexibleProperties calss is deprecated. This is being used mainly in following property files: > 1) catalog.properties > 2) payment.properties > 3) jsse.properties -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum closed OFBIZ-2066. ------------------------------ Resolution: Fixed It's been a month with no reports of further problems, so I'm closing this. > ${env.ofbiz.home} in property files does not get resolved after FlexibleProperties class is deprecated > ------------------------------------------------------------------------------------------------------ > > Key: OFBIZ-2066 > URL: https://issues.apache.org/jira/browse/OFBIZ-2066 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Mridul Pathak > Priority: Minor > Fix For: SVN trunk > > Attachments: catalog-properties-fix.patch, FlexibleStringExpander.patch, FlexibleStringExpander.patch > > > ${env.ofbiz.home} in property files doesn't get resolved anymore after FlexibleProperties calss is deprecated. This is being used mainly in following property files: > 1) catalog.properties > 2) payment.properties > 3) jsse.properties -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
Free forum by Nabble | Edit this page |