[jira] Created: (OFBIZ-2097) show organizationPartyId in header, rewrote financial history for a party in relation to the organizationParty

[Nicolas Malin (Jira)]

show organizationPartyId in header, rewrote financial history for a party in relation to the organizationParty
--------------------------------------------------------------------------------------------------------------

                 Key: OFBIZ-2097
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2097
             Project: OFBiz
          Issue Type: Improvement
          Components: accounting, party
    Affects Versions: SVN trunk
            Reporter: Hans Bakker
            Assignee: Hans Bakker
             Fix For: SVN trunk


Because this is a rather bigger change i first put it as proposal. When no major objections i will commit it in a few days.

first of all if only one currency is being used for the currency of the organizationPartyId, there are no changes to the system.

So, when I was changing the financial history to accommodate invoices being in different currency as the organization partyId, I saw that having the current organizationPartyId defined, is an essential requirement. Building on the organizationPartyId in preferences it is required to know at any time what the current assignment is. That is why I added it to the global context and show it on the top header.
The invoice/payment worker was changed to be able to select the currency to be displayed.

The changes more in detail:
1. introduced 2 new variables in the global context:
        a. organizationPartyId
        b. organizationPartyUomId
the organizationPartyId is stored in the users preferences and can be changed there.
Created a new entry in general.properties to define a default organizationPartyId when not set for the current logged in user.
Showed the organizationPartyId in the header now. It gets a bit full there perhaps we should move the language and location to the user preferences screen because not change often?

2. Paymentworker and Invoice worker if now aware of the different invoice currencies and invoice amounts can now be retrieved in the actual or organizationPartyUomId currency.  If everything is the organizationParty currency, there is no functional change to the system

3. Financial history now displays these two currencies when available making use of the new new payment/invoice worker methods.

4. New payment screen entry now only allows Disbursement and Taxpayment for outgoing payments and receipts for incoming payments.

5. removed many 'key-field-name' entries where not required in the payment forms

6. invoice PDF button "other currency" now only shows if there is a other currency available  


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hans Bakker updated OFBIZ-2097:
-------------------------------

    Attachment: organizationPartyHist.diff

the proposed changes in this svn diff file

> show organizationPartyId in header, rewrote financial history for a party in relation to the organizationParty
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2097
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2097
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting, party
>    Affects Versions: SVN trunk
>            Reporter: Hans Bakker
>            Assignee: Hans Bakker
>             Fix For: SVN trunk
>
>         Attachments: organizationPartyHist.diff
>
>
> Because this is a rather bigger change i first put it as proposal. When no major objections i will commit it in a few days.
> first of all if only one currency is being used for the currency of the organizationPartyId, there are no changes to the system.
> So, when I was changing the financial history to accommodate invoices being in different currency as the organization partyId, I saw that having the current organizationPartyId defined, is an essential requirement. Building on the organizationPartyId in preferences it is required to know at any time what the current assignment is. That is why I added it to the global context and show it on the top header.
> The invoice/payment worker was changed to be able to select the currency to be displayed.
> The changes more in detail:
> 1. introduced 2 new variables in the global context:
> a. organizationPartyId
> b. organizationPartyUomId
> the organizationPartyId is stored in the users preferences and can be changed there.
> Created a new entry in general.properties to define a default organizationPartyId when not set for the current logged in user.
> Showed the organizationPartyId in the header now. It gets a bit full there perhaps we should move the language and location to the user preferences screen because not change often?
> 2. Paymentworker and Invoice worker if now aware of the different invoice currencies and invoice amounts can now be retrieved in the actual or organizationPartyUomId currency.  If everything is the organizationParty currency, there is no functional change to the system
> 3. Financial history now displays these two currencies when available making use of the new new payment/invoice worker methods.
> 4. New payment screen entry now only allows Disbursement and Taxpayment for outgoing payments and receipts for incoming payments.
> 5. removed many 'key-field-name' entries where not required in the payment forms
> 6. invoice PDF button "other currency" now only shows if there is a other currency available  

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12658363#action_12658363 ]

David E. Jones commented on OFBIZ-2097:
---------------------------------------

Does anyone care about multi-organization support in OFBiz? If so, could you please help me communicate with Hans about issues with this sort of approach? I already tried with the issue of billing for WorkEfforts and he ignored me there, and evidently it really didn't make it through because this is going in the same direction.

Doing things based on an organizationPartyId associated with the user is BAD BAD BAD, and basically kills the multi-organization support in OFBiz.

In the WorkEffort example: you want the organization associated with the WorkEffort, and NOT with the user logged in. For example say you have a project WorkEffort and you want to do billing for it, and there is a service provider Party associated with the WorkEffort. If a user logs in to bill for that WorkEffort and the organizationPartyId is associated with the user then it doesn't matter who the service provider organization is, the user's organizationPartyId will be the from Party on the invoice. In other words, different people could login to generate the invoice and have different from Parties on the invoice, based solely on who is logged in.

Internal Organization parties should be associated with things like ProductStore, WorkEffort, etc, etc... but NOT with the logged in user or the Party associated with the logged in user.

Am I the only who sees a problem with this? Am I losing my mind? Hello? Anyone?

> show organizationPartyId in header, rewrote financial history for a party in relation to the organizationParty
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2097
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2097
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting, party
>    Affects Versions: SVN trunk
>            Reporter: Hans Bakker
>            Assignee: Hans Bakker
>             Fix For: SVN trunk
>
>         Attachments: organizationPartyHist.diff
>
>
> Because this is a rather bigger change i first put it as proposal. When no major objections i will commit it in a few days.
> first of all if only one currency is being used for the currency of the organizationPartyId, there are no changes to the system.
> So, when I was changing the financial history to accommodate invoices being in different currency as the organization partyId, I saw that having the current organizationPartyId defined, is an essential requirement. Building on the organizationPartyId in preferences it is required to know at any time what the current assignment is. That is why I added it to the global context and show it on the top header.
> The invoice/payment worker was changed to be able to select the currency to be displayed.
> The changes more in detail:
> 1. introduced 2 new variables in the global context:
> a. organizationPartyId
> b. organizationPartyUomId
> the organizationPartyId is stored in the users preferences and can be changed there.
> Created a new entry in general.properties to define a default organizationPartyId when not set for the current logged in user.
> Showed the organizationPartyId in the header now. It gets a bit full there perhaps we should move the language and location to the user preferences screen because not change often?
> 2. Paymentworker and Invoice worker if now aware of the different invoice currencies and invoice amounts can now be retrieved in the actual or organizationPartyUomId currency.  If everything is the organizationParty currency, there is no functional change to the system
> 3. Financial history now displays these two currencies when available making use of the new new payment/invoice worker methods.
> 4. New payment screen entry now only allows Disbursement and Taxpayment for outgoing payments and receipts for incoming payments.
> 5. removed many 'key-field-name' entries where not required in the payment forms
> 6. invoice PDF button "other currency" now only shows if there is a other currency available  

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12658364#action_12658364 ]

Hans Bakker commented on OFBIZ-2097:
------------------------------------

David probably i did not explain it correctly but you completely misunderstood me....

Having the organizationParty connected with the userlogin is for making the input and retrieval of data easier:

1. were i made it initially for, is to provide a financial history between 'a party' and the current active organization, you do not have to enter it...because a party can have a relationship with different organizations at the same time.
2. when you create an invoice, the organization can already selected but can still be changed.
3. the same for the creation of a payment, the organization can already selected but can still be changed.

this implementation does not prohibit the connection of an organization to a project, productstore and has nothing to do with the current userLogin....

so please read my changes again, now you know this....

> show organizationPartyId in header, rewrote financial history for a party in relation to the organizationParty
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2097
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2097
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting, party
>    Affects Versions: SVN trunk
>            Reporter: Hans Bakker
>            Assignee: Hans Bakker
>             Fix For: SVN trunk
>
>         Attachments: organizationPartyHist.diff
>
>
> Because this is a rather bigger change i first put it as proposal. When no major objections i will commit it in a few days.
> first of all if only one currency is being used for the currency of the organizationPartyId, there are no changes to the system.
> So, when I was changing the financial history to accommodate invoices being in different currency as the organization partyId, I saw that having the current organizationPartyId defined, is an essential requirement. Building on the organizationPartyId in preferences it is required to know at any time what the current assignment is. That is why I added it to the global context and show it on the top header.
> The invoice/payment worker was changed to be able to select the currency to be displayed.
> The changes more in detail:
> 1. introduced 2 new variables in the global context:
> a. organizationPartyId
> b. organizationPartyUomId
> the organizationPartyId is stored in the users preferences and can be changed there.
> Created a new entry in general.properties to define a default organizationPartyId when not set for the current logged in user.
> Showed the organizationPartyId in the header now. It gets a bit full there perhaps we should move the language and location to the user preferences screen because not change often?
> 2. Paymentworker and Invoice worker if now aware of the different invoice currencies and invoice amounts can now be retrieved in the actual or organizationPartyUomId currency.  If everything is the organizationParty currency, there is no functional change to the system
> 3. Financial history now displays these two currencies when available making use of the new new payment/invoice worker methods.
> 4. New payment screen entry now only allows Disbursement and Taxpayment for outgoing payments and receipts for incoming payments.
> 5. removed many 'key-field-name' entries where not required in the payment forms
> 6. invoice PDF button "other currency" now only shows if there is a other currency available  

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12658370#action_12658370 ]

Jacques Le Roux commented on OFBIZ-2097:
----------------------------------------

I did not yet use multi-organization support in OFBiz, but, yes, I really think we should care about it.

>It gets a bit full there perhaps we should move the language and location to the user preferences screen because not change often?
I think that for the purpose of demonstration it's better to have them there  OOTB, it's always possible to collapse.

Is the WorEffort issue already commited ?

Should we not care about this thread  http://www.nabble.com/Questions-about-PartyFinancialHistory-screen-td19721669.html ?
BTW where is to-scope="screen" defined ? I can't find any toScope.equals("screen")) in java code (user and application are ok), am I missing something (I suppose it was something specific to Hans code that did not get through to OFBiz) ?

I did not review the patch yet (the to-scope="screen"is removed there...) and I'm not sure to understand  all the points from Hans and David.

If I well understand, organizationPartyId is used to take care of payments, GL accounts to post to from a store, etc. . I can understand that a logged in user (a person Party) would be associated with an organisation. But if this user is associated with more than one organisation an issue arises. Is that the problem you raise David ?

> show organizationPartyId in header, rewrote financial history for a party in relation to the organizationParty
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2097
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2097
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting, party
>    Affects Versions: SVN trunk
>            Reporter: Hans Bakker
>            Assignee: Hans Bakker
>             Fix For: SVN trunk
>
>         Attachments: organizationPartyHist.diff
>
>
> Because this is a rather bigger change i first put it as proposal. When no major objections i will commit it in a few days.
> first of all if only one currency is being used for the currency of the organizationPartyId, there are no changes to the system.
> So, when I was changing the financial history to accommodate invoices being in different currency as the organization partyId, I saw that having the current organizationPartyId defined, is an essential requirement. Building on the organizationPartyId in preferences it is required to know at any time what the current assignment is. That is why I added it to the global context and show it on the top header.
> The invoice/payment worker was changed to be able to select the currency to be displayed.
> The changes more in detail:
> 1. introduced 2 new variables in the global context:
> a. organizationPartyId
> b. organizationPartyUomId
> the organizationPartyId is stored in the users preferences and can be changed there.
> Created a new entry in general.properties to define a default organizationPartyId when not set for the current logged in user.
> Showed the organizationPartyId in the header now. It gets a bit full there perhaps we should move the language and location to the user preferences screen because not change often?
> 2. Paymentworker and Invoice worker if now aware of the different invoice currencies and invoice amounts can now be retrieved in the actual or organizationPartyUomId currency.  If everything is the organizationParty currency, there is no functional change to the system
> 3. Financial history now displays these two currencies when available making use of the new new payment/invoice worker methods.
> 4. New payment screen entry now only allows Disbursement and Taxpayment for outgoing payments and receipts for incoming payments.
> 5. removed many 'key-field-name' entries where not required in the payment forms
> 6. invoice PDF button "other currency" now only shows if there is a other currency available  

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12658371#action_12658371 ]

Jacques Le Roux commented on OFBIZ-2097:
----------------------------------------

Hans,

But is there not a problem with the default value you want to set in general.properties ?

> show organizationPartyId in header, rewrote financial history for a party in relation to the organizationParty
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2097
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2097
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting, party
>    Affects Versions: SVN trunk
>            Reporter: Hans Bakker
>            Assignee: Hans Bakker
>             Fix For: SVN trunk
>
>         Attachments: organizationPartyHist.diff
>
>
> Because this is a rather bigger change i first put it as proposal. When no major objections i will commit it in a few days.
> first of all if only one currency is being used for the currency of the organizationPartyId, there are no changes to the system.
> So, when I was changing the financial history to accommodate invoices being in different currency as the organization partyId, I saw that having the current organizationPartyId defined, is an essential requirement. Building on the organizationPartyId in preferences it is required to know at any time what the current assignment is. That is why I added it to the global context and show it on the top header.
> The invoice/payment worker was changed to be able to select the currency to be displayed.
> The changes more in detail:
> 1. introduced 2 new variables in the global context:
> a. organizationPartyId
> b. organizationPartyUomId
> the organizationPartyId is stored in the users preferences and can be changed there.
> Created a new entry in general.properties to define a default organizationPartyId when not set for the current logged in user.
> Showed the organizationPartyId in the header now. It gets a bit full there perhaps we should move the language and location to the user preferences screen because not change often?
> 2. Paymentworker and Invoice worker if now aware of the different invoice currencies and invoice amounts can now be retrieved in the actual or organizationPartyUomId currency.  If everything is the organizationParty currency, there is no functional change to the system
> 3. Financial history now displays these two currencies when available making use of the new new payment/invoice worker methods.
> 4. New payment screen entry now only allows Disbursement and Taxpayment for outgoing payments and receipts for incoming payments.
> 5. removed many 'key-field-name' entries where not required in the payment forms
> 6. invoice PDF button "other currency" now only shows if there is a other currency available  

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12658370#action_12658370 ]

jacques.le.roux edited comment on OFBIZ-2097 at 12/21/08 2:13 AM:
------------------------------------------------------------------

I did not yet use multi-organization support in OFBiz, but, yes, I really think we should care about it.

>It gets a bit full there perhaps we should move the language and location to the user preferences screen because not change often?
I think that for the purpose of demonstration it's better to have them there  OOTB, it's always possible to collapse.

Is the WorEffort issue already commited ?

Should we not care about this thread  http://www.nabble.com/Questions-about-PartyFinancialHistory-screen-td19721669.html ?
BTW where is to-scope="screen" defined ? I can't find any toScope.equals("screen")) in java code (user and application are ok), am I missing something (I suppose it was something specific to Hans code that did not get through to OFBiz) ?

I did not review the patch yet (the to-scope="screen"is removed there...) and I'm not sure to understand  all the points from Hans and David.

Note: this comment was written before I was aware of Hans's comment  (during) just above

If I well understand, organizationPartyId is used to take care of payments, GL accounts to post to from a store, etc. . I can understand that a logged in user (a person Party) would be associated with an organisation. But if this user is associated with more than one organisation an issue arises. Is that the problem you raise David ?

      was (Author: jacques.le.roux):
    I did not yet use multi-organization support in OFBiz, but, yes, I really think we should care about it.

>It gets a bit full there perhaps we should move the language and location to the user preferences screen because not change often?
I think that for the purpose of demonstration it's better to have them there  OOTB, it's always possible to collapse.

Is the WorEffort issue already commited ?

Should we not care about this thread  http://www.nabble.com/Questions-about-PartyFinancialHistory-screen-td19721669.html ?
BTW where is to-scope="screen" defined ? I can't find any toScope.equals("screen")) in java code (user and application are ok), am I missing something (I suppose it was something specific to Hans code that did not get through to OFBiz) ?

I did not review the patch yet (the to-scope="screen"is removed there...) and I'm not sure to understand  all the points from Hans and David.

If I well understand, organizationPartyId is used to take care of payments, GL accounts to post to from a store, etc. . I can understand that a logged in user (a person Party) would be associated with an organisation. But if this user is associated with more than one organisation an issue arises. Is that the problem you raise David ?
 

> show organizationPartyId in header, rewrote financial history for a party in relation to the organizationParty
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2097
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2097
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting, party
>    Affects Versions: SVN trunk
>            Reporter: Hans Bakker
>            Assignee: Hans Bakker
>             Fix For: SVN trunk
>
>         Attachments: organizationPartyHist.diff
>
>
> Because this is a rather bigger change i first put it as proposal. When no major objections i will commit it in a few days.
> first of all if only one currency is being used for the currency of the organizationPartyId, there are no changes to the system.
> So, when I was changing the financial history to accommodate invoices being in different currency as the organization partyId, I saw that having the current organizationPartyId defined, is an essential requirement. Building on the organizationPartyId in preferences it is required to know at any time what the current assignment is. That is why I added it to the global context and show it on the top header.
> The invoice/payment worker was changed to be able to select the currency to be displayed.
> The changes more in detail:
> 1. introduced 2 new variables in the global context:
> a. organizationPartyId
> b. organizationPartyUomId
> the organizationPartyId is stored in the users preferences and can be changed there.
> Created a new entry in general.properties to define a default organizationPartyId when not set for the current logged in user.
> Showed the organizationPartyId in the header now. It gets a bit full there perhaps we should move the language and location to the user preferences screen because not change often?
> 2. Paymentworker and Invoice worker if now aware of the different invoice currencies and invoice amounts can now be retrieved in the actual or organizationPartyUomId currency.  If everything is the organizationParty currency, there is no functional change to the system
> 3. Financial history now displays these two currencies when available making use of the new new payment/invoice worker methods.
> 4. New payment screen entry now only allows Disbursement and Taxpayment for outgoing payments and receipts for incoming payments.
> 5. removed many 'key-field-name' entries where not required in the payment forms
> 6. invoice PDF button "other currency" now only shows if there is a other currency available  

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12658371#action_12658371 ]

jacques.le.roux edited comment on OFBIZ-2097 at 12/21/08 2:17 AM:
------------------------------------------------------------------

Hans,

But is there not a problem with the default value you want to set in general.properties ?

I mean if the person logged does not care. Should it not be better to have to enter that each time, or at least to allow the user to decide if he/she wants to have it by default or not ?

      was (Author: jacques.le.roux):
    Hans,

But is there not a problem with the default value you want to set in general.properties ?
 

> show organizationPartyId in header, rewrote financial history for a party in relation to the organizationParty
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2097
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2097
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting, party
>    Affects Versions: SVN trunk
>            Reporter: Hans Bakker
>            Assignee: Hans Bakker
>             Fix For: SVN trunk
>
>         Attachments: organizationPartyHist.diff
>
>
> Because this is a rather bigger change i first put it as proposal. When no major objections i will commit it in a few days.
> first of all if only one currency is being used for the currency of the organizationPartyId, there are no changes to the system.
> So, when I was changing the financial history to accommodate invoices being in different currency as the organization partyId, I saw that having the current organizationPartyId defined, is an essential requirement. Building on the organizationPartyId in preferences it is required to know at any time what the current assignment is. That is why I added it to the global context and show it on the top header.
> The invoice/payment worker was changed to be able to select the currency to be displayed.
> The changes more in detail:
> 1. introduced 2 new variables in the global context:
> a. organizationPartyId
> b. organizationPartyUomId
> the organizationPartyId is stored in the users preferences and can be changed there.
> Created a new entry in general.properties to define a default organizationPartyId when not set for the current logged in user.
> Showed the organizationPartyId in the header now. It gets a bit full there perhaps we should move the language and location to the user preferences screen because not change often?
> 2. Paymentworker and Invoice worker if now aware of the different invoice currencies and invoice amounts can now be retrieved in the actual or organizationPartyUomId currency.  If everything is the organizationParty currency, there is no functional change to the system
> 3. Financial history now displays these two currencies when available making use of the new new payment/invoice worker methods.
> 4. New payment screen entry now only allows Disbursement and Taxpayment for outgoing payments and receipts for incoming payments.
> 5. removed many 'key-field-name' entries where not required in the payment forms
> 6. invoice PDF button "other currency" now only shows if there is a other currency available  

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12658439#action_12658439 ]

Hans Bakker commented on OFBIZ-2097:
------------------------------------

David, after re-reading what i wrote i can be more clear.
This organizationPartyId assignment to a userlogin is used only for retrieval and entry default in fields. it is certainly not used for the creation of an invoice from a project, where the projectrole assignment should be used.

Jacques concerning your question:
The default setting will preset the organizationParty in the drop down, but it can still be adjusted by the user....

> show organizationPartyId in header, rewrote financial history for a party in relation to the organizationParty
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2097
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2097
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting, party
>    Affects Versions: SVN trunk
>            Reporter: Hans Bakker
>            Assignee: Hans Bakker
>             Fix For: SVN trunk
>
>         Attachments: organizationPartyHist.diff
>
>
> Because this is a rather bigger change i first put it as proposal. When no major objections i will commit it in a few days.
> first of all if only one currency is being used for the currency of the organizationPartyId, there are no changes to the system.
> So, when I was changing the financial history to accommodate invoices being in different currency as the organization partyId, I saw that having the current organizationPartyId defined, is an essential requirement. Building on the organizationPartyId in preferences it is required to know at any time what the current assignment is. That is why I added it to the global context and show it on the top header.
> The invoice/payment worker was changed to be able to select the currency to be displayed.
> The changes more in detail:
> 1. introduced 2 new variables in the global context:
> a. organizationPartyId
> b. organizationPartyUomId
> the organizationPartyId is stored in the users preferences and can be changed there.
> Created a new entry in general.properties to define a default organizationPartyId when not set for the current logged in user.
> Showed the organizationPartyId in the header now. It gets a bit full there perhaps we should move the language and location to the user preferences screen because not change often?
> 2. Paymentworker and Invoice worker if now aware of the different invoice currencies and invoice amounts can now be retrieved in the actual or organizationPartyUomId currency.  If everything is the organizationParty currency, there is no functional change to the system
> 3. Financial history now displays these two currencies when available making use of the new new payment/invoice worker methods.
> 4. New payment screen entry now only allows Disbursement and Taxpayment for outgoing payments and receipts for incoming payments.
> 5. removed many 'key-field-name' entries where not required in the payment forms
> 6. invoice PDF button "other currency" now only shows if there is a other currency available  

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12658541#action_12658541 ]

Jacques Le Roux commented on OFBIZ-2097:
----------------------------------------

So it seems ok to me

> show organizationPartyId in header, rewrote financial history for a party in relation to the organizationParty
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2097
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2097
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting, party
>    Affects Versions: SVN trunk
>            Reporter: Hans Bakker
>            Assignee: Hans Bakker
>             Fix For: SVN trunk
>
>         Attachments: organizationPartyHist.diff
>
>
> Because this is a rather bigger change i first put it as proposal. When no major objections i will commit it in a few days.
> first of all if only one currency is being used for the currency of the organizationPartyId, there are no changes to the system.
> So, when I was changing the financial history to accommodate invoices being in different currency as the organization partyId, I saw that having the current organizationPartyId defined, is an essential requirement. Building on the organizationPartyId in preferences it is required to know at any time what the current assignment is. That is why I added it to the global context and show it on the top header.
> The invoice/payment worker was changed to be able to select the currency to be displayed.
> The changes more in detail:
> 1. introduced 2 new variables in the global context:
> a. organizationPartyId
> b. organizationPartyUomId
> the organizationPartyId is stored in the users preferences and can be changed there.
> Created a new entry in general.properties to define a default organizationPartyId when not set for the current logged in user.
> Showed the organizationPartyId in the header now. It gets a bit full there perhaps we should move the language and location to the user preferences screen because not change often?
> 2. Paymentworker and Invoice worker if now aware of the different invoice currencies and invoice amounts can now be retrieved in the actual or organizationPartyUomId currency.  If everything is the organizationParty currency, there is no functional change to the system
> 3. Financial history now displays these two currencies when available making use of the new new payment/invoice worker methods.
> 4. New payment screen entry now only allows Disbursement and Taxpayment for outgoing payments and receipts for incoming payments.
> 5. removed many 'key-field-name' entries where not required in the payment forms
> 6. invoice PDF button "other currency" now only shows if there is a other currency available  

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12659057#action_12659057 ]

David E. Jones commented on OFBIZ-2097:
---------------------------------------


Using it as a default would be fine, as long as we really treat it as a default. To me that means:

1. the name always includes "default", ie "defaulOrganizationPartyId"
2. wherever it is used it is the default selected option (unless a more "local" default is applicable), but the user can always select other options before applying the default (ie not require going back and changing something after the default has been applied as that tends to be rather error-prone
3. if a more "local" default is applicable that should be used, like in the WorkEffort scenario where a project may already have an organization associated with it, and that is a better "default" than the user's generic default organization

> show organizationPartyId in header, rewrote financial history for a party in relation to the organizationParty
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2097
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2097
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting, party
>    Affects Versions: SVN trunk
>            Reporter: Hans Bakker
>            Assignee: Hans Bakker
>             Fix For: SVN trunk
>
>         Attachments: organizationPartyHist.diff
>
>
> Because this is a rather bigger change i first put it as proposal. When no major objections i will commit it in a few days.
> first of all if only one currency is being used for the currency of the organizationPartyId, there are no changes to the system.
> So, when I was changing the financial history to accommodate invoices being in different currency as the organization partyId, I saw that having the current organizationPartyId defined, is an essential requirement. Building on the organizationPartyId in preferences it is required to know at any time what the current assignment is. That is why I added it to the global context and show it on the top header.
> The invoice/payment worker was changed to be able to select the currency to be displayed.
> The changes more in detail:
> 1. introduced 2 new variables in the global context:
> a. organizationPartyId
> b. organizationPartyUomId
> the organizationPartyId is stored in the users preferences and can be changed there.
> Created a new entry in general.properties to define a default organizationPartyId when not set for the current logged in user.
> Showed the organizationPartyId in the header now. It gets a bit full there perhaps we should move the language and location to the user preferences screen because not change often?
> 2. Paymentworker and Invoice worker if now aware of the different invoice currencies and invoice amounts can now be retrieved in the actual or organizationPartyUomId currency.  If everything is the organizationParty currency, there is no functional change to the system
> 3. Financial history now displays these two currencies when available making use of the new new payment/invoice worker methods.
> 4. New payment screen entry now only allows Disbursement and Taxpayment for outgoing payments and receipts for incoming payments.
> 5. removed many 'key-field-name' entries where not required in the payment forms
> 6. invoice PDF button "other currency" now only shows if there is a other currency available  

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hans Bakker closed OFBIZ-2097.
------------------------------

    Resolution: Fixed

committed in r729396 with the change that organizationPartyId has been renamed to defaultOrganizationPartyId.

> show organizationPartyId in header, rewrote financial history for a party in relation to the organizationParty
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2097
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2097
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting, party
>    Affects Versions: SVN trunk
>            Reporter: Hans Bakker
>            Assignee: Hans Bakker
>             Fix For: SVN trunk
>
>         Attachments: organizationPartyHist.diff
>
>
> Because this is a rather bigger change i first put it as proposal. When no major objections i will commit it in a few days.
> first of all if only one currency is being used for the currency of the organizationPartyId, there are no changes to the system.
> So, when I was changing the financial history to accommodate invoices being in different currency as the organization partyId, I saw that having the current organizationPartyId defined, is an essential requirement. Building on the organizationPartyId in preferences it is required to know at any time what the current assignment is. That is why I added it to the global context and show it on the top header.
> The invoice/payment worker was changed to be able to select the currency to be displayed.
> The changes more in detail:
> 1. introduced 2 new variables in the global context:
> a. organizationPartyId
> b. organizationPartyUomId
> the organizationPartyId is stored in the users preferences and can be changed there.
> Created a new entry in general.properties to define a default organizationPartyId when not set for the current logged in user.
> Showed the organizationPartyId in the header now. It gets a bit full there perhaps we should move the language and location to the user preferences screen because not change often?
> 2. Paymentworker and Invoice worker if now aware of the different invoice currencies and invoice amounts can now be retrieved in the actual or organizationPartyUomId currency.  If everything is the organizationParty currency, there is no functional change to the system
> 3. Financial history now displays these two currencies when available making use of the new new payment/invoice worker methods.
> 4. New payment screen entry now only allows Disbursement and Taxpayment for outgoing payments and receipts for incoming payments.
> 5. removed many 'key-field-name' entries where not required in the payment forms
> 6. invoice PDF button "other currency" now only shows if there is a other currency available  

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.