[jira] Created: (OFBIZ-2122) Incomplete customization options for VisualThemes

[Nicolas Malin (Jira)]

Incomplete customization options for VisualThemes
--------------------------------------------------

                 Key: OFBIZ-2122
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2122
             Project: OFBiz
          Issue Type: Improvement
          Components: framework
    Affects Versions: SVN trunk
            Reporter: Michael Pätzold
             Fix For: SVN trunk


It's possible to provide adapted header.ftl/footer.ftl/... by providing a proper VisualTheme. Therein it's possible to overwrite the original fields in framework/common/widget/CommonScreens.xml.

Unfortunately this ability isn't given for all template files within GlobalDecorator screen, i.e.:
- appbar.ftl
- messages.ftl

Also all other screen definitions contain static ftl references. In order to provide a full VisualTheme adaptation of these needs to be possible, too.

In addition to changes in CommonScreens, the improvement of framework/common/data/CommonTypeData.xml needs to kept synchronized.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663790#action_12663790 ]

Adrian Crum commented on OFBIZ-2122:
------------------------------------

The main navigation is just an unordered list contained in a DIV element, and the system messages are just text contained in a DIV element. Why would those need to be changed? Each has its own CSS class - you can change their appearance with the style sheet.

The whole idea of Visual Themes is to change the appearance of the content, not change the content itself.

> Incomplete customization options for VisualThemes
> --------------------------------------------------
>
>                 Key: OFBIZ-2122
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2122
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Michael Pätzold
>             Fix For: SVN trunk
>
>
> It's possible to provide adapted header.ftl/footer.ftl/... by providing a proper VisualTheme. Therein it's possible to overwrite the original fields in framework/common/widget/CommonScreens.xml.
> Unfortunately this ability isn't given for all template files within GlobalDecorator screen, i.e.:
> - appbar.ftl
> - messages.ftl
> Also all other screen definitions contain static ftl references. In order to provide a full VisualTheme adaptation of these needs to be possible, too.
> In addition to changes in CommonScreens, the improvement of framework/common/data/CommonTypeData.xml needs to kept synchronized.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-2122:
-------------------------------

    Priority: Minor  (was: Major)

> Incomplete customization options for VisualThemes
> --------------------------------------------------
>
>                 Key: OFBIZ-2122
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2122
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Michael Pätzold
>            Priority: Minor
>             Fix For: SVN trunk
>
>
> It's possible to provide adapted header.ftl/footer.ftl/... by providing a proper VisualTheme. Therein it's possible to overwrite the original fields in framework/common/widget/CommonScreens.xml.
> Unfortunately this ability isn't given for all template files within GlobalDecorator screen, i.e.:
> - appbar.ftl
> - messages.ftl
> Also all other screen definitions contain static ftl references. In order to provide a full VisualTheme adaptation of these needs to be possible, too.
> In addition to changes in CommonScreens, the improvement of framework/common/data/CommonTypeData.xml needs to kept synchronized.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663803#action_12663803 ]

Michael Pätzold commented on OFBIZ-2122:
----------------------------------------

We got at least two problems that would require customization of appbar.ftl:

- In order to use a javascript for the appbar (<ul>) we would require an id property.
- As sorting of the applications can be done by providing a custom comparator, we would like to invoke getAppBarWebInfos(ofbizServerName, "main") with the third parameter - the comparator

The customization can only be implemented if the ftl is replaceable, or am I wrong?

> Incomplete customization options for VisualThemes
> --------------------------------------------------
>
>                 Key: OFBIZ-2122
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2122
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Michael Pätzold
>            Priority: Minor
>             Fix For: SVN trunk
>
>
> It's possible to provide adapted header.ftl/footer.ftl/... by providing a proper VisualTheme. Therein it's possible to overwrite the original fields in framework/common/widget/CommonScreens.xml.
> Unfortunately this ability isn't given for all template files within GlobalDecorator screen, i.e.:
> - appbar.ftl
> - messages.ftl
> Also all other screen definitions contain static ftl references. In order to provide a full VisualTheme adaptation of these needs to be possible, too.
> In addition to changes in CommonScreens, the improvement of framework/common/data/CommonTypeData.xml needs to kept synchronized.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663811#action_12663811 ]

Adrian Crum commented on OFBIZ-2122:
------------------------------------

The main navigation bar has an ID - main-navigation.

The main navigation template location has been added to the visual themes - rev 734455.

> Incomplete customization options for VisualThemes
> --------------------------------------------------
>
>                 Key: OFBIZ-2122
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2122
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Michael Pätzold
>            Priority: Minor
>             Fix For: SVN trunk
>
>
> It's possible to provide adapted header.ftl/footer.ftl/... by providing a proper VisualTheme. Therein it's possible to overwrite the original fields in framework/common/widget/CommonScreens.xml.
> Unfortunately this ability isn't given for all template files within GlobalDecorator screen, i.e.:
> - appbar.ftl
> - messages.ftl
> Also all other screen definitions contain static ftl references. In order to provide a full VisualTheme adaptation of these needs to be possible, too.
> In addition to changes in CommonScreens, the improvement of framework/common/data/CommonTypeData.xml needs to kept synchronized.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663818#action_12663818 ]

Bruno Busco commented on OFBIZ-2122:
------------------------------------

Thank you Adrian,
I think this is really usefull.
In OFBIZ-2118 I had to modify the CommonScreen.xml file also because the appbar.ftl was not theme-configurable.
Now I think I can rework it having less (or hopefully none) changes out of the theme.

> Incomplete customization options for VisualThemes
> --------------------------------------------------
>
>                 Key: OFBIZ-2122
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2122
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Michael Pätzold
>            Priority: Minor
>             Fix For: SVN trunk
>
>
> It's possible to provide adapted header.ftl/footer.ftl/... by providing a proper VisualTheme. Therein it's possible to overwrite the original fields in framework/common/widget/CommonScreens.xml.
> Unfortunately this ability isn't given for all template files within GlobalDecorator screen, i.e.:
> - appbar.ftl
> - messages.ftl
> Also all other screen definitions contain static ftl references. In order to provide a full VisualTheme adaptation of these needs to be possible, too.
> In addition to changes in CommonScreens, the improvement of framework/common/data/CommonTypeData.xml needs to kept synchronized.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663826#action_12663826 ]

Bruno Busco commented on OFBIZ-2122:
------------------------------------

In OFBIZ-2118 I wanted to implement a theme where the "logout" button was not in the AppBar menu but in the control-box at the top on the left of the header.
Wouldn't make sense to have this also customizable by a Visual Theme?

Could we, may be, have the CommonAppBar and CommonTabBarMenu defined in the theme also?

> Incomplete customization options for VisualThemes
> --------------------------------------------------
>
>                 Key: OFBIZ-2122
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2122
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Michael Pätzold
>            Priority: Minor
>             Fix For: SVN trunk
>
>
> It's possible to provide adapted header.ftl/footer.ftl/... by providing a proper VisualTheme. Therein it's possible to overwrite the original fields in framework/common/widget/CommonScreens.xml.
> Unfortunately this ability isn't given for all template files within GlobalDecorator screen, i.e.:
> - appbar.ftl
> - messages.ftl
> Also all other screen definitions contain static ftl references. In order to provide a full VisualTheme adaptation of these needs to be possible, too.
> In addition to changes in CommonScreens, the improvement of framework/common/data/CommonTypeData.xml needs to kept synchronized.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666780#action_12666780 ]

Jacques Le Roux commented on OFBIZ-2122:
----------------------------------------

Should this issue stay opened ? (Bruno ?)

> Incomplete customization options for VisualThemes
> --------------------------------------------------
>
>                 Key: OFBIZ-2122
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2122
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Michael Pätzold
>            Priority: Minor
>             Fix For: SVN trunk
>
>
> It's possible to provide adapted header.ftl/footer.ftl/... by providing a proper VisualTheme. Therein it's possible to overwrite the original fields in framework/common/widget/CommonScreens.xml.
> Unfortunately this ability isn't given for all template files within GlobalDecorator screen, i.e.:
> - appbar.ftl
> - messages.ftl
> Also all other screen definitions contain static ftl references. In order to provide a full VisualTheme adaptation of these needs to be possible, too.
> In addition to changes in CommonScreens, the improvement of framework/common/data/CommonTypeData.xml needs to kept synchronized.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco closed OFBIZ-2122.
------------------------------

    Resolution: Fixed

Both appbar.ftl and messages.ftl are now redefinable in the theme

> Incomplete customization options for VisualThemes
> --------------------------------------------------
>
>                 Key: OFBIZ-2122
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2122
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Michael Pätzold
>            Priority: Minor
>             Fix For: SVN trunk
>
>
> It's possible to provide adapted header.ftl/footer.ftl/... by providing a proper VisualTheme. Therein it's possible to overwrite the original fields in framework/common/widget/CommonScreens.xml.
> Unfortunately this ability isn't given for all template files within GlobalDecorator screen, i.e.:
> - appbar.ftl
> - messages.ftl
> Also all other screen definitions contain static ftl references. In order to provide a full VisualTheme adaptation of these needs to be possible, too.
> In addition to changes in CommonScreens, the improvement of framework/common/data/CommonTypeData.xml needs to kept synchronized.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.