[jira] Created: (OFBIZ-2138) Remove markup from labels

[Nicolas Malin (Jira)]

Remove markup from labels
-------------------------

                 Key: OFBIZ-2138
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2138
             Project: OFBiz
          Issue Type: Bug
    Affects Versions: SVN trunk
            Reporter: Bilgin Ibryam
            Assignee: Bilgin Ibryam
            Priority: Minor
             Fix For: SVN trunk


Using the gettext patch OFBIZ-2008, I found two labels that contains html markup.
The first one is loginevents.following_error_occurred_during_login and contains <b></b> for French and German translation.
The other label is ProductRedExplanation, and it has more html markups like <b style="color: red;">.
If nobody is against, I will simply remove markups from these 2 labels.

A quote from Adrian:
"Regarding the unescaped markup example: there is an even bigger problem with that translation - it uses embedded HTML in a UI label. That is a bad design and should be corrected."

 

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666978#action_12666978 ]

Jacques Le Roux commented on OFBIZ-2138:
----------------------------------------

Hi Bilgin,

There are a few more than those. I'm not against removing them, but please wait for all this labels cleaning effort to settle. At least for CleanupLabelsJLR.patch in OFBIZ-2070 to be commited (with changes I already found others small errors). Will you put the corresponding tags (which came from somewhere I guess) in the calling code ?

Thanks

> Remove markup from labels
> -------------------------
>
>                 Key: OFBIZ-2138
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2138
>             Project: OFBiz
>          Issue Type: Bug
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>            Assignee: Bilgin Ibryam
>            Priority: Minor
>             Fix For: SVN trunk
>
>
> Using the gettext patch OFBIZ-2008, I found two labels that contains html markup.
> The first one is loginevents.following_error_occurred_during_login and contains <b></b> for French and German translation.
> The other label is ProductRedExplanation, and it has more html markups like <b style="color: red;">.
> If nobody is against, I will simply remove markups from these 2 labels.
> A quote from Adrian:
> "Regarding the unescaped markup example: there is an even bigger problem with that translation - it uses embedded HTML in a UI label. That is a bad design and should be corrected."
>  

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.