[jira] Created: (OFBIZ-2156) Removing Login/Logout from AppBarMenu

[Nicolas Malin (Jira)]

Removing Login/Logout from AppBarMenu
-------------------------------------

                 Key: OFBIZ-2156
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2156
             Project: OFBiz
          Issue Type: Improvement
          Components: framework
            Reporter: Bruno Busco


please find attached a patch to remove the Login and Logout menu-items from the CommonAppBar menu and to put them into the header.
This was discussed recently and agreed to have better (drop-down) menus.



--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco updated OFBIZ-2156:
-------------------------------

    Attachment: HeaderLogOut.patch

> Removing Login/Logout from AppBarMenu
> -------------------------------------
>
>                 Key: OFBIZ-2156
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2156
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Bruno Busco
>         Attachments: HeaderLogOut.patch
>
>
> please find attached a patch to remove the Login and Logout menu-items from the CommonAppBar menu and to put them into the header.
> This was discussed recently and agreed to have better (drop-down) menus.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12669210#action_12669210 ]

Jacques Le Roux commented on OFBIZ-2156:
----------------------------------------

Hi Bruno,

It's almost OK with blue-light theme (I think we should have login/logout using the same color as other things in header) but it breaks the sd theme.

> Removing Login/Logout from AppBarMenu
> -------------------------------------
>
>                 Key: OFBIZ-2156
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2156
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Bruno Busco
>         Attachments: HeaderLogOut.patch
>
>
> please find attached a patch to remove the Login and Logout menu-items from the CommonAppBar menu and to put them into the header.
> This was discussed recently and agreed to have better (drop-down) menus.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12669214#action_12669214 ]

Jacques Le Roux commented on OFBIZ-2156:
----------------------------------------

Also not sure why yet but we got an issue with all browsers but IE7 (Opera, Chrome and Safari are really hurted) with last revision (739574) . I tried to put back r739406 but it's not related, still searching... The demo is still ok, so it should be a change since then (but we don't have the rev. number on demo)

> Removing Login/Logout from AppBarMenu
> -------------------------------------
>
>                 Key: OFBIZ-2156
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2156
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Bruno Busco
>         Attachments: HeaderLogOut.patch
>
>
> please find attached a patch to remove the Login and Logout menu-items from the CommonAppBar menu and to put them into the header.
> This was discussed recently and agreed to have better (drop-down) menus.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12669216#action_12669216 ]

Jacques Le Roux commented on OFBIZ-2156:
----------------------------------------

Forget my last comment, for a reason or another I had still the r739406 changes in :(

> Removing Login/Logout from AppBarMenu
> -------------------------------------
>
>                 Key: OFBIZ-2156
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2156
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Bruno Busco
>         Attachments: HeaderLogOut.patch
>
>
> please find attached a patch to remove the Login and Logout menu-items from the CommonAppBar menu and to put them into the header.
> This was discussed recently and agreed to have better (drop-down) menus.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12669217#action_12669217 ]

Jacques Le Roux commented on OFBIZ-2156:
----------------------------------------

So it's only a matter of color in header, I will take care of it and commit after...

> Removing Login/Logout from AppBarMenu
> -------------------------------------
>
>                 Key: OFBIZ-2156
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2156
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Bruno Busco
>         Attachments: HeaderLogOut.patch
>
>
> please find attached a patch to remove the Login and Logout menu-items from the CommonAppBar menu and to put them into the header.
> This was discussed recently and agreed to have better (drop-down) menus.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco updated OFBIZ-2156:
-------------------------------

    Attachment: HeaderLogOut.patch

Please find attached an hopefully better patch.

> Removing Login/Logout from AppBarMenu
> -------------------------------------
>
>                 Key: OFBIZ-2156
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2156
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Bruno Busco
>         Attachments: HeaderLogOut.patch, HeaderLogOut.patch
>
>
> please find attached a patch to remove the Login and Logout menu-items from the CommonAppBar menu and to put them into the header.
> This was discussed recently and agreed to have better (drop-down) menus.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12669222#action_12669222 ]

Jacques Le Roux commented on OFBIZ-2156:
----------------------------------------

Finally I let it like that for the moment. I'd like to use the same scheme (color, hover, etc.) than in preferences-menu, but then my question : why an id and not a class ?

> Removing Login/Logout from AppBarMenu
> -------------------------------------
>
>                 Key: OFBIZ-2156
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2156
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Bruno Busco
>         Attachments: HeaderLogOut.patch, HeaderLogOut.patch
>
>
> please find attached a patch to remove the Login and Logout menu-items from the CommonAppBar menu and to put them into the header.
> This was discussed recently and agreed to have better (drop-down) menus.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-2156.
----------------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk
         Assignee: Bruno Busco

Thanks Bruno,

Your last patch is in trunk revision: 739595  (I merged with previous commit)

> Removing Login/Logout from AppBarMenu
> -------------------------------------
>
>                 Key: OFBIZ-2156
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2156
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Bruno Busco
>            Assignee: Bruno Busco
>             Fix For: SVN trunk
>
>         Attachments: HeaderLogOut.patch, HeaderLogOut.patch
>
>
> please find attached a patch to remove the Login and Logout menu-items from the CommonAppBar menu and to put them into the header.
> This was discussed recently and agreed to have better (drop-down) menus.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.