[jira] Created: (OFBIZ-2162) Reduce the Redundancy of Java script in inlineProductDetail.ftl in order component

[Nicolas Malin (Jira)]

Reduce the Redundancy of Java script in inlineProductDetail.ftl in order component
----------------------------------------------------------------------------------

                 Key: OFBIZ-2162
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2162
             Project: OFBiz
          Issue Type: Improvement
          Components: order
    Affects Versions: SVN trunk
            Reporter: Arpit Singh Pandya


I checked this patch for the available products in DemoConfigurator.xml (ie for Configurable product PIZZA with virtual product options PEPPERS and SAUCE)

Before applying this patch , there are different js functions created with the same name and parameters more than one time in the Browser for each virtual product, although the last definition of the function is executed, other's are  of no use there.

After applying this patch it will reduce the redundancy of the java script  code in inlineProductDetail.ftl of order component in applications. This changes doesn't affect the behavior  of the  function or not  reduced  any functionality  of the script.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arpit Singh Pandya updated OFBIZ-2162:
--------------------------------------

    Attachment: inlineProductDetail.patch

It will reduce the redundancy of the java script  code in inlineProductDetail.ftl of order component in applications. This changes doesn't affect the behavior  of the  function or not  reduced  any functionality  of the script.

> Reduce the Redundancy of Java script in inlineProductDetail.ftl in order component
> ----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2162
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2162
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Arpit Singh Pandya
>         Attachments: inlineProductDetail.patch
>
>
> I checked this patch for the available products in DemoConfigurator.xml (ie for Configurable product PIZZA with virtual product options PEPPERS and SAUCE)
> Before applying this patch , there are different js functions created with the same name and parameters more than one time in the Browser for each virtual product, although the last definition of the function is executed, other's are  of no use there.
> After applying this patch it will reduce the redundancy of the java script  code in inlineProductDetail.ftl of order component in applications. This changes doesn't affect the behavior  of the  function or not  reduced  any functionality  of the script.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashish Vijaywargiya reassigned OFBIZ-2162:
------------------------------------------

    Assignee: Ashish Vijaywargiya

> Reduce the Redundancy of Java script in inlineProductDetail.ftl in order component
> ----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2162
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2162
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Arpit Singh Pandya
>            Assignee: Ashish Vijaywargiya
>         Attachments: inlineProductDetail.patch
>
>
> I checked this patch for the available products in DemoConfigurator.xml (ie for Configurable product PIZZA with virtual product options PEPPERS and SAUCE)
> Before applying this patch , there are different js functions created with the same name and parameters more than one time in the Browser for each virtual product, although the last definition of the function is executed, other's are  of no use there.
> After applying this patch it will reduce the redundancy of the java script  code in inlineProductDetail.ftl of order component in applications. This changes doesn't affect the behavior  of the  function or not  reduced  any functionality  of the script.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arpit Singh Pandya updated OFBIZ-2162:
--------------------------------------

    Attachment: inlineProductDetail.patch

it will reduce the redundancy of the java script  code in inlineProductDetail.ftl of order component in applications. This changes doesn't affect the behavior  of the  function or not  reduced  any functionality  of the script.

> Reduce the Redundancy of Java script in inlineProductDetail.ftl in order component
> ----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2162
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2162
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Arpit Singh Pandya
>            Assignee: Ashish Vijaywargiya
>         Attachments: inlineProductDetail.patch
>
>
> I checked this patch for the available products in DemoConfigurator.xml (ie for Configurable product PIZZA with virtual product options PEPPERS and SAUCE)
> Before applying this patch , there are different js functions created with the same name and parameters more than one time in the Browser for each virtual product, although the last definition of the function is executed, other's are  of no use there.
> After applying this patch it will reduce the redundancy of the java script  code in inlineProductDetail.ftl of order component in applications. This changes doesn't affect the behavior  of the  function or not  reduced  any functionality  of the script.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arpit Singh Pandya updated OFBIZ-2162:
--------------------------------------

    Attachment:     (was: inlineProductDetail.patch)

> Reduce the Redundancy of Java script in inlineProductDetail.ftl in order component
> ----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2162
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2162
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Arpit Singh Pandya
>            Assignee: Ashish Vijaywargiya
>         Attachments: inlineProductDetail.patch
>
>
> I checked this patch for the available products in DemoConfigurator.xml (ie for Configurable product PIZZA with virtual product options PEPPERS and SAUCE)
> Before applying this patch , there are different js functions created with the same name and parameters more than one time in the Browser for each virtual product, although the last definition of the function is executed, other's are  of no use there.
> After applying this patch it will reduce the redundancy of the java script  code in inlineProductDetail.ftl of order component in applications. This changes doesn't affect the behavior  of the  function or not  reduced  any functionality  of the script.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashish Vijaywargiya closed OFBIZ-2162.
--------------------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk

Thanks Arpit for your contribution.

Your patch is in trunk rev 741537.

--
Ashish

> Reduce the Redundancy of Java script in inlineProductDetail.ftl in order component
> ----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2162
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2162
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Arpit Singh Pandya
>            Assignee: Ashish Vijaywargiya
>             Fix For: SVN trunk
>
>         Attachments: inlineProductDetail.patch
>
>
> I checked this patch for the available products in DemoConfigurator.xml (ie for Configurable product PIZZA with virtual product options PEPPERS and SAUCE)
> Before applying this patch , there are different js functions created with the same name and parameters more than one time in the Browser for each virtual product, although the last definition of the function is executed, other's are  of no use there.
> After applying this patch it will reduce the redundancy of the java script  code in inlineProductDetail.ftl of order component in applications. This changes doesn't affect the behavior  of the  function or not  reduced  any functionality  of the script.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.