[jira] Created: (OFBIZ-2163) Packing issues: weights and remaining items
Locked
[jira] Created: (OFBIZ-2163) Packing issues: weights and remaining items
 
|
Packing issues: weights and remaining items
------------------------------------------- Key: OFBIZ-2163 URL: https://issues.apache.org/jira/browse/OFBIZ-2163 Project: OFBiz Issue Type: Bug Components: product Affects Versions: SVN trunk Environment: any Reporter: Karim Rahimpur Fix For: SVN trunk - package line weights are not cleared when lines are cleared, in: PackingSession.clearLine(...) PackingSession.clearAllLines(...) PackingSession.clear() - remaining number of items is not calculated correctly in PackOrder.ftl: inputQty Example: If the quantity of an order item is shipped in two ship groups and the first is packed, the second cannot be packed correctly because the remaining quantity is wrong. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-2163) Packing issues: weights and remaining items
|
|
[ https://issues.apache.org/jira/browse/OFBIZ-2163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karim Rahimpur updated OFBIZ-2163: ---------------------------------- Attachment: Packing.patch This patch *fixes these bugs*: - package line weights are not cleared when lines are cleared, fixed in: PackingSession.clearLine(...) PackingSession.clearAllLines(...) PackingSession.clear() - remaining number of items is not calculated correctly in PackOrder.ftl, fixed: inputQty is assign remaining quantity less packed quantity _*Improvements*_ The *patch adds/enables these functions*: - one may pack multiple packages of same characteristics - one may set the packed weight when adding a line PackingServices.packBulk(...) - list packages and packed items in order added PackingServices.getPackingSessionLinesByPackage() Files affected: applications/product/servicedef/services_shipment.xml applications/product/webapp/facility/shipment/PackOrder.ftl applications/product/src/org/ofbiz/shipment/packing/PackingServices.java applications/product/src/org/ofbiz/shipment/packing/PackingSession.java If these improvements are welcome (please try) then it would be a nice addition to the packing screen. We have a case where the need to pack multiple packages of the same kind (e.g. hundreds of them) at the same time is an absolute must, so that's where these functions come in handy. Also the list of packages with currently packed items, ordered by package sequence id and listing the items is provided in addition to the former plain list of items which goes below. > Packing issues: weights and remaining items > ------------------------------------------- > > Key: OFBIZ-2163 > URL: https://issues.apache.org/jira/browse/OFBIZ-2163 > Project: OFBiz > Issue Type: Bug > Components: product > Affects Versions: SVN trunk > Environment: any > Reporter: Karim Rahimpur > Fix For: SVN trunk > > Attachments: Packing.patch > > > - package line weights are not cleared when lines are cleared, in: > PackingSession.clearLine(...) > PackingSession.clearAllLines(...) > PackingSession.clear() > - remaining number of items is not calculated correctly in PackOrder.ftl: > inputQty > Example: If the quantity of an order item is shipped in two ship groups and the first is packed, the second cannot be packed correctly because the remaining quantity is wrong. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Assigned: (OFBIZ-2163) Packing issues: weights and remaining items
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-2163: -------------------------------------- Assignee: Jacques Le Roux > Packing issues: weights and remaining items > ------------------------------------------- > > Key: OFBIZ-2163 > URL: https://issues.apache.org/jira/browse/OFBIZ-2163 > Project: OFBiz > Issue Type: Bug > Components: product > Affects Versions: SVN trunk > Environment: any > Reporter: Karim Rahimpur > Assignee: Jacques Le Roux > Fix For: SVN trunk > > Attachments: Packing.patch > > > - package line weights are not cleared when lines are cleared, in: > PackingSession.clearLine(...) > PackingSession.clearAllLines(...) > PackingSession.clear() > - remaining number of items is not calculated correctly in PackOrder.ftl: > inputQty > Example: If the quantity of an order item is shipped in two ship groups and the first is packed, the second cannot be packed correctly because the remaining quantity is wrong. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-2163) Packing issues: weights and remaining items
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12673742#action_12673742 ] Jacques Le Roux commented on OFBIZ-2163: ---------------------------------------- Karim, I began to review your patch. Why did you remove shippedQuantity from inputQty calculation (BTW beware of formatting issues, there is one on this line) ? I wil continue later : ran out of time... Thanks > Packing issues: weights and remaining items > ------------------------------------------- > > Key: OFBIZ-2163 > URL: https://issues.apache.org/jira/browse/OFBIZ-2163 > Project: OFBiz > Issue Type: Bug > Components: product > Affects Versions: SVN trunk > Environment: any > Reporter: Karim Rahimpur > Assignee: Jacques Le Roux > Fix For: SVN trunk > > Attachments: Packing.patch > > > - package line weights are not cleared when lines are cleared, in: > PackingSession.clearLine(...) > PackingSession.clearAllLines(...) > PackingSession.clear() > - remaining number of items is not calculated correctly in PackOrder.ftl: > inputQty > Example: If the quantity of an order item is shipped in two ship groups and the first is packed, the second cannot be packed correctly because the remaining quantity is wrong. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-2163) Packing issues: weights and remaining items
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12673902#action_12673902 ] Jacques Le Roux commented on OFBIZ-2163: ---------------------------------------- Karim, Some comments : . Please in FTL use 2 spces indentation even if before some persons have not respected this rule (it's far easier when checking for end of blocks) . It works well but I don't understand how the 1st "Next package" button is working (does not seem related to your work though) . I did not understand why you used Hashtable in PackingSession.java (but also FastMap which we prefer) I have upload an updated paches with some trivial fixes. I will commit as soon as you will explain me why you removed shippedQuantity from inputQty calculation Thanks > Packing issues: weights and remaining items > ------------------------------------------- > > Key: OFBIZ-2163 > URL: https://issues.apache.org/jira/browse/OFBIZ-2163 > Project: OFBiz > Issue Type: Bug > Components: product > Affects Versions: SVN trunk > Environment: any > Reporter: Karim Rahimpur > Assignee: Jacques Le Roux > Fix For: SVN trunk > > Attachments: Packing.patch > > > - package line weights are not cleared when lines are cleared, in: > PackingSession.clearLine(...) > PackingSession.clearAllLines(...) > PackingSession.clear() > - remaining number of items is not calculated correctly in PackOrder.ftl: > inputQty > Example: If the quantity of an order item is shipped in two ship groups and the first is packed, the second cannot be packed correctly because the remaining quantity is wrong. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-2163) Packing issues: weights and remaining items
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-2163: ----------------------------------- Attachment: Packing.patch > Packing issues: weights and remaining items > ------------------------------------------- > > Key: OFBIZ-2163 > URL: https://issues.apache.org/jira/browse/OFBIZ-2163 > Project: OFBiz > Issue Type: Bug > Components: product > Affects Versions: SVN trunk > Environment: any > Reporter: Karim Rahimpur > Assignee: Jacques Le Roux > Fix For: SVN trunk > > Attachments: Packing.patch, Packing.patch > > > - package line weights are not cleared when lines are cleared, in: > PackingSession.clearLine(...) > PackingSession.clearAllLines(...) > PackingSession.clear() > - remaining number of items is not calculated correctly in PackOrder.ftl: > inputQty > Example: If the quantity of an order item is shipped in two ship groups and the first is packed, the second cannot be packed correctly because the remaining quantity is wrong. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-2163) Packing issues: weights and remaining items
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-2163: ----------------------------------- Attachment: Packing.patch Seems that I have messed up PackOrder.ftl in a pathetic try to resolve the problem using spaces -> tabs and then tab -> spaces(2). This patch is ok > Packing issues: weights and remaining items > ------------------------------------------- > > Key: OFBIZ-2163 > URL: https://issues.apache.org/jira/browse/OFBIZ-2163 > Project: OFBiz > Issue Type: Bug > Components: product > Affects Versions: SVN trunk > Environment: any > Reporter: Karim Rahimpur > Assignee: Jacques Le Roux > Fix For: SVN trunk > > Attachments: Packing.patch, Packing.patch, Packing.patch > > > - package line weights are not cleared when lines are cleared, in: > PackingSession.clearLine(...) > PackingSession.clearAllLines(...) > PackingSession.clear() > - remaining number of items is not calculated correctly in PackOrder.ftl: > inputQty > Example: If the quantity of an order item is shipped in two ship groups and the first is packed, the second cannot be packed correctly because the remaining quantity is wrong. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-2163) Packing issues: weights and remaining items
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12675009#action_12675009 ] Karim Rahimpur commented on OFBIZ-2163: --------------------------------------- Hi Jacques, Thanks for looking into this, about your questions: - shippedQuantity was removed because it's already taken into account when it comes to use (the quantity is taken from itemInfo which relies on OrderItemAndShipGrpInvResAndItemSum and not OrderItem) - as far as i know, the Next package button (yes it was already there) just skips to the next package number - FastMap can be used instead of Hashtable, although I don't see a big profit here > Packing issues: weights and remaining items > ------------------------------------------- > > Key: OFBIZ-2163 > URL: https://issues.apache.org/jira/browse/OFBIZ-2163 > Project: OFBiz > Issue Type: Bug > Components: product > Affects Versions: SVN trunk > Environment: any > Reporter: Karim Rahimpur > Assignee: Jacques Le Roux > Fix For: SVN trunk > > Attachments: Packing.patch, Packing.patch, Packing.patch > > > - package line weights are not cleared when lines are cleared, in: > PackingSession.clearLine(...) > PackingSession.clearAllLines(...) > PackingSession.clear() > - remaining number of items is not calculated correctly in PackOrder.ftl: > inputQty > Example: If the quantity of an order item is shipped in two ship groups and the first is packed, the second cannot be packed correctly because the remaining quantity is wrong. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Closed: (OFBIZ-2163) Packing issues: weights and remaining items
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-2163. ---------------------------------- Resolution: Fixed Thanks Karim, * Right, defintively not easy to track back * the Next package button does not seem to be useful actually, I wonder if we should not get rid of it; but I'm maybe missing something... * FastMap : yes, just because we prefer to use it everywhere as a replacement of Hastable Your slightly modified patch is in trunk at revision: 745931 > Packing issues: weights and remaining items > ------------------------------------------- > > Key: OFBIZ-2163 > URL: https://issues.apache.org/jira/browse/OFBIZ-2163 > Project: OFBiz > Issue Type: Bug > Components: product > Affects Versions: SVN trunk > Environment: any > Reporter: Karim Rahimpur > Assignee: Jacques Le Roux > Fix For: SVN trunk > > Attachments: Packing.patch, Packing.patch, Packing.patch > > > - package line weights are not cleared when lines are cleared, in: > PackingSession.clearLine(...) > PackingSession.clearAllLines(...) > PackingSession.clear() > - remaining number of items is not calculated correctly in PackOrder.ftl: > inputQty > Example: If the quantity of an order item is shipped in two ship groups and the first is packed, the second cannot be packed correctly because the remaining quantity is wrong. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |