[jira] Created: (OFBIZ-2219) Special feature to allow submitting patches for online help update

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12758977#action_12758977 ]

Hans Bakker commented on OFBIZ-2219:
------------------------------------

Hi Sharan,

you contribution OFBIZ-2219_DocbookAccountingHelp5.patch is Committed in revision 818348.

Could you please have a look at you editor settings?
4 spaces for a tab should be the setting so the file should not contain tabs.
In this contribution i have corrected this for you.

Regards,
Hans

> Special feature to allow submitting patches for online help update
> ------------------------------------------------------------------
>
>                 Key: OFBIZ-2219
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2219
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Hans Bakker
>            Priority: Minor
>         Attachments: OFBIZ-2219_DocbookAccountingHelp5.patch
>
>
> *This issue should not be closed, at least until the online help is not completed...*
> in OFBIZ-2133, Bruno Busco has used Sharan's work in wiki as an help from OFBiz OOTB. You can find links in AccountingHelpUrls.xml. I have asked Sharan if she could update this links, while she is improving documentation, and she agreed. So this issue is to allow her, and anybody else, to submit patches to improve the online help (not only accounting of course hence the ALL COMPONENTS)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12759002#action_12759002 ]

Jacques Le Roux commented on OFBIZ-2219:
----------------------------------------

Hi Sharan,

This may help

http://docs.ofbiz.org/display/OFBADMIN/Coding+Conventions

> Special feature to allow submitting patches for online help update
> ------------------------------------------------------------------
>
>                 Key: OFBIZ-2219
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2219
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Hans Bakker
>            Priority: Minor
>         Attachments: OFBIZ-2219_DocbookAccountingHelp5.patch
>
>
> *This issue should not be closed, at least until the online help is not completed...*
> in OFBIZ-2133, Bruno Busco has used Sharan's work in wiki as an help from OFBiz OOTB. You can find links in AccountingHelpUrls.xml. I have asked Sharan if she could update this links, while she is improving documentation, and she agreed. So this issue is to allow her, and anybody else, to submit patches to improve the online help (not only accounting of course hence the ALL COMPONENTS)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12759038#action_12759038 ]

Sharan Foga commented on OFBIZ-2219:
------------------------------------

Thanks Hans for sorting out the tabs.

Un Grand Merci - Jacques. You've saved me a long search through Eclipse to find these settings! I've updated my Eclipse now so hopefully no more tabs.

> Special feature to allow submitting patches for online help update
> ------------------------------------------------------------------
>
>                 Key: OFBIZ-2219
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2219
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Hans Bakker
>            Priority: Minor
>         Attachments: OFBIZ-2219_DocbookAccountingHelp5.patch
>
>
> *This issue should not be closed, at least until the online help is not completed...*
> in OFBIZ-2133, Bruno Busco has used Sharan's work in wiki as an help from OFBiz OOTB. You can find links in AccountingHelpUrls.xml. I have asked Sharan if she could update this links, while she is improving documentation, and she agreed. So this issue is to allow her, and anybody else, to submit patches to improve the online help (not only accounting of course hence the ALL COMPONENTS)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sharan Foga updated OFBIZ-2219:
-------------------------------

    Attachment:     (was: OFBIZ-2219_DocbookAccountingHelp5.patch)

> Special feature to allow submitting patches for online help update
> ------------------------------------------------------------------
>
>                 Key: OFBIZ-2219
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2219
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Hans Bakker
>            Priority: Minor
>
> *This issue should not be closed, at least until the online help is not completed...*
> in OFBIZ-2133, Bruno Busco has used Sharan's work in wiki as an help from OFBiz OOTB. You can find links in AccountingHelpUrls.xml. I have asked Sharan if she could update this links, while she is improving documentation, and she agreed. So this issue is to allow her, and anybody else, to submit patches to improve the online help (not only accounting of course hence the ALL COMPONENTS)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sharan Foga updated OFBIZ-2219:
-------------------------------

    Attachment: OFBIZ-2219_DocbookAccountingHelp6.patch

Hi Hans

See attached for OFBIZ-2219_DocbookAccountingHelp6.patch. This one is for the Financial Accounts tab. It's not totally complete because I'm still working on understanding the new functionality added around bank account deposits - (so will follow up with Anil about that) - but I've created the template xml files for each of the screens anyway and have copied over the existing info from the OFBENDUSER space.

For the bank account listing portlet - I had to add the mapkey parameter for it to work.

I've updated my Eclipse (Gallileo) so hopefully you wont find any tabs in any of the files - but if you do then let me know.

Thanks
Sharan

> Special feature to allow submitting patches for online help update
> ------------------------------------------------------------------
>
>                 Key: OFBIZ-2219
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2219
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Hans Bakker
>            Priority: Minor
>         Attachments: OFBIZ-2219_DocbookAccountingHelp6.patch
>
>
> *This issue should not be closed, at least until the online help is not completed...*
> in OFBIZ-2133, Bruno Busco has used Sharan's work in wiki as an help from OFBiz OOTB. You can find links in AccountingHelpUrls.xml. I have asked Sharan if she could update this links, while she is improving documentation, and she agreed. So this issue is to allow her, and anybody else, to submit patches to improve the online help (not only accounting of course hence the ALL COMPONENTS)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sharan Foga updated OFBIZ-2219:
-------------------------------

    Attachment:     (was: OFBIZ-2219_DocbookAccountingHelp6.patch)

> Special feature to allow submitting patches for online help update
> ------------------------------------------------------------------
>
>                 Key: OFBIZ-2219
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2219
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Hans Bakker
>            Priority: Minor
>
> *This issue should not be closed, at least until the online help is not completed...*
> in OFBIZ-2133, Bruno Busco has used Sharan's work in wiki as an help from OFBiz OOTB. You can find links in AccountingHelpUrls.xml. I have asked Sharan if she could update this links, while she is improving documentation, and she agreed. So this issue is to allow her, and anybody else, to submit patches to improve the online help (not only accounting of course hence the ALL COMPONENTS)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sharan Foga updated OFBIZ-2219:
-------------------------------

    Attachment: OFBIZ-2219_DocbookHRHelp1.patch

Hi Hans

This is a patch to fix the problems Jacques had with commit r826406 on the Human Resources help. I've got rid of the formatting and focussed on the content. I also did a svn rename but it still looks like it deleted then added the files.

I've done a full test it so it works for the online help index and also the docbook html file also works for viewing. I've gpt another patch ready for accounts but will wait for this one to be committed first.

Thanks
Sharan

> Special feature to allow submitting patches for online help update
> ------------------------------------------------------------------
>
>                 Key: OFBIZ-2219
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2219
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Hans Bakker
>            Priority: Minor
>         Attachments: OFBIZ-2219_DocbookHRHelp1.patch
>
>
> *This issue should not be closed, at least until the online help is not completed...*
> in OFBIZ-2133, Bruno Busco has used Sharan's work in wiki as an help from OFBiz OOTB. You can find links in AccountingHelpUrls.xml. I have asked Sharan if she could update this links, while she is improving documentation, and she agreed. So this issue is to allow her, and anybody else, to submit patches to improve the online help (not only accounting of course hence the ALL COMPONENTS)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12767238#action_12767238 ]

Jacques Le Roux commented on OFBIZ-2219:
----------------------------------------

Thanks Sharan,

So we can't use itemizedlist and orderedlist ? Are we only allowed to use para? Has anybody an idea why ? Should we not extend it ? Can we use image tags and other kinds ?

Actually a better question would be : what tags are we allowed to use ? Shoud we not extend them ?

> Special feature to allow submitting patches for online help update
> ------------------------------------------------------------------
>
>                 Key: OFBIZ-2219
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2219
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Hans Bakker
>            Priority: Minor
>         Attachments: OFBIZ-2219_DocbookHRHelp1.patch
>
>
> *This issue should not be closed, at least until the online help is not completed...*
> in OFBIZ-2133, Bruno Busco has used Sharan's work in wiki as an help from OFBiz OOTB. You can find links in AccountingHelpUrls.xml. I have asked Sharan if she could update this links, while she is improving documentation, and she agreed. So this issue is to allow her, and anybody else, to submit patches to improve the online help (not only accounting of course hence the ALL COMPONENTS)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12767244#action_12767244 ]

Hans Bakker commented on OFBIZ-2219:
------------------------------------

Hi Jacques,

why not simply copy an existing help file and change it?

If you want to use all tags from docbook, we need to use the xsl which will make the help pretty slow...

if you like to support more tags you are welcome to extend the help template in the  HelpTemplate.ftl file. ( i just cleaned it up)

Regards,
Hans

> Special feature to allow submitting patches for online help update
> ------------------------------------------------------------------
>
>                 Key: OFBIZ-2219
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2219
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Hans Bakker
>            Priority: Minor
>         Attachments: OFBIZ-2219_DocbookHRHelp1.patch
>
>
> *This issue should not be closed, at least until the online help is not completed...*
> in OFBIZ-2133, Bruno Busco has used Sharan's work in wiki as an help from OFBiz OOTB. You can find links in AccountingHelpUrls.xml. I have asked Sharan if she could update this links, while she is improving documentation, and she agreed. So this issue is to allow her, and anybody else, to submit patches to improve the online help (not only accounting of course hence the ALL COMPONENTS)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12767246#action_12767246 ]

Hans Bakker commented on OFBIZ-2219:
------------------------------------

Hi Sharan,

i try to commit your patch but have a problem: you are updating file applications/humanres/data/helpdata/HELP_HR.xml which i do not have.....

Regards,
Hans

> Special feature to allow submitting patches for online help update
> ------------------------------------------------------------------
>
>                 Key: OFBIZ-2219
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2219
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Hans Bakker
>            Priority: Minor
>         Attachments: OFBIZ-2219_DocbookHRHelp1.patch
>
>
> *This issue should not be closed, at least until the online help is not completed...*
> in OFBIZ-2133, Bruno Busco has used Sharan's work in wiki as an help from OFBiz OOTB. You can find links in AccountingHelpUrls.xml. I have asked Sharan if she could update this links, while she is improving documentation, and she agreed. So this issue is to allow her, and anybody else, to submit patches to improve the online help (not only accounting of course hence the ALL COMPONENTS)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12767253#action_12767253 ]

Jacques Le Roux commented on OFBIZ-2219:
----------------------------------------

Thanks Hans,

I see, thanks for comment. I will try that one day or another...

> Special feature to allow submitting patches for online help update
> ------------------------------------------------------------------
>
>                 Key: OFBIZ-2219
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2219
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Hans Bakker
>            Priority: Minor
>         Attachments: OFBIZ-2219_DocbookHRHelp1.patch
>
>
> *This issue should not be closed, at least until the online help is not completed...*
> in OFBIZ-2133, Bruno Busco has used Sharan's work in wiki as an help from OFBiz OOTB. You can find links in AccountingHelpUrls.xml. I have asked Sharan if she could update this links, while she is improving documentation, and she agreed. So this issue is to allow her, and anybody else, to submit patches to improve the online help (not only accounting of course hence the ALL COMPONENTS)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sharan Foga updated OFBIZ-2219:
-------------------------------

    Attachment:     (was: OFBIZ-2219_DocbookHRHelp1.patch)

> Special feature to allow submitting patches for online help update
> ------------------------------------------------------------------
>
>                 Key: OFBIZ-2219
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2219
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Hans Bakker
>            Priority: Minor
>
> *This issue should not be closed, at least until the online help is not completed...*
> in OFBIZ-2133, Bruno Busco has used Sharan's work in wiki as an help from OFBiz OOTB. You can find links in AccountingHelpUrls.xml. I have asked Sharan if she could update this links, while she is improving documentation, and she agreed. So this issue is to allow her, and anybody else, to submit patches to improve the online help (not only accounting of course hence the ALL COMPONENTS)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sharan Foga updated OFBIZ-2219:
-------------------------------

    Attachment: OFBIZ-2219_DocbookAccountingHelp7.patch

Hi Hans

This is the latest patch for accounting. This one is mainly for 'Tax Authorities' and I've added some more info on the Financial Accounts. I'll have another go at the HR patch for Jacques next.

Thanks
Sharan

> Special feature to allow submitting patches for online help update
> ------------------------------------------------------------------
>
>                 Key: OFBIZ-2219
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2219
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Hans Bakker
>            Priority: Minor
>         Attachments: OFBIZ-2219_DocbookAccountingHelp7.patch
>
>
> *This issue should not be closed, at least until the online help is not completed...*
> in OFBIZ-2133, Bruno Busco has used Sharan's work in wiki as an help from OFBiz OOTB. You can find links in AccountingHelpUrls.xml. I have asked Sharan if she could update this links, while she is improving documentation, and she agreed. So this issue is to allow her, and anybody else, to submit patches to improve the online help (not only accounting of course hence the ALL COMPONENTS)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12768069#action_12768069 ]

Hans Bakker commented on OFBIZ-2219:
------------------------------------

Hi Sharan,

it looks like the HELP_ACCOUNTING_tax_authorities.xml file is missing in this patch: OFBIZ-2219_DocbookAccountingHelp7.patch

regards,
Hans

> Special feature to allow submitting patches for online help update
> ------------------------------------------------------------------
>
>                 Key: OFBIZ-2219
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2219
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Hans Bakker
>            Priority: Minor
>         Attachments: OFBIZ-2219_DocbookAccountingHelp7.patch
>
>
> *This issue should not be closed, at least until the online help is not completed...*
> in OFBIZ-2133, Bruno Busco has used Sharan's work in wiki as an help from OFBiz OOTB. You can find links in AccountingHelpUrls.xml. I have asked Sharan if she could update this links, while she is improving documentation, and she agreed. So this issue is to allow her, and anybody else, to submit patches to improve the online help (not only accounting of course hence the ALL COMPONENTS)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12768143#action_12768143 ]

Sharan Foga commented on OFBIZ-2219:
------------------------------------

Hi Hans

I took another look at the patch7 and found the HELP_ACCOUNTING_tax_authorities.xml file in there (its after  HELP_ACCOUNTING_EditTaxAuthority.xml file and before HELP_ACCOUNTING_ListTaxAuthorityParties.xm file). The only other thing I can think of is if I made a typing mistake and spelled it wrongly somewhere....

I going to be offline for a few days so will take a look at again hopefully early next week.

Thanks
Sharan
 

> Special feature to allow submitting patches for online help update
> ------------------------------------------------------------------
>
>                 Key: OFBIZ-2219
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2219
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Hans Bakker
>            Priority: Minor
>         Attachments: OFBIZ-2219_DocbookAccountingHelp7.patch
>
>
> *This issue should not be closed, at least until the online help is not completed...*
> in OFBIZ-2133, Bruno Busco has used Sharan's work in wiki as an help from OFBiz OOTB. You can find links in AccountingHelpUrls.xml. I have asked Sharan if she could update this links, while she is improving documentation, and she agreed. So this issue is to allow her, and anybody else, to submit patches to improve the online help (not only accounting of course hence the ALL COMPONENTS)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12768156#action_12768156 ]

Hans Bakker commented on OFBIZ-2219:
------------------------------------

Hi Sharan,

your patch:   OFBIZ-2219_DocbookAccountingHelp7.patch is committed in revision 827946. i corrected two errors in references.

Thank you for the contribution.

Regards,
Hans

> Special feature to allow submitting patches for online help update
> ------------------------------------------------------------------
>
>                 Key: OFBIZ-2219
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2219
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Hans Bakker
>            Priority: Minor
>         Attachments: OFBIZ-2219_DocbookAccountingHelp7.patch
>
>
> *This issue should not be closed, at least until the online help is not completed...*
> in OFBIZ-2133, Bruno Busco has used Sharan's work in wiki as an help from OFBiz OOTB. You can find links in AccountingHelpUrls.xml. I have asked Sharan if she could update this links, while she is improving documentation, and she agreed. So this issue is to allow her, and anybody else, to submit patches to improve the online help (not only accounting of course hence the ALL COMPONENTS)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sharan Foga updated OFBIZ-2219:
-------------------------------

    Attachment:     (was: OFBIZ-2219_DocbookAccountingHelp7.patch)

> Special feature to allow submitting patches for online help update
> ------------------------------------------------------------------
>
>                 Key: OFBIZ-2219
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2219
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Hans Bakker
>            Priority: Minor
>
> *This issue should not be closed, at least until the online help is not completed...*
> in OFBIZ-2133, Bruno Busco has used Sharan's work in wiki as an help from OFBiz OOTB. You can find links in AccountingHelpUrls.xml. I have asked Sharan if she could update this links, while she is improving documentation, and she agreed. So this issue is to allow her, and anybody else, to submit patches to improve the online help (not only accounting of course hence the ALL COMPONENTS)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sharan Foga updated OFBIZ-2219:
-------------------------------

    Attachment: OFBIZ-2219_DocbookHRHelp1.patch

Hi Hans

This is my second try at doing the HR Help fix for Jacques. I've used the svn rename command to rename 3 files as follows:

HELP_HUMANRES_main.xml becomes HELP_HR_main.xml
HELP_HUMANRES.xml becomes HELP_HR.xml
HELP_HUMANRES_training.xml becomes HELP_HR_training.xml

So if there is problem with this patch then if someone can just rename these 3 files then I can easily fix the rest (it's just rename that seems to be giving me the problems!).

I've also added the HR application (as it was missing) as a chapter in the ApacheOfbizUser.xml file and also changed the HR ofbiz-component.xml file so that it loads the HR Help data as part of the 'seed' data.

Anyway - try it and let me know if it works this time.

Thanks
Sharan

> Special feature to allow submitting patches for online help update
> ------------------------------------------------------------------
>
>                 Key: OFBIZ-2219
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2219
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Hans Bakker
>            Priority: Minor
>         Attachments: OFBIZ-2219_DocbookHRHelp1.patch
>
>
> *This issue should not be closed, at least until the online help is not completed...*
> in OFBIZ-2133, Bruno Busco has used Sharan's work in wiki as an help from OFBiz OOTB. You can find links in AccountingHelpUrls.xml. I have asked Sharan if she could update this links, while she is improving documentation, and she agreed. So this issue is to allow her, and anybody else, to submit patches to improve the online help (not only accounting of course hence the ALL COMPONENTS)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12775264#action_12775264 ]

Hans Bakker commented on OFBIZ-2219:
------------------------------------

Hi Sharan,

always check the patch file itself before uploading.
The patch deletes the content of HELP_HUMANRES_main.xml but does not create/add HELP_HR_main.xml
Not sure if a rename can be included in a patch file.

anyway i corrected it  OFBIZ-2219_DocbookHRHelp1.patch Committed revision 834326.

Regards,
Hans

> Special feature to allow submitting patches for online help update
> ------------------------------------------------------------------
>
>                 Key: OFBIZ-2219
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2219
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Hans Bakker
>            Priority: Minor
>         Attachments: OFBIZ-2219_DocbookHRHelp1.patch
>
>
> *This issue should not be closed, at least until the online help is not completed...*
> in OFBIZ-2133, Bruno Busco has used Sharan's work in wiki as an help from OFBiz OOTB. You can find links in AccountingHelpUrls.xml. I have asked Sharan if she could update this links, while she is improving documentation, and she agreed. So this issue is to allow her, and anybody else, to submit patches to improve the online help (not only accounting of course hence the ALL COMPONENTS)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sharan Foga updated OFBIZ-2219:
-------------------------------

    Attachment:     (was: OFBIZ-2219_DocbookHRHelp1.patch)

> Special feature to allow submitting patches for online help update
> ------------------------------------------------------------------
>
>                 Key: OFBIZ-2219
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2219
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Hans Bakker
>            Priority: Minor
>
> *This issue should not be closed, at least until the online help is not completed...*
> in OFBIZ-2133, Bruno Busco has used Sharan's work in wiki as an help from OFBiz OOTB. You can find links in AccountingHelpUrls.xml. I have asked Sharan if she could update this links, while she is improving documentation, and she agreed. So this issue is to allow her, and anybody else, to submit patches to improve the online help (not only accounting of course hence the ALL COMPONENTS)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.