[jira] Created: (OFBIZ-2234) When recording PO, Company automatically sets price as "last price" on Supplier record

[Nicolas Malin (Jira)]

When recording PO, Company automatically sets price as "last price" on Supplier record
--------------------------------------------------------------------------------------

                 Key: OFBIZ-2234
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2234
             Project: OFBiz
          Issue Type: Sub-task
          Components: order
    Affects Versions: SVN trunk
            Reporter: Deepesh Kapoor
            Priority: Minor
             Fix For: SVN trunk


Modifying the existing system such that when the unit price of the item is edited the new value automatically gets set as last price on supplier record.

Implementation Notes :
Add service to expire (set availableThruDate) current applicable SupplierProduct record, create new record that clones the old record, current date as available from date
SECA trigger on create,purchase and receive order.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bharat Soni updated OFBIZ-2234:
-------------------------------

    Attachment: ofbiz-2234.patch

To test this patch follow these steps:
1 .Create PO with supplier ID(for e.g. BigSupplier), add products to cart than change their unit price and recalculate the order. Here check whether the total reflects the unit price changes.
2.  When the same supplier is selected and same product is added to cart than the changes done in unit price of previous PO  should reflect here as well.
3. The same behavior  should be observed while Editing the PO and changing the unit price there.
4. When the Inventory is received for the same purchase order, and if we change the unit price here than it should reflect when the next order will be created with the same supplier and product information.

> When recording PO, Company automatically sets price as "last price" on Supplier record
> --------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2234
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2234
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Deepesh Kapoor
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: ofbiz-2234.patch
>
>
> Modifying the existing system such that when the unit price of the item is edited the new value automatically gets set as last price on supplier record.
> Implementation Notes :
> Add service to expire (set availableThruDate) current applicable SupplierProduct record, create new record that clones the old record, current date as available from date
> SECA trigger on create,purchase and receive order.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12681372#action_12681372 ]

Pranay Pandey commented on OFBIZ-2234:
--------------------------------------

Uploaded patch needs to be reworked for more precise code.

> When recording PO, Company automatically sets price as "last price" on Supplier record
> --------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2234
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2234
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Deepesh Kapoor
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: ofbiz-2234.patch
>
>
> Modifying the existing system such that when the unit price of the item is edited the new value automatically gets set as last price on supplier record.
> Implementation Notes :
> Add service to expire (set availableThruDate) current applicable SupplierProduct record, create new record that clones the old record, current date as available from date
> SECA trigger on create,purchase and receive order.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bharat Soni updated OFBIZ-2234:
-------------------------------

    Attachment: OFBIZ-2234.patch

Removed unnecessary  code and made it more precise.

> When recording PO, Company automatically sets price as "last price" on Supplier record
> --------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2234
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2234
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Deepesh Kapoor
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2234.patch, ofbiz-2234.patch
>
>
> Modifying the existing system such that when the unit price of the item is edited the new value automatically gets set as last price on supplier record.
> Implementation Notes :
> Add service to expire (set availableThruDate) current applicable SupplierProduct record, create new record that clones the old record, current date as available from date
> SECA trigger on create,purchase and receive order.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bharat Soni updated OFBIZ-2234:
-------------------------------

    Attachment:     (was: OFBIZ-2234.patch)

> When recording PO, Company automatically sets price as "last price" on Supplier record
> --------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2234
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2234
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Deepesh Kapoor
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: ofbiz-2234.patch
>
>
> Modifying the existing system such that when the unit price of the item is edited the new value automatically gets set as last price on supplier record.
> Implementation Notes :
> Add service to expire (set availableThruDate) current applicable SupplierProduct record, create new record that clones the old record, current date as available from date
> SECA trigger on create,purchase and receive order.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bharat Soni updated OFBIZ-2234:
-------------------------------

    Attachment: ofbiz-2234.patch

> When recording PO, Company automatically sets price as "last price" on Supplier record
> --------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2234
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2234
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Deepesh Kapoor
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: ofbiz-2234.patch, ofbiz-2234.patch
>
>
> Modifying the existing system such that when the unit price of the item is edited the new value automatically gets set as last price on supplier record.
> Implementation Notes :
> Add service to expire (set availableThruDate) current applicable SupplierProduct record, create new record that clones the old record, current date as available from date
> SECA trigger on create,purchase and receive order.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12681706#action_12681706 ]

Pranay Pandey commented on OFBIZ-2234:
--------------------------------------

Thanks Bharat for providing updated patch.
Now code looks good.

I tested the patch against three conditions and service triggered and worked well for cloning up supplier product record with updated unit price (Last price):

# On creation of purchase order If I change the unit price on cart page and recalculate cart, and proceed with order its serving the purpose of cloning the record.
# On edit Items for a purchase order with updated unit price.
# On receiving inventory against a purchase order with updated unit price.

But there are few database warnings(Database type warning GenericEntity.set) on console when I do receive inventory and create purchase order by changing Unit price of the product, this is not the case when I edit Purchase order Items.

Please Resolve these errors and upload the updated patch.

> When recording PO, Company automatically sets price as "last price" on Supplier record
> --------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2234
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2234
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Deepesh Kapoor
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: ofbiz-2234.patch, ofbiz-2234.patch
>
>
> Modifying the existing system such that when the unit price of the item is edited the new value automatically gets set as last price on supplier record.
> Implementation Notes :
> Add service to expire (set availableThruDate) current applicable SupplierProduct record, create new record that clones the old record, current date as available from date
> SECA trigger on create,purchase and receive order.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bharat Soni updated OFBIZ-2234:
-------------------------------

    Attachment: ofbiz-2234.patch

Thank you pranay for review my patch here is updated patch.

> When recording PO, Company automatically sets price as "last price" on Supplier record
> --------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2234
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2234
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Deepesh Kapoor
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: ofbiz-2234.patch, ofbiz-2234.patch, ofbiz-2234.patch
>
>
> Modifying the existing system such that when the unit price of the item is edited the new value automatically gets set as last price on supplier record.
> Implementation Notes :
> Add service to expire (set availableThruDate) current applicable SupplierProduct record, create new record that clones the old record, current date as available from date
> SECA trigger on create,purchase and receive order.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12681723#action_12681723 ]

Pranay Pandey commented on OFBIZ-2234:
--------------------------------------

Thanks Bharat, Now no errors. I tested It successfully for all 3 scenarios.

Now I think one of the committer can pick this patch.

> When recording PO, Company automatically sets price as "last price" on Supplier record
> --------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2234
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2234
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Deepesh Kapoor
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: ofbiz-2234.patch, ofbiz-2234.patch, ofbiz-2234.patch
>
>
> Modifying the existing system such that when the unit price of the item is edited the new value automatically gets set as last price on supplier record.
> Implementation Notes :
> Add service to expire (set availableThruDate) current applicable SupplierProduct record, create new record that clones the old record, current date as available from date
> SECA trigger on create,purchase and receive order.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reassigned OFBIZ-2234:
--------------------------------------

    Assignee: Jacques Le Roux

> When recording PO, Company automatically sets price as "last price" on Supplier record
> --------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2234
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2234
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Deepesh Kapoor
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: ofbiz-2234.patch, ofbiz-2234.patch, ofbiz-2234.patch
>
>
> Modifying the existing system such that when the unit price of the item is edited the new value automatically gets set as last price on supplier record.
> Implementation Notes :
> Add service to expire (set availableThruDate) current applicable SupplierProduct record, create new record that clones the old record, current date as available from date
> SECA trigger on create,purchase and receive order.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-2234.
----------------------------------

    Resolution: Fixed

Thanks guys,

Bharat your patch is in trunk at revision: 754834 .

I only review as Pranay tested successfully.  Thanks to both of you, and to Deepesh for the initiative.

> When recording PO, Company automatically sets price as "last price" on Supplier record
> --------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2234
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2234
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Deepesh Kapoor
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: ofbiz-2234.patch, ofbiz-2234.patch, ofbiz-2234.patch
>
>
> Modifying the existing system such that when the unit price of the item is edited the new value automatically gets set as last price on supplier record.
> Implementation Notes :
> Add service to expire (set availableThruDate) current applicable SupplierProduct record, create new record that clones the old record, current date as available from date
> SECA trigger on create,purchase and receive order.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.