OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-2260) Secure URLs in Freemarker templates files

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

53 messages Options

123

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-2260) Secure URLs in Freemarker templates files

[ https://issues.apache.org/jira/browse/OFBIZ-2260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

CJ Horton updated OFBIZ-2260:
-----------------------------

Attachment: listPortalPortlets.patch

Jacques,

This is a subtle correction to your effort on the secure link that fixes one line in the file as follows:

<a href="javascript:document.createProductionRunsForShipment.submit()" class="buttontext">${uiLabelMap.CommonCancel}</a>

to

<a href="javascript:document.ManagePortalPages.submit()" >${uiLabelMap.CommonCancel}</a>

> Secure URLs in Freemarker templates files
> -----------------------------------------
>
> Key: OFBIZ-2260
> URL: https://issues.apache.org/jira/browse/OFBIZ-2260
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Affects Versions: Release Branch 4.0, Release Branch 9.3
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Fix For: Release Branch 4.0, Release Branch 9.3
>
> Attachments: listPortalPortlets.patch, OFBIZ-2256.patch, OFBIZ-2260.patch, OFBIZ-2260.patch
>
>
> Follow OFBIZ-2256 but for FTL files only

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Issue Comment Edited: (OFBIZ-2260) Secure URLs in Freemarker templates files

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12695986#action_12695986 ]

CJ Horton edited comment on OFBIZ-2260 at 4/5/09 11:13 PM:
-----------------------------------------------------------

Jacques,

Yes, that fixed it.

Also..I attached a small patch which is a subtle correction to your effort that does the following:

<a href="javascript:document.createProductionRunsForShipment.submit()" class="buttontext">${uiLabelMap.CommonCancel}</a>

to

<a href="javascript:document.ManagePortalPages.submit()" >${uiLabelMap.CommonCancel}</a>

My first time to submit a patch so please let me know if I should do it differently.

was (Author: cjhorton):
Jacques,

This is a subtle correction to your effort on the secure link that fixes one line in the file as follows:

<a href="javascript:document.createProductionRunsForShipment.submit()" class="buttontext">${uiLabelMap.CommonCancel}</a>

to

<a href="javascript:document.ManagePortalPages.submit()" >${uiLabelMap.CommonCancel}</a>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-2260) Secure URLs in Freemarker templates files

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashish Nagar updated OFBIZ-2260:
--------------------------------

Attachment: orderitems.patch

Removed {quote} javascript:document.addCommonToCartForm.method='post' {quote} from orderitems.ftl as suggested by David, as the method of this form is already defined as "post" in orderstatus.ftl.

Thanks Jacques, David, Pranay for the suggestions.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2260) Secure URLs in Freemarker templates files

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12695997#action_12695997 ]

Jacques Le Roux commented on OFBIZ-2260:
----------------------------------------

Thanks Ashish,

Your patch is commited at revision: 762224

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2260) Secure URLs in Freemarker templates files

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12696221#action_12696221 ]

CJ Horton commented on OFBIZ-2260:
----------------------------------

I apologize..I failed to notice that ManagePortalPages in listPortalPortlets isn't a service.

Everyone,

orderitems.ftl is having some issues. The links for forms(there are several) that have code like the following aren't working on the page:

https://localhost:8443/ordermgr/control/orderview?orderId=WSCO10001

<form name= "EditProductInventoryItems" method= "post" action= "/catalog/control/EditProductInventoryItems">
<input type= "hidden" name="productId" value= "${productId}">
<input type= "hidden" name="showAllFacilities" value= "Y">
<input type= "hidden" name="externalLoginKey" value= "${externalLoginKey}">
<a class="buttontext" href="javascript:document.EditProductInventoryItems.submit()" target="_blank">${uiLabelMap.ProductInventory}</a>
</form>

Since this(I don't think any of them are) is not calling a service should this be reverted back to:

<a href="/catalog/control/EditProduct?productId=${productId}" class="buttontext" target="_blank">${uiLabelMap.ProductCatalog}</a>

Or is there a better way?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-2260) Secure URLs in Freemarker templates files

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Divesh Dutta updated OFBIZ-2260:
--------------------------------

Attachment: UpdateLabelsFiles.patch

Clicking on Update Label Files link in Label Manager was creating an error due to security reasons. Here is the patch where parameters are send as a part of form-field.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2260) Secure URLs in Freemarker templates files

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12696640#action_12696640 ]

Jacques Le Roux commented on OFBIZ-2260:
----------------------------------------

Thanks Divesh,

Your patch is commited at revision: 762863

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2260) Secure URLs in Freemarker templates files

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12696733#action_12696733 ]

CJ Horton commented on OFBIZ-2260:
----------------------------------

Here is another one as of Rev. 762387

Page: https://localhost:8443/accounting/control/EditCustomTimePeriod
Link: https://localhost:8443/accounting/control/deleteCustomTimePeriod?customTimePeriodId=6001&currentCustomTimePeriodId=&findOrganizationPartyId=
Link: https://localhost:8443/accounting/control/deleteCustomTimePeriod?customTimePeriodId=6001

I tried to make a patch for this, but am having an "issue" with the javascript.

If I code like the following the Delete link does nothing when clicked:

<form name="DeleteCustomTimePeriod" method="post" action="<@ofbizUrl>deleteCustomTimePeriod</@ofbizUrl>">
<input type="hidden" name="customTimePeriodId" value="${customTimePeriod.customTimePeriodId?if_exists}">
<input type="hidden" name="currentCustomTimePeriodId" value="${currentCustomTimePeriodId?if_exists}">
<input type="hidden" name="findOrganizationPartyId" value="${findOrganizationPartyId?if_exists}">
<a href="javascript:document.DeleteCustomTimePeriod.submit()" >${uiLabelMap.CommonDelete}</a>
</form>

But, coding it like this works:

<form name="DeleteCustomTimePeriod" method="post" action="<@ofbizUrl>deleteCustomTimePeriod</@ofbizUrl>">
<input type="hidden" name="customTimePeriodId" value="${customTimePeriod.customTimePeriodId?if_exists}">
<input type="hidden" name="currentCustomTimePeriodId" value="${currentCustomTimePeriodId?if_exists}">
<input type="hidden" name="findOrganizationPartyId" value="${findOrganizationPartyId?if_exists}">
<input type="submit" value='${uiLabelMap.CommonDelete}'>
</form>

Am I missing something here? Advice is greatly appreciated!!

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Stephen Rufle-2

Re: [jira] Commented: (OFBIZ-2260) Secure URLs in Freemarker templates files

I think the <a> needs to be outside the form.

CJ Horton (JIRA) wrote:

> [ https://issues.apache.org/jira/browse/OFBIZ-2260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12696733#action_12696733 ]
>
> CJ Horton commented on OFBIZ-2260:
> ----------------------------------
>
> Here is another one as of Rev. 762387
>
> Page: https://localhost:8443/accounting/control/EditCustomTimePeriod
> Link: https://localhost:8443/accounting/control/deleteCustomTimePeriod?customTimePeriodId=6001&currentCustomTimePeriodId=&findOrganizationPartyId=
> Link: https://localhost:8443/accounting/control/deleteCustomTimePeriod?customTimePeriodId=6001
>
> I tried to make a patch for this, but am having an "issue" with the javascript.
>
> If I code like the following the Delete link does nothing when clicked:
>
> <form name="DeleteCustomTimePeriod" method="post" action="<@ofbizUrl>deleteCustomTimePeriod</@ofbizUrl>">
> <input type="hidden" name="customTimePeriodId" value="${customTimePeriod.customTimePeriodId?if_exists}">
> <input type="hidden" name="currentCustomTimePeriodId" value="${currentCustomTimePeriodId?if_exists}">
> <input type="hidden" name="findOrganizationPartyId" value="${findOrganizationPartyId?if_exists}">
> <a href="javascript:document.DeleteCustomTimePeriod.submit()" >${uiLabelMap.CommonDelete}</a>
> </form>
>
> But, coding it like this works:
>
> <form name="DeleteCustomTimePeriod" method="post" action="<@ofbizUrl>deleteCustomTimePeriod</@ofbizUrl>">
> <input type="hidden" name="customTimePeriodId" value="${customTimePeriod.customTimePeriodId?if_exists}">
> <input type="hidden" name="currentCustomTimePeriodId" value="${currentCustomTimePeriodId?if_exists}">
> <input type="hidden" name="findOrganizationPartyId" value="${findOrganizationPartyId?if_exists}">
> <input type="submit" value='${uiLabelMap.CommonDelete}'>
> </form>
>
> Am I missing something here? Advice is greatly appreciated!!
>
>
>
>> Secure URLs in Freemarker templates files
>> -----------------------------------------
>>
>> Key: OFBIZ-2260
>> URL: https://issues.apache.org/jira/browse/OFBIZ-2260
>> Project: OFBiz
>> Issue Type: Improvement
>> Components: ALL COMPONENTS
>> Affects Versions: Release Branch 4.0, Release Branch 9.3
>> Reporter: Jacques Le Roux
>> Assignee: Jacques Le Roux
>> Fix For: Release Branch 4.0, Release Branch 9.3
>>
>> Attachments: listPortalPortlets.patch, OFBIZ-2256.patch, OFBIZ-2260.patch, OFBIZ-2260.patch, orderitems.patch, UpdateLabelsFiles.patch
>>
>>
>> Follow OFBIZ-2256 but for FTL files only
>>
>
>

--
Stephen P Rufle
[hidden email]
H1:480-626-8022
H2:480-802-7173
Yahoo IM: stephen_rufle
AOL IM: stephen1rufle

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2260) Secure URLs in Freemarker templates files

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12696900#action_12696900 ]

Ashish Nagar commented on OFBIZ-2260:
-------------------------------------

Hello CJ,

I could not find any visible issue in the link you put here to submit the form, however using submit button will always work. Could you please tell the issue you are getting with js? Also please check with <a href="javascript:document.DeleteCustomTimePeriod.submit();" >${uiLabelMap.CommonDelete}</a>.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Ashish Nagar

Re: [jira] Commented: (OFBIZ-2260) Secure URLs in Freemarker templates files

In reply to this post by Stephen Rufle-2

Hello Stephen,

Would <a> outside the form, make any difference? As we are just calling
a js function with the link. The link within the form will make <a> as a
part of the form, so will be helpful to make the "link" layout fit
inside the form. Clearing the browser cache might help here.

Thanks & Regards,
--
Ashish Nagar

Stephen Rufle wrote:

> I think the <a> needs to be outside the form.
>
> CJ Horton (JIRA) wrote:
>
>> [ https://issues.apache.org/jira/browse/OFBIZ-2260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12696733#action_12696733 ]
>>
>> CJ Horton commented on OFBIZ-2260:
>> ----------------------------------
>>
>> Here is another one as of Rev. 762387
>>
>> Page: https://localhost:8443/accounting/control/EditCustomTimePeriod
>> Link: https://localhost:8443/accounting/control/deleteCustomTimePeriod?customTimePeriodId=6001&currentCustomTimePeriodId=&findOrganizationPartyId=
>> Link: https://localhost:8443/accounting/control/deleteCustomTimePeriod?customTimePeriodId=6001
>>
>> I tried to make a patch for this, but am having an "issue" with the javascript.
>>
>> If I code like the following the Delete link does nothing when clicked:
>>
>> <form name="DeleteCustomTimePeriod" method="post" action="<@ofbizUrl>deleteCustomTimePeriod</@ofbizUrl>">
>> <input type="hidden" name="customTimePeriodId" value="${customTimePeriod.customTimePeriodId?if_exists}">
>> <input type="hidden" name="currentCustomTimePeriodId" value="${currentCustomTimePeriodId?if_exists}">
>> <input type="hidden" name="findOrganizationPartyId" value="${findOrganizationPartyId?if_exists}">
>> <a href="javascript:document.DeleteCustomTimePeriod.submit()" >${uiLabelMap.CommonDelete}</a>
>> </form>
>>
>> But, coding it like this works:
>>
>> <form name="DeleteCustomTimePeriod" method="post" action="<@ofbizUrl>deleteCustomTimePeriod</@ofbizUrl>">
>> <input type="hidden" name="customTimePeriodId" value="${customTimePeriod.customTimePeriodId?if_exists}">
>> <input type="hidden" name="currentCustomTimePeriodId" value="${currentCustomTimePeriodId?if_exists}">
>> <input type="hidden" name="findOrganizationPartyId" value="${findOrganizationPartyId?if_exists}">
>> <input type="submit" value='${uiLabelMap.CommonDelete}'>
>> </form>
>>
>> Am I missing something here? Advice is greatly appreciated!!
>>
>>
>>
>>
>>> Secure URLs in Freemarker templates files
>>> -----------------------------------------
>>>
>>> Key: OFBIZ-2260
>>> URL: https://issues.apache.org/jira/browse/OFBIZ-2260
>>> Project: OFBiz
>>> Issue Type: Improvement
>>> Components: ALL COMPONENTS
>>> Affects Versions: Release Branch 4.0, Release Branch 9.3
>>> Reporter: Jacques Le Roux
>>> Assignee: Jacques Le Roux
>>> Fix For: Release Branch 4.0, Release Branch 9.3
>>>
>>> Attachments: listPortalPortlets.patch, OFBIZ-2256.patch, OFBIZ-2260.patch, OFBIZ-2260.patch, orderitems.patch, UpdateLabelsFiles.patch
>>>
>>>
>>> Follow OFBIZ-2256 but for FTL files only
>>>
>>>
>>
>>
>
>

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2260) Secure URLs in Freemarker templates files

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12696948#action_12696948 ]

CJ Horton commented on OFBIZ-2260:
----------------------------------

Hi Ashish,

I apologize if I was unclear. The issue I am having is that when I code the EditCustomTimePeriod.ftl by replacing the following:

<a href='<@ofbizUrl>deleteCustomTimePeriod?customTimePeriodId=${customTimePeriod.customTimePeriodId?if_exists}&currentCustomTimePeriodId=${currentCustomTimePeriodId?if_exists}&findOrganizationPartyId=${findOrganizationPartyId?if_exists}</@ofbizUrl>'>
${uiLabelMap.CommonDelete}</a

with:

<form name="DeleteCustomTimePeriod" method="post" action="<@ofbizUrl>deleteCustomTimePeriod</@ofbizUrl>">
<input type="hidden" name="customTimePeriodId" value="${customTimePeriod.customTimePeriodId?if_exists}">
<input type="hidden" name="currentCustomTimePeriodId" value="${currentCustomTimePeriodId?if_exists}">
<input type="hidden" name="findOrganizationPartyId" value="${findOrganizationPartyId?if_exists}">
<a href="javascript:document.DeleteCustomTimePeriod.submit()" >${uiLabelMap.CommonDelete}</a>
</form>

When I visit: https://localhost:8443/accounting/control/EditCustomTimePeriod and click on the Delete link, absolutely nothing happens. It is like I am just clicking on plain text. Same thing happens when I add the ; as in your post.

Now, when I code the .ftl file with:

<form name="DeleteCustomTimePeriod" method="post" action="<@ofbizUrl>deleteCustomTimePeriod</@ofbizUrl>">
<input type="hidden" name="customTimePeriodId" value="${customTimePeriod.customTimePeriodId?if_exists}">
<input type="hidden" name="currentCustomTimePeriodId" value="${currentCustomTimePeriodId?if_exists}">
<input type="hidden" name="findOrganizationPartyId" value="${findOrganizationPartyId?if_exists}">
<input type="submit" value='${uiLabelMap.CommonDelete}'>
</form>

and I visit the page in my browser, the Delete button behaves as expected(request->service->etc.)

I guess I am wondering why it doesn't work using <a href="javascript:document.DeleteCustomTimePeriod.submit()" >${uiLabelMap.CommonDelete}</a>?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2260) Secure URLs in Freemarker templates files

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12697004#action_12697004 ]

Ashish Nagar commented on OFBIZ-2260:
-------------------------------------

Hello CJ,

Is the javascript is getting blocked, (seen on the left bottom of the browser) or the link seems just like a text written not as hyperlink?
If js is getting blocked, please check after cleaning the browser cache. Can also try to customize the security level of the browser.

Thanks,
--
Ashish Nagar

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-2260) Secure URLs in Freemarker templates files

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

CJ Horton updated OFBIZ-2260:
-----------------------------

Attachment: CJ-Screenshot-04082009.JPG
forAshish.patch

Ashish,

It is seen on left bottom of browser, but it does nothing(literally) when clicked. I played with browser settings/etc and get the same result. I attached two files named forAshish.patch and CJ-Screenshot-04082009.JPG so you may see the code and my browser when I am clicking the link(looks the same before and after I click it).

CJ

> Secure URLs in Freemarker templates files
> -----------------------------------------
>
> Key: OFBIZ-2260
> URL: https://issues.apache.org/jira/browse/OFBIZ-2260
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Affects Versions: Release Branch 4.0, Release Branch 9.3
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Fix For: Release Branch 4.0, Release Branch 9.3
>
> Attachments: CJ-Screenshot-04082009.JPG, forAshish.patch, listPortalPortlets.patch, OFBIZ-2256.patch, OFBIZ-2260.patch, OFBIZ-2260.patch, orderitems.patch, UpdateLabelsFiles.patch
>
>
> Follow OFBIZ-2256 but for FTL files only

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Stephen Rufle-2

Re: [jira] Updated: (OFBIZ-2260) Secure URLs in Freemarker templates files

I think you may need to make the form name unique. I had something
similar on one of my own screens and it seems that adding an index and
appending that number to the form name work well.

Current:
<form name="DeleteCustomTimePeriod" method="post"
action="<@ofbizUrl>deleteCustomTimePeriod</@ofbizUrl>">
...
<a href="javascript:document.DeleteCustomTimePeriod.submit()"
>${uiLabelMap.CommonDelete}</a>
</form>

Suggested:
<form name="DeleteCustomTimePeriod_1" method="post"
action="<@ofbizUrl>deleteCustomTimePeriod</@ofbizUrl>">
...
<a href="javascript:document.DeleteCustomTimePeriod_1.submit()"
>${uiLabelMap.CommonDelete}</a>
</form>

CJ Horton (JIRA) wrote:

> [ https://issues.apache.org/jira/browse/OFBIZ-2260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> CJ Horton updated OFBIZ-2260:
> -----------------------------
>
> Attachment: CJ-Screenshot-04082009.JPG
> forAshish.patch
>
> Ashish,
>
> It is seen on left bottom of browser, but it does nothing(literally) when clicked. I played with browser settings/etc and get the same result. I attached two files named forAshish.patch and CJ-Screenshot-04082009.JPG so you may see the code and my browser when I am clicking the link(looks the same before and after I click it).
>
> CJ
>
>
>> Secure URLs in Freemarker templates files
>> -----------------------------------------
>>
>> Key: OFBIZ-2260
>> URL: https://issues.apache.org/jira/browse/OFBIZ-2260
>> Project: OFBiz
>> Issue Type: Improvement
>> Components: ALL COMPONENTS
>> Affects Versions: Release Branch 4.0, Release Branch 9.3
>> Reporter: Jacques Le Roux
>> Assignee: Jacques Le Roux
>> Fix For: Release Branch 4.0, Release Branch 9.3
>>
>> Attachments: CJ-Screenshot-04082009.JPG, forAshish.patch, listPortalPortlets.patch, OFBIZ-2256.patch, OFBIZ-2260.patch, OFBIZ-2260.patch, orderitems.patch, UpdateLabelsFiles.patch
>>
>>
>> Follow OFBIZ-2256 but for FTL files only
>>
>
>

--
Stephen P Rufle
[hidden email]
H1:480-626-8022
H2:480-802-7173
Yahoo IM: stephen_rufle
AOL IM: stephen1rufle

Jacques Le Roux

Re: [jira] Updated: (OFBIZ-2260) Secure URLs in Freemarker templates files

Administrator

It would be far more easier for those who are separating dev and jira threads to have comments directly in Jira issues

Thanks

Jacques

From: "Stephen Rufle" <[hidden email]>

>I think you may need to make the form name unique. I had something
> similar on one of my own screens and it seems that adding an index and
> appending that number to the form name work well.
>
> Current:
> <form name="DeleteCustomTimePeriod" method="post"
> action="<@ofbizUrl>deleteCustomTimePeriod</@ofbizUrl>">
> ...
> <a href="javascript:document.DeleteCustomTimePeriod.submit()"
>>${uiLabelMap.CommonDelete}</a>
> </form>
>
> Suggested:
> <form name="DeleteCustomTimePeriod_1" method="post"
> action="<@ofbizUrl>deleteCustomTimePeriod</@ofbizUrl>">
> ...
> <a href="javascript:document.DeleteCustomTimePeriod_1.submit()"
>>${uiLabelMap.CommonDelete}</a>
> </form>
>
> CJ Horton (JIRA) wrote:
>> [ https://issues.apache.org/jira/browse/OFBIZ-2260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>>
>> CJ Horton updated OFBIZ-2260:
>> -----------------------------
>>
>> Attachment: CJ-Screenshot-04082009.JPG
>> forAshish.patch
>>
>> Ashish,
>>
>> It is seen on left bottom of browser, but it does nothing(literally) when clicked. I played with browser settings/etc and get
>> the same result. I attached two files named forAshish.patch and CJ-Screenshot-04082009.JPG so you may see the code and my
>> browser when I am clicking the link(looks the same before and after I click it).
>>
>> CJ
>>
>>
>>> Secure URLs in Freemarker templates files
>>> -----------------------------------------
>>>
>>> Key: OFBIZ-2260
>>> URL: https://issues.apache.org/jira/browse/OFBIZ-2260
>>> Project: OFBiz
>>> Issue Type: Improvement
>>> Components: ALL COMPONENTS
>>> Affects Versions: Release Branch 4.0, Release Branch 9.3
>>> Reporter: Jacques Le Roux
>>> Assignee: Jacques Le Roux
>>> Fix For: Release Branch 4.0, Release Branch 9.3
>>>
>>> Attachments: CJ-Screenshot-04082009.JPG, forAshish.patch, listPortalPortlets.patch, OFBIZ-2256.patch, OFBIZ-2260.patch,
>>> OFBIZ-2260.patch, orderitems.patch, UpdateLabelsFiles.patch
>>>
>>>
>>> Follow OFBIZ-2256 but for FTL files only
>>>
>>
>>
>
> --
> Stephen P Rufle
> [hidden email]
> H1:480-626-8022
> H2:480-802-7173
> Yahoo IM: stephen_rufle
> AOL IM: stephen1rufle
>
>

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2260) Secure URLs in Freemarker templates files

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12697187#action_12697187 ]

Stephen Rufle commented on OFBIZ-2260:
--------------------------------------

I think you may need to make the form name unique. I had something
similar on one of my own screens and it seems that adding an index and
appending that number to the form name worked well for me.

Current:
{code:xml}
<form name="DeleteCustomTimePeriod" method="post"
action="<@ofbizUrl>deleteCustomTimePeriod</@ofbizUrl>">
...
<a href="javascript:document.DeleteCustomTimePeriod.submit()"
> >${uiLabelMap.CommonDelete}</a>
</form>
{code}
Suggested:
{code:xml}
<form name="DeleteCustomTimePeriod_1" method="post"
action="<@ofbizUrl>deleteCustomTimePeriod</@ofbizUrl>">
...
<a href="javascript:document.DeleteCustomTimePeriod_1.submit()"
> >${uiLabelMap.CommonDelete}</a>
</form>
{code}

> Secure URLs in Freemarker templates files
> -----------------------------------------
>
> Key: OFBIZ-2260
> URL: https://issues.apache.org/jira/browse/OFBIZ-2260
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Affects Versions: Release Branch 4.0, Release Branch 9.3
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Fix For: Release Branch 4.0, Release Branch 9.3
>
> Attachments: CJ-Screenshot-04082009.JPG, forAshish.patch, listPortalPortlets.patch, OFBIZ-2256.patch, OFBIZ-2260.patch, OFBIZ-2260.patch, orderitems.patch, UpdateLabelsFiles.patch
>
>
> Follow OFBIZ-2256 but for FTL files only

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-2260) Secure URLs in Freemarker templates files

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

CJ Horton updated OFBIZ-2260:
-----------------------------

Attachment: EditCustomTimePeriod.ftl.patch

Stephen,

You are absolutely correct. The sad thing is that I even saw the recent post on the ML about that like five times. I totally didn't think about the fact that the form was in a list. Ugh. Sorry to cause so much spam everyone.

EditCustomTimePeriod.ftl.patch corrects this.

> Secure URLs in Freemarker templates files
> -----------------------------------------
>
> Key: OFBIZ-2260
> URL: https://issues.apache.org/jira/browse/OFBIZ-2260
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Affects Versions: Release Branch 4.0, Release Branch 9.3
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Fix For: Release Branch 4.0, Release Branch 9.3
>
> Attachments: EditCustomTimePeriod.ftl.patch, listPortalPortlets.patch, OFBIZ-2256.patch, OFBIZ-2260.patch, OFBIZ-2260.patch, orderitems.patch, UpdateLabelsFiles.patch
>
>
> Follow OFBIZ-2256 but for FTL files only

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-2260) Secure URLs in Freemarker templates files

In reply to this post by Nicolas Malin (Jira)

> Secure URLs in Freemarker templates files
> -----------------------------------------
>
> Key: OFBIZ-2260
> URL: https://issues.apache.org/jira/browse/OFBIZ-2260
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Affects Versions: Release Branch 4.0, Release Branch 9.3
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Fix For: Release Branch 4.0, Release Branch 9.3
>
> Attachments: EditCustomTimePeriod.ftl.patch, listPortalPortlets.patch, OFBIZ-2256.patch, OFBIZ-2260.patch, OFBIZ-2260.patch, orderitems.patch, UpdateLabelsFiles.patch
>
>
> Follow OFBIZ-2256 but for FTL files only

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-2260) Secure URLs in Freemarker templates files

In reply to this post by Nicolas Malin (Jira)

> Secure URLs in Freemarker templates files
> -----------------------------------------
>
> Key: OFBIZ-2260
> URL: https://issues.apache.org/jira/browse/OFBIZ-2260
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Affects Versions: Release Branch 4.0, Release Branch 9.3
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Fix For: Release Branch 4.0, Release Branch 9.3
>
> Attachments: EditCustomTimePeriod.ftl.patch, listPortalPortlets.patch, OFBIZ-2256.patch, OFBIZ-2260.patch, OFBIZ-2260.patch, orderitems.patch, UpdateLabelsFiles.patch
>
>
> Follow OFBIZ-2256 but for FTL files only

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

123