[jira] Created: (OFBIZ-234) auto-cancel date hard coded

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (OFBIZ-234) auto-cancel date hard coded

Nicolas Malin (Jira)
auto-cancel date hard coded
---------------------------

                 Key: OFBIZ-234
                 URL: http://issues.apache.org/jira/browse/OFBIZ-234
             Project: OFBiz (The Open for Business Project)
          Issue Type: Bug
          Components: product
    Affects Versions: SVN trunk
         Environment: All
            Reporter: Marco Risaliti
            Priority: Minor


It seems from a report by David Welton that the auto-cancel date is hard coded?

In the code I was hacking at, I found '30' hard coded: near line 433
(give or take some because of my patch)

applications/product/src/org/ofbiz/product/inventory/InventoryServices.java

                        // need to know if nextShipDate is more then
30 days after promised
                        Calendar sCal = Calendar.getInstance();
                        sCal.setTimeInMillis(actualPromiseDate.getTime());
                        sCal.add(Calendar.DAY_OF_YEAR, 30);
                        Timestamp farPastPromised = new
Timestamp(sCal.getTimeInMillis());


--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-234) auto-cancel date hard coded

Nicolas Malin (Jira)
    [ http://issues.apache.org/jira/browse/OFBIZ-234?page=comments#action_12434101 ]
           
Marco Risaliti commented on OFBIZ-234:
--------------------------------------

It replace the old-jira issue OFBIZ-695.
Can someone close the old one.

Thanks
Marco

> auto-cancel date hard coded
> ---------------------------
>
>                 Key: OFBIZ-234
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-234
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>         Environment: All
>            Reporter: Marco Risaliti
>            Priority: Minor
>
> It seems from a report by David Welton that the auto-cancel date is hard coded?
> In the code I was hacking at, I found '30' hard coded: near line 433
> (give or take some because of my patch)
> applications/product/src/org/ofbiz/product/inventory/InventoryServices.java
>                         // need to know if nextShipDate is more then
> 30 days after promised
>                         Calendar sCal = Calendar.getInstance();
>                         sCal.setTimeInMillis(actualPromiseDate.getTime());
>                         sCal.add(Calendar.DAY_OF_YEAR, 30);
>                         Timestamp farPastPromised = new
> Timestamp(sCal.getTimeInMillis());

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-234) auto-cancel date hard coded

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
    [ http://issues.apache.org/jira/browse/OFBIZ-234?page=comments#action_12434200 ]
           
Joe Eckard commented on OFBIZ-234:
----------------------------------

This is hard coded because this service was created to comply with the FTC "30 Day" rule...

from: http://www.ftc.gov/bcp/conline/pubs/buspubs/mailorder.htm

What is the Mail or Telephone Order Rule?

The Rule requires that when you advertise merchandise, you must have a reasonable basis for stating or implying that you can ship within a certain time. If you make no shipment statement, you must have a reasonable basis for believing that you can ship within 30 days. That is why direct marketers sometimes call this the "30-day Rule."

> auto-cancel date hard coded
> ---------------------------
>
>                 Key: OFBIZ-234
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-234
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>         Environment: All
>            Reporter: Marco Risaliti
>            Priority: Minor
>
> It seems from a report by David Welton that the auto-cancel date is hard coded?
> In the code I was hacking at, I found '30' hard coded: near line 433
> (give or take some because of my patch)
> applications/product/src/org/ofbiz/product/inventory/InventoryServices.java
>                         // need to know if nextShipDate is more then
> 30 days after promised
>                         Calendar sCal = Calendar.getInstance();
>                         sCal.setTimeInMillis(actualPromiseDate.getTime());
>                         sCal.add(Calendar.DAY_OF_YEAR, 30);
>                         Timestamp farPastPromised = new
> Timestamp(sCal.getTimeInMillis());

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-234) auto-cancel date hard coded

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
    [ http://issues.apache.org/jira/browse/OFBIZ-234?page=comments#action_12434235 ]
           
Marco Risaliti commented on OFBIZ-234:
--------------------------------------

Ok, so if any desagree with the rule FTC "30 Day" this is not an issue and it can be closed with the causal "Won't be fixed".

Thanks
Marco

> auto-cancel date hard coded
> ---------------------------
>
>                 Key: OFBIZ-234
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-234
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>         Environment: All
>            Reporter: Marco Risaliti
>            Priority: Minor
>
> It seems from a report by David Welton that the auto-cancel date is hard coded?
> In the code I was hacking at, I found '30' hard coded: near line 433
> (give or take some because of my patch)
> applications/product/src/org/ofbiz/product/inventory/InventoryServices.java
>                         // need to know if nextShipDate is more then
> 30 days after promised
>                         Calendar sCal = Calendar.getInstance();
>                         sCal.setTimeInMillis(actualPromiseDate.getTime());
>                         sCal.add(Calendar.DAY_OF_YEAR, 30);
>                         Timestamp farPastPromised = new
> Timestamp(sCal.getTimeInMillis());

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (OFBIZ-234) auto-cancel date hard coded

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
     [ http://issues.apache.org/jira/browse/OFBIZ-234?page=all ]

Jacopo Cappellato closed OFBIZ-234.
-----------------------------------

    Resolution: Won't Fix

> auto-cancel date hard coded
> ---------------------------
>
>                 Key: OFBIZ-234
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-234
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>         Environment: All
>            Reporter: Marco Risaliti
>            Priority: Minor
>
> It seems from a report by David Welton that the auto-cancel date is hard coded?
> In the code I was hacking at, I found '30' hard coded: near line 433
> (give or take some because of my patch)
> applications/product/src/org/ofbiz/product/inventory/InventoryServices.java
>                         // need to know if nextShipDate is more then
> 30 days after promised
>                         Calendar sCal = Calendar.getInstance();
>                         sCal.setTimeInMillis(actualPromiseDate.getTime());
>                         sCal.add(Calendar.DAY_OF_YEAR, 30);
>                         Timestamp farPastPromised = new
> Timestamp(sCal.getTimeInMillis());

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira