[jira] Created: (OFBIZ-2467) Delete an action under price rule

[Nicolas Malin (Jira)]

Delete an action under price rule
---------------------------------

                 Key: OFBIZ-2467
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2467
             Project: OFBiz
          Issue Type: Sub-task
          Components: accounting
         Environment: red hat & postgres.
            Reporter: Rohit Sureka


The sage URL error is thrown up, when we try to delete an action under the price rule tab, in the catalog under admin section.

The following URL in the demo-servers throws the error.

Rohit

https://demo.ofbiz.org/catalog/control/deleteProductPriceAction?productPriceRuleId=10000&productPriceActionSeqId=01

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ahmed Dini updated OFBIZ-2467:
------------------------------

    Attachment: EditProductPriceRule.patch

Attached is a patch for this issue. I found out that I can't delete a ProductPriceAction If an OrderItemPriceInfoId exists which is linked to the product action through the OrderItemPriceInfoId's productPriceActionSeqId field unless  this relationship or the whole entity  is removed.  Otherwise it passed all my tests.

> Delete an action under price rule
> ---------------------------------
>
>                 Key: OFBIZ-2467
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2467
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>         Environment: red hat & postgres.
>            Reporter: Rohit Sureka
>         Attachments: EditProductPriceRule.patch
>
>
> The sage URL error is thrown up, when we try to delete an action under the price rule tab, in the catalog under admin section.
> The following URL in the demo-servers throws the error.
> Rohit
> https://demo.ofbiz.org/catalog/control/deleteProductPriceAction?productPriceRuleId=10000&productPriceActionSeqId=01

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anil K Patel reassigned OFBIZ-2467:
-----------------------------------

    Assignee: Anil K Patel

> Delete an action under price rule
> ---------------------------------
>
>                 Key: OFBIZ-2467
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2467
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>         Environment: red hat & postgres.
>            Reporter: Rohit Sureka
>            Assignee: Anil K Patel
>         Attachments: EditProductPriceRule.patch
>
>
> The sage URL error is thrown up, when we try to delete an action under the price rule tab, in the catalog under admin section.
> The following URL in the demo-servers throws the error.
> Rohit
> https://demo.ofbiz.org/catalog/control/deleteProductPriceAction?productPriceRuleId=10000&productPriceActionSeqId=01

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anil K Patel closed OFBIZ-2467.
-------------------------------

    Resolution: Fixed

Rohit, Thanks for reporting issue. Ahmed, Thanks for the patch.
Fix is in r800022.

> Delete an action under price rule
> ---------------------------------
>
>                 Key: OFBIZ-2467
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2467
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>         Environment: red hat & postgres.
>            Reporter: Rohit Sureka
>            Assignee: Anil K Patel
>         Attachments: EditProductPriceRule.patch
>
>
> The sage URL error is thrown up, when we try to delete an action under the price rule tab, in the catalog under admin section.
> The following URL in the demo-servers throws the error.
> Rohit
> https://demo.ofbiz.org/catalog/control/deleteProductPriceAction?productPriceRuleId=10000&productPriceActionSeqId=01

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vikas Mayur updated OFBIZ-2467:
-------------------------------

    Affects Version/s: SVN trunk
                       Release Branch 9.04
        Fix Version/s: SVN trunk
                       Release Branch 9.04

> Delete an action under price rule
> ---------------------------------
>
>                 Key: OFBIZ-2467
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2467
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>    Affects Versions: Release Branch 9.04, SVN trunk
>         Environment: red hat & postgres.
>            Reporter: Rohit Sureka
>            Assignee: Anil K Patel
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: EditProductPriceRule.patch
>
>
> The sage URL error is thrown up, when we try to delete an action under the price rule tab, in the catalog under admin section.
> The following URL in the demo-servers throws the error.
> Rohit
> https://demo.ofbiz.org/catalog/control/deleteProductPriceAction?productPriceRuleId=10000&productPriceActionSeqId=01

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12738201#action_12738201 ]

Sumit Pandit commented on OFBIZ-2467:
-------------------------------------

Ahmad, you did a good job. But here is a suggesting when you use counter in list  (<#assign rowCount = 0>) -
You can use list's loop variables to solve the purpose. For more information please visit - http://freemarker.sourceforge.net/docs-24pre1/ref_directive_list.html#ref_directive_list
and look at how can we use item_index in our loops.

Thanks And Regards
Sumit Pandit

> Delete an action under price rule
> ---------------------------------
>
>                 Key: OFBIZ-2467
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2467
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>    Affects Versions: Release Branch 9.04, SVN trunk
>         Environment: red hat & postgres.
>            Reporter: Rohit Sureka
>            Assignee: Anil K Patel
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: EditProductPriceRule.patch
>
>
> The sage URL error is thrown up, when we try to delete an action under the price rule tab, in the catalog under admin section.
> The following URL in the demo-servers throws the error.
> Rohit
> https://demo.ofbiz.org/catalog/control/deleteProductPriceAction?productPriceRuleId=10000&productPriceActionSeqId=01

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vikas Mayur reopened OFBIZ-2467:
--------------------------------

      Assignee: Vikas Mayur  (was: Anil K Patel)

> Delete an action under price rule
> ---------------------------------
>
>                 Key: OFBIZ-2467
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2467
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>    Affects Versions: Release Branch 9.04, SVN trunk
>         Environment: red hat & postgres.
>            Reporter: Rohit Sureka
>            Assignee: Vikas Mayur
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: EditProductPriceRule.patch
>
>
> The sage URL error is thrown up, when we try to delete an action under the price rule tab, in the catalog under admin section.
> The following URL in the demo-servers throws the error.
> Rohit
> https://demo.ofbiz.org/catalog/control/deleteProductPriceAction?productPriceRuleId=10000&productPriceActionSeqId=01

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vikas Mayur resolved OFBIZ-2467.
--------------------------------

    Resolution: Fixed

This should also be fixed in release09.04 in rev. 800223

> Delete an action under price rule
> ---------------------------------
>
>                 Key: OFBIZ-2467
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2467
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>    Affects Versions: Release Branch 9.04, SVN trunk
>         Environment: red hat & postgres.
>            Reporter: Rohit Sureka
>            Assignee: Vikas Mayur
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: EditProductPriceRule.patch
>
>
> The sage URL error is thrown up, when we try to delete an action under the price rule tab, in the catalog under admin section.
> The following URL in the demo-servers throws the error.
> Rohit
> https://demo.ofbiz.org/catalog/control/deleteProductPriceAction?productPriceRuleId=10000&productPriceActionSeqId=01

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-2467.
----------------------------------

> Delete an action under price rule
> ---------------------------------
>
>                 Key: OFBIZ-2467
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2467
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>    Affects Versions: Release Branch 9.04, SVN trunk
>         Environment: red hat & postgres.
>            Reporter: Rohit Sureka
>            Assignee: Vikas Mayur
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: EditProductPriceRule.patch
>
>
> The sage URL error is thrown up, when we try to delete an action under the price rule tab, in the catalog under admin section.
> The following URL in the demo-servers throws the error.
> Rohit
> https://demo.ofbiz.org/catalog/control/deleteProductPriceAction?productPriceRuleId=10000&productPriceActionSeqId=01

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12743720#action_12743720 ]

Ahmed Dini commented on OFBIZ-2467:
-----------------------------------

Thanks Sumit for the comment. I had a look at the link, I will follow the recommanded way.
Thanks again

> Delete an action under price rule
> ---------------------------------
>
>                 Key: OFBIZ-2467
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2467
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>    Affects Versions: Release Branch 9.04, SVN trunk
>         Environment: red hat & postgres.
>            Reporter: Rohit Sureka
>            Assignee: Vikas Mayur
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: EditProductPriceRule.patch
>
>
> The sage URL error is thrown up, when we try to delete an action under the price rule tab, in the catalog under admin section.
> The following URL in the demo-servers throws the error.
> Rohit
> https://demo.ofbiz.org/catalog/control/deleteProductPriceAction?productPriceRuleId=10000&productPriceActionSeqId=01

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.