[jira] Created: (OFBIZ-2493) ECommerce - product detail: Centre screenlet drops below the lowest existing screenlet

[Nicolas Malin (Jira)]

ECommerce - product detail: Centre screenlet drops below the lowest existing screenlet
--------------------------------------------------------------------------------------

                 Key: OFBIZ-2493
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2493
             Project: OFBiz
          Issue Type: Improvement
    Affects Versions: Release Branch 9.04
            Reporter: Torstein Hegbom
             Fix For: Release Branch 9.04


The centre screenlet seems to not to have enouch space (in the x-direction) for the last screenlet added (product detail), and it drops below the lowest existing screenlet.


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Torstein Hegbom updated OFBIZ-2493:
-----------------------------------

    Attachment: productdetail.ftl
                productdetail.ftl

Here is a suggested fix that stems from:
Applications/order/webapp/ordermgr/entry/catalog

and

Specialpurpose/ecomerce/webapp/ecomerce/catalog

> ECommerce - product detail: Centre screenlet drops below the lowest existing screenlet
> --------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2493
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2493
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Release Branch 9.04
>            Reporter: Torstein Hegbom
>             Fix For: Release Branch 9.04
>
>         Attachments: productdetail.ftl, productdetail.ftl
>
>
> The centre screenlet seems to not to have enouch space (in the x-direction) for the last screenlet added (product detail), and it drops below the lowest existing screenlet.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Torstein Hegbom updated OFBIZ-2493:
-----------------------------------

    Attachment: productdetail.diff

How I have created a patch-file that can be implemented or inspected.

> ECommerce - product detail: Centre screenlet drops below the lowest existing screenlet
> --------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2493
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2493
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Release Branch 9.04
>            Reporter: Torstein Hegbom
>             Fix For: Release Branch 9.04
>
>         Attachments: productdetail.diff, productdetail.ftl, productdetail.ftl
>
>
> The centre screenlet seems to not to have enouch space (in the x-direction) for the last screenlet added (product detail), and it drops below the lowest existing screenlet.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12751907#action_12751907 ]

Jacques Le Roux commented on OFBIZ-2493:
----------------------------------------

Hi Torstein,

I'd be interested to test and hopefully commit your patch but I get a conflict in eCommerce productdetail.ftl, could you please update ?

Thanks

> ECommerce - product detail: Centre screenlet drops below the lowest existing screenlet
> --------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2493
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2493
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Release Branch 9.04
>            Reporter: Torstein Hegbom
>             Fix For: Release Branch 9.04
>
>         Attachments: productdetail.diff, productdetail.ftl, productdetail.ftl
>
>
> The centre screenlet seems to not to have enouch space (in the x-direction) for the last screenlet added (product detail), and it drops below the lowest existing screenlet.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12759103#action_12759103 ]

Jacques Le Roux commented on OFBIZ-2493:
----------------------------------------

I could eventually commit in the order manager side but I did not find a product with an issue. I found WG-9943 in eCommerce

> ECommerce - product detail: Centre screenlet drops below the lowest existing screenlet
> --------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2493
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2493
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Release Branch 9.04
>            Reporter: Torstein Hegbom
>             Fix For: Release Branch 9.04
>
>         Attachments: productdetail.diff, productdetail.ftl, productdetail.ftl
>
>
> The centre screenlet seems to not to have enouch space (in the x-direction) for the last screenlet added (product detail), and it drops below the lowest existing screenlet.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Torstein Hegbom updated OFBIZ-2493:
-----------------------------------

    Attachment:     (was: productdetail.ftl)

> ECommerce - product detail: Centre screenlet drops below the lowest existing screenlet
> --------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2493
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2493
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Release Branch 9.04
>            Reporter: Torstein Hegbom
>             Fix For: Release Branch 9.04
>
>         Attachments: productdetail.ftl
>
>
> The centre screenlet seems to not to have enouch space (in the x-direction) for the last screenlet added (product detail), and it drops below the lowest existing screenlet.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Torstein Hegbom updated OFBIZ-2493:
-----------------------------------

    Attachment:     (was: productdetail.diff)

> ECommerce - product detail: Centre screenlet drops below the lowest existing screenlet
> --------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2493
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2493
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Release Branch 9.04
>            Reporter: Torstein Hegbom
>             Fix For: Release Branch 9.04
>
>         Attachments: productdetail.ftl
>
>
> The centre screenlet seems to not to have enouch space (in the x-direction) for the last screenlet added (product detail), and it drops below the lowest existing screenlet.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Torstein Hegbom updated OFBIZ-2493:
-----------------------------------

    Attachment:     (was: productdetail.ftl)

> ECommerce - product detail: Centre screenlet drops below the lowest existing screenlet
> --------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2493
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2493
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Release Branch 9.04
>            Reporter: Torstein Hegbom
>             Fix For: Release Branch 9.04
>
>         Attachments: ecommerce-product-detail.patch, order-product-detail.patch
>
>
> The centre screenlet seems to not to have enouch space (in the x-direction) for the last screenlet added (product detail), and it drops below the lowest existing screenlet.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Torstein Hegbom updated OFBIZ-2493:
-----------------------------------

    Attachment: order-product-detail.patch
                ecommerce-product-detail.patch

> ECommerce - product detail: Centre screenlet drops below the lowest existing screenlet
> --------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2493
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2493
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Release Branch 9.04
>            Reporter: Torstein Hegbom
>             Fix For: Release Branch 9.04
>
>         Attachments: ecommerce-product-detail.patch, order-product-detail.patch
>
>
> The centre screenlet seems to not to have enouch space (in the x-direction) for the last screenlet added (product detail), and it drops below the lowest existing screenlet.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12759860#action_12759860 ]

Torstein Hegbom commented on OFBIZ-2493:
----------------------------------------

I have uploaded an updated set of files that has been created using the latest update from the svn.

> ECommerce - product detail: Centre screenlet drops below the lowest existing screenlet
> --------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2493
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2493
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Release Branch 9.04
>            Reporter: Torstein Hegbom
>             Fix For: Release Branch 9.04
>
>         Attachments: ecommerce-product-detail.patch, order-product-detail.patch
>
>
> The centre screenlet seems to not to have enouch space (in the x-direction) for the last screenlet added (product detail), and it drops below the lowest existing screenlet.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12759883#action_12759883 ]

Jacques Le Roux commented on OFBIZ-2493:
----------------------------------------

Hi Torstein,

Sorry but you need to read http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices. At least 2 issues in your patches. I looked only at ecommerce-product-detail.patch and found a showstopper in the 1st change.
{code}
-        if (defaultDetailImage == null || defaultDetailImage == "null" || defaultDetailImage == "") {
+        if (defaultDetailImage == null || defaultDetailImage == "null") {
{code}

This change you remove has been introduced in [revision 811528|http://markmail.org/message/beu46a6abvqvu35f] and I don't see any reason to remove it. So please check that you have updated to last revision before creating your patch since else you may introduce regressive bugs :(

Also please follow contributors best practices, you forgot this advice
"Eclipse internal command (don't use finish and select project to avoid the 2 1st lines in the patch)"

Thanks

> ECommerce - product detail: Centre screenlet drops below the lowest existing screenlet
> --------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2493
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2493
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Release Branch 9.04
>            Reporter: Torstein Hegbom
>             Fix For: Release Branch 9.04
>
>         Attachments: ecommerce-product-detail.patch, order-product-detail.patch
>
>
> The centre screenlet seems to not to have enouch space (in the x-direction) for the last screenlet added (product detail), and it drops below the lowest existing screenlet.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12759884#action_12759884 ]

Jacques Le Roux commented on OFBIZ-2493:
----------------------------------------

Also, you don't need to comment your changes. We have enough tools for doing that (compare vesions, etc.). 2 reasons here
# it makes harder to review the code
#  it clutters the code afterward

Better are our contributors better is our code ;)

Thanks

> ECommerce - product detail: Centre screenlet drops below the lowest existing screenlet
> --------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2493
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2493
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Release Branch 9.04
>            Reporter: Torstein Hegbom
>             Fix For: Release Branch 9.04
>
>         Attachments: ecommerce-product-detail.patch, order-product-detail.patch
>
>
> The centre screenlet seems to not to have enouch space (in the x-direction) for the last screenlet added (product detail), and it drops below the lowest existing screenlet.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12769874#action_12769874 ]

Jacques Le Roux commented on OFBIZ-2493:
----------------------------------------

Hi Torstein,

About my comment above, I guess you did not update your local copy. When creating patches you need to build them from an updated local copy. If you don't want to update yours, simply made a fresch checkout and apply your changes againt it, review them and then contribute

Thanks

> ECommerce - product detail: Centre screenlet drops below the lowest existing screenlet
> --------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2493
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2493
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Release Branch 9.04
>            Reporter: Torstein Hegbom
>             Fix For: Release Branch 9.04
>
>         Attachments: ecommerce-product-detail.patch, order-product-detail.patch
>
>
> The centre screenlet seems to not to have enouch space (in the x-direction) for the last screenlet added (product detail), and it drops below the lowest existing screenlet.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Torstein Hegbom updated OFBIZ-2493:
-----------------------------------

    Attachment:     (was: ecommerce-product-detail.patch)

> ECommerce - product detail: Centre screenlet drops below the lowest existing screenlet
> --------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2493
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2493
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Release Branch 9.04
>            Reporter: Torstein Hegbom
>             Fix For: Release Branch 9.04
>
>         Attachments: order-product-detail.patch
>
>
> The centre screenlet seems to not to have enouch space (in the x-direction) for the last screenlet added (product detail), and it drops below the lowest existing screenlet.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Torstein Hegbom updated OFBIZ-2493:
-----------------------------------

    Attachment: order-product-detail.patch
                ecommerce-product-detail.patch

> ECommerce - product detail: Centre screenlet drops below the lowest existing screenlet
> --------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2493
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2493
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Release Branch 9.04
>            Reporter: Torstein Hegbom
>             Fix For: Release Branch 9.04
>
>         Attachments: ecommerce-product-detail.patch, order-product-detail.patch
>
>
> The centre screenlet seems to not to have enouch space (in the x-direction) for the last screenlet added (product detail), and it drops below the lowest existing screenlet.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Torstein Hegbom updated OFBIZ-2493:
-----------------------------------

    Attachment:     (was: order-product-detail.patch)

> ECommerce - product detail: Centre screenlet drops below the lowest existing screenlet
> --------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2493
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2493
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Release Branch 9.04
>            Reporter: Torstein Hegbom
>             Fix For: Release Branch 9.04
>
>         Attachments: ecommerce-product-detail.patch, order-product-detail.patch
>
>
> The centre screenlet seems to not to have enouch space (in the x-direction) for the last screenlet added (product detail), and it drops below the lowest existing screenlet.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12770024#action_12770024 ]

Torstein Hegbom commented on OFBIZ-2493:
----------------------------------------

The changes are made, but the testing still remains.  We are working hard on other development at the moment, but we will get back and test this as soon as possible.

> ECommerce - product detail: Centre screenlet drops below the lowest existing screenlet
> --------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2493
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2493
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Release Branch 9.04
>            Reporter: Torstein Hegbom
>             Fix For: Release Branch 9.04
>
>         Attachments: ecommerce-product-detail.patch, order-product-detail.patch
>
>
> The centre screenlet seems to not to have enouch space (in the x-direction) for the last screenlet added (product detail), and it drops below the lowest existing screenlet.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.