[jira] Created: (OFBIZ-2527) When editing items, Promotion Codes are getting deleted when we click Update Items.

[Nicolas Malin (Jira)]

When editing items, Promotion Codes are getting deleted when we click Update Items.
-----------------------------------------------------------------------------------

                 Key: OFBIZ-2527
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2527
             Project: OFBiz
          Issue Type: Improvement
          Components: order
    Affects Versions: SVN trunk
            Reporter: Chirag Manocha
             Fix For: SVN trunk


When edit items from order view screen and clicks on update items, the promotion codes applied at the time of order creation, gets deleted from the order.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chirag Manocha updated OFBIZ-2527:
----------------------------------

    Attachment: PromotionFix_OFBiz-2527.patch

Here is the patch for the same.
Work done :-
1) Saved record for the promotion code in OrderProductPromoCode entity for further use.
2) Fixed the issue by reapplying the promotion while Recalculating Cart.
3) On deletion of promotion, deleted record from OrderProductPromoCode entity. This is done in deleteOrderAdjustment service because OrderProductPromoCode record should be deleted when order adjustment of type promotion and have promotion code gets deleted.

Special Thanks to Ratnesh Upadhyay

Thanks
--Chirag Manocha

> When editing items, Promotion Codes are getting deleted when we click Update Items.
> -----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2527
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2527
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Chirag Manocha
>             Fix For: SVN trunk
>
>         Attachments: PromotionFix_OFBiz-2527.patch
>
>
> When edit items from order view screen and clicks on update items, the promotion codes applied at the time of order creation, gets deleted from the order.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chirag Manocha updated OFBIZ-2527:
----------------------------------

    Attachment: PromotionFix_OFBiz-2527.patch

I got a problem that for promotion in which discount on shipping and handling charges is not applying on clicking update items.

For this I just called doPromotion method after saveUpdatedCartToOrder method in OrderServices.java

Regards
--
Chirag Manocha

> When editing items, Promotion Codes are getting deleted when we click Update Items.
> -----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2527
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2527
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Chirag Manocha
>             Fix For: SVN trunk
>
>         Attachments: PromotionFix_OFBiz-2527.patch, PromotionFix_OFBiz-2527.patch
>
>
> When edit items from order view screen and clicks on update items, the promotion codes applied at the time of order creation, gets deleted from the order.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chirag Manocha updated OFBIZ-2527:
----------------------------------

    Attachment: PromotionFix_OFBiz-2527.patch

Minor fix in previous patch.

Regards
--
Chirag Manocha

> When editing items, Promotion Codes are getting deleted when we click Update Items.
> -----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2527
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2527
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Chirag Manocha
>             Fix For: SVN trunk
>
>         Attachments: PromotionFix_OFBiz-2527.patch, PromotionFix_OFBiz-2527.patch, PromotionFix_OFBiz-2527.patch
>
>
> When edit items from order view screen and clicks on update items, the promotion codes applied at the time of order creation, gets deleted from the order.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12715573#action_12715573 ]

Vince Clark commented on OFBIZ-2527:
------------------------------------

Should this be classified as a bug and applied to release 09.04?

Also, are you re-running promo rules or just saving the previous promotions applied? Seems to me that it should re-run the rules since items changed.

> When editing items, Promotion Codes are getting deleted when we click Update Items.
> -----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2527
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2527
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Chirag Manocha
>             Fix For: SVN trunk
>
>         Attachments: PromotionFix_OFBiz-2527.patch, PromotionFix_OFBiz-2527.patch, PromotionFix_OFBiz-2527.patch
>
>
> When edit items from order view screen and clicks on update items, the promotion codes applied at the time of order creation, gets deleted from the order.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12715864#action_12715864 ]

Chirag Manocha commented on OFBIZ-2527:
---------------------------------------

No this is improvement in existing functionality and this can go in release 9.04 also but i am not sure about it.

We are re-applying the customize promotion, but in existing scenario its getting lost after applied once if any one edit the order.

> When editing items, Promotion Codes are getting deleted when we click Update Items.
> -----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2527
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2527
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Chirag Manocha
>             Fix For: SVN trunk
>
>         Attachments: PromotionFix_OFBiz-2527.patch, PromotionFix_OFBiz-2527.patch, PromotionFix_OFBiz-2527.patch
>
>
> When edit items from order view screen and clicks on update items, the promotion codes applied at the time of order creation, gets deleted from the order.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ratnesh Upadhyay updated OFBIZ-2527:
------------------------------------

    Attachment: PromotionFix_OFBiz-2527.patch

Functional reviewed and tested patch submitted by Chirag. Fixed an issue by adding existence check and also done some small improvements. Uploaded updated/tested patch on issue.

--
Ratnesh Upadhyay

> When editing items, Promotion Codes are getting deleted when we click Update Items.
> -----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2527
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2527
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Chirag Manocha
>             Fix For: SVN trunk
>
>         Attachments: PromotionFix_OFBiz-2527.patch, PromotionFix_OFBiz-2527.patch, PromotionFix_OFBiz-2527.patch, PromotionFix_OFBiz-2527.patch
>
>
> When edit items from order view screen and clicks on update items, the promotion codes applied at the time of order creation, gets deleted from the order.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashish Vijaywargiya reassigned OFBIZ-2527:
------------------------------------------

    Assignee: Ashish Vijaywargiya

> When editing items, Promotion Codes are getting deleted when we click Update Items.
> -----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2527
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2527
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Chirag Manocha
>            Assignee: Ashish Vijaywargiya
>             Fix For: SVN trunk
>
>         Attachments: PromotionFix_OFBiz-2527.patch, PromotionFix_OFBiz-2527.patch, PromotionFix_OFBiz-2527.patch, PromotionFix_OFBiz-2527.patch
>
>
> When edit items from order view screen and clicks on update items, the promotion codes applied at the time of order creation, gets deleted from the order.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashish Vijaywargiya closed OFBIZ-2527.
--------------------------------------

       Resolution: Fixed
    Fix Version/s: Release Branch 9.04

Thanks Ratnesh & Chirag for your contribution.
Your changes are in trunk at rev: 783369 & 783374 (trunk and RB9.04 respectively)

> When editing items, Promotion Codes are getting deleted when we click Update Items.
> -----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2527
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2527
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Chirag Manocha
>            Assignee: Ashish Vijaywargiya
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: PromotionFix_OFBiz-2527.patch, PromotionFix_OFBiz-2527.patch, PromotionFix_OFBiz-2527.patch, PromotionFix_OFBiz-2527.patch
>
>
> When edit items from order view screen and clicks on update items, the promotion codes applied at the time of order creation, gets deleted from the order.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12749741#action_12749741 ]

Wickersheimer Jeremy commented on OFBIZ-2527:
---------------------------------------------

I think the OrderProductPromoCode entity is not defined in RB9.04, it seems it was only added in trunk in rev 778273

> When editing items, Promotion Codes are getting deleted when we click Update Items.
> -----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2527
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2527
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Chirag Manocha
>            Assignee: Ashish Vijaywargiya
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: PromotionFix_OFBiz-2527.patch, PromotionFix_OFBiz-2527.patch, PromotionFix_OFBiz-2527.patch, PromotionFix_OFBiz-2527.patch
>
>
> When edit items from order view screen and clicks on update items, the promotion codes applied at the time of order creation, gets deleted from the order.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12751018#action_12751018 ]

Jacques Le Roux commented on OFBIZ-2527:
----------------------------------------

Jeremy is right, I think we should revert  r783374

> When editing items, Promotion Codes are getting deleted when we click Update Items.
> -----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2527
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2527
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Chirag Manocha
>            Assignee: Ashish Vijaywargiya
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: PromotionFix_OFBiz-2527.patch, PromotionFix_OFBiz-2527.patch, PromotionFix_OFBiz-2527.patch, PromotionFix_OFBiz-2527.patch
>
>
> When edit items from order view screen and clicks on update items, the promotion codes applied at the time of order creation, gets deleted from the order.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reopened OFBIZ-2527:
------------------------------------

> When editing items, Promotion Codes are getting deleted when we click Update Items.
> -----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2527
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2527
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Chirag Manocha
>            Assignee: Ashish Vijaywargiya
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: PromotionFix_OFBiz-2527.patch, PromotionFix_OFBiz-2527.patch, PromotionFix_OFBiz-2527.patch, PromotionFix_OFBiz-2527.patch
>
>
> When edit items from order view screen and clicks on update items, the promotion codes applied at the time of order creation, gets deleted from the order.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12751024#action_12751024 ]

Chirag Manocha commented on OFBIZ-2527:
---------------------------------------

Yes we can revert r783374, and this bug will exists in current release.

> When editing items, Promotion Codes are getting deleted when we click Update Items.
> -----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2527
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2527
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Chirag Manocha
>            Assignee: Ashish Vijaywargiya
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: PromotionFix_OFBiz-2527.patch, PromotionFix_OFBiz-2527.patch, PromotionFix_OFBiz-2527.patch, PromotionFix_OFBiz-2527.patch
>
>
> When edit items from order view screen and clicks on update items, the promotion codes applied at the time of order creation, gets deleted from the order.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12751025#action_12751025 ]

Wickersheimer Jeremy commented on OFBIZ-2527:
---------------------------------------------

It seems to be a bug fix, so perhaps you could just add r778273 in 09.04; and test it again on 09.04. r778273 only adds the entity definition so it should be a simple change.
But i would not mind if it gets removed, i am just trying to follow the 09.04 branch as close as possible.

> When editing items, Promotion Codes are getting deleted when we click Update Items.
> -----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2527
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2527
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Chirag Manocha
>            Assignee: Ashish Vijaywargiya
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: PromotionFix_OFBiz-2527.patch, PromotionFix_OFBiz-2527.patch, PromotionFix_OFBiz-2527.patch, PromotionFix_OFBiz-2527.patch
>
>
> When edit items from order view screen and clicks on update items, the promotion codes applied at the time of order creation, gets deleted from the order.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12751034#action_12751034 ]

Jacques Le Roux commented on OFBIZ-2527:
----------------------------------------

You beat me on it Jeremy, I agree sounds better than revert IMO, thanks for comment Chirag.

> When editing items, Promotion Codes are getting deleted when we click Update Items.
> -----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2527
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2527
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Chirag Manocha
>            Assignee: Ashish Vijaywargiya
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: PromotionFix_OFBiz-2527.patch, PromotionFix_OFBiz-2527.patch, PromotionFix_OFBiz-2527.patch, PromotionFix_OFBiz-2527.patch
>
>
> When edit items from order view screen and clicks on update items, the promotion codes applied at the time of order creation, gets deleted from the order.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12751911#action_12751911 ]

Jacques Le Roux commented on OFBIZ-2527:
----------------------------------------

I'd like to have David's opinion on this since he commited r778273, David ?

> When editing items, Promotion Codes are getting deleted when we click Update Items.
> -----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2527
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2527
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Chirag Manocha
>            Assignee: Ashish Vijaywargiya
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: PromotionFix_OFBiz-2527.patch, PromotionFix_OFBiz-2527.patch, PromotionFix_OFBiz-2527.patch, PromotionFix_OFBiz-2527.patch
>
>
> When edit items from order view screen and clicks on update items, the promotion codes applied at the time of order creation, gets deleted from the order.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12751953#action_12751953 ]

David E. Jones commented on OFBIZ-2527:
---------------------------------------

Sorry, I haven't touched any of this stuff. If the changes are tested, really tested and not just assuming stuff will work, then there is nothing I could do that would help.

As for the branch... I think the point of it is pretty clear.

> When editing items, Promotion Codes are getting deleted when we click Update Items.
> -----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2527
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2527
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Chirag Manocha
>            Assignee: Ashish Vijaywargiya
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: PromotionFix_OFBiz-2527.patch, PromotionFix_OFBiz-2527.patch, PromotionFix_OFBiz-2527.patch, PromotionFix_OFBiz-2527.patch
>
>
> When edit items from order view screen and clicks on update items, the promotion codes applied at the time of order creation, gets deleted from the order.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12751955#action_12751955 ]

Jacques Le Roux commented on OFBIZ-2527:
----------------------------------------

Hi David,

Sorry but I'm not sure to getting you about the branche.
# If we revert r783374, a bug will stay as Chirag mentionned
# If we put r778273 we introduce changes that are needed for really fixing the bug but are actually new functionnalites (new Entities)

I guess you mean to do 2 as long as everything has been tested and OK, correct ?

> When editing items, Promotion Codes are getting deleted when we click Update Items.
> -----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2527
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2527
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Chirag Manocha
>            Assignee: Ashish Vijaywargiya
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: PromotionFix_OFBiz-2527.patch, PromotionFix_OFBiz-2527.patch, PromotionFix_OFBiz-2527.patch, PromotionFix_OFBiz-2527.patch
>
>
> When edit items from order view screen and clicks on update items, the promotion codes applied at the time of order creation, gets deleted from the order.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-2527.
----------------------------------

    Resolution: Fixed

I finally decided to backport r778273 in R9.04, done at r814793

> When editing items, Promotion Codes are getting deleted when we click Update Items.
> -----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2527
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2527
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Chirag Manocha
>            Assignee: Ashish Vijaywargiya
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: PromotionFix_OFBiz-2527.patch, PromotionFix_OFBiz-2527.patch, PromotionFix_OFBiz-2527.patch, PromotionFix_OFBiz-2527.patch
>
>
> When edit items from order view screen and clicks on update items, the promotion codes applied at the time of order creation, gets deleted from the order.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.