Deprecated warning for xerces
----------------------------- Key: OFBIZ-2532 URL: https://issues.apache.org/jira/browse/OFBIZ-2532 Project: OFBiz Issue Type: Bug Affects Versions: SVN trunk Reporter: Harmeet Bedi Fix For: SVN trunk Build looks ugly with these. 2 spots are CCPaymentServices and UtilXml Attaching svn diff patch for those. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[ https://issues.apache.org/jira/browse/OFBIZ-2532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Harmeet Bedi updated OFBIZ-2532: -------------------------------- Attachment: CCPaymentServices.java.diff > Deprecated warning for xerces > ----------------------------- > > Key: OFBIZ-2532 > URL: https://issues.apache.org/jira/browse/OFBIZ-2532 > Project: OFBiz > Issue Type: Bug > Affects Versions: SVN trunk > Reporter: Harmeet Bedi > Fix For: SVN trunk > > Attachments: CCPaymentServices.java.diff > > > Build looks ugly with these. > 2 spots are CCPaymentServices and UtilXml > Attaching svn diff patch for those. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Harmeet Bedi updated OFBIZ-2532: -------------------------------- Attachment: UtilXml.java.diff > Deprecated warning for xerces > ----------------------------- > > Key: OFBIZ-2532 > URL: https://issues.apache.org/jira/browse/OFBIZ-2532 > Project: OFBiz > Issue Type: Bug > Affects Versions: SVN trunk > Reporter: Harmeet Bedi > Fix For: SVN trunk > > Attachments: CCPaymentServices.java.diff, UtilXml.java.diff > > > Build looks ugly with these. > 2 spots are CCPaymentServices and UtilXml > Attaching svn diff patch for those. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Harmeet Bedi updated OFBIZ-2532: -------------------------------- Attachment: (was: CCPaymentServices.java.diff) > Deprecated warning for xerces > ----------------------------- > > Key: OFBIZ-2532 > URL: https://issues.apache.org/jira/browse/OFBIZ-2532 > Project: OFBiz > Issue Type: Bug > Affects Versions: SVN trunk > Reporter: Harmeet Bedi > Fix For: SVN trunk > > Attachments: CCPaymentServices.java.diff, UtilXml.java.diff > > > Build looks ugly with these. > 2 spots are CCPaymentServices and UtilXml > Attaching svn diff patch for those. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Harmeet Bedi updated OFBIZ-2532: -------------------------------- Attachment: CCPaymentServices.java.diff > Deprecated warning for xerces > ----------------------------- > > Key: OFBIZ-2532 > URL: https://issues.apache.org/jira/browse/OFBIZ-2532 > Project: OFBiz > Issue Type: Bug > Affects Versions: SVN trunk > Reporter: Harmeet Bedi > Fix For: SVN trunk > > Attachments: CCPaymentServices.java.diff, UtilXml.java.diff > > > Build looks ugly with these. > 2 spots are CCPaymentServices and UtilXml > Attaching svn diff patch for those. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Harmeet Bedi updated OFBIZ-2532: -------------------------------- Attachment: (was: UtilXml.java.diff) > Deprecated warning for xerces > ----------------------------- > > Key: OFBIZ-2532 > URL: https://issues.apache.org/jira/browse/OFBIZ-2532 > Project: OFBiz > Issue Type: Bug > Affects Versions: SVN trunk > Reporter: Harmeet Bedi > Fix For: SVN trunk > > Attachments: CCPaymentServices.java.diff > > > Build looks ugly with these. > 2 spots are CCPaymentServices and UtilXml > Attaching svn diff patch for those. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum reassigned OFBIZ-2532: ---------------------------------- Assignee: Adrian Crum > Deprecated warning for xerces > ----------------------------- > > Key: OFBIZ-2532 > URL: https://issues.apache.org/jira/browse/OFBIZ-2532 > Project: OFBiz > Issue Type: Bug > Affects Versions: SVN trunk > Reporter: Harmeet Bedi > Assignee: Adrian Crum > Fix For: SVN trunk > > Attachments: CCPaymentServices.java.diff > > > Build looks ugly with these. > 2 spots are CCPaymentServices and UtilXml > Attaching svn diff patch for those. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12713591#action_12713591 ] Adrian Crum commented on OFBIZ-2532: ------------------------------------ Harmeet, UtilXml.java has JAXP TrAX methods to accommodate this deprecation. You could make this patch much simpler by using the functionality that already exists in the framework. -Adrian > Deprecated warning for xerces > ----------------------------- > > Key: OFBIZ-2532 > URL: https://issues.apache.org/jira/browse/OFBIZ-2532 > Project: OFBiz > Issue Type: Bug > Affects Versions: SVN trunk > Reporter: Harmeet Bedi > Fix For: SVN trunk > > Attachments: CCPaymentServices.java.diff > > > Build looks ugly with these. > 2 spots are CCPaymentServices and UtilXml > Attaching svn diff patch for those. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Harmeet Bedi updated OFBIZ-2532: -------------------------------- Attachment: UtilXml.diff Adrian, Attaching patch removed writeXmlDocument(OutputStream os, Element element, OutputFormat format) found dependency and changed to equivalent writeXmlDocument(Node node, OutputStream os, String encoding, boolean omitXmlDeclaration, boolean indent, int indentAmount) made sure there were no other dependencies. > Deprecated warning for xerces > ----------------------------- > > Key: OFBIZ-2532 > URL: https://issues.apache.org/jira/browse/OFBIZ-2532 > Project: OFBiz > Issue Type: Bug > Affects Versions: SVN trunk > Reporter: Harmeet Bedi > Assignee: Adrian Crum > Fix For: SVN trunk > > Attachments: CCPaymentServices.java.diff, UtilXml.diff > > > Build looks ugly with these. > 2 spots are CCPaymentServices and UtilXml > Attaching svn diff patch for those. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12722460#action_12722460 ] Adrian Crum commented on OFBIZ-2532: ------------------------------------ That's not the fix I had in mind. There is nothing in UtilXml.java that needs to be changed. It's the applications that need to be changed. Any applications that use the deprecated Xerces classes should use the new UtilXml JAXP TrAX methods or DOM 3 methods. I will not commit any patch that modifies UtilXml - there is nothing wrong with it. The deprecation warnings it generates are expected and intentional. Once all applications have been converted, and there is time for the user base to update their code, THEN we can change UtilXml.java. > Deprecated warning for xerces > ----------------------------- > > Key: OFBIZ-2532 > URL: https://issues.apache.org/jira/browse/OFBIZ-2532 > Project: OFBiz > Issue Type: Bug > Affects Versions: SVN trunk > Reporter: Harmeet Bedi > Assignee: Adrian Crum > Fix For: SVN trunk > > Attachments: CCPaymentServices.java.diff, UtilXml.diff > > > Build looks ugly with these. > 2 spots are CCPaymentServices and UtilXml > Attaching svn diff patch for those. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12722468#action_12722468 ] Harmeet Bedi commented on OFBIZ-2532: ------------------------------------- regd. 'Once all applications have been converted,' I think trunk is already there. I looked in java, groovy, ftl and the only reference was in UtilXml itself from writeXmlDocument(OutputStream os, Element element). Changed it and suggested removal of writeXmlDocument(OutputStream os, Element element, OutputFormat format) > Deprecated warning for xerces > ----------------------------- > > Key: OFBIZ-2532 > URL: https://issues.apache.org/jira/browse/OFBIZ-2532 > Project: OFBiz > Issue Type: Bug > Affects Versions: SVN trunk > Reporter: Harmeet Bedi > Assignee: Adrian Crum > Fix For: SVN trunk > > Attachments: CCPaymentServices.java.diff, UtilXml.diff > > > Build looks ugly with these. > 2 spots are CCPaymentServices and UtilXml > Attaching svn diff patch for those. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12722475#action_12722475 ] Adrian Crum commented on OFBIZ-2532: ------------------------------------ Harmeet, I really appreciate your interest in contributing to the project. We could use all the help we can get! It takes some patience to become a good contributor. All of us had to go through a learning process - a process that might have included rejected patches. I said all of that because I don't want you to become discouraged. Now, let's step back for a moment and take an honest look at this Jira issue. It's about compiler deprecation warnings. Deprecation warnings are not bugs, they are not critical, and the world won't come to an end because of them. They are simply stating "something that exists today might not exist in the future." From a developer's perspective, they are a minor annoyance. Your solution to this annoyance is to remove framework methods that hundreds of OFBiz installations might be counting on. My solution is to deprecate those framework methods, and encourage the OFBiz developers to update the applications to use the newer methods, plus give the user base time to update their modifications that use those methods. I found 7 references to the deprecated Xerces class - org.apache.xml.serialize.OutputFormat. Those references need to be fixed, and they need to be tested. As I stated at the start, those references should be utilizing the new UtilXml JAXP TrAX methods or DOM 3 methods - so situations like this don't happen in the future. What I said earlier still stands. If you want to contribute a patch, then contribute a patch that fixes the applications, not UtilXml. > Deprecated warning for xerces > ----------------------------- > > Key: OFBIZ-2532 > URL: https://issues.apache.org/jira/browse/OFBIZ-2532 > Project: OFBiz > Issue Type: Bug > Affects Versions: SVN trunk > Reporter: Harmeet Bedi > Assignee: Adrian Crum > Fix For: SVN trunk > > Attachments: CCPaymentServices.java.diff, UtilXml.diff > > > Build looks ugly with these. > 2 spots are CCPaymentServices and UtilXml > Attaching svn diff patch for those. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12722491#action_12722491 ] Adrian Crum commented on OFBIZ-2532: ------------------------------------ For any committers that might be "listening in" - feel free to commit any application (non UtilXml) patches that pass your testing. I assigned this issue to me because I was the one who upgraded the Xerces library and provided the new UtilXml methods to replace the deprecated classes. I don't have access to the third party service providers that the applications in question (the ones using the deprecated classes) are using - so I'm relying on others to test them with the new UtilXml methods. > Deprecated warning for xerces > ----------------------------- > > Key: OFBIZ-2532 > URL: https://issues.apache.org/jira/browse/OFBIZ-2532 > Project: OFBiz > Issue Type: Bug > Affects Versions: SVN trunk > Reporter: Harmeet Bedi > Assignee: Adrian Crum > Fix For: SVN trunk > > Attachments: CCPaymentServices.java.diff, UtilXml.diff > > > Build looks ugly with these. > 2 spots are CCPaymentServices and UtilXml > Attaching svn diff patch for those. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum closed OFBIZ-2532. ------------------------------ Resolution: Fixed Fixed in rev 791212. > Deprecated warning for xerces > ----------------------------- > > Key: OFBIZ-2532 > URL: https://issues.apache.org/jira/browse/OFBIZ-2532 > Project: OFBiz > Issue Type: Bug > Affects Versions: SVN trunk > Reporter: Harmeet Bedi > Assignee: Adrian Crum > Fix For: SVN trunk > > Attachments: CCPaymentServices.java.diff, UtilXml.diff > > > Build looks ugly with these. > 2 spots are CCPaymentServices and UtilXml > Attaching svn diff patch for those. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
Free forum by Nabble | Edit this page |