OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-2556) createUpdateEmailAddress service should be renamed to createUpdatePartyEmailAddress remove the effort of updating contactMech infoString

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

7 messages Options

Nicolas Malin (Jira)

[jira] Created: (OFBIZ-2556) createUpdateEmailAddress service should be renamed to createUpdatePartyEmailAddress remove the effort of updating contactMech infoString

createUpdateEmailAddress service should be renamed to createUpdatePartyEmailAddress remove the effort of updating contactMech infoString
----------------------------------------------------------------------------------------------------------------------------------------

Key: OFBIZ-2556
URL: https://issues.apache.org/jira/browse/OFBIZ-2556
Project: OFBiz
Issue Type: Improvement
Components: party
Reporter: Anil K Patel
Priority: Minor

createUpdateEmilAddress service located in PartyServices.xml file has various issues.
1) Services with similar goals are located in PartyContactMechService.xml file. Move this service to PartyContactMechServices.xml file as well.
2) Service associates contact mech with party as well so this service should be renamed to createUpdatePartyEmailAddress.
3) This service duplicates effort of setting emailAddress in infoString field. Remove it.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Assigned: (OFBIZ-2556) createUpdateEmailAddress service should be renamed to createUpdatePartyEmailAddress remove the effort of updating contactMech infoString

[ https://issues.apache.org/jira/browse/OFBIZ-2556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anil K Patel reassigned OFBIZ-2556:
-----------------------------------

Assignee: Anil K Patel

> createUpdateEmailAddress service should be renamed to createUpdatePartyEmailAddress remove the effort of updating contactMech infoString
> ----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2556
> URL: https://issues.apache.org/jira/browse/OFBIZ-2556
> Project: OFBiz
> Issue Type: Improvement
> Components: party
> Reporter: Anil K Patel
> Assignee: Anil K Patel
> Priority: Minor
>
> createUpdateEmilAddress service located in PartyServices.xml file has various issues.
> 1) Services with similar goals are located in PartyContactMechService.xml file. Move this service to PartyContactMechServices.xml file as well.
> 2) Service associates contact mech with party as well so this service should be renamed to createUpdatePartyEmailAddress.
> 3) This service duplicates effort of setting emailAddress in infoString field. Remove it.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2556) createUpdateEmailAddress service should be renamed to createUpdatePartyEmailAddress remove the effort of updating contactMech infoString

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12714928#action_12714928 ]

BJ Freeman commented on OFBIZ-2556:
-----------------------------------

I am wondering if we should not follow the same process of depreciating a service as we do with methods.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-2556) createUpdateEmailAddress service should be renamed to createUpdatePartyEmailAddress remove the effort of updating contactMech infoString

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jyotsna Rathore updated OFBIZ-2556:
-----------------------------------

Attachment: CreateUpdatePartyEmailAddress.patch

Renamed it to createUpdatePartyEmailAddress,
Moved this service to PartyContactMechServices.xml,
Removed duplicates effort of setting emailAddress in infoString field.

> createUpdateEmailAddress service should be renamed to createUpdatePartyEmailAddress remove the effort of updating contactMech infoString
> ----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2556
> URL: https://issues.apache.org/jira/browse/OFBIZ-2556
> Project: OFBiz
> Issue Type: Improvement
> Components: party
> Reporter: Anil K Patel
> Assignee: Anil K Patel
> Priority: Minor
> Attachments: CreateUpdatePartyEmailAddress.patch
>
>
> createUpdateEmilAddress service located in PartyServices.xml file has various issues.
> 1) Services with similar goals are located in PartyContactMechService.xml file. Move this service to PartyContactMechServices.xml file as well.
> 2) Service associates contact mech with party as well so this service should be renamed to createUpdatePartyEmailAddress.
> 3) This service duplicates effort of setting emailAddress in infoString field. Remove it.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Assigned: (OFBIZ-2556) createUpdateEmailAddress service should be renamed to createUpdatePartyEmailAddress remove the effort of updating contactMech infoString

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashish Vijaywargiya reassigned OFBIZ-2556:
------------------------------------------

Assignee: Ashish Vijaywargiya (was: Anil K Patel)

> createUpdateEmailAddress service should be renamed to createUpdatePartyEmailAddress remove the effort of updating contactMech infoString
> ----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2556
> URL: https://issues.apache.org/jira/browse/OFBIZ-2556
> Project: OFBiz
> Issue Type: Improvement
> Components: party
> Reporter: Anil K Patel
> Assignee: Ashish Vijaywargiya
> Priority: Minor
> Attachments: CreateUpdatePartyEmailAddress.patch
>
>
> createUpdateEmilAddress service located in PartyServices.xml file has various issues.
> 1) Services with similar goals are located in PartyContactMechService.xml file. Move this service to PartyContactMechServices.xml file as well.
> 2) Service associates contact mech with party as well so this service should be renamed to createUpdatePartyEmailAddress.
> 3) This service duplicates effort of setting emailAddress in infoString field. Remove it.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-2556) createUpdateEmailAddress service should be renamed to createUpdatePartyEmailAddress remove the effort of updating contactMech infoString

In reply to this post by Nicolas Malin (Jira)

> createUpdateEmailAddress service should be renamed to createUpdatePartyEmailAddress remove the effort of updating contactMech infoString
> ----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2556
> URL: https://issues.apache.org/jira/browse/OFBIZ-2556
> Project: OFBiz
> Issue Type: Improvement
> Components: party
> Reporter: Anil K Patel
> Assignee: Ashish Vijaywargiya
> Priority: Minor
> Attachments: CreateUpdatePartyEmailAddress.patch, CreateUpdatePartyEmailAddress.patch
>
>
> createUpdateEmilAddress service located in PartyServices.xml file has various issues.
> 1) Services with similar goals are located in PartyContactMechService.xml file. Move this service to PartyContactMechServices.xml file as well.
> 2) Service associates contact mech with party as well so this service should be renamed to createUpdatePartyEmailAddress.
> 3) This service duplicates effort of setting emailAddress in infoString field. Remove it.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Closed: (OFBIZ-2556) createUpdateEmailAddress service should be renamed to createUpdatePartyEmailAddress remove the effort of updating contactMech infoString

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashish Vijaywargiya closed OFBIZ-2556.
--------------------------------------

Resolution: Fixed
Fix Version/s: SVN trunk

Thanks Jyotsna!
Changes are in trunk at revision 785194.

--
Ashish Vijaywargiya

> createUpdateEmailAddress service should be renamed to createUpdatePartyEmailAddress remove the effort of updating contactMech infoString
> ----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2556
> URL: https://issues.apache.org/jira/browse/OFBIZ-2556
> Project: OFBiz
> Issue Type: Improvement
> Components: party
> Reporter: Anil K Patel
> Assignee: Ashish Vijaywargiya
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: CreateUpdatePartyEmailAddress.patch, CreateUpdatePartyEmailAddress.patch
>
>
> createUpdateEmilAddress service located in PartyServices.xml file has various issues.
> 1) Services with similar goals are located in PartyContactMechService.xml file. Move this service to PartyContactMechServices.xml file as well.
> 2) Service associates contact mech with party as well so this service should be renamed to createUpdatePartyEmailAddress.
> 3) This service duplicates effort of setting emailAddress in infoString field. Remove it.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.