OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-2567) Entity VirtualProduct missing

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

23 messages Options

Nicolas Malin (Jira)

[jira] Created: (OFBIZ-2567) Entity VirtualProduct missing

Entity VirtualProduct missing
-----------------------------

Key: OFBIZ-2567
URL: https://issues.apache.org/jira/browse/OFBIZ-2567
Project: OFBiz
Issue Type: Bug
Components: product
Affects Versions: Release Branch 9.04
Environment: OFBiz 9.04.781707
Reporter: Jan Valkovic

Here https://localhost:8443/catalog/control/quickCreateVirtualWithVariants is occured this:

2009-06-04 14:23:56,055 (http-0.0.0.0-8443-3) [ ControlServlet.java:299:INFO ] [[[ApplyFeaturesToProduct] Request Done- total:1.456,since last([ApplyFeaturesToP...):1.456]]
2009-06-04 14:24:02,304 (http-0.0.0.0-8443-4) [ ControlServlet.java:130:INFO ] [[[quickCreateVirtualWithVariants] Request Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
2009-06-04 14:24:02,309 (http-0.0.0.0-8443-4) [ GenericDelegator.java:398:ERROR]
---- exception report ----------------------------------------------------------
Error getting entity definition from model
Exception: org.ofbiz.entity.GenericModelException
Message: Could not find definition for entity name VirtualProduct
---- stack trace ---------------------------------------------------------------

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-2567) Entity VirtualProduct missing

[ https://issues.apache.org/jira/browse/OFBIZ-2567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jan Valkovic updated OFBIZ-2567:
--------------------------------

Description:
Here https://localhost:8443/catalog/control/quickCreateVirtualWithVariants is occured this:

2009-06-04 14:23:56,055 (http-0.0.0.0-8443-3) [ ControlServlet.java:299:INFO ] [[[ApplyFeaturesToProduct] Request Done- total:1.456,since last([ApplyFeaturesToP...):1.456]]
2009-06-04 14:24:02,304 (http-0.0.0.0-8443-4) [ ControlServlet.java:130:INFO ] [[[quickCreateVirtualWithVariants] Request Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
2009-06-04 14:24:02,309 (http-0.0.0.0-8443-4) [ GenericDelegator.java:398:ERROR]
---- exception report ----------------------------------------------------------
Error getting entity definition from model
Exception: org.ofbiz.entity.GenericModelException
Message: Could not find definition for entity name VirtualProduct
---- stack trace ---------------------------------------------------------------

EDIT:
Stack trace ...

org.ofbiz.entity.GenericModelException: Could not find definition for entity name VirtualProduct
org.ofbiz.entity.model.ModelReader.getModelEntity(ModelReader.java:451)
org.ofbiz.entity.GenericDelegator.getModelEntity(GenericDelegator.java:396)
org.ofbiz.entity.GenericDelegator.getNextSeqIdLong(GenericDelegator.java:3166)
org.ofbiz.entity.GenericDelegator.getNextSeqId(GenericDelegator.java:3119)
org.ofbiz.entity.GenericDelegator.getNextSeqId(GenericDelegator.java:3109)
org.ofbiz.product.product.ProductServices.quickCreateVirtualWithVariants(ProductServices.java:743)

was:
Here https://localhost:8443/catalog/control/quickCreateVirtualWithVariants is occured this:

2009-06-04 14:23:56,055 (http-0.0.0.0-8443-3) [ ControlServlet.java:299:INFO ] [[[ApplyFeaturesToProduct] Request Done- total:1.456,since last([ApplyFeaturesToP...):1.456]]
2009-06-04 14:24:02,304 (http-0.0.0.0-8443-4) [ ControlServlet.java:130:INFO ] [[[quickCreateVirtualWithVariants] Request Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
2009-06-04 14:24:02,309 (http-0.0.0.0-8443-4) [ GenericDelegator.java:398:ERROR]
---- exception report ----------------------------------------------------------
Error getting entity definition from model
Exception: org.ofbiz.entity.GenericModelException
Message: Could not find definition for entity name VirtualProduct
---- stack trace ---------------------------------------------------------------

> Entity VirtualProduct missing
> -----------------------------
>
> Key: OFBIZ-2567
> URL: https://issues.apache.org/jira/browse/OFBIZ-2567
> Project: OFBiz
> Issue Type: Bug
> Components: product
> Affects Versions: Release Branch 9.04
> Environment: OFBiz 9.04.781707
> Reporter: Jan Valkovic
>
> Here https://localhost:8443/catalog/control/quickCreateVirtualWithVariants is occured this:
> 2009-06-04 14:23:56,055 (http-0.0.0.0-8443-3) [ ControlServlet.java:299:INFO ] [[[ApplyFeaturesToProduct] Request Done- total:1.456,since last([ApplyFeaturesToP...):1.456]]
> 2009-06-04 14:24:02,304 (http-0.0.0.0-8443-4) [ ControlServlet.java:130:INFO ] [[[quickCreateVirtualWithVariants] Request Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
> 2009-06-04 14:24:02,309 (http-0.0.0.0-8443-4) [ GenericDelegator.java:398:ERROR]
> ---- exception report ----------------------------------------------------------
> Error getting entity definition from model
> Exception: org.ofbiz.entity.GenericModelException
> Message: Could not find definition for entity name VirtualProduct
> ---- stack trace ---------------------------------------------------------------
> EDIT:
> Stack trace ...
> org.ofbiz.entity.GenericModelException: Could not find definition for entity name VirtualProduct
> org.ofbiz.entity.model.ModelReader.getModelEntity(ModelReader.java:451)
> org.ofbiz.entity.GenericDelegator.getModelEntity(GenericDelegator.java:396)
> org.ofbiz.entity.GenericDelegator.getNextSeqIdLong(GenericDelegator.java:3166)
> org.ofbiz.entity.GenericDelegator.getNextSeqId(GenericDelegator.java:3119)
> org.ofbiz.entity.GenericDelegator.getNextSeqId(GenericDelegator.java:3109)
> org.ofbiz.product.product.ProductServices.quickCreateVirtualWithVariants(ProductServices.java:743)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2567) Entity VirtualProduct missing

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12716846#action_12716846 ]

BJ Freeman commented on OFBIZ-2567:
-----------------------------------

there is no VirtualProduct. that is the correct.

the line refered to
productId = "VP" + delegator.getNextSeqId("VirtualProduct");
so not sure why the message that there is no entity.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2567) Entity VirtualProduct missing

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717246#action_12717246 ]

Jan Valkovic commented on OFBIZ-2567:
-------------------------------------

Problem is here:
org.ofbiz.entity.GenericDelegator.getNextSeqIdLong(GenericDelegator.java:3166)

public Long getNextSeqIdLong(String seqName, long staggerMax) {
(....)
// might be null, but will usually match the entity name
ModelEntity seqModelEntity = this.getModelEntity(seqName);
(....)

ModelEntity for entity "VirtualProduct" does not exists, because there is no entity "VirtualProduct"

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2567) Entity VirtualProduct missing

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717351#action_12717351 ]

BJ Freeman commented on OFBIZ-2567:
-----------------------------------

Ok suggest a patch to make it a warning instead of an error

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2567) Entity VirtualProduct missing

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717393#action_12717393 ]

Jacques Le Roux commented on OFBIZ-2567:
----------------------------------------

Could you please explain

# What you did (including detailed steps to reproduce)
# What you expected to happen
# What actually happened (including exact quotes of error messages, etc)

It seems that you already filled completly only 3d point

Thanks

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Closed: (OFBIZ-2567) Entity VirtualProduct missing

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott Gray closed OFBIZ-2567.
-----------------------------

Resolution: Fixed
Fix Version/s: SVN trunk
Release Branch 9.04
Assignee: Scott Gray

Fixed in trunk r782799 and 9.04 r782805

Thanks for the report Jan

> Entity VirtualProduct missing
> -----------------------------
>
> Key: OFBIZ-2567
> URL: https://issues.apache.org/jira/browse/OFBIZ-2567
> Project: OFBiz
> Issue Type: Bug
> Components: product
> Affects Versions: Release Branch 9.04
> Environment: OFBiz 9.04.781707
> Reporter: Jan Valkovic
> Assignee: Scott Gray
> Fix For: Release Branch 9.04, SVN trunk
>
>
> Here https://localhost:8443/catalog/control/quickCreateVirtualWithVariants is occured this:
> 2009-06-04 14:23:56,055 (http-0.0.0.0-8443-3) [ ControlServlet.java:299:INFO ] [[[ApplyFeaturesToProduct] Request Done- total:1.456,since last([ApplyFeaturesToP...):1.456]]
> 2009-06-04 14:24:02,304 (http-0.0.0.0-8443-4) [ ControlServlet.java:130:INFO ] [[[quickCreateVirtualWithVariants] Request Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
> 2009-06-04 14:24:02,309 (http-0.0.0.0-8443-4) [ GenericDelegator.java:398:ERROR]
> ---- exception report ----------------------------------------------------------
> Error getting entity definition from model
> Exception: org.ofbiz.entity.GenericModelException
> Message: Could not find definition for entity name VirtualProduct
> ---- stack trace ---------------------------------------------------------------
> EDIT:
> Stack trace ...
> org.ofbiz.entity.GenericModelException: Could not find definition for entity name VirtualProduct
> org.ofbiz.entity.model.ModelReader.getModelEntity(ModelReader.java:451)
> org.ofbiz.entity.GenericDelegator.getModelEntity(GenericDelegator.java:396)
> org.ofbiz.entity.GenericDelegator.getNextSeqIdLong(GenericDelegator.java:3166)
> org.ofbiz.entity.GenericDelegator.getNextSeqId(GenericDelegator.java:3119)
> org.ofbiz.entity.GenericDelegator.getNextSeqId(GenericDelegator.java:3109)
> org.ofbiz.product.product.ProductServices.quickCreateVirtualWithVariants(ProductServices.java:743)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2567) Entity VirtualProduct missing

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717491#action_12717491 ]

BJ Freeman commented on OFBIZ-2567:
-----------------------------------

Scott
the code says it can be null but it throws and error. That seems a bug to me.
also since the string is preappended as VP would it not use it own counter?

> Entity VirtualProduct missing
> -----------------------------
>
> Key: OFBIZ-2567
> URL: https://issues.apache.org/jira/browse/OFBIZ-2567
> Project: OFBiz
> Issue Type: Bug
> Components: product
> Affects Versions: Release Branch 9.04
> Environment: OFBiz 9.04.781707
> Reporter: Jan Valkovic
> Assignee: Scott Gray
> Fix For: Release Branch 9.04, SVN trunk
>
>
> Here https://localhost:8443/catalog/control/quickCreateVirtualWithVariants is occured this:
> 2009-06-04 14:23:56,055 (http-0.0.0.0-8443-3) [ ControlServlet.java:299:INFO ] [[[ApplyFeaturesToProduct] Request Done- total:1.456,since last([ApplyFeaturesToP...):1.456]]
> 2009-06-04 14:24:02,304 (http-0.0.0.0-8443-4) [ ControlServlet.java:130:INFO ] [[[quickCreateVirtualWithVariants] Request Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
> 2009-06-04 14:24:02,309 (http-0.0.0.0-8443-4) [ GenericDelegator.java:398:ERROR]
> ---- exception report ----------------------------------------------------------
> Error getting entity definition from model
> Exception: org.ofbiz.entity.GenericModelException
> Message: Could not find definition for entity name VirtualProduct
> ---- stack trace ---------------------------------------------------------------
> EDIT:
> Stack trace ...
> org.ofbiz.entity.GenericModelException: Could not find definition for entity name VirtualProduct
> org.ofbiz.entity.model.ModelReader.getModelEntity(ModelReader.java:451)
> org.ofbiz.entity.GenericDelegator.getModelEntity(GenericDelegator.java:396)
> org.ofbiz.entity.GenericDelegator.getNextSeqIdLong(GenericDelegator.java:3166)
> org.ofbiz.entity.GenericDelegator.getNextSeqId(GenericDelegator.java:3119)
> org.ofbiz.entity.GenericDelegator.getNextSeqId(GenericDelegator.java:3109)
> org.ofbiz.product.product.ProductServices.quickCreateVirtualWithVariants(ProductServices.java:743)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Issue Comment Edited: (OFBIZ-2567) Entity VirtualProduct missing

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717491#action_12717491 ]

BJ Freeman edited comment on OFBIZ-2567 at 6/8/09 5:06 PM:
-----------------------------------------------------------

Scott
the code says it can be null but it throws and error. That seems a bug to me.
also since the string is preappended as VP would it not use it own counter?
Does every counter need to be tied to a entity?

was (Author: bjfreeman):
Scott
the code says it can be null but it throws and error. That seems a bug to me.
also since the string is preappended as VP would it not use it own counter?

> Entity VirtualProduct missing
> -----------------------------
>
> Key: OFBIZ-2567
> URL: https://issues.apache.org/jira/browse/OFBIZ-2567
> Project: OFBiz
> Issue Type: Bug
> Components: product
> Affects Versions: Release Branch 9.04
> Environment: OFBiz 9.04.781707
> Reporter: Jan Valkovic
> Assignee: Scott Gray
> Fix For: Release Branch 9.04, SVN trunk
>
>
> Here https://localhost:8443/catalog/control/quickCreateVirtualWithVariants is occured this:
> 2009-06-04 14:23:56,055 (http-0.0.0.0-8443-3) [ ControlServlet.java:299:INFO ] [[[ApplyFeaturesToProduct] Request Done- total:1.456,since last([ApplyFeaturesToP...):1.456]]
> 2009-06-04 14:24:02,304 (http-0.0.0.0-8443-4) [ ControlServlet.java:130:INFO ] [[[quickCreateVirtualWithVariants] Request Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
> 2009-06-04 14:24:02,309 (http-0.0.0.0-8443-4) [ GenericDelegator.java:398:ERROR]
> ---- exception report ----------------------------------------------------------
> Error getting entity definition from model
> Exception: org.ofbiz.entity.GenericModelException
> Message: Could not find definition for entity name VirtualProduct
> ---- stack trace ---------------------------------------------------------------
> EDIT:
> Stack trace ...
> org.ofbiz.entity.GenericModelException: Could not find definition for entity name VirtualProduct
> org.ofbiz.entity.model.ModelReader.getModelEntity(ModelReader.java:451)
> org.ofbiz.entity.GenericDelegator.getModelEntity(GenericDelegator.java:396)
> org.ofbiz.entity.GenericDelegator.getNextSeqIdLong(GenericDelegator.java:3166)
> org.ofbiz.entity.GenericDelegator.getNextSeqId(GenericDelegator.java:3119)
> org.ofbiz.entity.GenericDelegator.getNextSeqId(GenericDelegator.java:3109)
> org.ofbiz.product.product.ProductServices.quickCreateVirtualWithVariants(ProductServices.java:743)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Reopened: (OFBIZ-2567) Entity VirtualProduct missing

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott Gray reopened OFBIZ-2567:
-------------------------------

Assignee: (was: Scott Gray)

You're quite right BJ, there is an additional bug in there that should be fixed because a sequence does not need to be tied to an entity. I haven't got time right now to fix it so I'll reopen the issue. All that is need is a try catch block around the getModelEntity method call.

> Entity VirtualProduct missing
> -----------------------------
>
> Key: OFBIZ-2567
> URL: https://issues.apache.org/jira/browse/OFBIZ-2567
> Project: OFBiz
> Issue Type: Bug
> Components: product
> Affects Versions: Release Branch 9.04
> Environment: OFBiz 9.04.781707
> Reporter: Jan Valkovic
> Fix For: Release Branch 9.04, SVN trunk
>
>
> Here https://localhost:8443/catalog/control/quickCreateVirtualWithVariants is occured this:
> 2009-06-04 14:23:56,055 (http-0.0.0.0-8443-3) [ ControlServlet.java:299:INFO ] [[[ApplyFeaturesToProduct] Request Done- total:1.456,since last([ApplyFeaturesToP...):1.456]]
> 2009-06-04 14:24:02,304 (http-0.0.0.0-8443-4) [ ControlServlet.java:130:INFO ] [[[quickCreateVirtualWithVariants] Request Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
> 2009-06-04 14:24:02,309 (http-0.0.0.0-8443-4) [ GenericDelegator.java:398:ERROR]
> ---- exception report ----------------------------------------------------------
> Error getting entity definition from model
> Exception: org.ofbiz.entity.GenericModelException
> Message: Could not find definition for entity name VirtualProduct
> ---- stack trace ---------------------------------------------------------------
> EDIT:
> Stack trace ...
> org.ofbiz.entity.GenericModelException: Could not find definition for entity name VirtualProduct
> org.ofbiz.entity.model.ModelReader.getModelEntity(ModelReader.java:451)
> org.ofbiz.entity.GenericDelegator.getModelEntity(GenericDelegator.java:396)
> org.ofbiz.entity.GenericDelegator.getNextSeqIdLong(GenericDelegator.java:3166)
> org.ofbiz.entity.GenericDelegator.getNextSeqId(GenericDelegator.java:3119)
> org.ofbiz.entity.GenericDelegator.getNextSeqId(GenericDelegator.java:3109)
> org.ofbiz.product.product.ProductServices.quickCreateVirtualWithVariants(ProductServices.java:743)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2567) Entity VirtualProduct missing

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717504#action_12717504 ]

BJ Freeman commented on OFBIZ-2567:
-----------------------------------

May be David can give some guidance.
I think that the getModelEntity should give a debug.info that a entity was not found and return a null.
ad the comments suggest.
or mabe use a different method to check for the entity.

> Entity VirtualProduct missing
> -----------------------------
>
> Key: OFBIZ-2567
> URL: https://issues.apache.org/jira/browse/OFBIZ-2567
> Project: OFBiz
> Issue Type: Bug
> Components: product
> Affects Versions: Release Branch 9.04
> Environment: OFBiz 9.04.781707
> Reporter: Jan Valkovic
> Fix For: Release Branch 9.04, SVN trunk
>
>
> Here https://localhost:8443/catalog/control/quickCreateVirtualWithVariants is occured this:
> 2009-06-04 14:23:56,055 (http-0.0.0.0-8443-3) [ ControlServlet.java:299:INFO ] [[[ApplyFeaturesToProduct] Request Done- total:1.456,since last([ApplyFeaturesToP...):1.456]]
> 2009-06-04 14:24:02,304 (http-0.0.0.0-8443-4) [ ControlServlet.java:130:INFO ] [[[quickCreateVirtualWithVariants] Request Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
> 2009-06-04 14:24:02,309 (http-0.0.0.0-8443-4) [ GenericDelegator.java:398:ERROR]
> ---- exception report ----------------------------------------------------------
> Error getting entity definition from model
> Exception: org.ofbiz.entity.GenericModelException
> Message: Could not find definition for entity name VirtualProduct
> ---- stack trace ---------------------------------------------------------------
> EDIT:
> Stack trace ...
> org.ofbiz.entity.GenericModelException: Could not find definition for entity name VirtualProduct
> org.ofbiz.entity.model.ModelReader.getModelEntity(ModelReader.java:451)
> org.ofbiz.entity.GenericDelegator.getModelEntity(GenericDelegator.java:396)
> org.ofbiz.entity.GenericDelegator.getNextSeqIdLong(GenericDelegator.java:3166)
> org.ofbiz.entity.GenericDelegator.getNextSeqId(GenericDelegator.java:3119)
> org.ofbiz.entity.GenericDelegator.getNextSeqId(GenericDelegator.java:3109)
> org.ofbiz.product.product.ProductServices.quickCreateVirtualWithVariants(ProductServices.java:743)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2567) Entity VirtualProduct missing

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717541#action_12717541 ]

Vince Clark commented on OFBIZ-2567:
------------------------------------

I'm a bit confused. Have never seen or heard of a "VirtualProduct" entity.

> Entity VirtualProduct missing
> -----------------------------
>
> Key: OFBIZ-2567
> URL: https://issues.apache.org/jira/browse/OFBIZ-2567
> Project: OFBiz
> Issue Type: Bug
> Components: product
> Affects Versions: Release Branch 9.04
> Environment: OFBiz 9.04.781707
> Reporter: Jan Valkovic
> Fix For: Release Branch 9.04, SVN trunk
>
>
> Here https://localhost:8443/catalog/control/quickCreateVirtualWithVariants is occured this:
> 2009-06-04 14:23:56,055 (http-0.0.0.0-8443-3) [ ControlServlet.java:299:INFO ] [[[ApplyFeaturesToProduct] Request Done- total:1.456,since last([ApplyFeaturesToP...):1.456]]
> 2009-06-04 14:24:02,304 (http-0.0.0.0-8443-4) [ ControlServlet.java:130:INFO ] [[[quickCreateVirtualWithVariants] Request Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
> 2009-06-04 14:24:02,309 (http-0.0.0.0-8443-4) [ GenericDelegator.java:398:ERROR]
> ---- exception report ----------------------------------------------------------
> Error getting entity definition from model
> Exception: org.ofbiz.entity.GenericModelException
> Message: Could not find definition for entity name VirtualProduct
> ---- stack trace ---------------------------------------------------------------
> EDIT:
> Stack trace ...
> org.ofbiz.entity.GenericModelException: Could not find definition for entity name VirtualProduct
> org.ofbiz.entity.model.ModelReader.getModelEntity(ModelReader.java:451)
> org.ofbiz.entity.GenericDelegator.getModelEntity(GenericDelegator.java:396)
> org.ofbiz.entity.GenericDelegator.getNextSeqIdLong(GenericDelegator.java:3166)
> org.ofbiz.entity.GenericDelegator.getNextSeqId(GenericDelegator.java:3119)
> org.ofbiz.entity.GenericDelegator.getNextSeqId(GenericDelegator.java:3109)
> org.ofbiz.product.product.ProductServices.quickCreateVirtualWithVariants(ProductServices.java:743)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2567) Entity VirtualProduct missing

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717542#action_12717542 ]

Scott Gray commented on OFBIZ-2567:
-----------------------------------

Yeah there is no VirtualProduct entity that was why in the commit I changed the sequence name to Product, BJ is just pointing out that using VirtualProduct as a sequence name shouldn't have been invalid because a sequence doesn't necessarily have to be tied to an entity name.

> Entity VirtualProduct missing
> -----------------------------
>
> Key: OFBIZ-2567
> URL: https://issues.apache.org/jira/browse/OFBIZ-2567
> Project: OFBiz
> Issue Type: Bug
> Components: product
> Affects Versions: Release Branch 9.04
> Environment: OFBiz 9.04.781707
> Reporter: Jan Valkovic
> Fix For: Release Branch 9.04, SVN trunk
>
>
> Here https://localhost:8443/catalog/control/quickCreateVirtualWithVariants is occured this:
> 2009-06-04 14:23:56,055 (http-0.0.0.0-8443-3) [ ControlServlet.java:299:INFO ] [[[ApplyFeaturesToProduct] Request Done- total:1.456,since last([ApplyFeaturesToP...):1.456]]
> 2009-06-04 14:24:02,304 (http-0.0.0.0-8443-4) [ ControlServlet.java:130:INFO ] [[[quickCreateVirtualWithVariants] Request Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
> 2009-06-04 14:24:02,309 (http-0.0.0.0-8443-4) [ GenericDelegator.java:398:ERROR]
> ---- exception report ----------------------------------------------------------
> Error getting entity definition from model
> Exception: org.ofbiz.entity.GenericModelException
> Message: Could not find definition for entity name VirtualProduct
> ---- stack trace ---------------------------------------------------------------
> EDIT:
> Stack trace ...
> org.ofbiz.entity.GenericModelException: Could not find definition for entity name VirtualProduct
> org.ofbiz.entity.model.ModelReader.getModelEntity(ModelReader.java:451)
> org.ofbiz.entity.GenericDelegator.getModelEntity(GenericDelegator.java:396)
> org.ofbiz.entity.GenericDelegator.getNextSeqIdLong(GenericDelegator.java:3166)
> org.ofbiz.entity.GenericDelegator.getNextSeqId(GenericDelegator.java:3119)
> org.ofbiz.entity.GenericDelegator.getNextSeqId(GenericDelegator.java:3109)
> org.ofbiz.product.product.ProductServices.quickCreateVirtualWithVariants(ProductServices.java:743)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2567) Entity VirtualProduct missing

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717574#action_12717574 ]

Hans Bakker commented on OFBIZ-2567:
------------------------------------

You may want to update the http://docs.ofbiz.org/display/OFBTECH/Revisions+Requiring+Data+Migration document because of this change the numbering in existing installations will start new again

> Entity VirtualProduct missing
> -----------------------------
>
> Key: OFBIZ-2567
> URL: https://issues.apache.org/jira/browse/OFBIZ-2567
> Project: OFBiz
> Issue Type: Bug
> Components: product
> Affects Versions: Release Branch 9.04
> Environment: OFBiz 9.04.781707
> Reporter: Jan Valkovic
> Fix For: Release Branch 9.04, SVN trunk
>
>
> Here https://localhost:8443/catalog/control/quickCreateVirtualWithVariants is occured this:
> 2009-06-04 14:23:56,055 (http-0.0.0.0-8443-3) [ ControlServlet.java:299:INFO ] [[[ApplyFeaturesToProduct] Request Done- total:1.456,since last([ApplyFeaturesToP...):1.456]]
> 2009-06-04 14:24:02,304 (http-0.0.0.0-8443-4) [ ControlServlet.java:130:INFO ] [[[quickCreateVirtualWithVariants] Request Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
> 2009-06-04 14:24:02,309 (http-0.0.0.0-8443-4) [ GenericDelegator.java:398:ERROR]
> ---- exception report ----------------------------------------------------------
> Error getting entity definition from model
> Exception: org.ofbiz.entity.GenericModelException
> Message: Could not find definition for entity name VirtualProduct
> ---- stack trace ---------------------------------------------------------------
> EDIT:
> Stack trace ...
> org.ofbiz.entity.GenericModelException: Could not find definition for entity name VirtualProduct
> org.ofbiz.entity.model.ModelReader.getModelEntity(ModelReader.java:451)
> org.ofbiz.entity.GenericDelegator.getModelEntity(GenericDelegator.java:396)
> org.ofbiz.entity.GenericDelegator.getNextSeqIdLong(GenericDelegator.java:3166)
> org.ofbiz.entity.GenericDelegator.getNextSeqId(GenericDelegator.java:3119)
> org.ofbiz.entity.GenericDelegator.getNextSeqId(GenericDelegator.java:3109)
> org.ofbiz.product.product.ProductServices.quickCreateVirtualWithVariants(ProductServices.java:743)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2567) Entity VirtualProduct missing

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717585#action_12717585 ]

BJ Freeman commented on OFBIZ-2567:
-----------------------------------

I would recommend reverting trunk r782799 and 9.04 r782805
force the real fix.

> Entity VirtualProduct missing
> -----------------------------
>
> Key: OFBIZ-2567
> URL: https://issues.apache.org/jira/browse/OFBIZ-2567
> Project: OFBiz
> Issue Type: Bug
> Components: product
> Affects Versions: Release Branch 9.04
> Environment: OFBiz 9.04.781707
> Reporter: Jan Valkovic
> Fix For: Release Branch 9.04, SVN trunk
>
>
> Here https://localhost:8443/catalog/control/quickCreateVirtualWithVariants is occured this:
> 2009-06-04 14:23:56,055 (http-0.0.0.0-8443-3) [ ControlServlet.java:299:INFO ] [[[ApplyFeaturesToProduct] Request Done- total:1.456,since last([ApplyFeaturesToP...):1.456]]
> 2009-06-04 14:24:02,304 (http-0.0.0.0-8443-4) [ ControlServlet.java:130:INFO ] [[[quickCreateVirtualWithVariants] Request Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
> 2009-06-04 14:24:02,309 (http-0.0.0.0-8443-4) [ GenericDelegator.java:398:ERROR]
> ---- exception report ----------------------------------------------------------
> Error getting entity definition from model
> Exception: org.ofbiz.entity.GenericModelException
> Message: Could not find definition for entity name VirtualProduct
> ---- stack trace ---------------------------------------------------------------
> EDIT:
> Stack trace ...
> org.ofbiz.entity.GenericModelException: Could not find definition for entity name VirtualProduct
> org.ofbiz.entity.model.ModelReader.getModelEntity(ModelReader.java:451)
> org.ofbiz.entity.GenericDelegator.getModelEntity(GenericDelegator.java:396)
> org.ofbiz.entity.GenericDelegator.getNextSeqIdLong(GenericDelegator.java:3166)
> org.ofbiz.entity.GenericDelegator.getNextSeqId(GenericDelegator.java:3119)
> org.ofbiz.entity.GenericDelegator.getNextSeqId(GenericDelegator.java:3109)
> org.ofbiz.product.product.ProductServices.quickCreateVirtualWithVariants(ProductServices.java:743)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2567) Entity VirtualProduct missing

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717587#action_12717587 ]

Scott Gray commented on OFBIZ-2567:
-----------------------------------

Hans, is there a good reason for this enforced VP prefixed naming strategy? My preference would be to remove the prefix and that would remove the need for data migration.

BJ, I fail to see why virtual products should require their own sequence over and above the Product sequence, do you have any thoughts on this?

> Entity VirtualProduct missing
> -----------------------------
>
> Key: OFBIZ-2567
> URL: https://issues.apache.org/jira/browse/OFBIZ-2567
> Project: OFBiz
> Issue Type: Bug
> Components: product
> Affects Versions: Release Branch 9.04
> Environment: OFBiz 9.04.781707
> Reporter: Jan Valkovic
> Fix For: Release Branch 9.04, SVN trunk
>
>
> Here https://localhost:8443/catalog/control/quickCreateVirtualWithVariants is occured this:
> 2009-06-04 14:23:56,055 (http-0.0.0.0-8443-3) [ ControlServlet.java:299:INFO ] [[[ApplyFeaturesToProduct] Request Done- total:1.456,since last([ApplyFeaturesToP...):1.456]]
> 2009-06-04 14:24:02,304 (http-0.0.0.0-8443-4) [ ControlServlet.java:130:INFO ] [[[quickCreateVirtualWithVariants] Request Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
> 2009-06-04 14:24:02,309 (http-0.0.0.0-8443-4) [ GenericDelegator.java:398:ERROR]
> ---- exception report ----------------------------------------------------------
> Error getting entity definition from model
> Exception: org.ofbiz.entity.GenericModelException
> Message: Could not find definition for entity name VirtualProduct
> ---- stack trace ---------------------------------------------------------------
> EDIT:
> Stack trace ...
> org.ofbiz.entity.GenericModelException: Could not find definition for entity name VirtualProduct
> org.ofbiz.entity.model.ModelReader.getModelEntity(ModelReader.java:451)
> org.ofbiz.entity.GenericDelegator.getModelEntity(GenericDelegator.java:396)
> org.ofbiz.entity.GenericDelegator.getNextSeqIdLong(GenericDelegator.java:3166)
> org.ofbiz.entity.GenericDelegator.getNextSeqId(GenericDelegator.java:3119)
> org.ofbiz.entity.GenericDelegator.getNextSeqId(GenericDelegator.java:3109)
> org.ofbiz.product.product.ProductServices.quickCreateVirtualWithVariants(ProductServices.java:743)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2567) Entity VirtualProduct missing

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717607#action_12717607 ]

Hans Bakker commented on OFBIZ-2567:
------------------------------------

Scott i agree with you, should not have a special numbering. If it is now going to use the already used numbering for product then there is no migration required.

> Entity VirtualProduct missing
> -----------------------------
>
> Key: OFBIZ-2567
> URL: https://issues.apache.org/jira/browse/OFBIZ-2567
> Project: OFBiz
> Issue Type: Bug
> Components: product
> Affects Versions: Release Branch 9.04
> Environment: OFBiz 9.04.781707
> Reporter: Jan Valkovic
> Fix For: Release Branch 9.04, SVN trunk
>
>
> Here https://localhost:8443/catalog/control/quickCreateVirtualWithVariants is occured this:
> 2009-06-04 14:23:56,055 (http-0.0.0.0-8443-3) [ ControlServlet.java:299:INFO ] [[[ApplyFeaturesToProduct] Request Done- total:1.456,since last([ApplyFeaturesToP...):1.456]]
> 2009-06-04 14:24:02,304 (http-0.0.0.0-8443-4) [ ControlServlet.java:130:INFO ] [[[quickCreateVirtualWithVariants] Request Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
> 2009-06-04 14:24:02,309 (http-0.0.0.0-8443-4) [ GenericDelegator.java:398:ERROR]
> ---- exception report ----------------------------------------------------------
> Error getting entity definition from model
> Exception: org.ofbiz.entity.GenericModelException
> Message: Could not find definition for entity name VirtualProduct
> ---- stack trace ---------------------------------------------------------------
> EDIT:
> Stack trace ...
> org.ofbiz.entity.GenericModelException: Could not find definition for entity name VirtualProduct
> org.ofbiz.entity.model.ModelReader.getModelEntity(ModelReader.java:451)
> org.ofbiz.entity.GenericDelegator.getModelEntity(GenericDelegator.java:396)
> org.ofbiz.entity.GenericDelegator.getNextSeqIdLong(GenericDelegator.java:3166)
> org.ofbiz.entity.GenericDelegator.getNextSeqId(GenericDelegator.java:3119)
> org.ofbiz.entity.GenericDelegator.getNextSeqId(GenericDelegator.java:3109)
> org.ofbiz.product.product.ProductServices.quickCreateVirtualWithVariants(ProductServices.java:743)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Issue Comment Edited: (OFBIZ-2567) Entity VirtualProduct missing

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717718#action_12717718 ]

BJ Freeman edited comment on OFBIZ-2567 at 6/9/09 8:52 AM:
-----------------------------------------------------------

Scott before I answer let me go through the history and code and see how and why it was used.
I was not the one that orginated the VirtualProduct
if we decide not to use it then all reference to VirtualProduct need to be changed.

was (Author: bjfreeman):
Scott before I answer let me go through the history and code and see how and why it was used.
I was not the one that orginated the VirtualProduct
if we decide not to use it then all instances of VirtualProduct need to be changed.

> Entity VirtualProduct missing
> -----------------------------
>
> Key: OFBIZ-2567
> URL: https://issues.apache.org/jira/browse/OFBIZ-2567
> Project: OFBiz
> Issue Type: Bug
> Components: product
> Affects Versions: Release Branch 9.04
> Environment: OFBiz 9.04.781707
> Reporter: Jan Valkovic
> Fix For: Release Branch 9.04, SVN trunk
>
>
> Here https://localhost:8443/catalog/control/quickCreateVirtualWithVariants is occured this:
> 2009-06-04 14:23:56,055 (http-0.0.0.0-8443-3) [ ControlServlet.java:299:INFO ] [[[ApplyFeaturesToProduct] Request Done- total:1.456,since last([ApplyFeaturesToP...):1.456]]
> 2009-06-04 14:24:02,304 (http-0.0.0.0-8443-4) [ ControlServlet.java:130:INFO ] [[[quickCreateVirtualWithVariants] Request Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
> 2009-06-04 14:24:02,309 (http-0.0.0.0-8443-4) [ GenericDelegator.java:398:ERROR]
> ---- exception report ----------------------------------------------------------
> Error getting entity definition from model
> Exception: org.ofbiz.entity.GenericModelException
> Message: Could not find definition for entity name VirtualProduct
> ---- stack trace ---------------------------------------------------------------
> EDIT:
> Stack trace ...
> org.ofbiz.entity.GenericModelException: Could not find definition for entity name VirtualProduct
> org.ofbiz.entity.model.ModelReader.getModelEntity(ModelReader.java:451)
> org.ofbiz.entity.GenericDelegator.getModelEntity(GenericDelegator.java:396)
> org.ofbiz.entity.GenericDelegator.getNextSeqIdLong(GenericDelegator.java:3166)
> org.ofbiz.entity.GenericDelegator.getNextSeqId(GenericDelegator.java:3119)
> org.ofbiz.entity.GenericDelegator.getNextSeqId(GenericDelegator.java:3109)
> org.ofbiz.product.product.ProductServices.quickCreateVirtualWithVariants(ProductServices.java:743)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2567) Entity VirtualProduct missing

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717718#action_12717718 ]

BJ Freeman commented on OFBIZ-2567:
-----------------------------------

Scott before I answer let me go through the history and code and see how and why it was used.
I was not the one that orginated the VirtualProduct
if we decide not to use it then all instances of VirtualProduct need to be changed.

> Entity VirtualProduct missing
> -----------------------------
>
> Key: OFBIZ-2567
> URL: https://issues.apache.org/jira/browse/OFBIZ-2567
> Project: OFBiz
> Issue Type: Bug
> Components: product
> Affects Versions: Release Branch 9.04
> Environment: OFBiz 9.04.781707
> Reporter: Jan Valkovic
> Fix For: Release Branch 9.04, SVN trunk
>
>
> Here https://localhost:8443/catalog/control/quickCreateVirtualWithVariants is occured this:
> 2009-06-04 14:23:56,055 (http-0.0.0.0-8443-3) [ ControlServlet.java:299:INFO ] [[[ApplyFeaturesToProduct] Request Done- total:1.456,since last([ApplyFeaturesToP...):1.456]]
> 2009-06-04 14:24:02,304 (http-0.0.0.0-8443-4) [ ControlServlet.java:130:INFO ] [[[quickCreateVirtualWithVariants] Request Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
> 2009-06-04 14:24:02,309 (http-0.0.0.0-8443-4) [ GenericDelegator.java:398:ERROR]
> ---- exception report ----------------------------------------------------------
> Error getting entity definition from model
> Exception: org.ofbiz.entity.GenericModelException
> Message: Could not find definition for entity name VirtualProduct
> ---- stack trace ---------------------------------------------------------------
> EDIT:
> Stack trace ...
> org.ofbiz.entity.GenericModelException: Could not find definition for entity name VirtualProduct
> org.ofbiz.entity.model.ModelReader.getModelEntity(ModelReader.java:451)
> org.ofbiz.entity.GenericDelegator.getModelEntity(GenericDelegator.java:396)
> org.ofbiz.entity.GenericDelegator.getNextSeqIdLong(GenericDelegator.java:3166)
> org.ofbiz.entity.GenericDelegator.getNextSeqId(GenericDelegator.java:3119)
> org.ofbiz.entity.GenericDelegator.getNextSeqId(GenericDelegator.java:3109)
> org.ofbiz.product.product.ProductServices.quickCreateVirtualWithVariants(ProductServices.java:743)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2567) Entity VirtualProduct missing

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717976#action_12717976 ]

Jan Valkovic commented on OFBIZ-2567:
-------------------------------------

@ Jacques Le Roux

This error occure when i was try create virtual product from "normal"(not-virtual, not-variant) product and variant/virtual product.
Steps to reproduce:
- create virtual and/or variant product with id "test"
- create second product, non-virtual non-variant product with id "test1"
- go https://localhost:8443/catalog/control/main and find products witt keyword "test"
- check both products and click on "Create Virtual Product"

I did some research about variant/virtual products and i was try to understand how it works. I didn't expect anything :-)

> Entity VirtualProduct missing
> -----------------------------
>
> Key: OFBIZ-2567
> URL: https://issues.apache.org/jira/browse/OFBIZ-2567
> Project: OFBiz
> Issue Type: Bug
> Components: product
> Affects Versions: Release Branch 9.04
> Environment: OFBiz 9.04.781707
> Reporter: Jan Valkovic
> Fix For: Release Branch 9.04, SVN trunk
>
>
> Here https://localhost:8443/catalog/control/quickCreateVirtualWithVariants is occured this:
> 2009-06-04 14:23:56,055 (http-0.0.0.0-8443-3) [ ControlServlet.java:299:INFO ] [[[ApplyFeaturesToProduct] Request Done- total:1.456,since last([ApplyFeaturesToP...):1.456]]
> 2009-06-04 14:24:02,304 (http-0.0.0.0-8443-4) [ ControlServlet.java:130:INFO ] [[[quickCreateVirtualWithVariants] Request Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
> 2009-06-04 14:24:02,309 (http-0.0.0.0-8443-4) [ GenericDelegator.java:398:ERROR]
> ---- exception report ----------------------------------------------------------
> Error getting entity definition from model
> Exception: org.ofbiz.entity.GenericModelException
> Message: Could not find definition for entity name VirtualProduct
> ---- stack trace ---------------------------------------------------------------
> EDIT:
> Stack trace ...
> org.ofbiz.entity.GenericModelException: Could not find definition for entity name VirtualProduct
> org.ofbiz.entity.model.ModelReader.getModelEntity(ModelReader.java:451)
> org.ofbiz.entity.GenericDelegator.getModelEntity(GenericDelegator.java:396)
> org.ofbiz.entity.GenericDelegator.getNextSeqIdLong(GenericDelegator.java:3166)
> org.ofbiz.entity.GenericDelegator.getNextSeqId(GenericDelegator.java:3119)
> org.ofbiz.entity.GenericDelegator.getNextSeqId(GenericDelegator.java:3109)
> org.ofbiz.product.product.ProductServices.quickCreateVirtualWithVariants(ProductServices.java:743)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.