[jira] Created: (OFBIZ-2572) UPS integration support for international order for paperless invoice

[Nicolas Malin (Jira)]

UPS integration support for international order for paperless invoice
---------------------------------------------------------------------

                 Key: OFBIZ-2572
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2572
             Project: OFBiz
          Issue Type: New Feature
          Components: product
    Affects Versions: SVN trunk
            Reporter: Pranay Pandey
            Priority: Minor
             Fix For: SVN trunk


UPS integration support for international order for paperless invoice.




--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pranay Pandey updated OFBIZ-2572:
---------------------------------

    Description:
UPS integration support for international order for International Invoice.




  was:
UPS integration support for international order for paperless invoice.




        Summary: UPS integration support for international order for International Invoice  (was: UPS integration support for international order for paperless invoice)

> UPS integration support for international order for International Invoice
> -------------------------------------------------------------------------
>
>                 Key: OFBIZ-2572
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2572
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Pranay Pandey
>            Priority: Minor
>             Fix For: SVN trunk
>
>
> UPS integration support for international order for International Invoice.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pranay Pandey updated OFBIZ-2572:
---------------------------------

    Attachment: UPS_Int_Order_OFBIZ-2572.patch

Here is the patch for UPS integration support for International Invoice.

Following are the steps to test this patch:
# UPS configuration done in shipment.properties file.
# Create an International sales order.
# Complete Packing process and go the shipment --> Rout Segment
# Send UPS Shipment Confirm Request
# Accpet UPS Shipment Request

upscie is not returning this at this moment. So implemented the code by the references taken from UPS Developer's reference doc. I have taken the caution to not to break any existing functionality.

> UPS integration support for international order for International Invoice
> -------------------------------------------------------------------------
>
>                 Key: OFBIZ-2572
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2572
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Pranay Pandey
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: UPS_Int_Order_OFBIZ-2572.patch
>
>
> UPS integration support for international order for International Invoice.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Divesh Dutta updated OFBIZ-2572:
--------------------------------

    Attachment: UPS_Int_Order_OFBIZ-2572.patch

Here is the new patch for the same functionality with some improvements after discussing it with Pranay. Improvements which are made:

#Commented the code for saving International Invoice image in shipmentPackageRouteSeg entity. As upscie is not returning it right now but  it might be useful in the future as there are other types of forms that may be returned

#Applied check for shipment.currencyUomId instead of shipmentRouteSegment.currencyUomId while sending  shipment.currencyUomId as part of request for International forms

#Also tested the patch and its not breaking any functionality

> UPS integration support for international order for International Invoice
> -------------------------------------------------------------------------
>
>                 Key: OFBIZ-2572
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2572
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Pranay Pandey
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: UPS_Int_Order_OFBIZ-2572.patch, UPS_Int_Order_OFBIZ-2572.patch
>
>
> UPS integration support for international order for International Invoice.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Divesh Dutta updated OFBIZ-2572:
--------------------------------

    Attachment:     (was: UPS_Int_Order_OFBIZ-2572.patch)

> UPS integration support for international order for International Invoice
> -------------------------------------------------------------------------
>
>                 Key: OFBIZ-2572
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2572
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Pranay Pandey
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: UPS_Int_Order_OFBIZ-2572.patch
>
>
> UPS integration support for international order for International Invoice.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Divesh Dutta updated OFBIZ-2572:
--------------------------------

    Attachment: UPS_Int_Order_OFBIZ-2572.patch

Forgot to attach License in last patch.

> UPS integration support for international order for International Invoice
> -------------------------------------------------------------------------
>
>                 Key: OFBIZ-2572
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2572
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Pranay Pandey
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: UPS_Int_Order_OFBIZ-2572.patch, UPS_Int_Order_OFBIZ-2572.patch
>
>
> UPS integration support for international order for International Invoice.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vikas Mayur reassigned OFBIZ-2572:
----------------------------------

    Assignee: Vikas Mayur

> UPS integration support for international order for International Invoice
> -------------------------------------------------------------------------
>
>                 Key: OFBIZ-2572
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2572
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Pranay Pandey
>            Assignee: Vikas Mayur
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: UPS_Int_Order_OFBIZ-2572.patch, UPS_Int_Order_OFBIZ-2572.patch
>
>
> UPS integration support for international order for International Invoice.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12716838#action_12716838 ]

Vikas Mayur commented on OFBIZ-2572:
------------------------------------

Divesh, Pranay, I did a cursory review and code looks good. Will commit it shortly.

> UPS integration support for international order for International Invoice
> -------------------------------------------------------------------------
>
>                 Key: OFBIZ-2572
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2572
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Pranay Pandey
>            Assignee: Vikas Mayur
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: UPS_Int_Order_OFBIZ-2572.patch, UPS_Int_Order_OFBIZ-2572.patch
>
>
> UPS integration support for international order for International Invoice.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vikas Mayur closed OFBIZ-2572.
------------------------------

    Resolution: Fixed

Thanks Divesh, Pranay!

Your patch is in trunk rev. 782194

Vikas

> UPS integration support for international order for International Invoice
> -------------------------------------------------------------------------
>
>                 Key: OFBIZ-2572
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2572
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Pranay Pandey
>            Assignee: Vikas Mayur
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: UPS_Int_Order_OFBIZ-2572.patch, UPS_Int_Order_OFBIZ-2572.patch
>
>
> UPS integration support for international order for International Invoice.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12716843#action_12716843 ]

Divesh Dutta commented on OFBIZ-2572:
-------------------------------------

Thanks Vikas.

> UPS integration support for international order for International Invoice
> -------------------------------------------------------------------------
>
>                 Key: OFBIZ-2572
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2572
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Pranay Pandey
>            Assignee: Vikas Mayur
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: UPS_Int_Order_OFBIZ-2572.patch, UPS_Int_Order_OFBIZ-2572.patch
>
>
> UPS integration support for international order for International Invoice.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.