[jira] Created: (OFBIZ-2576) take the product name instead of the itemDescription in orderview

[Nicolas Malin (Jira)]

take the product name instead of the itemDescription in orderview
-----------------------------------------------------------------

                 Key: OFBIZ-2576
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2576
             Project: OFBiz
          Issue Type: Improvement
          Components: order
    Affects Versions: Release Branch 9.04
            Reporter: Erwan de FERRIERES
             Fix For: Release Branch 9.04
         Attachments: OFBIZ-2576.diff

in the orderview screen, and working in a multilingual environment, the description of an orderItem is always using the description in the locale of the order. With this patch, we are using the product description which is stored in content according to the user's locale. So, when looking to an order, if the description exists, it will be displayed. If none, it will use the OrderItem.itemDescription

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Erwan de FERRIERES updated OFBIZ-2576:
--------------------------------------

    Attachment: OFBIZ-2576.diff

> take the product name instead of the itemDescription in orderview
> -----------------------------------------------------------------
>
>                 Key: OFBIZ-2576
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2576
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: Release Branch 9.04
>            Reporter: Erwan de FERRIERES
>             Fix For: Release Branch 9.04
>
>         Attachments: OFBIZ-2576.diff
>
>
> in the orderview screen, and working in a multilingual environment, the description of an orderItem is always using the description in the locale of the order. With this patch, we are using the product description which is stored in content according to the user's locale. So, when looking to an order, if the description exists, it will be displayed. If none, it will use the OrderItem.itemDescription

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Erwan de FERRIERES updated OFBIZ-2576:
--------------------------------------

        Fix Version/s:     (was: Release Branch 9.04)
                       SVN trunk
    Affects Version/s:     (was: Release Branch 9.04)
                       SVN trunk

> take the product name instead of the itemDescription in orderview
> -----------------------------------------------------------------
>
>                 Key: OFBIZ-2576
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2576
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2576.diff
>
>
> in the orderview screen, and working in a multilingual environment, the description of an orderItem is always using the description in the locale of the order. With this patch, we are using the product description which is stored in content according to the user's locale. So, when looking to an order, if the description exists, it will be displayed. If none, it will use the OrderItem.itemDescription

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Erwan de FERRIERES updated OFBIZ-2576:
--------------------------------------

    Description:
in the orderview screen, and working in a multilingual environment, the description of an orderItem is always using the description in the locale of the order.
the product description is displayed first if there is something in content, if there is nothing, the value in Product is taken. on a new line, the orderItem.itemDescription is displayed if it contains a value.

  was:in the orderview screen, and working in a multilingual environment, the description of an orderItem is always using the description in the locale of the order. With this patch, we are using the product description which is stored in content according to the user's locale. So, when looking to an order, if the description exists, it will be displayed. If none, it will use the OrderItem.itemDescription


improvement of the patch, to display the itemDescription

> take the product name instead of the itemDescription in orderview
> -----------------------------------------------------------------
>
>                 Key: OFBIZ-2576
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2576
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2576.diff, OFBIZ-2576.diff
>
>
> in the orderview screen, and working in a multilingual environment, the description of an orderItem is always using the description in the locale of the order.
> the product description is displayed first if there is something in content, if there is nothing, the value in Product is taken. on a new line, the orderItem.itemDescription is displayed if it contains a value.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Erwan de FERRIERES updated OFBIZ-2576:
--------------------------------------

    Attachment: OFBIZ-2576.diff

> take the product name instead of the itemDescription in orderview
> -----------------------------------------------------------------
>
>                 Key: OFBIZ-2576
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2576
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2576.diff, OFBIZ-2576.diff
>
>
> in the orderview screen, and working in a multilingual environment, the description of an orderItem is always using the description in the locale of the order.
> the product description is displayed first if there is something in content, if there is nothing, the value in Product is taken. on a new line, the orderItem.itemDescription is displayed if it contains a value.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Erwan de FERRIERES updated OFBIZ-2576:
--------------------------------------

    Attachment:     (was: OFBIZ-2576.diff)

> take the product name instead of the itemDescription in orderview
> -----------------------------------------------------------------
>
>                 Key: OFBIZ-2576
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2576
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2576.diff
>
>
> in the orderview screen, and working in a multilingual environment, the description of an orderItem is always using the description in the locale of the order.
> the product description is displayed first if there is something in content, if there is nothing, the value in Product is taken. on a new line, the orderItem.itemDescription is displayed if it contains a value.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Erwan de FERRIERES updated OFBIZ-2576:
--------------------------------------

    Summary: display the product name to complete the itemDescription in orderview  (was: take the product name instead of the itemDescription in orderview)

re-definition of the name of the improvement

> display the product name to complete the itemDescription in orderview
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-2576
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2576
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2576.diff
>
>
> in the orderview screen, and working in a multilingual environment, the description of an orderItem is always using the description in the locale of the order.
> the product description is displayed first if there is something in content, if there is nothing, the value in Product is taken. on a new line, the orderItem.itemDescription is displayed if it contains a value.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717322#action_12717322 ]

Jacques Le Roux commented on OFBIZ-2576:
----------------------------------------

Do we need to show both when one is there ? For instance try for WG-5569 : you get the same information twice, not very elegant.

> display the product name to complete the itemDescription in orderview
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-2576
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2576
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2576.diff
>
>
> in the orderview screen, and working in a multilingual environment, the description of an orderItem is always using the description in the locale of the order.
> the product description is displayed first if there is something in content, if there is nothing, the value in Product is taken. on a new line, the orderItem.itemDescription is displayed if it contains a value.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717632#action_12717632 ]

Erwan de FERRIERES commented on OFBIZ-2576:
-------------------------------------------

Hi Jacques,

You've raised a good point. The problem is that itemDescription is always filled when making an order with the description of the locale used by the client / operator. So if someone wants to view the order, he will have the itemDescription but maybe will not understand it because of the langage.
I'm going to update this patch, in order to compare the two strings, if they are the same, only one description will be displayed, if not, the second line will appear on the screen.

Hope that will be better,

> display the product name to complete the itemDescription in orderview
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-2576
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2576
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2576.diff
>
>
> in the orderview screen, and working in a multilingual environment, the description of an orderItem is always using the description in the locale of the order.
> the product description is displayed first if there is something in content, if there is nothing, the value in Product is taken. on a new line, the orderItem.itemDescription is displayed if it contains a value.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717636#action_12717636 ]

Jacques Le Roux commented on OFBIZ-2576:
----------------------------------------

HI Erwan,

Yes, I had the same idea : to compare the strings

> display the product name to complete the itemDescription in orderview
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-2576
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2576
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2576.diff
>
>
> in the orderview screen, and working in a multilingual environment, the description of an orderItem is always using the description in the locale of the order.
> the product description is displayed first if there is something in content, if there is nothing, the value in Product is taken. on a new line, the orderItem.itemDescription is displayed if it contains a value.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12762001#action_12762001 ]

Jacques Le Roux commented on OFBIZ-2576:
----------------------------------------

Hi Erwan,

Any update, should we not close ?

> display the product name to complete the itemDescription in orderview
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-2576
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2576
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2576.diff
>
>
> in the orderview screen, and working in a multilingual environment, the description of an orderItem is always using the description in the locale of the order.
> the product description is displayed first if there is something in content, if there is nothing, the value in Product is taken. on a new line, the orderItem.itemDescription is displayed if it contains a value.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12762550#action_12762550 ]

Erwan de FERRIERES commented on OFBIZ-2576:
-------------------------------------------

I was thinking to the same thing...

> display the product name to complete the itemDescription in orderview
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-2576
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2576
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2576.diff
>
>
> in the orderview screen, and working in a multilingual environment, the description of an orderItem is always using the description in the locale of the order.
> the product description is displayed first if there is something in content, if there is nothing, the value in Product is taken. on a new line, the orderItem.itemDescription is displayed if it contains a value.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Erwan de FERRIERES closed OFBIZ-2576.
-------------------------------------

    Resolution: Incomplete

> display the product name to complete the itemDescription in orderview
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-2576
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2576
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2576.diff
>
>
> in the orderview screen, and working in a multilingual environment, the description of an orderItem is always using the description in the locale of the order.
> the product description is displayed first if there is something in content, if there is nothing, the value in Product is taken. on a new line, the orderItem.itemDescription is displayed if it contains a value.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12762555#action_12762555 ]

Scott Gray commented on OFBIZ-2576:
-----------------------------------

Did I miss something? Why has the issue been closed?

> display the product name to complete the itemDescription in orderview
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-2576
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2576
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2576.diff
>
>
> in the orderview screen, and working in a multilingual environment, the description of an orderItem is always using the description in the locale of the order.
> the product description is displayed first if there is something in content, if there is nothing, the value in Product is taken. on a new line, the orderItem.itemDescription is displayed if it contains a value.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12762557#action_12762557 ]

Erwan de FERRIERES commented on OFBIZ-2576:
-------------------------------------------

I was the one creating the issue, 4 months ago. The patch I provided was not good enough to be commited (I think), and maybe we should have been working not only on the ftl file, but instead prepare the data to be displayed in the java files.
As Jacques suggested to close the issue, and as nothing from my side was done, I agreed with Jacques to close the issue and then close it.
Maybe this was a bit too fast, in this case, we could reopen it.

> display the product name to complete the itemDescription in orderview
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-2576
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2576
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2576.diff
>
>
> in the orderview screen, and working in a multilingual environment, the description of an orderItem is always using the description in the locale of the order.
> the product description is displayed first if there is something in content, if there is nothing, the value in Product is taken. on a new line, the orderItem.itemDescription is displayed if it contains a value.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott Gray reopened OFBIZ-2576:
-------------------------------


I think there is a potential issue here and if nothing else this issue will provide a place to continue the discussion when the time comes.

> display the product name to complete the itemDescription in orderview
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-2576
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2576
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2576.diff
>
>
> in the orderview screen, and working in a multilingual environment, the description of an orderItem is always using the description in the locale of the order.
> the product description is displayed first if there is something in content, if there is nothing, the value in Product is taken. on a new line, the orderItem.itemDescription is displayed if it contains a value.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.