[jira] Created: (OFBIZ-2620) Bug in InvoiceServices.createInvoicesFromShipments service

[Nicolas Malin (Jira)]

Bug in InvoiceServices.createInvoicesFromShipments service
----------------------------------------------------------

                 Key: OFBIZ-2620
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2620
             Project: OFBiz
          Issue Type: Bug
          Components: accounting
    Affects Versions: Release Branch 9.04, SVN trunk
            Reporter: Mridul Pathak
            Priority: Minor
             Fix For: Release Branch 9.04, SVN trunk


On line 1235 of InvoiceServices.java *billItems* list is iterated.  This list of GenericValue may contain *OrderItem* or *ShipmentReceipt* object.  On line 1297, quantity is being set for the GenericValue record and is updated.  Here, if the GenericValue record is of ShipmentReceipt, code tries to set *ShipmentReceipt.quantity* (wrong entity attribute) instead of *ShipmentReceipt.quantityAccepted* (right entity attribute), which gives error in certain scenarios.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mridul Pathak updated OFBIZ-2620:
---------------------------------

    Attachment: OFBiz-2620.patch

The attached patch fixes this issue.

> Bug in InvoiceServices.createInvoicesFromShipments service
> ----------------------------------------------------------
>
>                 Key: OFBIZ-2620
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2620
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Mridul Pathak
>            Priority: Minor
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OFBiz-2620.patch
>
>
> On line 1235 of InvoiceServices.java *billItems* list is iterated.  This list of GenericValue may contain *OrderItem* or *ShipmentReceipt* object.  On line 1297, quantity is being set for the GenericValue record and is updated.  Here, if the GenericValue record is of ShipmentReceipt, code tries to set *ShipmentReceipt.quantity* (wrong entity attribute) instead of *ShipmentReceipt.quantityAccepted* (right entity attribute), which gives error in certain scenarios.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashish Vijaywargiya reassigned OFBIZ-2620:
------------------------------------------

    Assignee: Ashish Vijaywargiya

> Bug in InvoiceServices.createInvoicesFromShipments service
> ----------------------------------------------------------
>
>                 Key: OFBIZ-2620
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2620
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Mridul Pathak
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OFBiz-2620.patch
>
>
> On line 1235 of InvoiceServices.java *billItems* list is iterated.  This list of GenericValue may contain *OrderItem* or *ShipmentReceipt* object.  On line 1297, quantity is being set for the GenericValue record and is updated.  Here, if the GenericValue record is of ShipmentReceipt, code tries to set *ShipmentReceipt.quantity* (wrong entity attribute) instead of *ShipmentReceipt.quantityAccepted* (right entity attribute), which gives error in certain scenarios.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashish Vijaywargiya closed OFBIZ-2620.
--------------------------------------

    Resolution: Fixed

Done at 785557 & 785558.
Thanks Mridul.

--
Ashish Vijaywargiya

> Bug in InvoiceServices.createInvoicesFromShipments service
> ----------------------------------------------------------
>
>                 Key: OFBIZ-2620
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2620
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Mridul Pathak
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OFBiz-2620.patch
>
>
> On line 1235 of InvoiceServices.java *billItems* list is iterated.  This list of GenericValue may contain *OrderItem* or *ShipmentReceipt* object.  On line 1297, quantity is being set for the GenericValue record and is updated.  Here, if the GenericValue record is of ShipmentReceipt, code tries to set *ShipmentReceipt.quantity* (wrong entity attribute) instead of *ShipmentReceipt.quantityAccepted* (right entity attribute), which gives error in certain scenarios.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.