Order manager order entry still looking at tracking code in cookie
------------------------------------------------------------------ Key: OFBIZ-264 URL: http://issues.apache.org/jira/browse/OFBIZ-264 Project: OFBiz (The Open for Business Project) Issue Type: Bug Components: marketing, order Affects Versions: SVN trunk Reporter: Marco Risaliti Priority: Minor If you visit the ecommerce store with a tracking code (?atc=${trackingCodeId}) and then visit the order manager and create an order, the order manager's order will also be attached to the tracking code. This is because in CheckoutEvents.java there is this block of code in createOrder: //get the TrackingCodeOrder List List trackingCodeOrders = TrackingCodeEvents.makeTrackingCodeOrders(request); String distributorId = (String) session.getAttribute("_DISTRIBUTOR_ID_"); String affiliateId = (String) session.getAttribute("_AFFILIATE_ID_"); String visitId = VisitHandler.getVisitId(session); String webSiteId = CatalogWorker.getWebSiteId(request) callResult = checkOutHelper.createOrder(userLogin, distributorId, affiliateId, trackingCodeOrders, areOrderItemsExploded, visitId, webSiteId); We need to find some way to let the checkout code know that the order is coming from the order manager and hence disable it from figuring out the tracking code. One possible solution is to set a parameter in web.xml for disable tracking code, so if it is turned on, then we skip this block of code. It's a copy of the old jira issue OFBIZ-700 and I have seen into the source this bug is still present (also if it is probably an improvement and not a bug). -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[ http://issues.apache.org/jira/browse/OFBIZ-264?page=all ]
Jacopo Cappellato updated OFBIZ-264: ------------------------------------ Description: It's a copy of the old jira issue http://jira.undersunconsulting.com/browse/OFBIZ-700 from Si Chen. ========================================================== If you visit the ecommerce store with a tracking code (?atc=${trackingCodeId}) and then visit the order manager and create an order, the order manager's order will also be attached to the tracking code. This is because in CheckoutEvents.java there is this block of code in createOrder: //get the TrackingCodeOrder List List trackingCodeOrders = TrackingCodeEvents.makeTrackingCodeOrders(request); String distributorId = (String) session.getAttribute("_DISTRIBUTOR_ID_"); String affiliateId = (String) session.getAttribute("_AFFILIATE_ID_"); String visitId = VisitHandler.getVisitId(session); String webSiteId = CatalogWorker.getWebSiteId(request) callResult = checkOutHelper.createOrder(userLogin, distributorId, affiliateId, trackingCodeOrders, areOrderItemsExploded, visitId, webSiteId); We need to find some way to let the checkout code know that the order is coming from the order manager and hence disable it from figuring out the tracking code. One possible solution is to set a parameter in web.xml for disable tracking code, so if it is turned on, then we skip this block of code. was: If you visit the ecommerce store with a tracking code (?atc=${trackingCodeId}) and then visit the order manager and create an order, the order manager's order will also be attached to the tracking code. This is because in CheckoutEvents.java there is this block of code in createOrder: //get the TrackingCodeOrder List List trackingCodeOrders = TrackingCodeEvents.makeTrackingCodeOrders(request); String distributorId = (String) session.getAttribute("_DISTRIBUTOR_ID_"); String affiliateId = (String) session.getAttribute("_AFFILIATE_ID_"); String visitId = VisitHandler.getVisitId(session); String webSiteId = CatalogWorker.getWebSiteId(request) callResult = checkOutHelper.createOrder(userLogin, distributorId, affiliateId, trackingCodeOrders, areOrderItemsExploded, visitId, webSiteId); We need to find some way to let the checkout code know that the order is coming from the order manager and hence disable it from figuring out the tracking code. One possible solution is to set a parameter in web.xml for disable tracking code, so if it is turned on, then we skip this block of code. It's a copy of the old jira issue OFBIZ-700 and I have seen into the source this bug is still present (also if it is probably an improvement and not a bug). > Order manager order entry still looking at tracking code in cookie > ------------------------------------------------------------------ > > Key: OFBIZ-264 > URL: http://issues.apache.org/jira/browse/OFBIZ-264 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: marketing, order > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Priority: Minor > > It's a copy of the old jira issue http://jira.undersunconsulting.com/browse/OFBIZ-700 from Si Chen. > ========================================================== > If you visit the ecommerce store with a tracking code (?atc=${trackingCodeId}) and then visit the order manager and create an order, the order manager's order will also be attached to the tracking code. This is because in CheckoutEvents.java there is this block of code in createOrder: > //get the TrackingCodeOrder List > List trackingCodeOrders = TrackingCodeEvents.makeTrackingCodeOrders(request); > String distributorId = (String) session.getAttribute("_DISTRIBUTOR_ID_"); > String affiliateId = (String) session.getAttribute("_AFFILIATE_ID_"); > String visitId = VisitHandler.getVisitId(session); > String webSiteId = CatalogWorker.getWebSiteId(request) > callResult = checkOutHelper.createOrder(userLogin, distributorId, affiliateId, trackingCodeOrders, areOrderItemsExploded, visitId, webSiteId); > We need to find some way to let the checkout code know that the order is coming from the order manager and hence disable it from figuring out the tracking code. > One possible solution is to set a parameter in web.xml for disable tracking code, so if it is turned on, then we skip this block of code. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
Free forum by Nabble | Edit this page |