[jira] Created: (OFBIZ-2657) 'from emailadress' defined in many places and therefore difficult to maintain
Locked
[jira] Created: (OFBIZ-2657) 'from emailadress' defined in many places and therefore difficult to maintain
 
|
'from emailadress' defined in many places and therefore difficult to maintain
----------------------------------------------------------------------------- Key: OFBIZ-2657 URL: https://issues.apache.org/jira/browse/OFBIZ-2657 Project: OFBiz Issue Type: Improvement Components: ALL COMPONENTS Affects Versions: Release Branch 9.04 Reporter: Hans Bakker Fix For: Release Branch 9.04 Currently many entities have a 'from emailaddress' defined. That is fine if it is used for an override of a default 'from address' which is however missing. the proposal is to add a 'default.from.emailaddress' to the general.properties file and change the seed/demo data to have the 'from emailaddresss' not defined(null). Obviously change the programs that when this field is null it should take it from the general properties file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-2657) 'from emailadress' defined in many places and therefore difficult to maintain
|
|
[ https://issues.apache.org/jira/browse/OFBIZ-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12723886#action_12723886 ] Hans Bakker commented on OFBIZ-2657: ------------------------------------ The reason i found this is a problem is that the content of the entity EmailTemplateSetting can never be seed data if it contains the [hidden email] email address. If somebody would change it in a production environment and then load the seed data it would be set back. If it is however not defined in the seed data it will leave the local setting intact > 'from emailadress' defined in many places and therefore difficult to maintain > ----------------------------------------------------------------------------- > > Key: OFBIZ-2657 > URL: https://issues.apache.org/jira/browse/OFBIZ-2657 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS > Affects Versions: Release Branch 9.04 > Reporter: Hans Bakker > Fix For: Release Branch 9.04 > > > Currently many entities have a 'from emailaddress' defined. That is fine if it is used for an override of a default 'from address' which is however missing. > the proposal is to add a 'default.from.emailaddress' to the general.properties file and change the seed/demo data to have the 'from emailaddresss' not defined(null). Obviously change the programs that when this field is null it should take it from the general properties file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-2657) 'from emailadress' defined in many places and therefore difficult to maintain
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12723890#action_12723890 ] David E. Jones commented on OFBIZ-2657: --------------------------------------- About the seed data loading causing the data to be set back: that is what the "seed-initial" data loader is for, ie those will only be loaded once. > 'from emailadress' defined in many places and therefore difficult to maintain > ----------------------------------------------------------------------------- > > Key: OFBIZ-2657 > URL: https://issues.apache.org/jira/browse/OFBIZ-2657 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS > Affects Versions: Release Branch 9.04 > Reporter: Hans Bakker > Fix For: Release Branch 9.04 > > > Currently many entities have a 'from emailaddress' defined. That is fine if it is used for an override of a default 'from address' which is however missing. > the proposal is to add a 'default.from.emailaddress' to the general.properties file and change the seed/demo data to have the 'from emailaddresss' not defined(null). Obviously change the programs that when this field is null it should take it from the general properties file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-2657) 'from emailadress' defined in many places and therefore difficult to maintain
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12723891#action_12723891 ] Hans Bakker commented on OFBIZ-2657: ------------------------------------ I completely agree with you david, but esspecially in the email templates i expect more and more will be added and ext-seed cannot be loaded again.... I would prefer to add EmailTemplateSetting to seed so it can be easily updated. > 'from emailadress' defined in many places and therefore difficult to maintain > ----------------------------------------------------------------------------- > > Key: OFBIZ-2657 > URL: https://issues.apache.org/jira/browse/OFBIZ-2657 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS > Affects Versions: Release Branch 9.04 > Reporter: Hans Bakker > Fix For: Release Branch 9.04 > > > Currently many entities have a 'from emailaddress' defined. That is fine if it is used for an override of a default 'from address' which is however missing. > the proposal is to add a 'default.from.emailaddress' to the general.properties file and change the seed/demo data to have the 'from emailaddresss' not defined(null). Obviously change the programs that when this field is null it should take it from the general properties file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-2657) 'from emailadress' & baseurl & baseSecureUrl defined in many places and therefore difficult to maintain
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hans Bakker updated OFBIZ-2657: ------------------------------- Summary: 'from emailadress' & baseurl & baseSecureUrl defined in many places and therefore difficult to maintain (was: 'from emailadress' defined in many places and therefore difficult to maintain) > 'from emailadress' & baseurl & baseSecureUrl defined in many places and therefore difficult to maintain > ------------------------------------------------------------------------------------------------------- > > Key: OFBIZ-2657 > URL: https://issues.apache.org/jira/browse/OFBIZ-2657 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS > Affects Versions: Release Branch 9.04 > Reporter: Hans Bakker > Fix For: Release Branch 9.04 > > > Currently many entities have a 'from emailaddress' defined. That is fine if it is used for an override of a default 'from address' which is however missing. > the proposal is to add a 'default.from.emailaddress' to the general.properties file and change the seed/demo data to have the 'from emailaddresss' not defined(null). Obviously change the programs that when this field is null it should take it from the general properties file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-2657) 'from emailadress' & baseurl & baseSecureUrl defined in many places and therefore difficult to maintain
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724428#action_12724428 ] Hans Bakker commented on OFBIZ-2657: ------------------------------------ After some more investigation i would like to propose the following: in general.properties define the basic default values of the installed system which will be used when not defined elsewhere. add: baseUrl baseSecureUrl fromEmailAddress these values will be slowly introduced where needed and will only be used when not found where they are currently defined. The first program will be org.ofbiz.common.NotificationServices: setBaseUrl which should use these values when a website is not known and should return the ip numbers as it currently does, when not defined in general.properties. It is also proposed to change the data for EmailTemplateSetting entity to leave the email address empty and change the sendMailFromTemplateSetting service to use the emailaddress in general properties when it is not defined in EmailTemplateSetting. This will also allow to make the EmailTemplateSetting data 'seed' data (email address not defined anymore here. when no objections i will implement this proposed change shortly. > 'from emailadress' & baseurl & baseSecureUrl defined in many places and therefore difficult to maintain > ------------------------------------------------------------------------------------------------------- > > Key: OFBIZ-2657 > URL: https://issues.apache.org/jira/browse/OFBIZ-2657 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS > Affects Versions: Release Branch 9.04 > Reporter: Hans Bakker > Fix For: Release Branch 9.04 > > > Currently many entities have a 'from emailaddress' defined. That is fine if it is used for an override of a default 'from address' which is however missing. > the proposal is to add a 'default.from.emailaddress' to the general.properties file and change the seed/demo data to have the 'from emailaddresss' not defined(null). Obviously change the programs that when this field is null it should take it from the general properties file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-2657) 'from emailadress' & baseurl & baseSecureUrl defined in many places and therefore difficult to maintain
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724569#action_12724569 ] David E. Jones commented on OFBIZ-2657: --------------------------------------- How will this relate to the stuff in url.properties? > 'from emailadress' & baseurl & baseSecureUrl defined in many places and therefore difficult to maintain > ------------------------------------------------------------------------------------------------------- > > Key: OFBIZ-2657 > URL: https://issues.apache.org/jira/browse/OFBIZ-2657 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS > Affects Versions: Release Branch 9.04 > Reporter: Hans Bakker > Fix For: Release Branch 9.04 > > > Currently many entities have a 'from emailaddress' defined. That is fine if it is used for an override of a default 'from address' which is however missing. > the proposal is to add a 'default.from.emailaddress' to the general.properties file and change the seed/demo data to have the 'from emailaddresss' not defined(null). Obviously change the programs that when this field is null it should take it from the general properties file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-2657) 'from emailadress' & baseurl & baseSecureUrl defined in many places and therefore difficult to maintain
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724579#action_12724579 ] Adrian Crum commented on OFBIZ-2657: ------------------------------------ David, Thanks for pointing that out! I didn't notice that file. > 'from emailadress' & baseurl & baseSecureUrl defined in many places and therefore difficult to maintain > ------------------------------------------------------------------------------------------------------- > > Key: OFBIZ-2657 > URL: https://issues.apache.org/jira/browse/OFBIZ-2657 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS > Affects Versions: Release Branch 9.04 > Reporter: Hans Bakker > Fix For: Release Branch 9.04 > > > Currently many entities have a 'from emailaddress' defined. That is fine if it is used for an override of a default 'from address' which is however missing. > the proposal is to add a 'default.from.emailaddress' to the general.properties file and change the seed/demo data to have the 'from emailaddresss' not defined(null). Obviously change the programs that when this field is null it should take it from the general properties file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-2657) 'from emailadress' & baseurl & baseSecureUrl defined in many places and therefore difficult to maintain
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724790#action_12724790 ] Hans Bakker commented on OFBIZ-2657: ------------------------------------ We could consider to move the 2 related properties also to general.properties. I did a search on getPropertyValue("url" and found 6. there were no references in minilanguage files. So at least least these 3 systemwide used values can be set centrally My proposal in general would be to store properties more centrally within the framework componentset. > 'from emailadress' & baseurl & baseSecureUrl defined in many places and therefore difficult to maintain > ------------------------------------------------------------------------------------------------------- > > Key: OFBIZ-2657 > URL: https://issues.apache.org/jira/browse/OFBIZ-2657 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS > Affects Versions: Release Branch 9.04 > Reporter: Hans Bakker > Fix For: Release Branch 9.04 > > > Currently many entities have a 'from emailaddress' defined. That is fine if it is used for an override of a default 'from address' which is however missing. > the proposal is to add a 'default.from.emailaddress' to the general.properties file and change the seed/demo data to have the 'from emailaddresss' not defined(null). Obviously change the programs that when this field is null it should take it from the general properties file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-2657) 'from emailadress' & baseurl & baseSecureUrl defined in many places and therefore difficult to maintain
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724791#action_12724791 ] BJ Freeman commented on OFBIZ-2657: ----------------------------------- how about making the company Main Email address the defualt. That way when there are sub companies they also would have main Email and be easier to expand the feature in the future. > 'from emailadress' & baseurl & baseSecureUrl defined in many places and therefore difficult to maintain > ------------------------------------------------------------------------------------------------------- > > Key: OFBIZ-2657 > URL: https://issues.apache.org/jira/browse/OFBIZ-2657 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS > Affects Versions: Release Branch 9.04 > Reporter: Hans Bakker > Fix For: Release Branch 9.04 > > > Currently many entities have a 'from emailaddress' defined. That is fine if it is used for an override of a default 'from address' which is however missing. > the proposal is to add a 'default.from.emailaddress' to the general.properties file and change the seed/demo data to have the 'from emailaddresss' not defined(null). Obviously change the programs that when this field is null it should take it from the general properties file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-2657) 'from emailadress' & baseurl & baseSecureUrl defined in many places and therefore difficult to maintain
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724794#action_12724794 ] David E. Jones commented on OFBIZ-2657: --------------------------------------- Please no. The URL settings have been in the url.properties file for about 8 years now, and various documentation points to them (such as the technical production setup guide, and various others). Also, please note that there are URL fields on the WebSite entity that override the fields in the url.properties file. > 'from emailadress' & baseurl & baseSecureUrl defined in many places and therefore difficult to maintain > ------------------------------------------------------------------------------------------------------- > > Key: OFBIZ-2657 > URL: https://issues.apache.org/jira/browse/OFBIZ-2657 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS > Affects Versions: Release Branch 9.04 > Reporter: Hans Bakker > Fix For: Release Branch 9.04 > > > Currently many entities have a 'from emailaddress' defined. That is fine if it is used for an override of a default 'from address' which is however missing. > the proposal is to add a 'default.from.emailaddress' to the general.properties file and change the seed/demo data to have the 'from emailaddresss' not defined(null). Obviously change the programs that when this field is null it should take it from the general properties file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-2657) 'from emailadress' & baseurl & baseSecureUrl defined in many places and therefore difficult to maintain
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724813#action_12724813 ] Hans Bakker commented on OFBIZ-2657: ------------------------------------ Using the company email address is a bit difficult because there can be more than one (primary), and how do we find the company partyId? Seeing the comments here the proposal is now: 1. add the 'fromEmailAddress' to general properties 2. add a comment that the deafult url's are difined in url.properties. 3. retrieve the baseUrl and baseSecureUrl from org.ofbiz.common.NotificationServices: setBaseUrl which will be amended to use, when the website is not provided, the data in url properties. > 'from emailadress' & baseurl & baseSecureUrl defined in many places and therefore difficult to maintain > ------------------------------------------------------------------------------------------------------- > > Key: OFBIZ-2657 > URL: https://issues.apache.org/jira/browse/OFBIZ-2657 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS > Affects Versions: Release Branch 9.04 > Reporter: Hans Bakker > Fix For: Release Branch 9.04 > > > Currently many entities have a 'from emailaddress' defined. That is fine if it is used for an override of a default 'from address' which is however missing. > the proposal is to add a 'default.from.emailaddress' to the general.properties file and change the seed/demo data to have the 'from emailaddresss' not defined(null). Obviously change the programs that when this field is null it should take it from the general properties file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-2657) 'from emailadress' & baseurl & baseSecureUrl defined in many places and therefore difficult to maintain
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724861#action_12724861 ] BJ Freeman commented on OFBIZ-2657: ----------------------------------- OK in my implementatiion I use Company as the defualt PartyID and uses Defaultemail as the purpose. > 'from emailadress' & baseurl & baseSecureUrl defined in many places and therefore difficult to maintain > ------------------------------------------------------------------------------------------------------- > > Key: OFBIZ-2657 > URL: https://issues.apache.org/jira/browse/OFBIZ-2657 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS > Affects Versions: Release Branch 9.04 > Reporter: Hans Bakker > Fix For: Release Branch 9.04 > > > Currently many entities have a 'from emailaddress' defined. That is fine if it is used for an override of a default 'from address' which is however missing. > the proposal is to add a 'default.from.emailaddress' to the general.properties file and change the seed/demo data to have the 'from emailaddresss' not defined(null). Obviously change the programs that when this field is null it should take it from the general properties file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Closed: (OFBIZ-2657) 'from emailadress' & baseurl & baseSecureUrl defined in many places and therefore difficult to maintain
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hans Bakker closed OFBIZ-2657. ------------------------------ Resolution: Fixed Fix Version/s: (was: Release Branch 9.04) SVN trunk Committed revision 789652. > 'from emailadress' & baseurl & baseSecureUrl defined in many places and therefore difficult to maintain > ------------------------------------------------------------------------------------------------------- > > Key: OFBIZ-2657 > URL: https://issues.apache.org/jira/browse/OFBIZ-2657 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS > Affects Versions: Release Branch 9.04 > Reporter: Hans Bakker > Fix For: SVN trunk > > > Currently many entities have a 'from emailaddress' defined. That is fine if it is used for an override of a default 'from address' which is however missing. > the proposal is to add a 'default.from.emailaddress' to the general.properties file and change the seed/demo data to have the 'from emailaddresss' not defined(null). Obviously change the programs that when this field is null it should take it from the general properties file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |