[jira] Created: (OFBIZ-2668) Delete Store survey

[Nicolas Malin (Jira)]

Delete Store survey
--------------------

                 Key: OFBIZ-2668
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2668
             Project: OFBiz
          Issue Type: Sub-task
            Reporter: Kojo Gambrah




--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12725105#action_12725105 ]

Kojo Gambrah commented on OFBIZ-2668:
-------------------------------------

I experience the following error message when I attempt deleting a store survey.

org.ofbiz.webapp.event.EventHandlerException: Found URL parameter [productStoreSurveyId] passed to secure (https) request-map with uri [deleteProductStoreSurveyAppl] with an event that calls service [deleteProductStoreSurveyAppl]; this is not allowed for security reasons! The data should be encrypted by making it part of the request body (a form field) instead of the request URL.

Steps to reproduce the error.
Goto Catalog>Stores>Ofbiz Ecommerce Store>Surveys
Attempt deleting any of the associated surveys




> Delete Store survey
> --------------------
>
>                 Key: OFBIZ-2668
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2668
>             Project: OFBiz
>          Issue Type: Sub-task
>            Reporter: Kojo Gambrah
>


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kojo Gambrah updated OFBIZ-2668:
--------------------------------

             Priority: Minor  (was: Major)
          Environment: Ubuntu Linux 9.04, ofbiz trunk, revision -780597
    Affects Version/s: SVN trunk

> Delete Store survey
> --------------------
>
>                 Key: OFBIZ-2668
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2668
>             Project: OFBiz
>          Issue Type: Sub-task
>    Affects Versions: SVN trunk
>         Environment: Ubuntu Linux 9.04, ofbiz trunk, revision -780597
>            Reporter: Kojo Gambrah
>            Priority: Minor
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ahmed Dini updated OFBIZ-2668:
------------------------------

    Attachment: DeleteStoreSurvey.patch

The attached patch fixes the problem.

Please let me know if I am doing anything wrong as this is my first patch.

> Delete Store survey
> --------------------
>
>                 Key: OFBIZ-2668
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2668
>             Project: OFBiz
>          Issue Type: Sub-task
>    Affects Versions: SVN trunk
>         Environment: Ubuntu Linux 9.04, ofbiz trunk, revision -780597
>            Reporter: Kojo Gambrah
>            Priority: Minor
>         Attachments: DeleteStoreSurvey.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vikas Mayur reassigned OFBIZ-2668:
----------------------------------

    Assignee: Vikas Mayur

> Delete Store survey
> --------------------
>
>                 Key: OFBIZ-2668
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2668
>             Project: OFBiz
>          Issue Type: Sub-task
>    Affects Versions: SVN trunk
>         Environment: Ubuntu Linux 9.04, ofbiz trunk, revision -780597
>            Reporter: Kojo Gambrah
>            Assignee: Vikas Mayur
>            Priority: Minor
>         Attachments: DeleteStoreSurvey.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vikas Mayur closed OFBIZ-2668.
------------------------------

    Resolution: Fixed

Thanks Kojo for reporting and Ahmed for the providing a patch.

A slightly modified patch is in trunk rev. 801898 as well as release09.04 rev. 801900

Vikas

> Delete Store survey
> --------------------
>
>                 Key: OFBIZ-2668
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2668
>             Project: OFBiz
>          Issue Type: Sub-task
>    Affects Versions: SVN trunk
>         Environment: Ubuntu Linux 9.04, ofbiz trunk, revision -780597
>            Reporter: Kojo Gambrah
>            Assignee: Vikas Mayur
>            Priority: Minor
>         Attachments: DeleteStoreSurvey.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12740441#action_12740441 ]

Vikas Mayur commented on OFBIZ-2668:
------------------------------------

Hi Ahmed,

First of all thanks for working through these issues. This is your second patch that I come across and its a good start though I found few issues. I know that you are working on some Jira issues as is obvious from the mailing list notification so going forward I thought to share few things with you. I hope you would keep in mind the best practices before working on any issues. This way you would save a lot of time of the reviewer and committer of the patch and being said that this will also increase the chances of your patch being committed to OFBiz sooner than expected.

Here is brief summary about the issues in your patch.

1. Never use tabs (tab key) in your code, instead use spaces (space bar).
2. Avoid unnecessary changes.

For example, there is no need to add ?if_exists function to storeSurvey.productStoreSurveyId  since productStoreSurveyId is the primary key for this generic value and this will never be empty.
{code}
<input type= "hidden" name= "productStoreSurveyId" value= "${(storeSurvey.productStoreSurveyId)?if_exists}">
{code}

Though adding this will not harm but it is just extra coding and should be avoided.

3. Instead of defining a row counter variable, you can use the FTL built in _index.

4. This change was also not required.

{code}
-                <td>${storeSurvey.fromDate?string}</td>
+                <td>${storeSurvey.fromDate?if_exists?string}</td>
{code}


Looking forward to see more and more of your involvement with project.

Thanks,
Vikas

> Delete Store survey
> --------------------
>
>                 Key: OFBIZ-2668
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2668
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: product
>    Affects Versions: Release Branch 9.04, SVN trunk
>         Environment: Ubuntu Linux 9.04, ofbiz trunk, revision -780597
>            Reporter: Kojo Gambrah
>            Assignee: Vikas Mayur
>            Priority: Minor
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: DeleteStoreSurvey.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vikas Mayur updated OFBIZ-2668:
-------------------------------

          Component/s: product
    Affects Version/s: Release Branch 9.04
        Fix Version/s: SVN trunk
                       Release Branch 9.04

> Delete Store survey
> --------------------
>
>                 Key: OFBIZ-2668
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2668
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: product
>    Affects Versions: Release Branch 9.04, SVN trunk
>         Environment: Ubuntu Linux 9.04, ofbiz trunk, revision -780597
>            Reporter: Kojo Gambrah
>            Assignee: Vikas Mayur
>            Priority: Minor
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: DeleteStoreSurvey.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12740909#action_12740909 ]

Ahmed Dini commented on OFBIZ-2668:
-----------------------------------

Hello Vikas,

Thanks for the great and educating comment. I have taken all the points you made, and I will make sure I don't repeat such mistakes in my future developments. Your comment has woken me up again, after I have made  a couple of new feature developments which have not yet been looked at.  I understand and also read in the Best Practice documents that all commiters are so busy and contributors should be patient if their patches don't get reviewed.

I honnest admit when someone new to the project develops new feature for the first time and eagerly awaits for comments and reviews for days, it really doesn't encourage them. Yet I understand, even negative comments are relief.  One great thing I have noticed about Ofbiz, is that as soon as bug issues are created in Jira especially if it is for trunk within a day or two they are fixed. Fortunately, there are alot of people waiting for this and this is a good sign that Ofbiz is well looked after.

So, I thought I would try developing new features as well as fixing bugs, I have plenty of time to contribute to Ofbiz. I will continue fixing bugs and also participate development, but great comments like the one above is what keeps new contributors going and encourage contributors to contribute. Yet I understand commiters would not have been able to do anything, if they had commented almost everything, but at least it needs to be considered. If you have time and only when you feel like doing it, please review for me the 2 issues below. Thanks again.

https://issues.apache.org/jira/browse/OFBIZ-2790
https://issues.apache.org/jira/browse/OFBIZ-2794

> Delete Store survey
> --------------------
>
>                 Key: OFBIZ-2668
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2668
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: product
>    Affects Versions: Release Branch 9.04, SVN trunk
>         Environment: Ubuntu Linux 9.04, ofbiz trunk, revision -780597
>            Reporter: Kojo Gambrah
>            Assignee: Vikas Mayur
>            Priority: Minor
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: DeleteStoreSurvey.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.