[jira] Created: (OFBIZ-270) USPS Rate Estimation
Locked
[jira] Created: (OFBIZ-270) USPS Rate Estimation
 
|
USPS Rate Estimation
-------------------- Key: OFBIZ-270 URL: http://issues.apache.org/jira/browse/OFBIZ-270 Project: OFBiz (The Open for Business Project) Issue Type: Bug Components: product Affects Versions: SVN trunk Environment: Any Reporter: Marco Risaliti Priority: Minor Attachments: shipping.patch The USPS automatic Rate Inquiry module has numerous flaws. I was able to find and fix them, albeit, with potentially unacceptable techniques. Specifically: 1.) USPS now uses Get and does not Post any longer. 2.) Pounds must be a integer number. 3.) The calculation for breaking a weight into pounds and ounces was inaccurate. (UPS module too) 4.) The HttpClient HTTP GET was inserting & between the value pairs instead of & !!!! My fix for this issue may not be appropriate! 5.) No provision for converting other units of measure to Pounds. Other parts of the program seem to default to the ounce, while shipping defaulted to the pound. Remaining Issues... Must find a way to disable the estimator during an error. The system currently defaults to $1, which is a believeable, yet money loosing postage. Need to add International Shipping Support. Finally... This is my first patch contribution... It will need extra time and attention to verify! Thanks Daniel All Comments Work Log Change History Sort Order: Comment by Daniel Kunkel [08/Jan/06 02:13 AM] [ Permlink ] My fixes which SEEM to work. Your milage may vary. Comment by Marco Risaliti [13/Sep/06 01:43 AM] [ Permlink ] Can be closed ? Thanks Marco Comment by Daniel Kunkel [13/Sep/06 02:09 AM] [ Permlink ] I think it would be a waste to close this issue without first applying the patch... Granted it was my first patch and even I don't like the code, but it did get the domestic USPS postal calculator working which has been a real boon for our business. Furthermore it allowed for the conversion of product weights to lbs for the usps, another feature we needed. PS. I do have an iCLA signed. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Updated: (OFBIZ-270) USPS Rate Estimation
|
|
[ http://issues.apache.org/jira/browse/OFBIZ-270?page=all ]
Marco Risaliti updated OFBIZ-270: --------------------------------- Attachment: shipping.patch > USPS Rate Estimation > -------------------- > > Key: OFBIZ-270 > URL: http://issues.apache.org/jira/browse/OFBIZ-270 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: product > Affects Versions: SVN trunk > Environment: Any > Reporter: Marco Risaliti > Priority: Minor > Attachments: shipping.patch > > > The USPS automatic Rate Inquiry module has numerous flaws. > I was able to find and fix them, albeit, with potentially unacceptable techniques. > Specifically: > 1.) USPS now uses Get and does not Post any longer. > 2.) Pounds must be a integer number. > 3.) The calculation for breaking a weight into pounds and ounces was inaccurate. (UPS module too) > 4.) The HttpClient HTTP GET was inserting & between the value pairs instead of & > !!!! My fix for this issue may not be appropriate! > 5.) No provision for converting other units of measure to Pounds. Other parts of the program seem to default to the ounce, while shipping defaulted to the pound. > Remaining Issues... > Must find a way to disable the estimator during an error. The system currently defaults to $1, which is a believeable, yet money loosing postage. > Need to add International Shipping Support. > Finally... This is my first patch contribution... It will need extra time and attention to verify! > Thanks > Daniel > > > All Comments Work Log Change History Sort Order: > Comment by Daniel Kunkel [08/Jan/06 02:13 AM] [ Permlink ] > My fixes which SEEM to work. Your milage may vary. > Comment by Marco Risaliti [13/Sep/06 01:43 AM] [ Permlink ] > Can be closed ? > Thanks > Marco > Comment by Daniel Kunkel [13/Sep/06 02:09 AM] [ Permlink ] > I think it would be a waste to close this issue without first applying the patch... Granted it was my first patch and even I don't like the code, but it did get the domestic USPS postal calculator working which has been a real boon for our business. Furthermore it allowed for the conversion of product weights to lbs for the usps, another feature we needed. > PS. I do have an iCLA signed. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Updated: (OFBIZ-270) USPS Rate Estimation
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-270?page=all ]
Jacopo Cappellato updated OFBIZ-270: ------------------------------------ Description: This is a copy of the old Jira issue http://jira.undersunconsulting.com/browse/OFBIZ-657 from Daniel Kunkel =========================================================== The USPS automatic Rate Inquiry module has numerous flaws. I was able to find and fix them, albeit, with potentially unacceptable techniques. Specifically: 1.) USPS now uses Get and does not Post any longer. 2.) Pounds must be a integer number. 3.) The calculation for breaking a weight into pounds and ounces was inaccurate. (UPS module too) 4.) The HttpClient HTTP GET was inserting & between the value pairs instead of & !!!! My fix for this issue may not be appropriate! 5.) No provision for converting other units of measure to Pounds. Other parts of the program seem to default to the ounce, while shipping defaulted to the pound. Remaining Issues... Must find a way to disable the estimator during an error. The system currently defaults to $1, which is a believeable, yet money loosing postage. Need to add International Shipping Support. Finally... This is my first patch contribution... It will need extra time and attention to verify! Thanks Daniel All Comments Work Log Change History Sort Order: Comment by Daniel Kunkel [08/Jan/06 02:13 AM] [ Permlink ] My fixes which SEEM to work. Your milage may vary. Comment by Marco Risaliti [13/Sep/06 01:43 AM] [ Permlink ] Can be closed ? Thanks Marco Comment by Daniel Kunkel [13/Sep/06 02:09 AM] [ Permlink ] I think it would be a waste to close this issue without first applying the patch... Granted it was my first patch and even I don't like the code, but it did get the domestic USPS postal calculator working which has been a real boon for our business. Furthermore it allowed for the conversion of product weights to lbs for the usps, another feature we needed. PS. I do have an iCLA signed. was: The USPS automatic Rate Inquiry module has numerous flaws. I was able to find and fix them, albeit, with potentially unacceptable techniques. Specifically: 1.) USPS now uses Get and does not Post any longer. 2.) Pounds must be a integer number. 3.) The calculation for breaking a weight into pounds and ounces was inaccurate. (UPS module too) 4.) The HttpClient HTTP GET was inserting & between the value pairs instead of & !!!! My fix for this issue may not be appropriate! 5.) No provision for converting other units of measure to Pounds. Other parts of the program seem to default to the ounce, while shipping defaulted to the pound. Remaining Issues... Must find a way to disable the estimator during an error. The system currently defaults to $1, which is a believeable, yet money loosing postage. Need to add International Shipping Support. Finally... This is my first patch contribution... It will need extra time and attention to verify! Thanks Daniel All Comments Work Log Change History Sort Order: Comment by Daniel Kunkel [08/Jan/06 02:13 AM] [ Permlink ] My fixes which SEEM to work. Your milage may vary. Comment by Marco Risaliti [13/Sep/06 01:43 AM] [ Permlink ] Can be closed ? Thanks Marco Comment by Daniel Kunkel [13/Sep/06 02:09 AM] [ Permlink ] I think it would be a waste to close this issue without first applying the patch... Granted it was my first patch and even I don't like the code, but it did get the domestic USPS postal calculator working which has been a real boon for our business. Furthermore it allowed for the conversion of product weights to lbs for the usps, another feature we needed. PS. I do have an iCLA signed. > USPS Rate Estimation > -------------------- > > Key: OFBIZ-270 > URL: http://issues.apache.org/jira/browse/OFBIZ-270 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: product > Affects Versions: SVN trunk > Environment: Any > Reporter: Marco Risaliti > Priority: Minor > Attachments: shipping.patch > > > This is a copy of the old Jira issue http://jira.undersunconsulting.com/browse/OFBIZ-657 from Daniel Kunkel > =========================================================== > The USPS automatic Rate Inquiry module has numerous flaws. > I was able to find and fix them, albeit, with potentially unacceptable techniques. > Specifically: > 1.) USPS now uses Get and does not Post any longer. > 2.) Pounds must be a integer number. > 3.) The calculation for breaking a weight into pounds and ounces was inaccurate. (UPS module too) > 4.) The HttpClient HTTP GET was inserting & between the value pairs instead of & > !!!! My fix for this issue may not be appropriate! > 5.) No provision for converting other units of measure to Pounds. Other parts of the program seem to default to the ounce, while shipping defaulted to the pound. > Remaining Issues... > Must find a way to disable the estimator during an error. The system currently defaults to $1, which is a believeable, yet money loosing postage. > Need to add International Shipping Support. > Finally... This is my first patch contribution... It will need extra time and attention to verify! > Thanks > Daniel > > > All Comments Work Log Change History Sort Order: > Comment by Daniel Kunkel [08/Jan/06 02:13 AM] [ Permlink ] > My fixes which SEEM to work. Your milage may vary. > Comment by Marco Risaliti [13/Sep/06 01:43 AM] [ Permlink ] > Can be closed ? > Thanks > Marco > Comment by Daniel Kunkel [13/Sep/06 02:09 AM] [ Permlink ] > I think it would be a waste to close this issue without first applying the patch... Granted it was my first patch and even I don't like the code, but it did get the domestic USPS postal calculator working which has been a real boon for our business. Furthermore it allowed for the conversion of product weights to lbs for the usps, another feature we needed. > PS. I do have an iCLA signed. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Assigned: (OFBIZ-270) USPS Rate Estimation
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-270?page=all ]
Jacques Le Roux reassigned OFBIZ-270: ------------------------------------- Assignee: Jacques Le Roux > USPS Rate Estimation > -------------------- > > Key: OFBIZ-270 > URL: http://issues.apache.org/jira/browse/OFBIZ-270 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: product > Affects Versions: SVN trunk > Environment: Any > Reporter: Marco Risaliti > Assigned To: Jacques Le Roux > Priority: Minor > Attachments: shipping.patch > > > This is a copy of the old Jira issue http://jira.undersunconsulting.com/browse/OFBIZ-657 from Daniel Kunkel > =========================================================== > The USPS automatic Rate Inquiry module has numerous flaws. > I was able to find and fix them, albeit, with potentially unacceptable techniques. > Specifically: > 1.) USPS now uses Get and does not Post any longer. > 2.) Pounds must be a integer number. > 3.) The calculation for breaking a weight into pounds and ounces was inaccurate. (UPS module too) > 4.) The HttpClient HTTP GET was inserting & between the value pairs instead of & > !!!! My fix for this issue may not be appropriate! > 5.) No provision for converting other units of measure to Pounds. Other parts of the program seem to default to the ounce, while shipping defaulted to the pound. > Remaining Issues... > Must find a way to disable the estimator during an error. The system currently defaults to $1, which is a believeable, yet money loosing postage. > Need to add International Shipping Support. > Finally... This is my first patch contribution... It will need extra time and attention to verify! > Thanks > Daniel > > > All Comments Work Log Change History Sort Order: > Comment by Daniel Kunkel [08/Jan/06 02:13 AM] [ Permlink ] > My fixes which SEEM to work. Your milage may vary. > Comment by Marco Risaliti [13/Sep/06 01:43 AM] [ Permlink ] > Can be closed ? > Thanks > Marco > Comment by Daniel Kunkel [13/Sep/06 02:09 AM] [ Permlink ] > I think it would be a waste to close this issue without first applying the patch... Granted it was my first patch and even I don't like the code, but it did get the domestic USPS postal calculator working which has been a real boon for our business. Furthermore it allowed for the conversion of product weights to lbs for the usps, another feature we needed. > PS. I do have an iCLA signed. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-270) USPS Rate Estimation
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-270?page=comments#action_12459198 ]
Jacques Le Roux commented on OFBIZ-270: --------------------------------------- Nobody interested to review this patch ? > USPS Rate Estimation > -------------------- > > Key: OFBIZ-270 > URL: http://issues.apache.org/jira/browse/OFBIZ-270 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: product > Affects Versions: SVN trunk > Environment: Any > Reporter: Marco Risaliti > Assigned To: Jacques Le Roux > Priority: Minor > Attachments: shipping.patch > > > This is a copy of the old Jira issue http://jira.undersunconsulting.com/browse/OFBIZ-657 from Daniel Kunkel > =========================================================== > The USPS automatic Rate Inquiry module has numerous flaws. > I was able to find and fix them, albeit, with potentially unacceptable techniques. > Specifically: > 1.) USPS now uses Get and does not Post any longer. > 2.) Pounds must be a integer number. > 3.) The calculation for breaking a weight into pounds and ounces was inaccurate. (UPS module too) > 4.) The HttpClient HTTP GET was inserting & between the value pairs instead of & > !!!! My fix for this issue may not be appropriate! > 5.) No provision for converting other units of measure to Pounds. Other parts of the program seem to default to the ounce, while shipping defaulted to the pound. > Remaining Issues... > Must find a way to disable the estimator during an error. The system currently defaults to $1, which is a believeable, yet money loosing postage. > Need to add International Shipping Support. > Finally... This is my first patch contribution... It will need extra time and attention to verify! > Thanks > Daniel > > > All Comments Work Log Change History Sort Order: > Comment by Daniel Kunkel [08/Jan/06 02:13 AM] [ Permlink ] > My fixes which SEEM to work. Your milage may vary. > Comment by Marco Risaliti [13/Sep/06 01:43 AM] [ Permlink ] > Can be closed ? > Thanks > Marco > Comment by Daniel Kunkel [13/Sep/06 02:09 AM] [ Permlink ] > I think it would be a waste to close this issue without first applying the patch... Granted it was my first patch and even I don't like the code, but it did get the domestic USPS postal calculator working which has been a real boon for our business. Furthermore it allowed for the conversion of product weights to lbs for the usps, another feature we needed. > PS. I do have an iCLA signed. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-270) USPS Rate Estimation
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-270?page=comments#action_12459200 ]
Jacques Le Roux commented on OFBIZ-270: --------------------------------------- One point : don't have to be commiter to review a patch. I guess if people were reviewing each others patches commiters could be far more efficient... Thanks :o) > USPS Rate Estimation > -------------------- > > Key: OFBIZ-270 > URL: http://issues.apache.org/jira/browse/OFBIZ-270 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: product > Affects Versions: SVN trunk > Environment: Any > Reporter: Marco Risaliti > Assigned To: Jacques Le Roux > Priority: Minor > Attachments: shipping.patch > > > This is a copy of the old Jira issue http://jira.undersunconsulting.com/browse/OFBIZ-657 from Daniel Kunkel > =========================================================== > The USPS automatic Rate Inquiry module has numerous flaws. > I was able to find and fix them, albeit, with potentially unacceptable techniques. > Specifically: > 1.) USPS now uses Get and does not Post any longer. > 2.) Pounds must be a integer number. > 3.) The calculation for breaking a weight into pounds and ounces was inaccurate. (UPS module too) > 4.) The HttpClient HTTP GET was inserting & between the value pairs instead of & > !!!! My fix for this issue may not be appropriate! > 5.) No provision for converting other units of measure to Pounds. Other parts of the program seem to default to the ounce, while shipping defaulted to the pound. > Remaining Issues... > Must find a way to disable the estimator during an error. The system currently defaults to $1, which is a believeable, yet money loosing postage. > Need to add International Shipping Support. > Finally... This is my first patch contribution... It will need extra time and attention to verify! > Thanks > Daniel > > > All Comments Work Log Change History Sort Order: > Comment by Daniel Kunkel [08/Jan/06 02:13 AM] [ Permlink ] > My fixes which SEEM to work. Your milage may vary. > Comment by Marco Risaliti [13/Sep/06 01:43 AM] [ Permlink ] > Can be closed ? > Thanks > Marco > Comment by Daniel Kunkel [13/Sep/06 02:09 AM] [ Permlink ] > I think it would be a waste to close this issue without first applying the patch... Granted it was my first patch and even I don't like the code, but it did get the domestic USPS postal calculator working which has been a real boon for our business. Furthermore it allowed for the conversion of product weights to lbs for the usps, another feature we needed. > PS. I do have an iCLA signed. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-270) USPS Rate Estimation
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-270?page=comments#action_12459223 ]
Chris Howe commented on OFBIZ-270: ---------------------------------- I would opt for the commit then review approach on this one. I don't think there is a critical mass using USPS in OFBiz (especially if it wasn't working before). Because of that, I don't fore see too many people taking the time to track down the nuances of USPS's api to see if this works as expected (thanks Daniel). But that's just an opinion and that's all it is ;) > USPS Rate Estimation > -------------------- > > Key: OFBIZ-270 > URL: http://issues.apache.org/jira/browse/OFBIZ-270 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: product > Affects Versions: SVN trunk > Environment: Any > Reporter: Marco Risaliti > Assigned To: Jacques Le Roux > Priority: Minor > Attachments: shipping.patch > > > This is a copy of the old Jira issue http://jira.undersunconsulting.com/browse/OFBIZ-657 from Daniel Kunkel > =========================================================== > The USPS automatic Rate Inquiry module has numerous flaws. > I was able to find and fix them, albeit, with potentially unacceptable techniques. > Specifically: > 1.) USPS now uses Get and does not Post any longer. > 2.) Pounds must be a integer number. > 3.) The calculation for breaking a weight into pounds and ounces was inaccurate. (UPS module too) > 4.) The HttpClient HTTP GET was inserting & between the value pairs instead of & > !!!! My fix for this issue may not be appropriate! > 5.) No provision for converting other units of measure to Pounds. Other parts of the program seem to default to the ounce, while shipping defaulted to the pound. > Remaining Issues... > Must find a way to disable the estimator during an error. The system currently defaults to $1, which is a believeable, yet money loosing postage. > Need to add International Shipping Support. > Finally... This is my first patch contribution... It will need extra time and attention to verify! > Thanks > Daniel > > > All Comments Work Log Change History Sort Order: > Comment by Daniel Kunkel [08/Jan/06 02:13 AM] [ Permlink ] > My fixes which SEEM to work. Your milage may vary. > Comment by Marco Risaliti [13/Sep/06 01:43 AM] [ Permlink ] > Can be closed ? > Thanks > Marco > Comment by Daniel Kunkel [13/Sep/06 02:09 AM] [ Permlink ] > I think it would be a waste to close this issue without first applying the patch... Granted it was my first patch and even I don't like the code, but it did get the domestic USPS postal calculator working which has been a real boon for our business. Furthermore it allowed for the conversion of product weights to lbs for the usps, another feature we needed. > PS. I do have an iCLA signed. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |