[jira] Created: (OFBIZ-2774) Change the createPaymentGroupMember and updatePaymentGroupMemeber services and UI.

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (OFBIZ-2774) Change the createPaymentGroupMember and updatePaymentGroupMemeber services and UI.

Nicolas Malin (Jira)
Change the createPaymentGroupMember and updatePaymentGroupMemeber services and UI.
----------------------------------------------------------------------------------

                 Key: OFBIZ-2774
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2774
             Project: OFBiz
          Issue Type: Improvement
          Components: accounting
    Affects Versions: SVN trunk
            Reporter: Rishi Solanki
             Fix For: SVN trunk


For the PaymentGroupMember, CRUD services are implemented using entity-auto engine.
Need to customize both services ;
The services should implemented to test the following scenarios.
- From paymentGroupId get the generic value of PaymentGroup and get its type.
- If the type is Check Run the the payment should be Disbursement otherwise do not allow to create/update it and return error, "can't add incoming payment to party group type Check Run".
  -- Use isDisbursement() static method of UtilAccounting to check.
- If the type is Batch Of Payments the the payment should be Receipt otherwise do not allow to create/update it and return error, "can't add outgoing payment to party group type Batch Of Payments".
   -- Use isReceipt() static method of UtilAccounting to check.

Also change the UI, the partyGroupType should be in display only mode user should not change it, because it decides the members should be outgoing or incoming.

--
Rishi

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-2774) Change the createPaymentGroupMember and updatePaymentGroupMemeber services and UI.

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-2774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12737061#action_12737061 ]

Rishi Solanki commented on OFBIZ-2774:
--------------------------------------

My apology,
return error should be
 - "can't add incoming payment to payment group type Check Run"
 - "can't add outgoing payment to payment group type Batch Of Payments"

No need to change the updatePaymentGroupMember service as it handles from UI.

> Change the createPaymentGroupMember and updatePaymentGroupMemeber services and UI.
> ----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2774
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2774
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Rishi Solanki
>             Fix For: SVN trunk
>
>
> For the PaymentGroupMember, CRUD services are implemented using entity-auto engine.
> Need to customize both services ;
> The services should implemented to test the following scenarios.
> - From paymentGroupId get the generic value of PaymentGroup and get its type.
> - If the type is Check Run the the payment should be Disbursement otherwise do not allow to create/update it and return error, "can't add incoming payment to party group type Check Run".
>   -- Use isDisbursement() static method of UtilAccounting to check.
> - If the type is Batch Of Payments the the payment should be Receipt otherwise do not allow to create/update it and return error, "can't add outgoing payment to party group type Batch Of Payments".
>    -- Use isReceipt() static method of UtilAccounting to check.
> Also change the UI, the partyGroupType should be in display only mode user should not change it, because it decides the members should be outgoing or incoming.
> --
> Rishi

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-2774) Change the createPaymentGroupMember and updatePaymentGroupMemeber services and UI.

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-2774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Parimal Gain updated OFBIZ-2774:
--------------------------------

    Attachment: createPaymentGroupMember.patch

Re Implement service createPaymentGroupMember.
Now service Check For Outgoing/Incoming Payment And then Create Payment Group Member.
At Ui paymentGroupType is non editable.

Thanks to Rishi.

> Change the createPaymentGroupMember and updatePaymentGroupMemeber services and UI.
> ----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2774
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2774
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Rishi Solanki
>             Fix For: SVN trunk
>
>         Attachments: createPaymentGroupMember.patch
>
>
> For the PaymentGroupMember, CRUD services are implemented using entity-auto engine.
> Need to customize both services ;
> The services should implemented to test the following scenarios.
> - From paymentGroupId get the generic value of PaymentGroup and get its type.
> - If the type is Check Run the the payment should be Disbursement otherwise do not allow to create/update it and return error, "can't add incoming payment to party group type Check Run".
>   -- Use isDisbursement() static method of UtilAccounting to check.
> - If the type is Batch Of Payments the the payment should be Receipt otherwise do not allow to create/update it and return error, "can't add outgoing payment to party group type Batch Of Payments".
>    -- Use isReceipt() static method of UtilAccounting to check.
> Also change the UI, the partyGroupType should be in display only mode user should not change it, because it decides the members should be outgoing or incoming.
> --
> Rishi

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Assigned: (OFBIZ-2774) Change the createPaymentGroupMember and updatePaymentGroupMemeber services and UI.

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-2774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anil K Patel reassigned OFBIZ-2774:
-----------------------------------

    Assignee: Anil K Patel

> Change the createPaymentGroupMember and updatePaymentGroupMemeber services and UI.
> ----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2774
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2774
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Rishi Solanki
>            Assignee: Anil K Patel
>             Fix For: SVN trunk
>
>         Attachments: createPaymentGroupMember.patch
>
>
> For the PaymentGroupMember, CRUD services are implemented using entity-auto engine.
> Need to customize both services ;
> The services should implemented to test the following scenarios.
> - From paymentGroupId get the generic value of PaymentGroup and get its type.
> - If the type is Check Run the the payment should be Disbursement otherwise do not allow to create/update it and return error, "can't add incoming payment to party group type Check Run".
>   -- Use isDisbursement() static method of UtilAccounting to check.
> - If the type is Batch Of Payments the the payment should be Receipt otherwise do not allow to create/update it and return error, "can't add outgoing payment to party group type Batch Of Payments".
>    -- Use isReceipt() static method of UtilAccounting to check.
> Also change the UI, the partyGroupType should be in display only mode user should not change it, because it decides the members should be outgoing or incoming.
> --
> Rishi

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (OFBIZ-2774) Change the createPaymentGroupMember and updatePaymentGroupMemeber services and UI.

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-2774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anil K Patel closed OFBIZ-2774.
-------------------------------

    Resolution: Fixed

Patch in r799265. Thanks for patch.

> Change the createPaymentGroupMember and updatePaymentGroupMemeber services and UI.
> ----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2774
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2774
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Rishi Solanki
>            Assignee: Anil K Patel
>             Fix For: SVN trunk
>
>         Attachments: createPaymentGroupMember.patch
>
>
> For the PaymentGroupMember, CRUD services are implemented using entity-auto engine.
> Need to customize both services ;
> The services should implemented to test the following scenarios.
> - From paymentGroupId get the generic value of PaymentGroup and get its type.
> - If the type is Check Run the the payment should be Disbursement otherwise do not allow to create/update it and return error, "can't add incoming payment to party group type Check Run".
>   -- Use isDisbursement() static method of UtilAccounting to check.
> - If the type is Batch Of Payments the the payment should be Receipt otherwise do not allow to create/update it and return error, "can't add outgoing payment to party group type Batch Of Payments".
>    -- Use isReceipt() static method of UtilAccounting to check.
> Also change the UI, the partyGroupType should be in display only mode user should not change it, because it decides the members should be outgoing or incoming.
> --
> Rishi

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Reopened: (OFBIZ-2774) Change the createPaymentGroupMember and updatePaymentGroupMemeber services and UI.

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-2774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anil K Patel reopened OFBIZ-2774:
---------------------------------


few bugs identified.

> Change the createPaymentGroupMember and updatePaymentGroupMemeber services and UI.
> ----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2774
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2774
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Rishi Solanki
>            Assignee: Anil K Patel
>             Fix For: SVN trunk
>
>         Attachments: createPaymentGroupMember.patch
>
>
> For the PaymentGroupMember, CRUD services are implemented using entity-auto engine.
> Need to customize both services ;
> The services should implemented to test the following scenarios.
> - From paymentGroupId get the generic value of PaymentGroup and get its type.
> - If the type is Check Run the the payment should be Disbursement otherwise do not allow to create/update it and return error, "can't add incoming payment to party group type Check Run".
>   -- Use isDisbursement() static method of UtilAccounting to check.
> - If the type is Batch Of Payments the the payment should be Receipt otherwise do not allow to create/update it and return error, "can't add outgoing payment to party group type Batch Of Payments".
>    -- Use isReceipt() static method of UtilAccounting to check.
> Also change the UI, the partyGroupType should be in display only mode user should not change it, because it decides the members should be outgoing or incoming.
> --
> Rishi

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-2774) Change the createPaymentGroupMember and updatePaymentGroupMemeber services and UI.

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-2774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12742392#action_12742392 ]

Sumit Pandit commented on OFBIZ-2774:
-------------------------------------

Modify existing process to create batch -

Existing system allows that a payment can be associate with many PaymentGroups, this shouldn't be happen. Therefore,
Create a service which will verify existing active PaymentGroupMember records before creating a new batch for Payments. If any record is exists then return appropriate error message.

Anil/Rishi please reopen this issue.

> Change the createPaymentGroupMember and updatePaymentGroupMemeber services and UI.
> ----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2774
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2774
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Rishi Solanki
>            Assignee: Anil K Patel
>             Fix For: SVN trunk
>
>         Attachments: createPaymentGroupMember.patch
>
>
> For the PaymentGroupMember, CRUD services are implemented using entity-auto engine.
> Need to customize both services ;
> The services should implemented to test the following scenarios.
> - From paymentGroupId get the generic value of PaymentGroup and get its type.
> - If the type is Check Run the the payment should be Disbursement otherwise do not allow to create/update it and return error, "can't add incoming payment to party group type Check Run".
>   -- Use isDisbursement() static method of UtilAccounting to check.
> - If the type is Batch Of Payments the the payment should be Receipt otherwise do not allow to create/update it and return error, "can't add outgoing payment to party group type Batch Of Payments".
>    -- Use isReceipt() static method of UtilAccounting to check.
> Also change the UI, the partyGroupType should be in display only mode user should not change it, because it decides the members should be outgoing or incoming.
> --
> Rishi

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-2774) Change the createPaymentGroupMember and updatePaymentGroupMemeber services and UI.

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-2774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Awdesh Singh Parihar updated OFBIZ-2774:
----------------------------------------

    Attachment: createPaymentGroupMember.patch

As per Sumit comment : -
I have implemented a service to check valid payment before create a new batch for payments .


> Change the createPaymentGroupMember and updatePaymentGroupMemeber services and UI.
> ----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2774
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2774
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Rishi Solanki
>            Assignee: Anil K Patel
>             Fix For: SVN trunk
>
>         Attachments: createPaymentGroupMember.patch, createPaymentGroupMember.patch
>
>
> For the PaymentGroupMember, CRUD services are implemented using entity-auto engine.
> Need to customize both services ;
> The services should implemented to test the following scenarios.
> - From paymentGroupId get the generic value of PaymentGroup and get its type.
> - If the type is Check Run the the payment should be Disbursement otherwise do not allow to create/update it and return error, "can't add incoming payment to party group type Check Run".
>   -- Use isDisbursement() static method of UtilAccounting to check.
> - If the type is Batch Of Payments the the payment should be Receipt otherwise do not allow to create/update it and return error, "can't add outgoing payment to party group type Batch Of Payments".
>    -- Use isReceipt() static method of UtilAccounting to check.
> Also change the UI, the partyGroupType should be in display only mode user should not change it, because it decides the members should be outgoing or incoming.
> --
> Rishi

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-2774) Change the createPaymentGroupMember and updatePaymentGroupMemeber services and UI.

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-2774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Awdesh Singh Parihar updated OFBIZ-2774:
----------------------------------------

    Attachment: createPaymentGroupMember.patch

Resolved Conflict and upload updated patch.

> Change the createPaymentGroupMember and updatePaymentGroupMemeber services and UI.
> ----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2774
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2774
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Rishi Solanki
>            Assignee: Anil K Patel
>             Fix For: SVN trunk
>
>         Attachments: createPaymentGroupMember.patch, createPaymentGroupMember.patch, createPaymentGroupMember.patch
>
>
> For the PaymentGroupMember, CRUD services are implemented using entity-auto engine.
> Need to customize both services ;
> The services should implemented to test the following scenarios.
> - From paymentGroupId get the generic value of PaymentGroup and get its type.
> - If the type is Check Run the the payment should be Disbursement otherwise do not allow to create/update it and return error, "can't add incoming payment to party group type Check Run".
>   -- Use isDisbursement() static method of UtilAccounting to check.
> - If the type is Batch Of Payments the the payment should be Receipt otherwise do not allow to create/update it and return error, "can't add outgoing payment to party group type Batch Of Payments".
>    -- Use isReceipt() static method of UtilAccounting to check.
> Also change the UI, the partyGroupType should be in display only mode user should not change it, because it decides the members should be outgoing or incoming.
> --
> Rishi

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (OFBIZ-2774) Change the createPaymentGroupMember and updatePaymentGroupMemeber services and UI.

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-2774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anil K Patel closed OFBIZ-2774.
-------------------------------

    Resolution: Fixed

Patch applied to r 803572. Regards

> Change the createPaymentGroupMember and updatePaymentGroupMemeber services and UI.
> ----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2774
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2774
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Rishi Solanki
>            Assignee: Anil K Patel
>             Fix For: SVN trunk
>
>         Attachments: createPaymentGroupMember.patch, createPaymentGroupMember.patch, createPaymentGroupMember.patch
>
>
> For the PaymentGroupMember, CRUD services are implemented using entity-auto engine.
> Need to customize both services ;
> The services should implemented to test the following scenarios.
> - From paymentGroupId get the generic value of PaymentGroup and get its type.
> - If the type is Check Run the the payment should be Disbursement otherwise do not allow to create/update it and return error, "can't add incoming payment to party group type Check Run".
>   -- Use isDisbursement() static method of UtilAccounting to check.
> - If the type is Batch Of Payments the the payment should be Receipt otherwise do not allow to create/update it and return error, "can't add outgoing payment to party group type Batch Of Payments".
>    -- Use isReceipt() static method of UtilAccounting to check.
> Also change the UI, the partyGroupType should be in display only mode user should not change it, because it decides the members should be outgoing or incoming.
> --
> Rishi

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.