[jira] Created: (OFBIZ-278) relative path
Locked
[jira] Created: (OFBIZ-278) relative path
 
|
relative path
------------- Key: OFBIZ-278 URL: http://issues.apache.org/jira/browse/OFBIZ-278 Project: OFBiz (The Open for Business Project) Issue Type: Bug Components: order Affects Versions: SVN trunk Reporter: Marco Risaliti Priority: Trivial component://order/webapp/ordermgr/WEB-INF/actions/order/OrderDeliveryScheduleInfo.bsh line 53: uses "/order/OrderDeliveryScheduleForms.xml" as a parameter. Because of this every app that calls this beanshell script must have the forms.xml file in it's path. This is extremely trivial at the moment, but will cause some people some trouble once the order application is updated to use mainDecoratorLocation variable -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Updated: (OFBIZ-278) relative path
|
|
[ http://issues.apache.org/jira/browse/OFBIZ-278?page=all ]
Jacopo Cappellato updated OFBIZ-278: ------------------------------------ Description: Copy of http://jira.undersunconsulting.com/browse/OFBIZ-603 from Chris Howe. ================================================== component://order/webapp/ordermgr/WEB-INF/actions/order/OrderDeliveryScheduleInfo.bsh line 53: uses "/order/OrderDeliveryScheduleForms.xml" as a parameter. Because of this every app that calls this beanshell script must have the forms.xml file in it's path. This is extremely trivial at the moment, but will cause some people some trouble once the order application is updated to use mainDecoratorLocation variable was: component://order/webapp/ordermgr/WEB-INF/actions/order/OrderDeliveryScheduleInfo.bsh line 53: uses "/order/OrderDeliveryScheduleForms.xml" as a parameter. Because of this every app that calls this beanshell script must have the forms.xml file in it's path. This is extremely trivial at the moment, but will cause some people some trouble once the order application is updated to use mainDecoratorLocation variable > relative path > ------------- > > Key: OFBIZ-278 > URL: http://issues.apache.org/jira/browse/OFBIZ-278 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: order > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Priority: Trivial > > Copy of http://jira.undersunconsulting.com/browse/OFBIZ-603 from Chris Howe. > ================================================== > component://order/webapp/ordermgr/WEB-INF/actions/order/OrderDeliveryScheduleInfo.bsh > line 53: > uses "/order/OrderDeliveryScheduleForms.xml" as a parameter. > Because of this every app that calls this beanshell script must have the forms.xml file in it's path. This is extremely trivial at the moment, but will cause some people some trouble once the order application is updated to use mainDecoratorLocation variable -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-278) relative path
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-278?page=comments#action_12453546 ]
Jacopo Cappellato commented on OFBIZ-278: ----------------------------------------- This is a more general issue. We should fix all the bsh scripts that use the HtmlFormWrapper constructor to put in the context an instance of a form wrapper. I did a search for the "new HtmlFormWrapper(" sting and I've found a lot of scripts. > relative path > ------------- > > Key: OFBIZ-278 > URL: http://issues.apache.org/jira/browse/OFBIZ-278 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: order > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Priority: Trivial > > Copy of http://jira.undersunconsulting.com/browse/OFBIZ-603 from Chris Howe. > ================================================== > component://order/webapp/ordermgr/WEB-INF/actions/order/OrderDeliveryScheduleInfo.bsh > line 53: > uses "/order/OrderDeliveryScheduleForms.xml" as a parameter. > Because of this every app that calls this beanshell script must have the forms.xml file in it's path. This is extremely trivial at the moment, but will cause some people some trouble once the order application is updated to use mainDecoratorLocation variable -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Updated: (OFBIZ-278) Relative paths for form definitions passed to the HtmlFormWrapper constructor limit reusability of scripts.
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-278?page=all ]
Jacopo Cappellato updated OFBIZ-278: ------------------------------------ Component/s: accounting content ecommerce manufacturing product Summary: Relative paths for form definitions passed to the HtmlFormWrapper constructor limit reusability of scripts. (was: relative path) > Relative paths for form definitions passed to the HtmlFormWrapper constructor limit reusability of scripts. > ----------------------------------------------------------------------------------------------------------- > > Key: OFBIZ-278 > URL: http://issues.apache.org/jira/browse/OFBIZ-278 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: accounting, content, ecommerce, manufacturing, order, product > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Priority: Trivial > > Copy of http://jira.undersunconsulting.com/browse/OFBIZ-603 from Chris Howe. > ================================================== > component://order/webapp/ordermgr/WEB-INF/actions/order/OrderDeliveryScheduleInfo.bsh > line 53: > uses "/order/OrderDeliveryScheduleForms.xml" as a parameter. > Because of this every app that calls this beanshell script must have the forms.xml file in it's path. This is extremely trivial at the moment, but will cause some people some trouble once the order application is updated to use mainDecoratorLocation variable -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-278) Relative paths for form definitions passed to the HtmlFormWrapper constructor limit reusability of scripts.
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-278?page=comments#action_12453667 ]
Jacques Le Roux commented on OFBIZ-278: --------------------------------------- So the HtmlFormWrapper is deprecated ? > Relative paths for form definitions passed to the HtmlFormWrapper constructor limit reusability of scripts. > ----------------------------------------------------------------------------------------------------------- > > Key: OFBIZ-278 > URL: http://issues.apache.org/jira/browse/OFBIZ-278 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: accounting, content, ecommerce, manufacturing, order, product > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Priority: Trivial > > Copy of http://jira.undersunconsulting.com/browse/OFBIZ-603 from Chris Howe. > ================================================== > component://order/webapp/ordermgr/WEB-INF/actions/order/OrderDeliveryScheduleInfo.bsh > line 53: > uses "/order/OrderDeliveryScheduleForms.xml" as a parameter. > Because of this every app that calls this beanshell script must have the forms.xml file in it's path. This is extremely trivial at the moment, but will cause some people some trouble once the order application is updated to use mainDecoratorLocation variable -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-278) Relative paths for form definitions passed to the HtmlFormWrapper constructor limit reusability of scripts.
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-278?page=comments#action_12454828 ]
Jacopo Cappellato commented on OFBIZ-278: ----------------------------------------- Jacques, I wouldn't say that the HtmlFormWrapper is deprecated, there are probably situation where putting the forms in the context by declaring them in the screen definition wouldn't work well... however I think that whenever possible, we should avoid to create the form wrapper in the bsh script. > Relative paths for form definitions passed to the HtmlFormWrapper constructor limit reusability of scripts. > ----------------------------------------------------------------------------------------------------------- > > Key: OFBIZ-278 > URL: http://issues.apache.org/jira/browse/OFBIZ-278 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: accounting, content, ecommerce, manufacturing, order, product > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Priority: Trivial > > Copy of http://jira.undersunconsulting.com/browse/OFBIZ-603 from Chris Howe. > ================================================== > component://order/webapp/ordermgr/WEB-INF/actions/order/OrderDeliveryScheduleInfo.bsh > line 53: > uses "/order/OrderDeliveryScheduleForms.xml" as a parameter. > Because of this every app that calls this beanshell script must have the forms.xml file in it's path. This is extremely trivial at the moment, but will cause some people some trouble once the order application is updated to use mainDecoratorLocation variable -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-278) Relative paths for form definitions passed to the HtmlFormWrapper constructor limit reusability of scripts.
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-278?page=comments#action_12454835 ]
Jacques Le Roux commented on OFBIZ-278: --------------------------------------- Thanks Jacopo, I asked this question because for the moment HtmlFormWrapper is only used in BSH with harcoded pathes. Which, if I have well understood, is not a best practice at all. > Relative paths for form definitions passed to the HtmlFormWrapper constructor limit reusability of scripts. > ----------------------------------------------------------------------------------------------------------- > > Key: OFBIZ-278 > URL: http://issues.apache.org/jira/browse/OFBIZ-278 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: accounting, content, ecommerce, manufacturing, order, product > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Priority: Trivial > > Copy of http://jira.undersunconsulting.com/browse/OFBIZ-603 from Chris Howe. > ================================================== > component://order/webapp/ordermgr/WEB-INF/actions/order/OrderDeliveryScheduleInfo.bsh > line 53: > uses "/order/OrderDeliveryScheduleForms.xml" as a parameter. > Because of this every app that calls this beanshell script must have the forms.xml file in it's path. This is extremely trivial at the moment, but will cause some people some trouble once the order application is updated to use mainDecoratorLocation variable -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-278) Relative paths for form definitions passed to the HtmlFormWrapper constructor limit reusability of scripts.
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-278?page=comments#action_12456514 ]
David E. Jones commented on OFBIZ-278: -------------------------------------- I don't see what the issue is. Even in screen definitions the form location and name are usually "hard coded". This is the old way of doing it, used when the form widget existed and the screen widget did not. So yes, these could certainly be updated to use the screen widget instead of including forms in an FTL file, but it's not a huge deal. > Relative paths for form definitions passed to the HtmlFormWrapper constructor limit reusability of scripts. > ----------------------------------------------------------------------------------------------------------- > > Key: OFBIZ-278 > URL: http://issues.apache.org/jira/browse/OFBIZ-278 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: accounting, content, ecommerce, manufacturing, order, product > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Priority: Trivial > > Copy of http://jira.undersunconsulting.com/browse/OFBIZ-603 from Chris Howe. > ================================================== > component://order/webapp/ordermgr/WEB-INF/actions/order/OrderDeliveryScheduleInfo.bsh > line 53: > uses "/order/OrderDeliveryScheduleForms.xml" as a parameter. > Because of this every app that calls this beanshell script must have the forms.xml file in it's path. This is extremely trivial at the moment, but will cause some people some trouble once the order application is updated to use mainDecoratorLocation variable -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-278) Relative paths for form definitions passed to the HtmlFormWrapper constructor limit reusability of scripts.
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-278?page=comments#action_12456524 ]
Chris Howe commented on OFBIZ-278: ---------------------------------- It's not that it's hard coded, it's that it is a relative path. it is using using /order/... instead of component://order/webapp/order/... Therefore if another component wants to reuse that script, it has to have a component://my_component/webapp/my_webapp/order/OrderDeliveryScheduleForms.xml > Relative paths for form definitions passed to the HtmlFormWrapper constructor limit reusability of scripts. > ----------------------------------------------------------------------------------------------------------- > > Key: OFBIZ-278 > URL: http://issues.apache.org/jira/browse/OFBIZ-278 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: accounting, content, ecommerce, manufacturing, order, product > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Priority: Trivial > > Copy of http://jira.undersunconsulting.com/browse/OFBIZ-603 from Chris Howe. > ================================================== > component://order/webapp/ordermgr/WEB-INF/actions/order/OrderDeliveryScheduleInfo.bsh > line 53: > uses "/order/OrderDeliveryScheduleForms.xml" as a parameter. > Because of this every app that calls this beanshell script must have the forms.xml file in it's path. This is extremely trivial at the moment, but will cause some people some trouble once the order application is updated to use mainDecoratorLocation variable -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-278) Relative paths for form definitions passed to the HtmlFormWrapper constructor limit reusability of scripts.
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-278?page=comments#action_12456530 ]
David E. Jones commented on OFBIZ-278: -------------------------------------- If you want to make stuff reusable, definitely refactor it to include from a screen definition rather than leaving it this way. Unless for some reason that isn't possible? > Relative paths for form definitions passed to the HtmlFormWrapper constructor limit reusability of scripts. > ----------------------------------------------------------------------------------------------------------- > > Key: OFBIZ-278 > URL: http://issues.apache.org/jira/browse/OFBIZ-278 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: accounting, content, ecommerce, manufacturing, order, product > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Priority: Trivial > > Copy of http://jira.undersunconsulting.com/browse/OFBIZ-603 from Chris Howe. > ================================================== > component://order/webapp/ordermgr/WEB-INF/actions/order/OrderDeliveryScheduleInfo.bsh > line 53: > uses "/order/OrderDeliveryScheduleForms.xml" as a parameter. > Because of this every app that calls this beanshell script must have the forms.xml file in it's path. This is extremely trivial at the moment, but will cause some people some trouble once the order application is updated to use mainDecoratorLocation variable -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-278) Relative paths for form definitions passed to the HtmlFormWrapper constructor limit reusability of scripts.
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-278?page=comments#action_12456570 ]
Chris Howe commented on OFBIZ-278: ---------------------------------- HtmlFormWrapper cannot handle the resource path component://.... as input. So, the first thing that needs to be solved is that HtmlFormWrapper needs to be able to do that. After that, it's not an issue of refactoring to parameterizing the resource into the screen widget (while that might be beneficial in some cases), but rather refactoring : /order/OrderDeliveryScheduleForms.xml to: component://order/webapp/ordermgr/order/OrderDeliveryScheduleForms.xml This issue is simply broadened because the format HtmlFormWrapper() uses a relative path at least 53 times throughout the applications folder. > Relative paths for form definitions passed to the HtmlFormWrapper constructor limit reusability of scripts. > ----------------------------------------------------------------------------------------------------------- > > Key: OFBIZ-278 > URL: http://issues.apache.org/jira/browse/OFBIZ-278 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: accounting, content, ecommerce, manufacturing, order, product > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Priority: Trivial > > Copy of http://jira.undersunconsulting.com/browse/OFBIZ-603 from Chris Howe. > ================================================== > component://order/webapp/ordermgr/WEB-INF/actions/order/OrderDeliveryScheduleInfo.bsh > line 53: > uses "/order/OrderDeliveryScheduleForms.xml" as a parameter. > Because of this every app that calls this beanshell script must have the forms.xml file in it's path. This is extremely trivial at the moment, but will cause some people some trouble once the order application is updated to use mainDecoratorLocation variable -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-278) Relative paths for form definitions passed to the HtmlFormWrapper constructor limit reusability of scripts.
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-278?page=comments#action_12458271 ]
Jacques Le Roux commented on OFBIZ-278: --------------------------------------- Chris, May we keep this issue open ? > Relative paths for form definitions passed to the HtmlFormWrapper constructor limit reusability of scripts. > ----------------------------------------------------------------------------------------------------------- > > Key: OFBIZ-278 > URL: http://issues.apache.org/jira/browse/OFBIZ-278 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: accounting, content, ecommerce, manufacturing, order, product > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Priority: Trivial > > Copy of http://jira.undersunconsulting.com/browse/OFBIZ-603 from Chris Howe. > ================================================== > component://order/webapp/ordermgr/WEB-INF/actions/order/OrderDeliveryScheduleInfo.bsh > line 53: > uses "/order/OrderDeliveryScheduleForms.xml" as a parameter. > Because of this every app that calls this beanshell script must have the forms.xml file in it's path. This is extremely trivial at the moment, but will cause some people some trouble once the order application is updated to use mainDecoratorLocation variable -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-278) Relative paths for form definitions passed to the HtmlFormWrapper constructor limit reusability of scripts.
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-278?page=comments#action_12458284 ]
Chris Howe commented on OFBIZ-278: ---------------------------------- I haven't had a chance to create/test out the proposed solution yet. Applications outside of the component still fail when trying reuse the script, so this should stay open until there's a solution. This is no longer a "trivial" issue since the order component does use the parameters.mainDecorator approach. > Relative paths for form definitions passed to the HtmlFormWrapper constructor limit reusability of scripts. > ----------------------------------------------------------------------------------------------------------- > > Key: OFBIZ-278 > URL: http://issues.apache.org/jira/browse/OFBIZ-278 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: accounting, content, ecommerce, manufacturing, order, product > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Priority: Trivial > > Copy of http://jira.undersunconsulting.com/browse/OFBIZ-603 from Chris Howe. > ================================================== > component://order/webapp/ordermgr/WEB-INF/actions/order/OrderDeliveryScheduleInfo.bsh > line 53: > uses "/order/OrderDeliveryScheduleForms.xml" as a parameter. > Because of this every app that calls this beanshell script must have the forms.xml file in it's path. This is extremely trivial at the moment, but will cause some people some trouble once the order application is updated to use mainDecoratorLocation variable -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Updated: (OFBIZ-278) Relative paths for form definitions passed to the HtmlFormWrapper constructor limit reusability of scripts.
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-278?page=all ]
Jacques Le Roux updated OFBIZ-278: ---------------------------------- Priority: Major (was: Trivial) > Relative paths for form definitions passed to the HtmlFormWrapper constructor limit reusability of scripts. > ----------------------------------------------------------------------------------------------------------- > > Key: OFBIZ-278 > URL: http://issues.apache.org/jira/browse/OFBIZ-278 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: accounting, content, ecommerce, manufacturing, order, product > Affects Versions: SVN trunk > Reporter: Marco Risaliti > > Copy of http://jira.undersunconsulting.com/browse/OFBIZ-603 from Chris Howe. > ================================================== > component://order/webapp/ordermgr/WEB-INF/actions/order/OrderDeliveryScheduleInfo.bsh > line 53: > uses "/order/OrderDeliveryScheduleForms.xml" as a parameter. > Because of this every app that calls this beanshell script must have the forms.xml file in it's path. This is extremely trivial at the moment, but will cause some people some trouble once the order application is updated to use mainDecoratorLocation variable -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |