[jira] Created: (OFBIZ-284) Runtime BSH error when searching orders with just order number

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (OFBIZ-284) Runtime BSH error when searching orders with just order number

Nicolas Malin (Jira)
Runtime BSH error when searching orders with just order number
--------------------------------------------------------------

                 Key: OFBIZ-284
                 URL: http://issues.apache.org/jira/browse/OFBIZ-284
             Project: OFBiz (The Open for Business Project)
          Issue Type: Bug
          Components: order
    Affects Versions: SVN trunk
         Environment: Windows XP
Java 1.5
            Reporter: John Martin


Using the Find Order and only searching on Order Number, the orderview.bsh script fails due to the partyId variable not be assigned at line 370.


--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-284) Runtime BSH error when searching orders with just order number

Nicolas Malin (Jira)
     [ http://issues.apache.org/jira/browse/OFBIZ-284?page=all ]

John Martin updated OFBIZ-284:
------------------------------

    Attachment: diff.txt

Here is a quick patch that fixes \ofbiz\applications\order\webapp\ordermgr\WEB-INF\actions\order\orderview.bsh

> Runtime BSH error when searching orders with just order number
> --------------------------------------------------------------
>
>                 Key: OFBIZ-284
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-284
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: Windows XP
> Java 1.5
>            Reporter: John Martin
>         Attachments: diff.txt
>
>
> Using the Find Order and only searching on Order Number, the orderview.bsh script fails due to the partyId variable not be assigned at line 370.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Assigned: (OFBIZ-284) Runtime BSH error when searching orders with just order number

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
     [ http://issues.apache.org/jira/browse/OFBIZ-284?page=all ]

Si Chen reassigned OFBIZ-284:
-----------------------------

    Assignee: Si Chen

> Runtime BSH error when searching orders with just order number
> --------------------------------------------------------------
>
>                 Key: OFBIZ-284
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-284
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: Windows XP
> Java 1.5
>            Reporter: John Martin
>         Assigned To: Si Chen
>         Attachments: diff.txt
>
>
> Using the Find Order and only searching on Order Number, the orderview.bsh script fails due to the partyId variable not be assigned at line 370.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-284) Runtime BSH error when searching orders with just order number

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
    [ http://issues.apache.org/jira/browse/OFBIZ-284?page=comments#action_12434725 ]
           
Si Chen commented on OFBIZ-284:
-------------------------------

Sorry, how does one produce this error you are reporting?  Can you give a more detailed example?

> Runtime BSH error when searching orders with just order number
> --------------------------------------------------------------
>
>                 Key: OFBIZ-284
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-284
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: Windows XP
> Java 1.5
>            Reporter: John Martin
>         Assigned To: Si Chen
>         Attachments: diff.txt
>
>
> Using the Find Order and only searching on Order Number, the orderview.bsh script fails due to the partyId variable not be assigned at line 370.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-284) Runtime BSH error when searching orders with just order number

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
    [ http://issues.apache.org/jira/browse/OFBIZ-284?page=comments#action_12434733 ]
           
John Martin commented on OFBIZ-284:
-----------------------------------

Hi Si

1. Click on the Find Order link
2. Enter an non-existing order Number
3. Press enter to search

When I wrote this up, I didn't realize it was only an error when the order number was invalid.

The error message was:

org.ofbiz.base.util.GeneralException: Error rendering screen [component://order/widget/ordermgr/OrderViewScreens.xml#OrderHeaderView]: org.ofbiz.base.util.GeneralException: Error running BSH script at location [component://order/webapp/ordermgr/WEB-INF/actions/order/orderview.bsh]: org.ofbiz.base.util.GeneralException: Error running BSH script at [component://order/webapp/ordermgr/WEB-INF/actions/order/orderview.bsh], line [370]: Sourced file: component://order/webapp/ordermgr/WEB-INF/actions/order/orderview.bsh : Error in method invocation: Attempt to pass void argument (position 1) to method: toMap : at Line: 370 : in file: component://order/webapp/ordermgr/WEB-INF/actions/order/orderview.bsh : UtilMisc .toMap ( "partyId" , partyId )
(Sourced file: component://order/webapp/ordermgr/WEB-INF/actions/order/orderview.bsh : Error in method invocation: Attempt to pass void argument (position 1) to method: toMap) (Error running BSH script at [component://order/webapp/ordermgr/WEB-INF/actions/order/orderview.bsh], line [370]: Sourced file: component://order/webapp/ordermgr/WEB-INF/actions/order/orderview.bsh : Error in method invocation: Attempt to pass void argument (position 1) to method: toMap : at Line: 370 : in file: component://order/webapp/ordermgr/WEB-INF/actions/order/orderview.bsh : UtilMisc .toMap ( "partyId" , partyId )
(Sourced file: component://order/webapp/ordermgr/WEB-INF/actions/order/orderview.bsh : Error in method invocation: Attempt to pass void argument (position 1) to method: toMap)) (Error running BSH script at location [component://order/webapp/ordermgr/WEB-INF/actions/order/orderview.bsh]: org.ofbiz.base.util.GeneralException: Error running BSH script at [component://order/webapp/ordermgr/WEB-INF/actions/order/orderview.bsh], line [370]: Sourced file: component://order/webapp/ordermgr/WEB-INF/actions/order/orderview.bsh : Error in method invocation: Attempt to pass void argument (position 1) to method: toMap : at Line: 370 : in file: component://order/webapp/ordermgr/WEB-INF/actions/order/orderview.bsh : UtilMisc .toMap ( "partyId" , partyId )
(Sourced file: component://order/webapp/ordermgr/WEB-INF/actions/order/orderview.bsh : Error in method invocation: Attempt to pass void argument (position 1) to method: toMap) (Error running BSH script at [component://order/webapp/ordermgr/WEB-INF/actions/order/orderview.bsh], line [370]: Sourced file: component://order/webapp/ordermgr/WEB-INF/actions/order/orderview.bsh : Error in method invocation: Attempt to pass void argument (position 1) to method: toMap : at Line: 370 : in file: component://order/webapp/ordermgr/WEB-INF/actions/order/orderview.bsh : UtilMisc .toMap ( "partyId" , partyId )
(Sourced file: component://order/webapp/ordermgr/WEB-INF/actions/order/orderview.bsh : Error in method invocation: Attempt to pass void argument (position 1) to method: toMap)))

> Runtime BSH error when searching orders with just order number
> --------------------------------------------------------------
>
>                 Key: OFBIZ-284
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-284
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: Windows XP
> Java 1.5
>            Reporter: John Martin
>         Assigned To: Si Chen
>         Attachments: diff.txt
>
>
> Using the Find Order and only searching on Order Number, the orderview.bsh script fails due to the partyId variable not be assigned at line 370.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-284) Runtime BSH error when searching orders with just order number

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
    [ http://issues.apache.org/jira/browse/OFBIZ-284?page=comments#action_12434739 ]
           
Si Chen commented on OFBIZ-284:
-------------------------------

So there should be something which checks if the order is indeed found and if not, do a
request.setAttribute("_ERROR_MESSAGE_", "Order " + orderId + " not found!");
return;

in the bsh.

> Runtime BSH error when searching orders with just order number
> --------------------------------------------------------------
>
>                 Key: OFBIZ-284
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-284
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: Windows XP
> Java 1.5
>            Reporter: John Martin
>         Assigned To: Si Chen
>         Attachments: diff.txt
>
>
> Using the Find Order and only searching on Order Number, the orderview.bsh script fails due to the partyId variable not be assigned at line 370.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-284) Runtime BSH error when searching orders with just order number

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
    [ http://issues.apache.org/jira/browse/OFBIZ-284?page=comments#action_12434766 ]
           
John Martin commented on OFBIZ-284:
-----------------------------------

After examining how it behaves when unsuccessfully searching on other properties (i.e. External ID, User Login Id, etc), I think it should just return the "No Orders Found" search results form.  For some reason, the code behaves differently when the orderId is present.  I'll look at this and see if it is a simple tweak.

John

> Runtime BSH error when searching orders with just order number
> --------------------------------------------------------------
>
>                 Key: OFBIZ-284
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-284
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: Windows XP
> Java 1.5
>            Reporter: John Martin
>         Assigned To: Si Chen
>         Attachments: diff.txt
>
>
> Using the Find Order and only searching on Order Number, the orderview.bsh script fails due to the partyId variable not be assigned at line 370.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-284) Runtime BSH error when searching orders with just order number

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
    [ http://issues.apache.org/jira/browse/OFBIZ-284?page=comments#action_12435599 ]
           
Si Chen commented on OFBIZ-284:
-------------------------------

Ok.  I think I fixed this in SVN r 447604.  Can you test it?

> Runtime BSH error when searching orders with just order number
> --------------------------------------------------------------
>
>                 Key: OFBIZ-284
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-284
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: Windows XP
> Java 1.5
>            Reporter: John Martin
>         Assigned To: Si Chen
>         Attachments: diff.txt
>
>
> Using the Find Order and only searching on Order Number, the orderview.bsh script fails due to the partyId variable not be assigned at line 370.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (OFBIZ-284) Runtime BSH error when searching orders with just order number

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
     [ http://issues.apache.org/jira/browse/OFBIZ-284?page=all ]

Si Chen closed OFBIZ-284.
-------------------------

    Resolution: Fixed

> Runtime BSH error when searching orders with just order number
> --------------------------------------------------------------
>
>                 Key: OFBIZ-284
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-284
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: Windows XP
> Java 1.5
>            Reporter: John Martin
>         Assigned To: Si Chen
>         Attachments: diff.txt
>
>
> Using the Find Order and only searching on Order Number, the orderview.bsh script fails due to the partyId variable not be assigned at line 370.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira