[jira] Created: (OFBIZ-2938) HR Leave Enhancement
Locked
[jira] Created: (OFBIZ-2938) HR Leave Enhancement
 
|
HR Leave Enhancement
--------------------- Key: OFBIZ-2938 URL: https://issues.apache.org/jira/browse/OFBIZ-2938 Project: OFBiz Issue Type: Improvement Components: humanres Affects Versions: SVN trunk Environment: Windows XP, JDK 1.6 Reporter: Pradeep Ruhil Priority: Minor Fix For: SVN trunk Attachments: HR Leave.patch In this patch we are doing enhancement in HumanResource Leave Module. Initially we can only create new leave application for a partyId. But there was not functionality available for approval of leave. So in this patch we have given functionality for Leave approval as well as leave creation. Thanks & Regards, Pradeep Ruhil L & T Infotech, Mumbai -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-2938) HR Leave Enhancement
|
|
[ https://issues.apache.org/jira/browse/OFBIZ-2938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pradeep Ruhil updated OFBIZ-2938: --------------------------------- Attachment: HR Leave.patch > HR Leave Enhancement > --------------------- > > Key: OFBIZ-2938 > URL: https://issues.apache.org/jira/browse/OFBIZ-2938 > Project: OFBiz > Issue Type: Improvement > Components: humanres > Affects Versions: SVN trunk > Environment: Windows XP, JDK 1.6 > Reporter: Pradeep Ruhil > Priority: Minor > Fix For: SVN trunk > > Attachments: HR Leave.patch > > Original Estimate: 8h > Remaining Estimate: 8h > > In this patch we are doing enhancement in HumanResource Leave Module. Initially we can only create new leave application for a partyId. But there was not functionality available for approval of leave. So in this patch we have given functionality for Leave approval as well as leave creation. > Thanks & Regards, > Pradeep Ruhil > L & T Infotech, Mumbai -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-2938) HR Leave Enhancement
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12754975#action_12754975 ] Erwan de FERRIERES commented on OFBIZ-2938: ------------------------------------------- Hi Pradeep, have you looked to my patch, which also allow to accept leaves ? In it you will find a visualisation of leaves, too. https://issues.apache.org/jira/browse/OFBIZ-2874 > HR Leave Enhancement > --------------------- > > Key: OFBIZ-2938 > URL: https://issues.apache.org/jira/browse/OFBIZ-2938 > Project: OFBiz > Issue Type: Improvement > Components: humanres > Affects Versions: SVN trunk > Environment: Windows XP, JDK 1.6 > Reporter: Pradeep Ruhil > Priority: Minor > Fix For: SVN trunk > > Attachments: HR Leave.patch > > Original Estimate: 8h > Remaining Estimate: 8h > > In this patch we are doing enhancement in HumanResource Leave Module. Initially we can only create new leave application for a partyId. But there was not functionality available for approval of leave. So in this patch we have given functionality for Leave approval as well as leave creation. > Thanks & Regards, > Pradeep Ruhil > L & T Infotech, Mumbai -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-2938) HR Leave Enhancement
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12755364#action_12755364 ] Pradeep Ruhil commented on OFBIZ-2938: -------------------------------------- Hi Erwan I saw you patch and I find that you have only implemented the view calendar functionality and in the party profile screen, you have shown the leave taken by the corresponding party. But through calendar I am not able to select any date. Is this calendar intended for selection of date when you are applying leave? Because it is showing me only the dates with no corresponding day on it, i.e. Sunday, Monday and so on and I am not able to apply leave through calendar. Where as in our patch we have enhanced the core functionality of leave. Earlier there was functionality of leave creation only, but no approval process was there for approval of leaves applied by the party. So we have implemented role based approval process. Where a party can apply for leave, he/she can select the approver party for approval of his leave applied. Now when a approver logins in, he will see the leave applied to it and then he can approve or reject the leave. Problems I have found in you patch: 1. If a leave is rejected by the admin, then he can approve the same later, which is wrong. That should not happen. 2. Party can apply the leave without specifying the thru date, which ideally should not be the case. 3. Party can edit the status field in the party profile page by specifying its own status, which should not change. 4. When I applied your patch I got this error in party profile screen when admin applies leave to himself and approves the same then he is redirected to party profile screen, there when admin click on profile page I got this exception. Error on line 37, column 24 in component://party/webapp/partymgr/party/profileblocks/Leaves.ftl leave.getRelatedOne("StatusItem") is undefined. It cannot be assigned to status The problematic instruction: ---------- ==> assignment: status=leave.getRelatedOne("StatusItem") [on line 37, column 24 in component://party/webapp/partymgr/party/profileblocks/Leaves.ftl] ---------- Java backtrace for programmers: ---------- freemarker.core.InvalidReferenceException: Error on line 37, column 24 in component://party/webapp/partymgr/party/profileblocks/Leaves.ftl leave.getRelatedOne("StatusItem") is undefined. It cannot be assigned to status at So what I feel your functionality is a bit different, where in your case any party having update permission can approve the leave and in our case selected approver party having approval role with update permission can only change the status > HR Leave Enhancement > --------------------- > > Key: OFBIZ-2938 > URL: https://issues.apache.org/jira/browse/OFBIZ-2938 > Project: OFBiz > Issue Type: Improvement > Components: humanres > Affects Versions: SVN trunk > Environment: Windows XP, JDK 1.6 > Reporter: Pradeep Ruhil > Priority: Minor > Fix For: SVN trunk > > Attachments: HR Leave.patch > > Original Estimate: 8h > Remaining Estimate: 8h > > In this patch we are doing enhancement in HumanResource Leave Module. Initially we can only create new leave application for a partyId. But there was not functionality available for approval of leave. So in this patch we have given functionality for Leave approval as well as leave creation. > Thanks & Regards, > Pradeep Ruhil > L & T Infotech, Mumbai -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Closed: (OFBIZ-2938) HR Leave Enhancement
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-2938. ---------------------------------- Resolution: Fixed Assignee: Jacques Le Roux Thanks Pradeep, Your patch is in trunk at r826429 > HR Leave Enhancement > --------------------- > > Key: OFBIZ-2938 > URL: https://issues.apache.org/jira/browse/OFBIZ-2938 > Project: OFBiz > Issue Type: Improvement > Components: humanres > Affects Versions: SVN trunk > Environment: Windows XP, JDK 1.6 > Reporter: Pradeep Ruhil > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: HR Leave.patch > > Original Estimate: 8h > Remaining Estimate: 8h > > In this patch we are doing enhancement in HumanResource Leave Module. Initially we can only create new leave application for a partyId. But there was not functionality available for approval of leave. So in this patch we have given functionality for Leave approval as well as leave creation. > Thanks & Regards, > Pradeep Ruhil > L & T Infotech, Mumbai -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Reopened: (OFBIZ-2938) HR Leave Enhancement
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reopened OFBIZ-2938: ------------------------------------ Hi Pradeep, I have reverted your work at r826964. There has been a [discussion about it on dev ML|http://markmail.org/thread/vzcj3oaevvxyvek7]. Of course if you ca follow the advices in these thread and fix the issues reported there we will commit your work again. Thanks for your appreciated work > HR Leave Enhancement > --------------------- > > Key: OFBIZ-2938 > URL: https://issues.apache.org/jira/browse/OFBIZ-2938 > Project: OFBiz > Issue Type: Improvement > Components: humanres > Affects Versions: SVN trunk > Environment: Windows XP, JDK 1.6 > Reporter: Pradeep Ruhil > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: HR Leave.patch > > Original Estimate: 8h > Remaining Estimate: 8h > > In this patch we are doing enhancement in HumanResource Leave Module. Initially we can only create new leave application for a partyId. But there was not functionality available for approval of leave. So in this patch we have given functionality for Leave approval as well as leave creation. > Thanks & Regards, > Pradeep Ruhil > L & T Infotech, Mumbai -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-2938) HR Leave Enhancement
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12767714#action_12767714 ] Anil K Patel commented on OFBIZ-2938: ------------------------------------- Jacques, Thanks for reverting this patch. Data model changes were bothering me the most. > HR Leave Enhancement > --------------------- > > Key: OFBIZ-2938 > URL: https://issues.apache.org/jira/browse/OFBIZ-2938 > Project: OFBiz > Issue Type: Improvement > Components: humanres > Affects Versions: SVN trunk > Environment: Windows XP, JDK 1.6 > Reporter: Pradeep Ruhil > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: HR Leave.patch > > Original Estimate: 8h > Remaining Estimate: 8h > > In this patch we are doing enhancement in HumanResource Leave Module. Initially we can only create new leave application for a partyId. But there was not functionality available for approval of leave. So in this patch we have given functionality for Leave approval as well as leave creation. > Thanks & Regards, > Pradeep Ruhil > L & T Infotech, Mumbai -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-2938) HR Leave Enhancement
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12767718#action_12767718 ] Jacques Le Roux commented on OFBIZ-2938: ---------------------------------------- Anil, Yes, I don't know why I did not spot them. Certainly too confident in others work. Axtually Infotech has contributed some patches in the HR area these last times and there were not much pb, I guess my confidence came from this, lesson learned :/ > HR Leave Enhancement > --------------------- > > Key: OFBIZ-2938 > URL: https://issues.apache.org/jira/browse/OFBIZ-2938 > Project: OFBiz > Issue Type: Improvement > Components: humanres > Affects Versions: SVN trunk > Environment: Windows XP, JDK 1.6 > Reporter: Pradeep Ruhil > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: HR Leave.patch > > Original Estimate: 8h > Remaining Estimate: 8h > > In this patch we are doing enhancement in HumanResource Leave Module. Initially we can only create new leave application for a partyId. But there was not functionality available for approval of leave. So in this patch we have given functionality for Leave approval as well as leave creation. > Thanks & Regards, > Pradeep Ruhil > L & T Infotech, Mumbai -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-2938) HR Leave Enhancement
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12767865#action_12767865 ] Anil K Patel commented on OFBIZ-2938: ------------------------------------- Actually most of the contributions from this group has had problems, Initially Ashish helped them to improve, he gave up because he did not see much improvements in future contributions. I review most of their contributions but don't pick them up because of Data Model changes without much thought. > HR Leave Enhancement > --------------------- > > Key: OFBIZ-2938 > URL: https://issues.apache.org/jira/browse/OFBIZ-2938 > Project: OFBiz > Issue Type: Improvement > Components: humanres > Affects Versions: SVN trunk > Environment: Windows XP, JDK 1.6 > Reporter: Pradeep Ruhil > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: HR Leave.patch > > Original Estimate: 8h > Remaining Estimate: 8h > > In this patch we are doing enhancement in HumanResource Leave Module. Initially we can only create new leave application for a partyId. But there was not functionality available for approval of leave. So in this patch we have given functionality for Leave approval as well as leave creation. > Thanks & Regards, > Pradeep Ruhil > L & T Infotech, Mumbai -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-2938) HR Leave Enhancement
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12767879#action_12767879 ] Jacques Le Roux commented on OFBIZ-2938: ---------------------------------------- Thanks for sharing this Anil, I understand that we will need to be more careful in future. I have to say that the Training enhancement also done by Infotech team (OFBIZ-2534) seems good though not yet finished and unfortunately we have not much informations since commit. So I hope Infotech team will not give up working with us as contributors. We need to help them much to follow Apache OFBiz best practices, even if it's not always easy to do (on both sides). I think both parties (Apache OFBiz project and Infotech team) will get benefits from this collaboration. Us, because more (better) contributors is good for the project, them because following best practices will help them to deliver better deliverables to their clients... > HR Leave Enhancement > --------------------- > > Key: OFBIZ-2938 > URL: https://issues.apache.org/jira/browse/OFBIZ-2938 > Project: OFBiz > Issue Type: Improvement > Components: humanres > Affects Versions: SVN trunk > Environment: Windows XP, JDK 1.6 > Reporter: Pradeep Ruhil > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: HR Leave.patch > > Original Estimate: 8h > Remaining Estimate: 8h > > In this patch we are doing enhancement in HumanResource Leave Module. Initially we can only create new leave application for a partyId. But there was not functionality available for approval of leave. So in this patch we have given functionality for Leave approval as well as leave creation. > Thanks & Regards, > Pradeep Ruhil > L & T Infotech, Mumbai -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-2938) HR Leave Enhancement
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pradeep Ruhil updated OFBIZ-2938: --------------------------------- Attachment: HR Leave.patch Hi Jacques, I have uploaded the new patch with the suggested changes that you have said. Please check the same and let me know if any changes required. Thanks & Regards Pradeep Ruhil L & T Infotech. > HR Leave Enhancement > --------------------- > > Key: OFBIZ-2938 > URL: https://issues.apache.org/jira/browse/OFBIZ-2938 > Project: OFBiz > Issue Type: Improvement > Components: humanres > Affects Versions: SVN trunk > Environment: Windows XP, JDK 1.6 > Reporter: Pradeep Ruhil > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: HR Leave.patch, HR Leave.patch > > Original Estimate: 8h > Remaining Estimate: 8h > > In this patch we are doing enhancement in HumanResource Leave Module. Initially we can only create new leave application for a partyId. But there was not functionality available for approval of leave. So in this patch we have given functionality for Leave approval as well as leave creation. > Thanks & Regards, > Pradeep Ruhil > L & T Infotech, Mumbai -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Issue Comment Edited: (OFBIZ-2938) HR Leave Enhancement
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12767879#action_12767879 ] Jacques Le Roux edited comment on OFBIZ-2938 at 10/29/09 10:42 AM: ------------------------------------------------------------------- Thanks for sharing this Anil, I understand that we will need to be more careful in future. I have to say that the Training enhancement also done by Infotech team (OFBIZ-2531) seems good though not yet finished and unfortunately we have not much informations since commit. So I hope Infotech team will not give up working with us as contributors. We need to help them much to follow Apache OFBiz best practices, even if it's not always easy to do (on both sides). I think both parties (Apache OFBiz project and Infotech team) will get benefits from this collaboration. Us, because more (better) contributors is good for the project, them because following best practices will help them to deliver better deliverables to their clients... *EDIT : I misstyped OFBIZ-2534 instead of OFBIZ-2531* was (Author: jacques.le.roux): Thanks for sharing this Anil, I understand that we will need to be more careful in future. I have to say that the Training enhancement also done by Infotech team (OFBIZ-2534) seems good though not yet finished and unfortunately we have not much informations since commit. So I hope Infotech team will not give up working with us as contributors. We need to help them much to follow Apache OFBiz best practices, even if it's not always easy to do (on both sides). I think both parties (Apache OFBiz project and Infotech team) will get benefits from this collaboration. Us, because more (better) contributors is good for the project, them because following best practices will help them to deliver better deliverables to their clients... > HR Leave Enhancement > --------------------- > > Key: OFBIZ-2938 > URL: https://issues.apache.org/jira/browse/OFBIZ-2938 > Project: OFBiz > Issue Type: Improvement > Components: humanres > Affects Versions: SVN trunk > Environment: Windows XP, JDK 1.6 > Reporter: Pradeep Ruhil > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: HR Leave.patch, HR Leave.patch > > Original Estimate: 8h > Remaining Estimate: 8h > > In this patch we are doing enhancement in HumanResource Leave Module. Initially we can only create new leave application for a partyId. But there was not functionality available for approval of leave. So in this patch we have given functionality for Leave approval as well as leave creation. > Thanks & Regards, > Pradeep Ruhil > L & T Infotech, Mumbai -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Closed: (OFBIZ-2938) HR Leave Enhancement
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-2938. ---------------------------------- Resolution: Fixed Thanks Pradeep, After a serious review and test of your patch I have commited your patch in trunk at r831249 > HR Leave Enhancement > --------------------- > > Key: OFBIZ-2938 > URL: https://issues.apache.org/jira/browse/OFBIZ-2938 > Project: OFBiz > Issue Type: Improvement > Components: humanres > Affects Versions: SVN trunk > Environment: Windows XP, JDK 1.6 > Reporter: Pradeep Ruhil > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: HR Leave.patch, HR Leave.patch > > Original Estimate: 8h > Remaining Estimate: 8h > > In this patch we are doing enhancement in HumanResource Leave Module. Initially we can only create new leave application for a partyId. But there was not functionality available for approval of leave. So in this patch we have given functionality for Leave approval as well as leave creation. > Thanks & Regards, > Pradeep Ruhil > L & T Infotech, Mumbai -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-2938) HR Leave Enhancement
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771900#action_12771900 ] Pradeep Ruhil commented on OFBIZ-2938: -------------------------------------- Hi Jacques, Thanks for commiting our work and we will continue to contribute more into OFBiz.. Thanks & Regards Pradeep Ruhil L & T Infotech > HR Leave Enhancement > --------------------- > > Key: OFBIZ-2938 > URL: https://issues.apache.org/jira/browse/OFBIZ-2938 > Project: OFBiz > Issue Type: Improvement > Components: humanres > Affects Versions: SVN trunk > Environment: Windows XP, JDK 1.6 > Reporter: Pradeep Ruhil > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: HR Leave.patch, HR Leave.patch > > Original Estimate: 8h > Remaining Estimate: 8h > > In this patch we are doing enhancement in HumanResource Leave Module. Initially we can only create new leave application for a partyId. But there was not functionality available for approval of leave. So in this patch we have given functionality for Leave approval as well as leave creation. > Thanks & Regards, > Pradeep Ruhil > L & T Infotech, Mumbai -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |