[jira] Created: (OFBIZ-3000) sendCreatePartyEmailNotification

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
12 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (OFBIZ-3000) sendCreatePartyEmailNotification

Nicolas Malin (Jira)
sendCreatePartyEmailNotification
--------------------------------

                 Key: OFBIZ-3000
                 URL: https://issues.apache.org/jira/browse/OFBIZ-3000
             Project: OFBiz
          Issue Type: Bug
          Components: party
    Affects Versions: SVN trunk
         Environment: Mac OS X
Macbook Pro
Eclipse IDE
            Reporter: Frederick Ancheta


I was working on making custom ProductStoreEmailSettings in the Catalog and I found that I couldn't get them to send the right email templates. For example, I am working on making a page where users can create new profiles, thus calling the createCustomerProfile event in the Ecommerce application (ecommerece/script/org/ofbiz/ecommerce/customer/CustomerEvents.xml).

The problem is, when I create a new customer profile, it does everything perfectly until the email is called to be sent out. The createCustomerProfile event calls a service in the Party application called sendCreatePartyEmailNotification (party/script/org/ofbiz/party/party/PartyServices.xml).

Now in this code (minilang), from what I gather, it does the following:

1. Gets all the ProductStoreEmailSettings in the table who's emailType is "PARTY_REGIS_CONFIRM". 2. Grabs the first from the list and uses it's email settings to send the email. 3. Call the service to actually send the mail (sendMailFromScreen).

My issue is with step 2. Why doesn't it also match the correct ProductStore rather than just grabbing the first one on the list? Before I make any code changes to the Party application, I just want to verify with any developers the reasons for designing it this way and if it will break any other application.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-3000) sendCreatePartyEmailNotification

Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-3000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Frederick Ancheta updated OFBIZ-3000:
-------------------------------------


I will be working on a patch to fix just this file specifically.  Hopefully this isn't seen anywhere else.

> sendCreatePartyEmailNotification
> --------------------------------
>
>                 Key: OFBIZ-3000
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3000
>             Project: OFBiz
>          Issue Type: Bug
>          Components: party
>    Affects Versions: SVN trunk
>         Environment: Mac OS X
> Macbook Pro
> Eclipse IDE
>            Reporter: Frederick Ancheta
>
> I was working on making custom ProductStoreEmailSettings in the Catalog and I found that I couldn't get them to send the right email templates. For example, I am working on making a page where users can create new profiles, thus calling the createCustomerProfile event in the Ecommerce application (ecommerece/script/org/ofbiz/ecommerce/customer/CustomerEvents.xml).
> The problem is, when I create a new customer profile, it does everything perfectly until the email is called to be sent out. The createCustomerProfile event calls a service in the Party application called sendCreatePartyEmailNotification (party/script/org/ofbiz/party/party/PartyServices.xml).
> Now in this code (minilang), from what I gather, it does the following:
> 1. Gets all the ProductStoreEmailSettings in the table who's emailType is "PARTY_REGIS_CONFIRM". 2. Grabs the first from the list and uses it's email settings to send the email. 3. Call the service to actually send the mail (sendMailFromScreen).
> My issue is with step 2. Why doesn't it also match the correct ProductStore rather than just grabbing the first one on the list? Before I make any code changes to the Party application, I just want to verify with any developers the reasons for designing it this way and if it will break any other application.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-3000) sendCreatePartyEmailNotification

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-3000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12762498#action_12762498 ]

Ashish Vijaywargiya commented on OFBIZ-3000:
--------------------------------------------

Can you please share your thoughts about the implementation plan?
I can help you in reviewing the patch and we can work together on any blocker or issue.

Thanks for your help in this Fred - Much appreciated!

--
Ashish

> sendCreatePartyEmailNotification
> --------------------------------
>
>                 Key: OFBIZ-3000
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3000
>             Project: OFBiz
>          Issue Type: Bug
>          Components: party
>    Affects Versions: SVN trunk
>         Environment: Mac OS X
> Macbook Pro
> Eclipse IDE
>            Reporter: Frederick Ancheta
>
> I was working on making custom ProductStoreEmailSettings in the Catalog and I found that I couldn't get them to send the right email templates. For example, I am working on making a page where users can create new profiles, thus calling the createCustomerProfile event in the Ecommerce application (ecommerece/script/org/ofbiz/ecommerce/customer/CustomerEvents.xml).
> The problem is, when I create a new customer profile, it does everything perfectly until the email is called to be sent out. The createCustomerProfile event calls a service in the Party application called sendCreatePartyEmailNotification (party/script/org/ofbiz/party/party/PartyServices.xml).
> Now in this code (minilang), from what I gather, it does the following:
> 1. Gets all the ProductStoreEmailSettings in the table who's emailType is "PARTY_REGIS_CONFIRM". 2. Grabs the first from the list and uses it's email settings to send the email. 3. Call the service to actually send the mail (sendMailFromScreen).
> My issue is with step 2. Why doesn't it also match the correct ProductStore rather than just grabbing the first one on the list? Before I make any code changes to the Party application, I just want to verify with any developers the reasons for designing it this way and if it will break any other application.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Assigned: (OFBIZ-3000) sendCreatePartyEmailNotification

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-3000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashish Vijaywargiya reassigned OFBIZ-3000:
------------------------------------------

    Assignee: Ashish Vijaywargiya

> sendCreatePartyEmailNotification
> --------------------------------
>
>                 Key: OFBIZ-3000
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3000
>             Project: OFBiz
>          Issue Type: Bug
>          Components: party
>    Affects Versions: SVN trunk
>         Environment: Mac OS X
> Macbook Pro
> Eclipse IDE
>            Reporter: Frederick Ancheta
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>
> I was working on making custom ProductStoreEmailSettings in the Catalog and I found that I couldn't get them to send the right email templates. For example, I am working on making a page where users can create new profiles, thus calling the createCustomerProfile event in the Ecommerce application (ecommerece/script/org/ofbiz/ecommerce/customer/CustomerEvents.xml).
> The problem is, when I create a new customer profile, it does everything perfectly until the email is called to be sent out. The createCustomerProfile event calls a service in the Party application called sendCreatePartyEmailNotification (party/script/org/ofbiz/party/party/PartyServices.xml).
> Now in this code (minilang), from what I gather, it does the following:
> 1. Gets all the ProductStoreEmailSettings in the table who's emailType is "PARTY_REGIS_CONFIRM". 2. Grabs the first from the list and uses it's email settings to send the email. 3. Call the service to actually send the mail (sendMailFromScreen).
> My issue is with step 2. Why doesn't it also match the correct ProductStore rather than just grabbing the first one on the list? Before I make any code changes to the Party application, I just want to verify with any developers the reasons for designing it this way and if it will break any other application.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-3000) sendCreatePartyEmailNotification

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-3000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashish Vijaywargiya updated OFBIZ-3000:
---------------------------------------

    Priority: Minor  (was: Major)

As long as it is not breaking any functionality we will keep it as Minor one.


> sendCreatePartyEmailNotification
> --------------------------------
>
>                 Key: OFBIZ-3000
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3000
>             Project: OFBiz
>          Issue Type: Bug
>          Components: party
>    Affects Versions: SVN trunk
>         Environment: Mac OS X
> Macbook Pro
> Eclipse IDE
>            Reporter: Frederick Ancheta
>            Priority: Minor
>
> I was working on making custom ProductStoreEmailSettings in the Catalog and I found that I couldn't get them to send the right email templates. For example, I am working on making a page where users can create new profiles, thus calling the createCustomerProfile event in the Ecommerce application (ecommerece/script/org/ofbiz/ecommerce/customer/CustomerEvents.xml).
> The problem is, when I create a new customer profile, it does everything perfectly until the email is called to be sent out. The createCustomerProfile event calls a service in the Party application called sendCreatePartyEmailNotification (party/script/org/ofbiz/party/party/PartyServices.xml).
> Now in this code (minilang), from what I gather, it does the following:
> 1. Gets all the ProductStoreEmailSettings in the table who's emailType is "PARTY_REGIS_CONFIRM". 2. Grabs the first from the list and uses it's email settings to send the email. 3. Call the service to actually send the mail (sendMailFromScreen).
> My issue is with step 2. Why doesn't it also match the correct ProductStore rather than just grabbing the first one on the list? Before I make any code changes to the Party application, I just want to verify with any developers the reasons for designing it this way and if it will break any other application.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-3000) sendCreatePartyEmailNotification

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-3000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12762688#action_12762688 ]

Frederick Ancheta commented on OFBIZ-3000:
------------------------------------------

There is a very simple fix where we just pass the productStoreId as a parameter to sendCreatePartyEmailNotification.  So there would be a change to the definition in party/servicedef/services.xml as well as party/script/org/ofbiz/party/party/PartyServices.xml.

The only thing is, there would need to be changes made to any existing code to include passing the productStoreId when calling the service.

Any thoughts?  If there is a more simple way to pass that parameter without having to modify the existing code in the callers of the service, it would be much better.

> sendCreatePartyEmailNotification
> --------------------------------
>
>                 Key: OFBIZ-3000
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3000
>             Project: OFBiz
>          Issue Type: Bug
>          Components: party
>    Affects Versions: SVN trunk
>         Environment: Mac OS X
> Macbook Pro
> Eclipse IDE
>            Reporter: Frederick Ancheta
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>
> I was working on making custom ProductStoreEmailSettings in the Catalog and I found that I couldn't get them to send the right email templates. For example, I am working on making a page where users can create new profiles, thus calling the createCustomerProfile event in the Ecommerce application (ecommerece/script/org/ofbiz/ecommerce/customer/CustomerEvents.xml).
> The problem is, when I create a new customer profile, it does everything perfectly until the email is called to be sent out. The createCustomerProfile event calls a service in the Party application called sendCreatePartyEmailNotification (party/script/org/ofbiz/party/party/PartyServices.xml).
> Now in this code (minilang), from what I gather, it does the following:
> 1. Gets all the ProductStoreEmailSettings in the table who's emailType is "PARTY_REGIS_CONFIRM". 2. Grabs the first from the list and uses it's email settings to send the email. 3. Call the service to actually send the mail (sendMailFromScreen).
> My issue is with step 2. Why doesn't it also match the correct ProductStore rather than just grabbing the first one on the list? Before I make any code changes to the Party application, I just want to verify with any developers the reasons for designing it this way and if it will break any other application.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-3000) sendCreatePartyEmailNotification

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-3000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12762872#action_12762872 ]

Ashish Vijaywargiya commented on OFBIZ-3000:
--------------------------------------------

Hello Fred,

Ok - This should be pretty simple.
The sendCreatePartyEmailNotification is being called from two places one is Partymgr component & Other one is Ecommerce component.
We can pass productStoreId from these two component in the following way.

1) For ecommerce component each webapp is/should be associated with Website record and Website should be associated with ProductStore (Website.productStoreId).

2) For Partymgr component you can create DemoData for WebSite entity and put it in file having reader name "demo". For example you can keep demo data in PartyDemoData.xml. For now you can safely associate WebSite record in Partymgr component with ProductStore = "9000".

3) In the service definition you can add productStoreId as an optional field and can provide conditional check before checking record in ProductStoreEmailSetting entity.

HTH!

--
Ashish

> sendCreatePartyEmailNotification
> --------------------------------
>
>                 Key: OFBIZ-3000
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3000
>             Project: OFBiz
>          Issue Type: Bug
>          Components: party
>    Affects Versions: SVN trunk
>         Environment: Mac OS X
> Macbook Pro
> Eclipse IDE
>            Reporter: Frederick Ancheta
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>
> I was working on making custom ProductStoreEmailSettings in the Catalog and I found that I couldn't get them to send the right email templates. For example, I am working on making a page where users can create new profiles, thus calling the createCustomerProfile event in the Ecommerce application (ecommerece/script/org/ofbiz/ecommerce/customer/CustomerEvents.xml).
> The problem is, when I create a new customer profile, it does everything perfectly until the email is called to be sent out. The createCustomerProfile event calls a service in the Party application called sendCreatePartyEmailNotification (party/script/org/ofbiz/party/party/PartyServices.xml).
> Now in this code (minilang), from what I gather, it does the following:
> 1. Gets all the ProductStoreEmailSettings in the table who's emailType is "PARTY_REGIS_CONFIRM". 2. Grabs the first from the list and uses it's email settings to send the email. 3. Call the service to actually send the mail (sendMailFromScreen).
> My issue is with step 2. Why doesn't it also match the correct ProductStore rather than just grabbing the first one on the list? Before I make any code changes to the Party application, I just want to verify with any developers the reasons for designing it this way and if it will break any other application.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-3000) sendCreatePartyEmailNotification

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-3000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12763130#action_12763130 ]

Frederick Ancheta commented on OFBIZ-3000:
------------------------------------------

What is the path of the file in Partymgr where this service is called?

> sendCreatePartyEmailNotification
> --------------------------------
>
>                 Key: OFBIZ-3000
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3000
>             Project: OFBiz
>          Issue Type: Bug
>          Components: party
>    Affects Versions: SVN trunk
>         Environment: Mac OS X
> Macbook Pro
> Eclipse IDE
>            Reporter: Frederick Ancheta
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>
> I was working on making custom ProductStoreEmailSettings in the Catalog and I found that I couldn't get them to send the right email templates. For example, I am working on making a page where users can create new profiles, thus calling the createCustomerProfile event in the Ecommerce application (ecommerece/script/org/ofbiz/ecommerce/customer/CustomerEvents.xml).
> The problem is, when I create a new customer profile, it does everything perfectly until the email is called to be sent out. The createCustomerProfile event calls a service in the Party application called sendCreatePartyEmailNotification (party/script/org/ofbiz/party/party/PartyServices.xml).
> Now in this code (minilang), from what I gather, it does the following:
> 1. Gets all the ProductStoreEmailSettings in the table who's emailType is "PARTY_REGIS_CONFIRM". 2. Grabs the first from the list and uses it's email settings to send the email. 3. Call the service to actually send the mail (sendMailFromScreen).
> My issue is with step 2. Why doesn't it also match the correct ProductStore rather than just grabbing the first one on the list? Before I make any code changes to the Party application, I just want to verify with any developers the reasons for designing it this way and if it will break any other application.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-3000) sendCreatePartyEmailNotification

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-3000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12763161#action_12763161 ]

Frederick Ancheta commented on OFBIZ-3000:
------------------------------------------

So I've modified ecommerce to correctly pass the right productStoreId to sendCreatePartyEmailNotification.  In Partymgr, however, there is no ProductStore associated with the Party application itself.  So should an email be sent from this application?  If so, should the productStoreId be selected from the Partymgr application itself?

> sendCreatePartyEmailNotification
> --------------------------------
>
>                 Key: OFBIZ-3000
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3000
>             Project: OFBiz
>          Issue Type: Bug
>          Components: party
>    Affects Versions: SVN trunk
>         Environment: Mac OS X
> Macbook Pro
> Eclipse IDE
>            Reporter: Frederick Ancheta
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>
> I was working on making custom ProductStoreEmailSettings in the Catalog and I found that I couldn't get them to send the right email templates. For example, I am working on making a page where users can create new profiles, thus calling the createCustomerProfile event in the Ecommerce application (ecommerece/script/org/ofbiz/ecommerce/customer/CustomerEvents.xml).
> The problem is, when I create a new customer profile, it does everything perfectly until the email is called to be sent out. The createCustomerProfile event calls a service in the Party application called sendCreatePartyEmailNotification (party/script/org/ofbiz/party/party/PartyServices.xml).
> Now in this code (minilang), from what I gather, it does the following:
> 1. Gets all the ProductStoreEmailSettings in the table who's emailType is "PARTY_REGIS_CONFIRM". 2. Grabs the first from the list and uses it's email settings to send the email. 3. Call the service to actually send the mail (sendMailFromScreen).
> My issue is with step 2. Why doesn't it also match the correct ProductStore rather than just grabbing the first one on the list? Before I make any code changes to the Party application, I just want to verify with any developers the reasons for designing it this way and if it will break any other application.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-3000) sendCreatePartyEmailNotification

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-3000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12763356#action_12763356 ]

Ashish Vijaywargiya commented on OFBIZ-3000:
--------------------------------------------

>> What is the path of the file in Partymgr where this service is called?
UserEvents.xml

For fetching productStoreId in the event you can pass "request" object to ProductStoreWorker.getProductStoreId() method.


>>In Partymgr, however, there is no ProductStore associated with the Party application itself. So should an email be sent from this application?

Yes for now there is no ProductStore associated with it. And yes we should send email to customer in case of customer is been created from back office application. Customer can can be created from CSR representative and it is important that we inform to customer that you account is been created. For associating ProductStore with WebSite record please read my point #2 in previous comment.

HTH!

--
Ashish

> sendCreatePartyEmailNotification
> --------------------------------
>
>                 Key: OFBIZ-3000
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3000
>             Project: OFBiz
>          Issue Type: Bug
>          Components: party
>    Affects Versions: SVN trunk
>         Environment: Mac OS X
> Macbook Pro
> Eclipse IDE
>            Reporter: Frederick Ancheta
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>
> I was working on making custom ProductStoreEmailSettings in the Catalog and I found that I couldn't get them to send the right email templates. For example, I am working on making a page where users can create new profiles, thus calling the createCustomerProfile event in the Ecommerce application (ecommerece/script/org/ofbiz/ecommerce/customer/CustomerEvents.xml).
> The problem is, when I create a new customer profile, it does everything perfectly until the email is called to be sent out. The createCustomerProfile event calls a service in the Party application called sendCreatePartyEmailNotification (party/script/org/ofbiz/party/party/PartyServices.xml).
> Now in this code (minilang), from what I gather, it does the following:
> 1. Gets all the ProductStoreEmailSettings in the table who's emailType is "PARTY_REGIS_CONFIRM". 2. Grabs the first from the list and uses it's email settings to send the email. 3. Call the service to actually send the mail (sendMailFromScreen).
> My issue is with step 2. Why doesn't it also match the correct ProductStore rather than just grabbing the first one on the list? Before I make any code changes to the Party application, I just want to verify with any developers the reasons for designing it this way and if it will break any other application.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-3000) sendCreatePartyEmailNotification

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-3000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Frederick Ancheta updated OFBIZ-3000:
-------------------------------------

    Attachment: JIRA-Issue3000.patch

I've attached a patch with the following changes:

applications/party/servicedef/services.xml

-added a IN parameter called productStoreId to be passed to sendCreateEmailNotification
-this parameter is OPTIONAL

applications/party/script/org/ofbiz/party/party/PartyServices.xml

-with productStoreId being passed, we check if it is empty
-if no productStoreId is provided, it will log a warning and send no email

applications/party/webapp/partymgr/party/PartyForms.xml

-see NewUser form
-added a new select (dropdown) field for user to choose which Product Store to create the customer for
-this way, the user who is creating the customer has control over which productStoreId is passed to sendCreateEmailNotification

applications/party/script/org/ofbiz/party/user/UserEvents.xml

-see createUser event, this is called when NewUser form is submitted
-this now takes the productStoreId from the NewUser form to pass on to sendCreateEmailNotification
-if no productStoreId is created, no email is sent

Please let me know if this will break anything else.  For now, this works with the current implementation we have over here at our company.  Thanks so much for your help.

> sendCreatePartyEmailNotification
> --------------------------------
>
>                 Key: OFBIZ-3000
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3000
>             Project: OFBiz
>          Issue Type: Bug
>          Components: party
>    Affects Versions: SVN trunk
>         Environment: Mac OS X
> Macbook Pro
> Eclipse IDE
>            Reporter: Frederick Ancheta
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>         Attachments: JIRA-Issue3000.patch
>
>
> I was working on making custom ProductStoreEmailSettings in the Catalog and I found that I couldn't get them to send the right email templates. For example, I am working on making a page where users can create new profiles, thus calling the createCustomerProfile event in the Ecommerce application (ecommerece/script/org/ofbiz/ecommerce/customer/CustomerEvents.xml).
> The problem is, when I create a new customer profile, it does everything perfectly until the email is called to be sent out. The createCustomerProfile event calls a service in the Party application called sendCreatePartyEmailNotification (party/script/org/ofbiz/party/party/PartyServices.xml).
> Now in this code (minilang), from what I gather, it does the following:
> 1. Gets all the ProductStoreEmailSettings in the table who's emailType is "PARTY_REGIS_CONFIRM". 2. Grabs the first from the list and uses it's email settings to send the email. 3. Call the service to actually send the mail (sendMailFromScreen).
> My issue is with step 2. Why doesn't it also match the correct ProductStore rather than just grabbing the first one on the list? Before I make any code changes to the Party application, I just want to verify with any developers the reasons for designing it this way and if it will break any other application.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (OFBIZ-3000) sendCreatePartyEmailNotification

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-3000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashish Vijaywargiya closed OFBIZ-3000.
--------------------------------------

    Resolution: Fixed

Thanks Frederick for the contribution - your changes are being taken care in jira issue OFBIZ-3508 with additional enhancement. Code is committed at r916219.

--
Ashish

> sendCreatePartyEmailNotification
> --------------------------------
>
>                 Key: OFBIZ-3000
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3000
>             Project: OFBiz
>          Issue Type: Bug
>          Components: party
>    Affects Versions: SVN trunk
>         Environment: Mac OS X
> Macbook Pro
> Eclipse IDE
>            Reporter: Frederick Ancheta
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>         Attachments: JIRA-Issue3000.patch
>
>
> I was working on making custom ProductStoreEmailSettings in the Catalog and I found that I couldn't get them to send the right email templates. For example, I am working on making a page where users can create new profiles, thus calling the createCustomerProfile event in the Ecommerce application (ecommerece/script/org/ofbiz/ecommerce/customer/CustomerEvents.xml).
> The problem is, when I create a new customer profile, it does everything perfectly until the email is called to be sent out. The createCustomerProfile event calls a service in the Party application called sendCreatePartyEmailNotification (party/script/org/ofbiz/party/party/PartyServices.xml).
> Now in this code (minilang), from what I gather, it does the following:
> 1. Gets all the ProductStoreEmailSettings in the table who's emailType is "PARTY_REGIS_CONFIRM". 2. Grabs the first from the list and uses it's email settings to send the email. 3. Call the service to actually send the mail (sendMailFromScreen).
> My issue is with step 2. Why doesn't it also match the correct ProductStore rather than just grabbing the first one on the list? Before I make any code changes to the Party application, I just want to verify with any developers the reasons for designing it this way and if it will break any other application.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.